From: Shawn Guo <shawnguo@kernel.org>
To: "A.s. Dong" <aisheng.dong@nxp.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Michael Turquette <mturquette@baylibre.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH] clk: bulk: call of_clk_get() when id is NULL
Date: Thu, 31 Aug 2017 15:01:20 +0800 [thread overview]
Message-ID: <20170831070118.GA3328@dragon> (raw)
In-Reply-To: <AM3PR04MB3064504A935B4AA0CBEE962809C0@AM3PR04MB306.eurprd04.prod.outlook.com>
On Wed, Aug 30, 2017 at 03:31:38PM +0000, A.s. Dong wrote:
> IMHO how about implement a of_clk_bulk_get() to handle this issue as we already
> have a of_clk_get?
> e.g.
>
> int __must_check of_clk_bulk_get(struct device_node *np, int num_clks,
> struct clk_bulk_data *clks)
> {
> for (i = 0; i < num_clks; i++) {
> clks[i].clk = of_clk_get(dev, clks[i].id);
The of_clk_get() takes clock index rather than name/id as the second
parameter.
Shawn
> ...
>
> }
WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: bulk: call of_clk_get() when id is NULL
Date: Thu, 31 Aug 2017 15:01:20 +0800 [thread overview]
Message-ID: <20170831070118.GA3328@dragon> (raw)
In-Reply-To: <AM3PR04MB3064504A935B4AA0CBEE962809C0@AM3PR04MB306.eurprd04.prod.outlook.com>
On Wed, Aug 30, 2017 at 03:31:38PM +0000, A.s. Dong wrote:
> IMHO how about implement a of_clk_bulk_get() to handle this issue as we already
> have a of_clk_get?
> e.g.
>
> int __must_check of_clk_bulk_get(struct device_node *np, int num_clks,
> struct clk_bulk_data *clks)
> {
> for (i = 0; i < num_clks; i++) {
> clks[i].clk = of_clk_get(dev, clks[i].id);
The of_clk_get() takes clock index rather than name/id as the second
parameter.
Shawn
> ...
>
> }
next prev parent reply other threads:[~2017-08-31 7:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 1:50 [PATCH] clk: bulk: call of_clk_get() when id is NULL Shawn Guo
2017-08-09 1:50 ` Shawn Guo
2017-08-09 17:33 ` Stephen Boyd
2017-08-09 17:33 ` Stephen Boyd
2017-08-10 1:31 ` Shawn Guo
2017-08-10 1:31 ` Shawn Guo
2017-08-13 14:18 ` Shawn Guo
2017-08-13 14:18 ` Shawn Guo
2017-08-30 15:31 ` A.s. Dong
2017-08-30 15:31 ` A.s. Dong
2017-08-31 5:26 ` Stephen Boyd
2017-08-31 5:26 ` Stephen Boyd
2017-09-11 4:51 ` A.s. Dong
2017-09-11 4:51 ` A.s. Dong
2017-09-11 5:57 ` Shawn Guo
2017-09-11 5:57 ` Shawn Guo
2017-08-31 7:01 ` Shawn Guo [this message]
2017-08-31 7:01 ` Shawn Guo
2017-08-31 7:12 ` A.s. Dong
2017-08-31 7:12 ` A.s. Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831070118.GA3328@dragon \
--to=shawnguo@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.