All of lore.kernel.org
 help / color / mirror / Atom feed
From: "A.s. Dong" <aisheng.dong@nxp.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
	Michael Turquette <mturquette@baylibre.com>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Shawn Guo <shawn.guo@linaro.org>
Subject: RE: [PATCH] clk: bulk: call of_clk_get() when id is NULL
Date: Thu, 31 Aug 2017 07:12:06 +0000	[thread overview]
Message-ID: <AM3PR04MB306B791472D5AB2BF12730F809D0@AM3PR04MB306.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20170831070118.GA3328@dragon>

> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: Thursday, August 31, 2017 3:01 PM
> To: A.s. Dong
> Cc: Stephen Boyd; Michael Turquette; linux-clk@vger.kernel.org; linux-arm=
-
> kernel@lists.infradead.org; Shawn Guo
> Subject: Re: [PATCH] clk: bulk: call of_clk_get() when id is NULL
>=20
> On Wed, Aug 30, 2017 at 03:31:38PM +0000, A.s. Dong wrote:
> > IMHO how about implement a of_clk_bulk_get() to handle this issue as
> > we already have a of_clk_get?
> > e.g.
> >
> > int __must_check of_clk_bulk_get(struct device_node *np, int num_clks,
> >                               struct clk_bulk_data *clks) {
> >         for (i =3D 0; i < num_clks; i++) {
> >                 clks[i].clk =3D of_clk_get(dev, clks[i].id);
>=20
> The of_clk_get() takes clock index rather than name/id as the second
> parameter.
>=20

You're right.
It's for only an idea demonstration, so sent too quick! :-)

Regards
Dong Aisheng

> Shawn
>=20
> > ...
> >
> > }

WARNING: multiple messages have this Message-ID (diff)
From: aisheng.dong@nxp.com (A.s. Dong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: bulk: call of_clk_get() when id is NULL
Date: Thu, 31 Aug 2017 07:12:06 +0000	[thread overview]
Message-ID: <AM3PR04MB306B791472D5AB2BF12730F809D0@AM3PR04MB306.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20170831070118.GA3328@dragon>

> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo at kernel.org]
> Sent: Thursday, August 31, 2017 3:01 PM
> To: A.s. Dong
> Cc: Stephen Boyd; Michael Turquette; linux-clk at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org; Shawn Guo
> Subject: Re: [PATCH] clk: bulk: call of_clk_get() when id is NULL
> 
> On Wed, Aug 30, 2017 at 03:31:38PM +0000, A.s. Dong wrote:
> > IMHO how about implement a of_clk_bulk_get() to handle this issue as
> > we already have a of_clk_get?
> > e.g.
> >
> > int __must_check of_clk_bulk_get(struct device_node *np, int num_clks,
> >                               struct clk_bulk_data *clks) {
> >         for (i = 0; i < num_clks; i++) {
> >                 clks[i].clk = of_clk_get(dev, clks[i].id);
> 
> The of_clk_get() takes clock index rather than name/id as the second
> parameter.
> 

You're right.
It's for only an idea demonstration, so sent too quick! :-)

Regards
Dong Aisheng

> Shawn
> 
> > ...
> >
> > }

  reply	other threads:[~2017-08-31  7:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09  1:50 [PATCH] clk: bulk: call of_clk_get() when id is NULL Shawn Guo
2017-08-09  1:50 ` Shawn Guo
2017-08-09 17:33 ` Stephen Boyd
2017-08-09 17:33   ` Stephen Boyd
2017-08-10  1:31   ` Shawn Guo
2017-08-10  1:31     ` Shawn Guo
2017-08-13 14:18   ` Shawn Guo
2017-08-13 14:18     ` Shawn Guo
2017-08-30 15:31     ` A.s. Dong
2017-08-30 15:31       ` A.s. Dong
2017-08-31  5:26       ` Stephen Boyd
2017-08-31  5:26         ` Stephen Boyd
2017-09-11  4:51         ` A.s. Dong
2017-09-11  4:51           ` A.s. Dong
2017-09-11  5:57           ` Shawn Guo
2017-09-11  5:57             ` Shawn Guo
2017-08-31  7:01       ` Shawn Guo
2017-08-31  7:01         ` Shawn Guo
2017-08-31  7:12         ` A.s. Dong [this message]
2017-08-31  7:12           ` A.s. Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM3PR04MB306B791472D5AB2BF12730F809D0@AM3PR04MB306.eurprd04.prod.outlook.com \
    --to=aisheng.dong@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    --cc=shawn.guo@linaro.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.