From: Mark Brown <broonie@kernel.org>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
perex@perex.cz, tiwai@suse.com, arvind.yadav.cs@gmail.com,
nicolas.ferre@microchip.com, garsilva@embeddedor.com,
andriy.shevchenko@linux.intel.com, bhumirks@gmail.com,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()'
Date: Thu, 31 Aug 2017 11:19:03 +0100 [thread overview]
Message-ID: <20170831101903.avhj5tqywpvfsj4u@sirena.org.uk> (raw)
In-Reply-To: <20170831081021.g4luo557ggtnyfyg@piout.net>
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
On Thu, Aug 31, 2017 at 10:10:21AM +0200, Alexandre Belloni wrote:
> And here is the fallout of the stupid, brainless "fixing" of issues
> reported by static analysis tools.
> This clk_prepare_enable will never fail. If it was going to fail, the
> platform would never boot to a point were it is able to execute that
> code. It is really annoying to have so much churn for absolutely 0
> benefit.
It may currently be the case that the SoCs you're looking at happen to
make this clock essential but that doesn't mean that it's not going to
be different in some future SoC, nor that we can't have a software bug
that this will detect. Being consistent with our error checking also
means that we can spot places where it might practically be a problem
more easily, it's even easier if the error checking is there first time
but it's still worth it to go back later.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: alsa-devel@alsa-project.org, andriy.shevchenko@linux.intel.com,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
nicolas.ferre@microchip.com, tiwai@suse.com,
garsilva@embeddedor.com, arvind.yadav.cs@gmail.com,
bhumirks@gmail.com
Subject: Re: [alsa-devel] [PATCH] ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()'
Date: Thu, 31 Aug 2017 10:19:03 +0000 [thread overview]
Message-ID: <20170831101903.avhj5tqywpvfsj4u@sirena.org.uk> (raw)
In-Reply-To: <20170831081021.g4luo557ggtnyfyg@piout.net>
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
On Thu, Aug 31, 2017 at 10:10:21AM +0200, Alexandre Belloni wrote:
> And here is the fallout of the stupid, brainless "fixing" of issues
> reported by static analysis tools.
> This clk_prepare_enable will never fail. If it was going to fail, the
> platform would never boot to a point were it is able to execute that
> code. It is really annoying to have so much churn for absolutely 0
> benefit.
It may currently be the case that the SoCs you're looking at happen to
make this clock essential but that doesn't mean that it's not going to
be different in some future SoC, nor that we can't have a software bug
that this will detect. Being consistent with our error checking also
means that we can spot places where it might practically be a problem
more easily, it's even easier if the error checking is there first time
but it's still worth it to go back later.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: alsa-devel@alsa-project.org, andriy.shevchenko@linux.intel.com,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
nicolas.ferre@microchip.com, tiwai@suse.com,
garsilva@embeddedor.com, arvind.yadav.cs@gmail.com,
bhumirks@gmail.com
Subject: Re: [PATCH] ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()'
Date: Thu, 31 Aug 2017 11:19:03 +0100 [thread overview]
Message-ID: <20170831101903.avhj5tqywpvfsj4u@sirena.org.uk> (raw)
In-Reply-To: <20170831081021.g4luo557ggtnyfyg@piout.net>
[-- Attachment #1.1: Type: text/plain, Size: 867 bytes --]
On Thu, Aug 31, 2017 at 10:10:21AM +0200, Alexandre Belloni wrote:
> And here is the fallout of the stupid, brainless "fixing" of issues
> reported by static analysis tools.
> This clk_prepare_enable will never fail. If it was going to fail, the
> platform would never boot to a point were it is able to execute that
> code. It is really annoying to have so much churn for absolutely 0
> benefit.
It may currently be the case that the SoCs you're looking at happen to
make this clock essential but that doesn't mean that it's not going to
be different in some future SoC, nor that we can't have a software bug
that this will detect. Being consistent with our error checking also
means that we can spot places where it might practically be a problem
more easily, it's even easier if the error checking is there first time
but it's still worth it to go back later.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2017-08-31 10:19 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 4:40 [PATCH] ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()' Christophe JAILLET
2017-08-31 4:40 ` Christophe JAILLET
2017-08-31 4:40 ` Christophe JAILLET
2017-08-31 8:10 ` [alsa-devel] " Alexandre Belloni
2017-08-31 8:10 ` Alexandre Belloni
2017-08-31 8:10 ` [alsa-devel] " Alexandre Belloni
2017-08-31 8:23 ` Julia Lawall
2017-08-31 8:23 ` Julia Lawall
2017-08-31 8:23 ` [alsa-devel] " Julia Lawall
2017-08-31 9:04 ` Andy Shevchenko
2017-08-31 9:04 ` Andy Shevchenko
2017-08-31 9:04 ` [alsa-devel] " Andy Shevchenko
2017-08-31 9:35 ` Alexandre Belloni
2017-08-31 9:35 ` Alexandre Belloni
2017-08-31 9:38 ` Andy Shevchenko
2017-08-31 9:38 ` Andy Shevchenko
2017-08-31 9:57 ` Alexandre Belloni
2017-08-31 9:57 ` Alexandre Belloni
2017-08-31 9:57 ` [alsa-devel] " Alexandre Belloni
2017-08-31 9:56 ` Alexandre Belloni
2017-08-31 9:56 ` Alexandre Belloni
2017-08-31 9:56 ` [alsa-devel] " Alexandre Belloni
2017-08-31 10:13 ` Takashi Iwai
2017-08-31 10:13 ` Takashi Iwai
2017-08-31 10:13 ` [alsa-devel] " Takashi Iwai
2017-08-31 10:19 ` Alexandre Belloni
2017-08-31 10:19 ` Alexandre Belloni
2017-08-31 10:23 ` Takashi Iwai
2017-08-31 10:23 ` Takashi Iwai
2017-08-31 10:23 ` Takashi Iwai
2017-08-31 10:37 ` Mark Brown
2017-08-31 10:37 ` Mark Brown
2017-08-31 10:37 ` [alsa-devel] " Mark Brown
2017-08-31 10:49 ` Takashi Iwai
2017-08-31 10:49 ` Takashi Iwai
2017-08-31 10:19 ` Mark Brown [this message]
2017-08-31 10:19 ` Mark Brown
2017-08-31 10:19 ` [alsa-devel] " Mark Brown
2017-08-31 10:31 ` Takashi Iwai
2017-08-31 10:31 ` Takashi Iwai
2017-08-31 10:31 ` [alsa-devel] " Takashi Iwai
2017-08-31 10:38 ` Mark Brown
2017-08-31 10:38 ` Mark Brown
2017-08-31 10:38 ` [alsa-devel] " Mark Brown
2017-08-31 19:08 ` Christophe JAILLET
2017-08-31 19:08 ` Christophe JAILLET
2017-08-31 19:08 ` Christophe JAILLET
2017-08-31 20:50 ` Alexandre Belloni
2017-08-31 20:50 ` Alexandre Belloni
2017-08-31 21:07 ` Julia Lawall
2017-08-31 21:07 ` Julia Lawall
2017-08-31 21:07 ` Julia Lawall
2017-08-31 11:55 ` Applied "ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()'" to the asoc tree Mark Brown
2017-08-31 11:55 ` Mark Brown
2017-08-31 11:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831101903.avhj5tqywpvfsj4u@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=bhumirks@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=garsilva@embeddedor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.