From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
alsa-devel@alsa-project.org, garsilva@embeddedor.com,
arvind.yadav.cs@gmail.com, bhumirks@gmail.com,
andriy.shevchenko@linux.intel.com, nicolas.ferre@microchip.com,
perex@perex.cz, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [alsa-devel] [PATCH] ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()'
Date: Thu, 31 Aug 2017 11:38:25 +0100 [thread overview]
Message-ID: <20170831103825.77shnqzi7ykpm7ah@sirena.org.uk> (raw)
In-Reply-To: <s5h1snsjaey.wl-tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
On Thu, Aug 31, 2017 at 12:31:33PM +0200, Takashi Iwai wrote:
> This is again a typical problem by such a trivial fix patch: the code
> looks as if it were trivial and correct, buried in a patch series that
> easily leads to the oversight by the maintainer's review.
Right, plus the amount of context that diff shows you.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, nicolas.ferre@microchip.com,
garsilva@embeddedor.com,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
arvind.yadav.cs@gmail.com,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
andriy.shevchenko@linux.intel.com, bhumirks@gmail.com
Subject: Re: [alsa-devel] [PATCH] ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()'
Date: Thu, 31 Aug 2017 10:38:25 +0000 [thread overview]
Message-ID: <20170831103825.77shnqzi7ykpm7ah@sirena.org.uk> (raw)
In-Reply-To: <s5h1snsjaey.wl-tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
On Thu, Aug 31, 2017 at 12:31:33PM +0200, Takashi Iwai wrote:
> This is again a typical problem by such a trivial fix patch: the code
> looks as if it were trivial and correct, buried in a patch series that
> easily leads to the oversight by the maintainer's review.
Right, plus the amount of context that diff shows you.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, nicolas.ferre@microchip.com,
garsilva@embeddedor.com,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
arvind.yadav.cs@gmail.com,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
andriy.shevchenko@linux.intel.com, bhumirks@gmail.com
Subject: Re: [PATCH] ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()'
Date: Thu, 31 Aug 2017 11:38:25 +0100 [thread overview]
Message-ID: <20170831103825.77shnqzi7ykpm7ah@sirena.org.uk> (raw)
In-Reply-To: <s5h1snsjaey.wl-tiwai@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 324 bytes --]
On Thu, Aug 31, 2017 at 12:31:33PM +0200, Takashi Iwai wrote:
> This is again a typical problem by such a trivial fix patch: the code
> looks as if it were trivial and correct, buried in a patch series that
> easily leads to the oversight by the maintainer's review.
Right, plus the amount of context that diff shows you.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2017-08-31 10:38 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 4:40 [PATCH] ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()' Christophe JAILLET
2017-08-31 4:40 ` Christophe JAILLET
2017-08-31 4:40 ` Christophe JAILLET
2017-08-31 8:10 ` [alsa-devel] " Alexandre Belloni
2017-08-31 8:10 ` Alexandre Belloni
2017-08-31 8:10 ` [alsa-devel] " Alexandre Belloni
2017-08-31 8:23 ` Julia Lawall
2017-08-31 8:23 ` Julia Lawall
2017-08-31 8:23 ` [alsa-devel] " Julia Lawall
2017-08-31 9:04 ` Andy Shevchenko
2017-08-31 9:04 ` Andy Shevchenko
2017-08-31 9:04 ` [alsa-devel] " Andy Shevchenko
2017-08-31 9:35 ` Alexandre Belloni
2017-08-31 9:35 ` Alexandre Belloni
2017-08-31 9:38 ` Andy Shevchenko
2017-08-31 9:38 ` Andy Shevchenko
2017-08-31 9:57 ` Alexandre Belloni
2017-08-31 9:57 ` Alexandre Belloni
2017-08-31 9:57 ` [alsa-devel] " Alexandre Belloni
2017-08-31 9:56 ` Alexandre Belloni
2017-08-31 9:56 ` Alexandre Belloni
2017-08-31 9:56 ` [alsa-devel] " Alexandre Belloni
2017-08-31 10:13 ` Takashi Iwai
2017-08-31 10:13 ` Takashi Iwai
2017-08-31 10:13 ` [alsa-devel] " Takashi Iwai
2017-08-31 10:19 ` Alexandre Belloni
2017-08-31 10:19 ` Alexandre Belloni
2017-08-31 10:23 ` Takashi Iwai
2017-08-31 10:23 ` Takashi Iwai
2017-08-31 10:23 ` Takashi Iwai
2017-08-31 10:37 ` Mark Brown
2017-08-31 10:37 ` Mark Brown
2017-08-31 10:37 ` [alsa-devel] " Mark Brown
2017-08-31 10:49 ` Takashi Iwai
2017-08-31 10:49 ` Takashi Iwai
2017-08-31 10:19 ` Mark Brown
2017-08-31 10:19 ` Mark Brown
2017-08-31 10:19 ` [alsa-devel] " Mark Brown
2017-08-31 10:31 ` Takashi Iwai
2017-08-31 10:31 ` Takashi Iwai
2017-08-31 10:31 ` [alsa-devel] " Takashi Iwai
2017-08-31 10:38 ` Mark Brown [this message]
2017-08-31 10:38 ` Mark Brown
2017-08-31 10:38 ` [alsa-devel] " Mark Brown
2017-08-31 19:08 ` Christophe JAILLET
2017-08-31 19:08 ` Christophe JAILLET
2017-08-31 19:08 ` Christophe JAILLET
2017-08-31 20:50 ` Alexandre Belloni
2017-08-31 20:50 ` Alexandre Belloni
2017-08-31 21:07 ` Julia Lawall
2017-08-31 21:07 ` Julia Lawall
2017-08-31 21:07 ` Julia Lawall
2017-08-31 11:55 ` Applied "ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()'" to the asoc tree Mark Brown
2017-08-31 11:55 ` Mark Brown
2017-08-31 11:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831103825.77shnqzi7ykpm7ah@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=bhumirks@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=garsilva@embeddedor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.