From: jglisse@redhat.com To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, "Jérôme Glisse" <jglisse@redhat.com>, amd-gfx@lists.freedesktop.org, "Felix Kuehling" <Felix.Kuehling@amd.com>, "Christian König" <christian.koenig@amd.com>, "Alex Deucher" <alexander.deucher@amd.com>, "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>, "Andrew Morton" <akpm@linux-foundation.org>, "Linus Torvalds" <torvalds@linux-foundation.org>, "Andrea Arcangeli" <aarcange@redhat.com> Subject: [PATCH 04/13] drm/amdgpu: update to new mmu_notifier semantic Date: Thu, 31 Aug 2017 17:17:29 -0400 [thread overview] Message-ID: <20170831211738.17922-5-jglisse@redhat.com> (raw) In-Reply-To: <20170831211738.17922-1-jglisse@redhat.com> From: Jérôme Glisse <jglisse@redhat.com> Call to mmu_notifier_invalidate_page() are replaced by call to mmu_notifier_invalidate_range() and thus call are bracketed by call to mmu_notifier_invalidate_range_start()/end() Remove now useless invalidate_page callback. Signed-off-by: Jérôme Glisse <jglisse@redhat.com> Reviewed-by: Christian König <christian.koenig@amd.com> Cc: amd-gfx@lists.freedesktop.org Cc: Felix Kuehling <Felix.Kuehling@amd.com> Cc: Christian König <christian.koenig@amd.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Andrea Arcangeli <aarcange@redhat.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 31 ------------------------------- 1 file changed, 31 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c index 6558a3ed57a7..e1cde6b80027 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c @@ -147,36 +147,6 @@ static void amdgpu_mn_invalidate_node(struct amdgpu_mn_node *node, } /** - * amdgpu_mn_invalidate_page - callback to notify about mm change - * - * @mn: our notifier - * @mn: the mm this callback is about - * @address: address of invalidate page - * - * Invalidation of a single page. Blocks for all BOs mapping it - * and unmap them by move them into system domain again. - */ -static void amdgpu_mn_invalidate_page(struct mmu_notifier *mn, - struct mm_struct *mm, - unsigned long address) -{ - struct amdgpu_mn *rmn = container_of(mn, struct amdgpu_mn, mn); - struct interval_tree_node *it; - - mutex_lock(&rmn->lock); - - it = interval_tree_iter_first(&rmn->objects, address, address); - if (it) { - struct amdgpu_mn_node *node; - - node = container_of(it, struct amdgpu_mn_node, it); - amdgpu_mn_invalidate_node(node, address, address); - } - - mutex_unlock(&rmn->lock); -} - -/** * amdgpu_mn_invalidate_range_start - callback to notify about mm change * * @mn: our notifier @@ -215,7 +185,6 @@ static void amdgpu_mn_invalidate_range_start(struct mmu_notifier *mn, static const struct mmu_notifier_ops amdgpu_mn_ops = { .release = amdgpu_mn_release, - .invalidate_page = amdgpu_mn_invalidate_page, .invalidate_range_start = amdgpu_mn_invalidate_range_start, }; -- 2.13.5
WARNING: multiple messages have this Message-ID (diff)
From: jglisse@redhat.com To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, "Jérôme Glisse" <jglisse@redhat.com>, amd-gfx@lists.freedesktop.org, "Felix Kuehling" <Felix.Kuehling@amd.com>, "Christian König" <christian.koenig@amd.com>, "Alex Deucher" <alexander.deucher@amd.com>, "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>, "Andrew Morton" <akpm@linux-foundation.org>, "Linus Torvalds" <torvalds@linux-foundation.org>, "Andrea Arcangeli" <aarcange@redhat.com> Subject: [PATCH 04/13] drm/amdgpu: update to new mmu_notifier semantic Date: Thu, 31 Aug 2017 17:17:29 -0400 [thread overview] Message-ID: <20170831211738.17922-5-jglisse@redhat.com> (raw) In-Reply-To: <20170831211738.17922-1-jglisse@redhat.com> From: JA(C)rA'me Glisse <jglisse@redhat.com> Call to mmu_notifier_invalidate_page() are replaced by call to mmu_notifier_invalidate_range() and thus call are bracketed by call to mmu_notifier_invalidate_range_start()/end() Remove now useless invalidate_page callback. Signed-off-by: JA(C)rA'me Glisse <jglisse@redhat.com> Reviewed-by: Christian KA?nig <christian.koenig@amd.com> Cc: amd-gfx@lists.freedesktop.org Cc: Felix Kuehling <Felix.Kuehling@amd.com> Cc: Christian KA?nig <christian.koenig@amd.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Andrea Arcangeli <aarcange@redhat.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 31 ------------------------------- 1 file changed, 31 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c index 6558a3ed57a7..e1cde6b80027 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c @@ -147,36 +147,6 @@ static void amdgpu_mn_invalidate_node(struct amdgpu_mn_node *node, } /** - * amdgpu_mn_invalidate_page - callback to notify about mm change - * - * @mn: our notifier - * @mn: the mm this callback is about - * @address: address of invalidate page - * - * Invalidation of a single page. Blocks for all BOs mapping it - * and unmap them by move them into system domain again. - */ -static void amdgpu_mn_invalidate_page(struct mmu_notifier *mn, - struct mm_struct *mm, - unsigned long address) -{ - struct amdgpu_mn *rmn = container_of(mn, struct amdgpu_mn, mn); - struct interval_tree_node *it; - - mutex_lock(&rmn->lock); - - it = interval_tree_iter_first(&rmn->objects, address, address); - if (it) { - struct amdgpu_mn_node *node; - - node = container_of(it, struct amdgpu_mn_node, it); - amdgpu_mn_invalidate_node(node, address, address); - } - - mutex_unlock(&rmn->lock); -} - -/** * amdgpu_mn_invalidate_range_start - callback to notify about mm change * * @mn: our notifier @@ -215,7 +185,6 @@ static void amdgpu_mn_invalidate_range_start(struct mmu_notifier *mn, static const struct mmu_notifier_ops amdgpu_mn_ops = { .release = amdgpu_mn_release, - .invalidate_page = amdgpu_mn_invalidate_page, .invalidate_range_start = amdgpu_mn_invalidate_range_start, }; -- 2.13.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-08-31 21:17 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-31 21:17 [PATCH 00/13] mmu_notifier kill invalidate_page callback v2 jglisse 2017-08-31 21:17 ` jglisse 2017-08-31 21:17 ` jglisse 2017-08-31 21:17 ` [PATCH 01/13] dax: update to new mmu_notifier semantic jglisse 2017-08-31 21:17 ` jglisse 2017-09-02 13:35 ` Andrea Arcangeli 2017-09-02 13:35 ` Andrea Arcangeli 2017-08-31 21:17 ` [PATCH 02/13] mm/rmap: update to new mmu_notifier semantic v2 jglisse 2017-08-31 21:17 ` jglisse 2017-08-31 21:17 ` [PATCH 03/13] powerpc/powernv: update to new mmu_notifier semantic jglisse 2017-08-31 21:17 ` jglisse 2017-08-31 21:17 ` jglisse [this message] 2017-08-31 21:17 ` [PATCH 04/13] drm/amdgpu: " jglisse 2017-08-31 21:17 ` [PATCH 05/13] IB/umem: " jglisse 2017-08-31 21:17 ` jglisse 2017-08-31 21:17 ` jglisse 2017-08-31 21:17 ` [PATCH 06/13] IB/hfi1: " jglisse 2017-08-31 21:17 ` jglisse 2017-08-31 21:17 ` jglisse 2017-08-31 21:17 ` [PATCH 07/13] iommu/amd: " jglisse 2017-08-31 21:17 ` jglisse-H+wXaHxf7aLQT0dZR+AlfA 2017-08-31 21:17 ` jglisse 2017-08-31 21:17 ` [PATCH 08/13] iommu/intel: " jglisse 2017-08-31 21:17 ` jglisse-H+wXaHxf7aLQT0dZR+AlfA 2017-08-31 21:17 ` jglisse 2017-08-31 21:17 ` [PATCH 09/13] misc/mic/scif: " jglisse 2017-08-31 21:17 ` jglisse 2017-08-31 21:17 ` [PATCH 10/13] sgi-gru: " jglisse 2017-08-31 21:17 ` jglisse 2017-09-05 16:21 ` Dimitri Sivanich 2017-09-05 16:21 ` Dimitri Sivanich 2017-08-31 21:17 ` [PATCH 11/13] xen/gntdev: " jglisse 2017-08-31 21:17 ` jglisse 2017-08-31 21:17 ` jglisse 2017-08-31 21:17 ` [PATCH 12/13] KVM: update to new mmu_notifier semantic v2 jglisse 2017-08-31 21:17 ` jglisse 2017-08-31 21:17 ` [PATCH 13/13] mm/mmu_notifier: kill invalidate_page jglisse 2017-08-31 21:17 ` jglisse 2017-09-02 13:28 ` [PATCH 00/13] mmu_notifier kill invalidate_page callback v2 Andrea Arcangeli 2017-09-02 13:28 ` Andrea Arcangeli 2017-09-02 13:28 ` Andrea Arcangeli 2017-09-02 13:28 ` Andrea Arcangeli -- strict thread matches above, loose matches on Subject: below -- 2017-08-29 23:54 [PATCH 00/13] mmu_notifier kill invalidate_page callback Jérôme Glisse 2017-08-29 23:54 ` [PATCH 04/13] drm/amdgpu: update to new mmu_notifier semantic Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-30 6:18 ` Christian König 2017-08-30 6:18 ` Christian König
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170831211738.17922-5-jglisse@redhat.com \ --to=jglisse@redhat.com \ --cc=Felix.Kuehling@amd.com \ --cc=aarcange@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=alexander.deucher@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=christian.koenig@amd.com \ --cc=kirill.shutemov@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.