From: "Christian König" <christian.koenig@amd.com> To: "Jérôme Glisse" <jglisse@redhat.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: amd-gfx@lists.freedesktop.org, Felix Kuehling <Felix.Kuehling@amd.com>, Alex Deucher <alexander.deucher@amd.com>, "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>, Andrew Morton <akpm@linux-foundation.org>, Linus Torvalds <torvalds@linux-foundation.org>, Andrea Arcangeli <aarcange@redhat.com> Subject: Re: [PATCH 04/13] drm/amdgpu: update to new mmu_notifier semantic Date: Wed, 30 Aug 2017 08:18:37 +0200 [thread overview] Message-ID: <2bdbe5bd-ab1f-831b-5f0e-c2381b0cd14f@amd.com> (raw) In-Reply-To: <20170829235447.10050-5-jglisse@redhat.com> Am 30.08.2017 um 01:54 schrieb Jérôme Glisse: > Call to mmu_notifier_invalidate_page() are replaced by call to > mmu_notifier_invalidate_range() and thus call are bracketed by > call to mmu_notifier_invalidate_range_start()/end() > > Remove now useless invalidate_page callback. > > Signed-off-by: Jérôme Glisse <jglisse@redhat.com> Reviewed-by: Christian König <christian.koenig@amd.com> The general approach is Acked-by: Christian König <christian.koenig@amd.com>. It's something very welcome since I was one of the people (together with the Intel guys) which failed to recognize what this callback really does. Regards, Christian. > Cc: amd-gfx@lists.freedesktop.org > Cc: Felix Kuehling <Felix.Kuehling@amd.com> > Cc: Christian König <christian.koenig@amd.com> > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Linus Torvalds <torvalds@linux-foundation.org> > Cc: Andrea Arcangeli <aarcange@redhat.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 31 ------------------------------- > 1 file changed, 31 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c > index 6558a3ed57a7..e1cde6b80027 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c > @@ -147,36 +147,6 @@ static void amdgpu_mn_invalidate_node(struct amdgpu_mn_node *node, > } > > /** > - * amdgpu_mn_invalidate_page - callback to notify about mm change > - * > - * @mn: our notifier > - * @mn: the mm this callback is about > - * @address: address of invalidate page > - * > - * Invalidation of a single page. Blocks for all BOs mapping it > - * and unmap them by move them into system domain again. > - */ > -static void amdgpu_mn_invalidate_page(struct mmu_notifier *mn, > - struct mm_struct *mm, > - unsigned long address) > -{ > - struct amdgpu_mn *rmn = container_of(mn, struct amdgpu_mn, mn); > - struct interval_tree_node *it; > - > - mutex_lock(&rmn->lock); > - > - it = interval_tree_iter_first(&rmn->objects, address, address); > - if (it) { > - struct amdgpu_mn_node *node; > - > - node = container_of(it, struct amdgpu_mn_node, it); > - amdgpu_mn_invalidate_node(node, address, address); > - } > - > - mutex_unlock(&rmn->lock); > -} > - > -/** > * amdgpu_mn_invalidate_range_start - callback to notify about mm change > * > * @mn: our notifier > @@ -215,7 +185,6 @@ static void amdgpu_mn_invalidate_range_start(struct mmu_notifier *mn, > > static const struct mmu_notifier_ops amdgpu_mn_ops = { > .release = amdgpu_mn_release, > - .invalidate_page = amdgpu_mn_invalidate_page, > .invalidate_range_start = amdgpu_mn_invalidate_range_start, > }; >
WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <christian.koenig@amd.com> To: "Jérôme Glisse" <jglisse@redhat.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: amd-gfx@lists.freedesktop.org, Felix Kuehling <Felix.Kuehling@amd.com>, Alex Deucher <alexander.deucher@amd.com>, "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>, Andrew Morton <akpm@linux-foundation.org>, Linus Torvalds <torvalds@linux-foundation.org>, Andrea Arcangeli <aarcange@redhat.com> Subject: Re: [PATCH 04/13] drm/amdgpu: update to new mmu_notifier semantic Date: Wed, 30 Aug 2017 08:18:37 +0200 [thread overview] Message-ID: <2bdbe5bd-ab1f-831b-5f0e-c2381b0cd14f@amd.com> (raw) In-Reply-To: <20170829235447.10050-5-jglisse@redhat.com> Am 30.08.2017 um 01:54 schrieb JA(C)rA'me Glisse: > Call to mmu_notifier_invalidate_page() are replaced by call to > mmu_notifier_invalidate_range() and thus call are bracketed by > call to mmu_notifier_invalidate_range_start()/end() > > Remove now useless invalidate_page callback. > > Signed-off-by: JA(C)rA'me Glisse <jglisse@redhat.com> Reviewed-by: Christian KA?nig <christian.koenig@amd.com> The general approach is Acked-by: Christian KA?nig <christian.koenig@amd.com>. It's something very welcome since I was one of the people (together with the Intel guys) which failed to recognize what this callback really does. Regards, Christian. > Cc: amd-gfx@lists.freedesktop.org > Cc: Felix Kuehling <Felix.Kuehling@amd.com> > Cc: Christian KA?nig <christian.koenig@amd.com> > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Linus Torvalds <torvalds@linux-foundation.org> > Cc: Andrea Arcangeli <aarcange@redhat.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 31 ------------------------------- > 1 file changed, 31 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c > index 6558a3ed57a7..e1cde6b80027 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c > @@ -147,36 +147,6 @@ static void amdgpu_mn_invalidate_node(struct amdgpu_mn_node *node, > } > > /** > - * amdgpu_mn_invalidate_page - callback to notify about mm change > - * > - * @mn: our notifier > - * @mn: the mm this callback is about > - * @address: address of invalidate page > - * > - * Invalidation of a single page. Blocks for all BOs mapping it > - * and unmap them by move them into system domain again. > - */ > -static void amdgpu_mn_invalidate_page(struct mmu_notifier *mn, > - struct mm_struct *mm, > - unsigned long address) > -{ > - struct amdgpu_mn *rmn = container_of(mn, struct amdgpu_mn, mn); > - struct interval_tree_node *it; > - > - mutex_lock(&rmn->lock); > - > - it = interval_tree_iter_first(&rmn->objects, address, address); > - if (it) { > - struct amdgpu_mn_node *node; > - > - node = container_of(it, struct amdgpu_mn_node, it); > - amdgpu_mn_invalidate_node(node, address, address); > - } > - > - mutex_unlock(&rmn->lock); > -} > - > -/** > * amdgpu_mn_invalidate_range_start - callback to notify about mm change > * > * @mn: our notifier > @@ -215,7 +185,6 @@ static void amdgpu_mn_invalidate_range_start(struct mmu_notifier *mn, > > static const struct mmu_notifier_ops amdgpu_mn_ops = { > .release = amdgpu_mn_release, > - .invalidate_page = amdgpu_mn_invalidate_page, > .invalidate_range_start = amdgpu_mn_invalidate_range_start, > }; > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-08-30 6:18 UTC|newest] Thread overview: 162+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-29 23:54 [PATCH 00/13] mmu_notifier kill invalidate_page callback Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` [PATCH 01/13] dax: update to new mmu_notifier semantic Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` [PATCH 02/13] mm/rmap: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-30 2:46 ` Nadav Amit 2017-08-30 2:46 ` Nadav Amit 2017-08-30 2:59 ` Jerome Glisse 2017-08-30 2:59 ` Jerome Glisse 2017-08-30 3:16 ` Nadav Amit 2017-08-30 3:16 ` Nadav Amit 2017-08-30 3:18 ` Nadav Amit 2017-08-30 3:18 ` Nadav Amit 2017-08-30 17:27 ` Andrea Arcangeli 2017-08-30 17:27 ` Andrea Arcangeli 2017-08-30 18:00 ` Nadav Amit 2017-08-30 18:00 ` Nadav Amit 2017-08-30 21:25 ` Andrea Arcangeli 2017-08-30 21:25 ` Andrea Arcangeli 2017-08-30 23:25 ` Nadav Amit 2017-08-30 23:25 ` Nadav Amit 2017-08-31 0:47 ` Jerome Glisse 2017-08-31 0:47 ` Jerome Glisse 2017-08-31 0:47 ` Jerome Glisse 2017-08-31 17:12 ` Andrea Arcangeli 2017-08-31 17:12 ` Andrea Arcangeli 2017-08-31 17:12 ` Andrea Arcangeli 2017-08-31 19:15 ` Nadav Amit 2017-08-31 19:15 ` Nadav Amit 2017-08-30 18:20 ` Jerome Glisse 2017-08-30 18:20 ` Jerome Glisse 2017-08-30 18:40 ` Nadav Amit 2017-08-30 18:40 ` Nadav Amit 2017-08-30 20:45 ` Jerome Glisse 2017-08-30 20:45 ` Jerome Glisse 2017-08-30 22:17 ` Andrea Arcangeli 2017-08-30 22:17 ` Andrea Arcangeli 2017-08-30 20:55 ` Andrea Arcangeli 2017-08-30 20:55 ` Andrea Arcangeli 2017-08-30 16:52 ` Andrea Arcangeli 2017-08-30 16:52 ` Andrea Arcangeli 2017-08-30 17:48 ` Jerome Glisse 2017-08-30 17:48 ` Jerome Glisse 2017-08-30 21:53 ` Linus Torvalds 2017-08-30 21:53 ` Linus Torvalds 2017-08-30 23:01 ` Andrea Arcangeli 2017-08-30 23:01 ` Andrea Arcangeli 2017-08-31 18:25 ` Jerome Glisse 2017-08-31 18:25 ` Jerome Glisse 2017-08-31 19:40 ` Linus Torvalds 2017-08-31 19:40 ` Linus Torvalds 2017-08-29 23:54 ` [PATCH 03/13] powerpc/powernv: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` [PATCH 04/13] drm/amdgpu: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-30 6:18 ` Christian König [this message] 2017-08-30 6:18 ` Christian König 2017-08-29 23:54 ` [PATCH 05/13] IB/umem: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-30 6:13 ` Leon Romanovsky 2017-08-29 23:54 ` [PATCH 06/13] IB/hfi1: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-09-06 14:08 ` Arumugam, Kamenee 2017-08-29 23:54 ` [PATCH 07/13] iommu/amd: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` [PATCH 08/13] iommu/intel: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` [PATCH 09/13] misc/mic/scif: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` [PATCH 10/13] sgi-gru: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` [PATCH 11/13] xen/gntdev: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-30 19:32 ` Boris Ostrovsky 2017-08-30 19:32 ` Boris Ostrovsky 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` [PATCH 12/13] KVM: " Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse 2017-08-29 23:54 ` [PATCH 13/13] mm/mmu_notifier: kill invalidate_page Jérôme Glisse 2017-08-29 23:54 ` Jérôme Glisse [not found] ` <20170829235447.10050-1-jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2017-08-30 0:11 ` [PATCH 00/13] mmu_notifier kill invalidate_page callback Linus Torvalds 2017-08-30 0:11 ` Linus Torvalds 2017-08-30 0:11 ` Linus Torvalds 2017-08-30 0:11 ` Linus Torvalds 2017-08-30 0:56 ` Jerome Glisse 2017-08-30 0:56 ` Jerome Glisse 2017-08-30 0:56 ` Jerome Glisse 2017-08-30 0:56 ` Jerome Glisse 2017-08-30 8:40 ` Mike Galbraith 2017-08-30 8:40 ` Mike Galbraith 2017-08-30 8:40 ` Mike Galbraith 2017-08-30 8:40 ` Mike Galbraith 2017-08-30 8:40 ` Mike Galbraith 2017-08-30 14:57 ` Adam Borowski 2017-08-30 14:57 ` Adam Borowski 2017-08-30 14:57 ` Adam Borowski 2017-08-30 14:57 ` Adam Borowski 2017-09-01 14:47 ` Jeff Cook 2017-09-01 14:47 ` Jeff Cook 2017-09-01 14:47 ` Jeff Cook 2017-09-01 14:47 ` Jeff Cook 2017-09-01 14:47 ` Jeff Cook 2017-09-01 14:50 ` taskboxtester 2017-09-01 14:50 ` taskboxtester 2017-08-30 21:51 ` Felix Kuehling 2017-08-31 13:59 ` Jerome Glisse [not found] ` <20170831135953.GA9227-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2017-08-31 14:14 ` Christian König 2017-08-31 18:39 ` Felix Kuehling 2017-08-31 19:00 ` Jerome Glisse [not found] ` <20170831190021.GG9227-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2017-08-31 23:19 ` Felix Kuehling 2017-08-31 23:29 ` Jerome Glisse 2017-08-30 0:11 ` Linus Torvalds 2017-11-30 9:33 ` BSOD with " Fabian Grünbichler 2017-11-30 9:33 ` Fabian Grünbichler 2017-11-30 11:20 ` Paolo Bonzini 2017-11-30 11:20 ` Paolo Bonzini 2017-11-30 11:20 ` Paolo Bonzini 2017-11-30 16:19 ` Radim Krčmář 2017-11-30 16:19 ` Radim Krčmář 2017-11-30 18:05 ` [PATCH 1/2] KVM: x86: fix APIC page invalidation Radim Krčmář 2017-11-30 18:05 ` Radim Krčmář 2017-11-30 18:05 ` Radim Krčmář 2017-11-30 18:05 ` [PATCH 2/2] TESTING! KVM: x86: add invalidate_range mmu notifier Radim Krčmář 2017-11-30 18:05 ` Radim Krčmář 2017-12-01 15:15 ` Paolo Bonzini 2017-12-01 15:15 ` Paolo Bonzini 2017-12-01 15:15 ` Paolo Bonzini 2017-12-03 17:24 ` Andrea Arcangeli 2017-12-03 17:24 ` Andrea Arcangeli 2017-12-03 17:24 ` Andrea Arcangeli 2017-12-01 12:21 ` [PATCH 1/2] KVM: x86: fix APIC page invalidation Fabian Grünbichler 2017-12-01 12:21 ` Fabian Grünbichler 2017-12-01 15:27 ` Paolo Bonzini 2017-12-01 15:27 ` Paolo Bonzini 2017-12-03 17:28 ` Andrea Arcangeli 2017-12-03 17:28 ` Andrea Arcangeli 2017-12-03 17:28 ` Andrea Arcangeli 2017-12-06 2:32 ` Wanpeng Li 2017-12-06 2:32 ` Wanpeng Li 2017-12-06 9:50 ` 王金浦 2017-12-06 9:50 ` 王金浦 2017-12-06 10:00 ` Paolo Bonzini 2017-12-06 10:00 ` Paolo Bonzini 2017-12-06 10:00 ` Paolo Bonzini 2017-12-06 8:15 ` Fabian Grünbichler 2017-12-06 8:15 ` Fabian Grünbichler 2017-12-06 8:15 ` Fabian Grünbichler 2017-12-13 12:54 ` Richard Purdie 2017-12-13 12:54 ` Richard Purdie 2017-12-13 12:54 ` Richard Purdie 2017-11-30 16:19 ` BSOD with [PATCH 00/13] mmu_notifier kill invalidate_page callback Radim Krčmář 2017-11-30 11:20 ` Paolo Bonzini 2017-11-30 9:33 ` Fabian Grünbichler 2017-08-31 21:17 [PATCH 00/13] mmu_notifier kill invalidate_page callback v2 jglisse 2017-08-31 21:17 ` [PATCH 04/13] drm/amdgpu: update to new mmu_notifier semantic jglisse 2017-08-31 21:17 ` jglisse
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2bdbe5bd-ab1f-831b-5f0e-c2381b0cd14f@amd.com \ --to=christian.koenig@amd.com \ --cc=Felix.Kuehling@amd.com \ --cc=aarcange@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=alexander.deucher@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=jglisse@redhat.com \ --cc=kirill.shutemov@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.