[PATCH] ARM: Remove leftover of fixmap_page_table

[PATCH] ARM: Remove leftover of fixmap_page_table

[Vladimir Murzin]

fixmap_page_table was removed by commit 836a24183273 (ARM: expand
fixmap region to 3MB), but some traces are still there - get rid of
them.

Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
---
 arch/arm/include/asm/highmem.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/include/asm/highmem.h b/arch/arm/include/asm/highmem.h
index 0a0e2d1..61736fd 100644
--- a/arch/arm/include/asm/highmem.h
+++ b/arch/arm/include/asm/highmem.h
@@ -18,7 +18,6 @@
 	} while (0)
 
 extern pte_t *pkmap_page_table;
-extern pte_t *fixmap_page_table;
 
 extern void *kmap_high(struct page *page);
 extern void kunmap_high(struct page *page);
-- 
2.0.0

[PATCH] ARM: entry: Remove dead code in sys_mmap2

[Vladimir Murzin]

We support page size of 4K only, remove dead code.

Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
---
 arch/arm/kernel/entry-common.S | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/arch/arm/kernel/entry-common.S b/arch/arm/kernel/entry-common.S
index eb5cd77..52237ce 100644
--- a/arch/arm/kernel/entry-common.S
+++ b/arch/arm/kernel/entry-common.S
@@ -371,17 +371,8 @@ ENDPROC(sys_fstatfs64_wrapper)
  * offset, we return EINVAL.
  */
 sys_mmap2:
-#if PAGE_SHIFT > 12
-		tst	r5, #PGOFF_MASK
-		moveq	r5, r5, lsr #PAGE_SHIFT - 12
-		streq	r5, [sp, #4]
-		beq	sys_mmap_pgoff
-		mov	r0, #-EINVAL
-		ret	lr
-#else
 		str	r5, [sp, #4]
 		b	sys_mmap_pgoff
-#endif
 ENDPROC(sys_mmap2)
 
 #ifdef CONFIG_OABI_COMPAT
-- 
2.0.0

[PATCH] ARM: mm: Remove dead code in mem_init()

[Vladimir Murzin]

The code in question checks memory constrains to set default policy for
overcommit; however we support page size of 4K only thus condition is
always evaluated to false. Remove that dead code.

Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
---
 arch/arm/mm/init.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
index ad80548..81d4482 100644
--- a/arch/arm/mm/init.c
+++ b/arch/arm/mm/init.c
@@ -580,16 +580,6 @@ void __init mem_init(void)
 	BUILD_BUG_ON(PKMAP_BASE + LAST_PKMAP * PAGE_SIZE > PAGE_OFFSET);
 	BUG_ON(PKMAP_BASE + LAST_PKMAP * PAGE_SIZE	> PAGE_OFFSET);
 #endif
-
-	if (PAGE_SIZE >= 16384 && get_num_physpages() <= 128) {
-		extern int sysctl_overcommit_memory;
-		/*
-		 * On a machine this small we won't get
-		 * anywhere without overcommit, so turn
-		 * it on by default.
-		 */
-		sysctl_overcommit_memory = OVERCOMMIT_ALWAYS;
-	}
 }
 
 #ifdef CONFIG_STRICT_KERNEL_RWX
-- 
2.0.0

[PATCH] ARM: Remove leftover of fixmap_page_table

[Vladimir Murzin]

On 14/08/17 09:44, Vladimir Murzin wrote:
> fixmap_page_table was removed by commit 836a24183273 (ARM: expand
> fixmap region to 3MB), but some traces are still there - get rid of
> them.
>
> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
> ---
>  arch/arm/include/asm/highmem.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/highmem.h b/arch/arm/include/asm/highmem.h
> index 0a0e2d1..61736fd 100644
> --- a/arch/arm/include/asm/highmem.h
> +++ b/arch/arm/include/asm/highmem.h
> @@ -18,7 +18,6 @@
>       } while (0)
>
>  extern pte_t *pkmap_page_table;
> -extern pte_t *fixmap_page_table;
>
>  extern void *kmap_high(struct page *page);
>  extern void kunmap_high(struct page *page);
>

Ok for patch tracker?

Vladimir
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

[PATCH] ARM: entry: Remove dead code in sys_mmap2

[Vladimir Murzin]

On 14/08/17 09:44, Vladimir Murzin wrote:
> We support page size of 4K only, remove dead code.
>
> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
> ---
>  arch/arm/kernel/entry-common.S | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/arch/arm/kernel/entry-common.S b/arch/arm/kernel/entry-common.S
> index eb5cd77..52237ce 100644
> --- a/arch/arm/kernel/entry-common.S
> +++ b/arch/arm/kernel/entry-common.S
> @@ -371,17 +371,8 @@ ENDPROC(sys_fstatfs64_wrapper)
>   * offset, we return EINVAL.
>   */
>  sys_mmap2:
> -#if PAGE_SHIFT > 12
> -             tst     r5, #PGOFF_MASK
> -             moveq   r5, r5, lsr #PAGE_SHIFT - 12
> -             streq   r5, [sp, #4]
> -             beq     sys_mmap_pgoff
> -             mov     r0, #-EINVAL
> -             ret     lr
> -#else
>               str     r5, [sp, #4]
>               b       sys_mmap_pgoff
> -#endif
>  ENDPROC(sys_mmap2)
>
>  #ifdef CONFIG_OABI_COMPAT
>

Ok for patch tracker?

Vladimir
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

[PATCH] ARM: mm: Remove dead code in mem_init()

[Vladimir Murzin]

On 14/08/17 09:44, Vladimir Murzin wrote:
> The code in question checks memory constrains to set default policy for
> overcommit; however we support page size of 4K only thus condition is
> always evaluated to false. Remove that dead code.
>
> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
> ---
>  arch/arm/mm/init.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
> index ad80548..81d4482 100644
> --- a/arch/arm/mm/init.c
> +++ b/arch/arm/mm/init.c
> @@ -580,16 +580,6 @@ void __init mem_init(void)
>       BUILD_BUG_ON(PKMAP_BASE + LAST_PKMAP * PAGE_SIZE > PAGE_OFFSET);
>       BUG_ON(PKMAP_BASE + LAST_PKMAP * PAGE_SIZE      > PAGE_OFFSET);
>  #endif
> -
> -     if (PAGE_SIZE >= 16384 && get_num_physpages() <= 128) {
> -             extern int sysctl_overcommit_memory;
> -             /*
> -              * On a machine this small we won't get
> -              * anywhere without overcommit, so turn
> -              * it on by default.
> -              */
> -             sysctl_overcommit_memory = OVERCOMMIT_ALWAYS;
> -     }
>  }
>
>  #ifdef CONFIG_STRICT_KERNEL_RWX
>

Ok for patch tracker?

Vladimir
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

[PATCH] ARM: Remove leftover of fixmap_page_table

[Russell King - ARM Linux]

On Fri, Sep 01, 2017 at 11:34:23AM +0100, Vladimir Murzin wrote:
> On 14/08/17 09:44, Vladimir Murzin wrote:
> > fixmap_page_table was removed by commit 836a24183273 (ARM: expand
> > fixmap region to 3MB), but some traces are still there - get rid of
> > them.
> >
> > Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
> > ---
> >  arch/arm/include/asm/highmem.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/arm/include/asm/highmem.h b/arch/arm/include/asm/highmem.h
> > index 0a0e2d1..61736fd 100644
> > --- a/arch/arm/include/asm/highmem.h
> > +++ b/arch/arm/include/asm/highmem.h
> > @@ -18,7 +18,6 @@
> >       } while (0)
> >
> >  extern pte_t *pkmap_page_table;
> > -extern pte_t *fixmap_page_table;
> >
> >  extern void *kmap_high(struct page *page);
> >  extern void kunmap_high(struct page *page);
> >
> 
> Ok for patch tracker?

Yep.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

[PATCH] ARM: entry: Remove dead code in sys_mmap2

[Russell King - ARM Linux]

On Fri, Sep 01, 2017 at 11:35:00AM +0100, Vladimir Murzin wrote:
> On 14/08/17 09:44, Vladimir Murzin wrote:
> > We support page size of 4K only, remove dead code.
> >
> > Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
> > ---
> >  arch/arm/kernel/entry-common.S | 9 ---------
> >  1 file changed, 9 deletions(-)
> >
> > diff --git a/arch/arm/kernel/entry-common.S b/arch/arm/kernel/entry-common.S
> > index eb5cd77..52237ce 100644
> > --- a/arch/arm/kernel/entry-common.S
> > +++ b/arch/arm/kernel/entry-common.S
> > @@ -371,17 +371,8 @@ ENDPROC(sys_fstatfs64_wrapper)
> >   * offset, we return EINVAL.
> >   */
> >  sys_mmap2:
> > -#if PAGE_SHIFT > 12
> > -             tst     r5, #PGOFF_MASK
> > -             moveq   r5, r5, lsr #PAGE_SHIFT - 12
> > -             streq   r5, [sp, #4]
> > -             beq     sys_mmap_pgoff
> > -             mov     r0, #-EINVAL
> > -             ret     lr
> > -#else
> >               str     r5, [sp, #4]
> >               b       sys_mmap_pgoff
> > -#endif
> >  ENDPROC(sys_mmap2)
> >
> >  #ifdef CONFIG_OABI_COMPAT
> >
> 
> Ok for patch tracker?

Yep.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

[PATCH] ARM: mm: Remove dead code in mem_init()

[Russell King - ARM Linux]

On Fri, Sep 01, 2017 at 11:35:16AM +0100, Vladimir Murzin wrote:
> On 14/08/17 09:44, Vladimir Murzin wrote:
> > The code in question checks memory constrains to set default policy for
> > overcommit; however we support page size of 4K only thus condition is
> > always evaluated to false. Remove that dead code.
> >
> > Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
> > ---
> >  arch/arm/mm/init.c | 10 ----------
> >  1 file changed, 10 deletions(-)
> >
> > diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
> > index ad80548..81d4482 100644
> > --- a/arch/arm/mm/init.c
> > +++ b/arch/arm/mm/init.c
> > @@ -580,16 +580,6 @@ void __init mem_init(void)
> >       BUILD_BUG_ON(PKMAP_BASE + LAST_PKMAP * PAGE_SIZE > PAGE_OFFSET);
> >       BUG_ON(PKMAP_BASE + LAST_PKMAP * PAGE_SIZE      > PAGE_OFFSET);
> >  #endif
> > -
> > -     if (PAGE_SIZE >= 16384 && get_num_physpages() <= 128) {
> > -             extern int sysctl_overcommit_memory;
> > -             /*
> > -              * On a machine this small we won't get
> > -              * anywhere without overcommit, so turn
> > -              * it on by default.
> > -              */
> > -             sysctl_overcommit_memory = OVERCOMMIT_ALWAYS;
> > -     }
> >  }
> >
> >  #ifdef CONFIG_STRICT_KERNEL_RWX
> >
> 
> Ok for patch tracker?

Yep.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up