All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: niklas.soderlund-1zkq55x86MTxsAP9Fp7wbw@public.gmane.org,
	robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org,
	laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	pavel-+ZI9xUNit7I@public.gmane.org,
	sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: [PATCH v8 19/21] smiapp: Add support for flash and lens devices
Date: Tue,  5 Sep 2017 16:05:51 +0300	[thread overview]
Message-ID: <20170905130553.1332-20-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20170905130553.1332-1-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

Parse async sub-devices by using
v4l2_subdev_fwnode_reference_parse_sensor_common().

These types devices aren't directly related to the sensor, but are
nevertheless handled by the smiapp driver due to the relationship of these
component to the main part of the camera module --- the sensor.

This does not yet address providing the user space with information on how
to associate the sensor or lens devices but the kernel now has the
necessary information to do that.

Signed-off-by: Sakari Ailus <sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
 drivers/media/i2c/smiapp/smiapp-core.c | 18 ++++++++++++++++--
 drivers/media/i2c/smiapp/smiapp.h      |  4 +++-
 2 files changed, 19 insertions(+), 3 deletions(-)

diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c
index 700f433261d0..2a7cf430270c 100644
--- a/drivers/media/i2c/smiapp/smiapp-core.c
+++ b/drivers/media/i2c/smiapp/smiapp-core.c
@@ -31,7 +31,7 @@
 #include <linux/regulator/consumer.h>
 #include <linux/slab.h>
 #include <linux/smiapp.h>
-#include <linux/v4l2-mediabus.h>
+#include <media/v4l2-async.h>
 #include <media/v4l2-fwnode.h>
 #include <media/v4l2-device.h>
 
@@ -2887,6 +2887,11 @@ static int smiapp_probe(struct i2c_client *client,
 	v4l2_i2c_subdev_init(&sensor->src->sd, client, &smiapp_ops);
 	sensor->src->sd.internal_ops = &smiapp_internal_src_ops;
 
+	rval = v4l2_fwnode_reference_parse_sensor_common(
+		&client->dev, &sensor->notifier);
+	if (rval < 0 && rval != -ENOENT)
+		return rval;
+
 	sensor->vana = devm_regulator_get(&client->dev, "vana");
 	if (IS_ERR(sensor->vana)) {
 		dev_err(&client->dev, "could not get regulator for vana\n");
@@ -3092,9 +3097,14 @@ static int smiapp_probe(struct i2c_client *client,
 	if (rval < 0)
 		goto out_media_entity_cleanup;
 
+	rval = v4l2_async_subdev_notifier_register(&sensor->src->sd,
+						   &sensor->notifier);
+	if (rval)
+		goto out_media_entity_cleanup;
+
 	rval = v4l2_async_register_subdev(&sensor->src->sd);
 	if (rval < 0)
-		goto out_media_entity_cleanup;
+		goto out_unregister_async_notifier;
 
 	pm_runtime_set_active(&client->dev);
 	pm_runtime_get_noresume(&client->dev);
@@ -3105,6 +3115,9 @@ static int smiapp_probe(struct i2c_client *client,
 
 	return 0;
 
+out_unregister_async_notifier:
+	v4l2_async_notifier_unregister(&sensor->notifier);
+
 out_media_entity_cleanup:
 	media_entity_cleanup(&sensor->src->sd.entity);
 
@@ -3124,6 +3137,7 @@ static int smiapp_remove(struct i2c_client *client)
 	unsigned int i;
 
 	v4l2_async_unregister_subdev(subdev);
+	v4l2_async_notifier_unregister(&sensor->notifier);
 
 	pm_runtime_disable(&client->dev);
 	if (!pm_runtime_status_suspended(&client->dev))
diff --git a/drivers/media/i2c/smiapp/smiapp.h b/drivers/media/i2c/smiapp/smiapp.h
index f74d695018b9..be92cb5713f4 100644
--- a/drivers/media/i2c/smiapp/smiapp.h
+++ b/drivers/media/i2c/smiapp/smiapp.h
@@ -20,9 +20,10 @@
 #define __SMIAPP_PRIV_H_
 
 #include <linux/mutex.h>
+#include <media/i2c/smiapp.h>
+#include <media/v4l2-async.h>
 #include <media/v4l2-ctrls.h>
 #include <media/v4l2-subdev.h>
-#include <media/i2c/smiapp.h>
 
 #include "smiapp-pll.h"
 #include "smiapp-reg.h"
@@ -172,6 +173,7 @@ struct smiapp_subdev {
  * struct smiapp_sensor - Main device structure
  */
 struct smiapp_sensor {
+	struct v4l2_async_notifier notifier;
 	/*
 	 * "mutex" is used to serialise access to all fields here
 	 * except v4l2_ctrls at the end of the struct. "mutex" is also
-- 
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: niklas.soderlund@ragnatech.se, robh@kernel.org,
	hverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com,
	devicetree@vger.kernel.org, pavel@ucw.cz, sre@kernel.org
Subject: [PATCH v8 19/21] smiapp: Add support for flash and lens devices
Date: Tue,  5 Sep 2017 16:05:51 +0300	[thread overview]
Message-ID: <20170905130553.1332-20-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20170905130553.1332-1-sakari.ailus@linux.intel.com>

Parse async sub-devices by using
v4l2_subdev_fwnode_reference_parse_sensor_common().

These types devices aren't directly related to the sensor, but are
nevertheless handled by the smiapp driver due to the relationship of these
component to the main part of the camera module --- the sensor.

This does not yet address providing the user space with information on how
to associate the sensor or lens devices but the kernel now has the
necessary information to do that.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/media/i2c/smiapp/smiapp-core.c | 18 ++++++++++++++++--
 drivers/media/i2c/smiapp/smiapp.h      |  4 +++-
 2 files changed, 19 insertions(+), 3 deletions(-)

diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c
index 700f433261d0..2a7cf430270c 100644
--- a/drivers/media/i2c/smiapp/smiapp-core.c
+++ b/drivers/media/i2c/smiapp/smiapp-core.c
@@ -31,7 +31,7 @@
 #include <linux/regulator/consumer.h>
 #include <linux/slab.h>
 #include <linux/smiapp.h>
-#include <linux/v4l2-mediabus.h>
+#include <media/v4l2-async.h>
 #include <media/v4l2-fwnode.h>
 #include <media/v4l2-device.h>
 
@@ -2887,6 +2887,11 @@ static int smiapp_probe(struct i2c_client *client,
 	v4l2_i2c_subdev_init(&sensor->src->sd, client, &smiapp_ops);
 	sensor->src->sd.internal_ops = &smiapp_internal_src_ops;
 
+	rval = v4l2_fwnode_reference_parse_sensor_common(
+		&client->dev, &sensor->notifier);
+	if (rval < 0 && rval != -ENOENT)
+		return rval;
+
 	sensor->vana = devm_regulator_get(&client->dev, "vana");
 	if (IS_ERR(sensor->vana)) {
 		dev_err(&client->dev, "could not get regulator for vana\n");
@@ -3092,9 +3097,14 @@ static int smiapp_probe(struct i2c_client *client,
 	if (rval < 0)
 		goto out_media_entity_cleanup;
 
+	rval = v4l2_async_subdev_notifier_register(&sensor->src->sd,
+						   &sensor->notifier);
+	if (rval)
+		goto out_media_entity_cleanup;
+
 	rval = v4l2_async_register_subdev(&sensor->src->sd);
 	if (rval < 0)
-		goto out_media_entity_cleanup;
+		goto out_unregister_async_notifier;
 
 	pm_runtime_set_active(&client->dev);
 	pm_runtime_get_noresume(&client->dev);
@@ -3105,6 +3115,9 @@ static int smiapp_probe(struct i2c_client *client,
 
 	return 0;
 
+out_unregister_async_notifier:
+	v4l2_async_notifier_unregister(&sensor->notifier);
+
 out_media_entity_cleanup:
 	media_entity_cleanup(&sensor->src->sd.entity);
 
@@ -3124,6 +3137,7 @@ static int smiapp_remove(struct i2c_client *client)
 	unsigned int i;
 
 	v4l2_async_unregister_subdev(subdev);
+	v4l2_async_notifier_unregister(&sensor->notifier);
 
 	pm_runtime_disable(&client->dev);
 	if (!pm_runtime_status_suspended(&client->dev))
diff --git a/drivers/media/i2c/smiapp/smiapp.h b/drivers/media/i2c/smiapp/smiapp.h
index f74d695018b9..be92cb5713f4 100644
--- a/drivers/media/i2c/smiapp/smiapp.h
+++ b/drivers/media/i2c/smiapp/smiapp.h
@@ -20,9 +20,10 @@
 #define __SMIAPP_PRIV_H_
 
 #include <linux/mutex.h>
+#include <media/i2c/smiapp.h>
+#include <media/v4l2-async.h>
 #include <media/v4l2-ctrls.h>
 #include <media/v4l2-subdev.h>
-#include <media/i2c/smiapp.h>
 
 #include "smiapp-pll.h"
 #include "smiapp-reg.h"
@@ -172,6 +173,7 @@ struct smiapp_subdev {
  * struct smiapp_sensor - Main device structure
  */
 struct smiapp_sensor {
+	struct v4l2_async_notifier notifier;
 	/*
 	 * "mutex" is used to serialise access to all fields here
 	 * except v4l2_ctrls at the end of the struct. "mutex" is also
-- 
2.11.0

  parent reply	other threads:[~2017-09-05 13:05 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-05 13:05 [PATCH v8 00/21] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS Sakari Ailus
2017-09-05 13:05 ` [PATCH v8 02/21] v4l: async: Remove re-probing support Sakari Ailus
2017-09-06  7:00   ` Hans Verkuil
2017-09-05 13:05 ` [PATCH v8 03/21] v4l: async: Use more intuitive names for internal functions Sakari Ailus
2017-09-06  7:01   ` Hans Verkuil
2017-09-08 12:40   ` Pavel Machek
2017-09-05 13:05 ` [PATCH v8 05/21] docs-rst: v4l: Include Qualcomm CAMSS in documentation build Sakari Ailus
2017-09-05 13:05 ` [PATCH v8 06/21] v4l: fwnode: Support generic parsing of graph endpoints in a device Sakari Ailus
     [not found]   ` <20170905130553.1332-7-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-06  7:41     ` Hans Verkuil
2017-09-06  7:41       ` Hans Verkuil
     [not found]       ` <dd3a2e55-8de0-c30e-04a7-cb26b519689c-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2017-09-07  7:34         ` Sakari Ailus
2017-09-07  7:34           ` Sakari Ailus
2017-09-07  8:51           ` Hans Verkuil
2017-09-07  9:58             ` Sakari Ailus
     [not found]               ` <20170907095850.m7mlag3tofwbj2jc-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2017-09-07 12:03                 ` Hans Verkuil
2017-09-07 12:03                   ` Hans Verkuil
2017-09-05 13:05 ` [PATCH v8 09/21] omap3isp: Fix check for our own sub-devices Sakari Ailus
     [not found]   ` <20170905130553.1332-10-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-06  7:45     ` Hans Verkuil
2017-09-06  7:45       ` Hans Verkuil
2017-09-05 13:05 ` [PATCH v8 12/21] v4l: async: Introduce helpers for calling async ops callbacks Sakari Ailus
     [not found]   ` <20170905130553.1332-13-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-06  7:50     ` Hans Verkuil
2017-09-06  7:50       ` Hans Verkuil
2017-09-07  7:51       ` Sakari Ailus
2017-09-05 13:05 ` [PATCH v8 16/21] dt: bindings: Add lens-focus binding for image sensors Sakari Ailus
     [not found]   ` <20170905130553.1332-17-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-06  8:48     ` Hans Verkuil
2017-09-06  8:48       ` Hans Verkuil
     [not found] ` <20170905130553.1332-1-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-05 13:05   ` [PATCH v8 01/21] v4l: fwnode: Move KernelDoc documentation to the header Sakari Ailus
2017-09-05 13:05     ` Sakari Ailus
     [not found]     ` <20170905130553.1332-2-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-08 12:39       ` Pavel Machek
2017-09-08 12:39         ` Pavel Machek
2017-09-05 13:05   ` [PATCH v8 04/21] v4l: async: Add V4L2 async documentation to the documentation build Sakari Ailus
2017-09-05 13:05     ` Sakari Ailus
2017-09-05 13:05   ` [PATCH v8 07/21] omap3isp: Use generic parser for parsing fwnode endpoints Sakari Ailus
2017-09-05 13:05     ` Sakari Ailus
     [not found]     ` <20170905130553.1332-8-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-06  7:42       ` Hans Verkuil
2017-09-06  7:42         ` Hans Verkuil
2017-09-05 13:05   ` [PATCH v8 08/21] rcar-vin: " Sakari Ailus
2017-09-05 13:05     ` Sakari Ailus
     [not found]     ` <20170905130553.1332-9-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-06  7:44       ` Hans Verkuil
2017-09-06  7:44         ` Hans Verkuil
     [not found]         ` <a51aea1f-0a00-7a7b-8197-e0f5a0443a05-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2017-09-07  8:09           ` Sakari Ailus
2017-09-07  8:09             ` Sakari Ailus
2017-09-05 13:05   ` [PATCH v8 10/21] omap3isp: Print the name of the entity where no source pads could be found Sakari Ailus
2017-09-05 13:05     ` Sakari Ailus
2017-09-06  7:45     ` Hans Verkuil
2017-09-05 13:05   ` [PATCH v8 11/21] v4l: async: Move async subdev notifier operations to a separate structure Sakari Ailus
2017-09-05 13:05     ` Sakari Ailus
2017-09-05 13:05   ` [PATCH v8 13/21] v4l: async: Register sub-devices before calling bound callback Sakari Ailus
2017-09-05 13:05     ` Sakari Ailus
     [not found]     ` <20170905130553.1332-14-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-06  7:51       ` Hans Verkuil
2017-09-06  7:51         ` Hans Verkuil
2017-09-05 13:05   ` [PATCH v8 14/21] v4l: async: Allow binding notifiers to sub-devices Sakari Ailus
2017-09-05 13:05     ` Sakari Ailus
     [not found]     ` <20170905130553.1332-15-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-06  8:46       ` Hans Verkuil
2017-09-06  8:46         ` Hans Verkuil
2017-09-07  8:32         ` Sakari Ailus
     [not found]           ` <20170907083209.3xtaxwhrfmgrtpfz-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2017-09-07 12:02             ` Hans Verkuil
2017-09-07 12:02               ` Hans Verkuil
2017-09-05 13:05   ` [PATCH v8 15/21] dt: bindings: Add a binding for flash devices associated to a sensor Sakari Ailus
2017-09-05 13:05     ` Sakari Ailus
2017-09-06  8:47     ` Hans Verkuil
2017-09-05 13:05   ` [PATCH v8 17/21] v4l: fwnode: Add convenience function for parsing generic references Sakari Ailus
2017-09-05 13:05     ` Sakari Ailus
2017-09-05 13:05   ` [PATCH v8 18/21] v4l: fwnode: Add convenience function for parsing common external refs Sakari Ailus
2017-09-05 13:05     ` Sakari Ailus
2017-09-05 13:05   ` Sakari Ailus [this message]
2017-09-05 13:05     ` [PATCH v8 19/21] smiapp: Add support for flash and lens devices Sakari Ailus
2017-09-05 13:05 ` [PATCH v8 20/21] dt: bindings: smiapp: Document lens-focus and flash properties Sakari Ailus
2017-09-05 13:05 ` [PATCH v8 21/21] arm: dts: omap3: N9/N950: Add flash references to the camera Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170905130553.1332-20-sakari.ailus@linux.intel.com \
    --to=sakari.ailus-vuqaysv1563yd54fqh9/ca@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org \
    --cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
    --cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=niklas.soderlund-1zkq55x86MTxsAP9Fp7wbw@public.gmane.org \
    --cc=pavel-+ZI9xUNit7I@public.gmane.org \
    --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.