From: Nicolin Chen <nicoleotsuka@gmail.com> To: "Łukasz Majewski" <lukma@denx.de> Cc: Fabio Estevam <fabio.estevam@nxp.com>, Timur Tabi <timur@tabi.org>, Xiubo Li <Xiubo.Lee@gmail.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, "festevam@gmail.com" <festevam@gmail.com>, "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Date: Tue, 5 Sep 2017 15:52:26 -0700 [thread overview] Message-ID: <20170905225225.GA14132@Asurada-Nvidia> (raw) In-Reply-To: <cfb8f844-87aa-f1f3-bd55-4f2b60f3cf88@denx.de> On Tue, Sep 05, 2017 at 11:13:40PM +0200, Łukasz Majewski wrote: > They key point here is the asoc_simple_card_parse_clk() function > from simple-card-utils.c > > Please look how the clock is assigned; It first checks for cpu > clock, then for "system-clock-frequency" DTS node and _finally_ > looks for another "child" clock [1], which is the codec attached to > I2C. Here is the routine that I understood from the code: 1) asoc_simple_card_parse_clk_cpu(dev, cpu, dai_link, cpu_dai); => asoc_simple_card_parse_clk(dev, cpu, // cpu node in sound{} [1] dai_link->cpu_of_node, // node ssi2 [2] cpu_dai, dai_link->cpu_dai_name); ==> 1.1) devm_get_clk_from_child(dev, node, NULL); // [1] ==> 1.2) of_property_read_u32(node, "system-clock-frequency", &val)// [1] ==> 1.3) devm_get_clk_from_child(dev, dai_of_node, NULL); // [2] 2) asoc_simple_card_parse_clk_codec(dev, codec, dai_link, codec_dai); => asoc_simple_card_parse_clk(dev, codec, // codec node in sound{} [3] dai_link->codec_of_node,// node tfa9879 [4] codec_dai, dai_link->codec_dai_name); ==> 2.1) devm_get_clk_from_child(dev, node, NULL); // [3] ==> 2.2) of_property_read_u32(node, "system-clock-frequency", &val)// [3] ==> 2.3) devm_get_clk_from_child(dev, dai_of_node, NULL); // [4] For the cpu routine, it first checks for clock property under cpu node of simple-card, then for "system-clock-frequency" in the cpu node of simple-card, and finally looks for clock property in ssi2 node. For codec routine, it first checks for clock property under codec node of simple-card, then for "system-clock-frequency" in codec node of simple-card, and finally looks for clock property in the tfa9879 node. The cpu and codec are totally separate, aren't they? And I don't think it's right if not. > >>which has clock from I2C (66 MHz). > > > >You mean I2C scl or I2S sclk? > > I2C scl. A couple of things here..... 1) I don't think I2C scl can run at 66MHz...The 66MHz is probably the ipg clock of I2C controller. 2) Even if the scl does run at 66MHz, there is no point in passing the clock of I2C scl into an I2S dai-link. So I feel something must be wrong. I suggest you to add some printk to check the names of those nodes and x_of_node in the simple card driver. > My DTS [1] (it is different than other in-tree supported codecs - at > least I did not find similar setup in DTSes): > > sound { > compatible = "simple-audio-card"; > label = "tfa9879-mono"; > > simple-audio-card,dai-link { > /* DAC */ > format = "i2s"; > bitclock-master = <&dailink_master>; > frame-master = <&dailink_master>; > > dailink_master: cpu { > sound-dai = <&ssi2>; > }; > codec { > sound-dai = <&codec>; > }; > }; I remember there is another style for a single dai-link. Could you please try that one? There is an example in: Documentation/devicetree/bindings/sound/simple-card.txt
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com> To: "Łukasz Majewski" <lukma@denx.de> Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, Timur Tabi <timur@tabi.org>, Xiubo Li <Xiubo.Lee@gmail.com>, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>, Takashi Iwai <tiwai@suse.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Fabio Estevam <fabio.estevam@nxp.com>, "festevam@gmail.com" <festevam@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Date: Tue, 5 Sep 2017 15:52:26 -0700 [thread overview] Message-ID: <20170905225225.GA14132@Asurada-Nvidia> (raw) In-Reply-To: <cfb8f844-87aa-f1f3-bd55-4f2b60f3cf88@denx.de> On Tue, Sep 05, 2017 at 11:13:40PM +0200, Łukasz Majewski wrote: > They key point here is the asoc_simple_card_parse_clk() function > from simple-card-utils.c > > Please look how the clock is assigned; It first checks for cpu > clock, then for "system-clock-frequency" DTS node and _finally_ > looks for another "child" clock [1], which is the codec attached to > I2C. Here is the routine that I understood from the code: 1) asoc_simple_card_parse_clk_cpu(dev, cpu, dai_link, cpu_dai); => asoc_simple_card_parse_clk(dev, cpu, // cpu node in sound{} [1] dai_link->cpu_of_node, // node ssi2 [2] cpu_dai, dai_link->cpu_dai_name); ==> 1.1) devm_get_clk_from_child(dev, node, NULL); // [1] ==> 1.2) of_property_read_u32(node, "system-clock-frequency", &val)// [1] ==> 1.3) devm_get_clk_from_child(dev, dai_of_node, NULL); // [2] 2) asoc_simple_card_parse_clk_codec(dev, codec, dai_link, codec_dai); => asoc_simple_card_parse_clk(dev, codec, // codec node in sound{} [3] dai_link->codec_of_node,// node tfa9879 [4] codec_dai, dai_link->codec_dai_name); ==> 2.1) devm_get_clk_from_child(dev, node, NULL); // [3] ==> 2.2) of_property_read_u32(node, "system-clock-frequency", &val)// [3] ==> 2.3) devm_get_clk_from_child(dev, dai_of_node, NULL); // [4] For the cpu routine, it first checks for clock property under cpu node of simple-card, then for "system-clock-frequency" in the cpu node of simple-card, and finally looks for clock property in ssi2 node. For codec routine, it first checks for clock property under codec node of simple-card, then for "system-clock-frequency" in codec node of simple-card, and finally looks for clock property in the tfa9879 node. The cpu and codec are totally separate, aren't they? And I don't think it's right if not. > >>which has clock from I2C (66 MHz). > > > >You mean I2C scl or I2S sclk? > > I2C scl. A couple of things here..... 1) I don't think I2C scl can run at 66MHz...The 66MHz is probably the ipg clock of I2C controller. 2) Even if the scl does run at 66MHz, there is no point in passing the clock of I2C scl into an I2S dai-link. So I feel something must be wrong. I suggest you to add some printk to check the names of those nodes and x_of_node in the simple card driver. > My DTS [1] (it is different than other in-tree supported codecs - at > least I did not find similar setup in DTSes): > > sound { > compatible = "simple-audio-card"; > label = "tfa9879-mono"; > > simple-audio-card,dai-link { > /* DAC */ > format = "i2s"; > bitclock-master = <&dailink_master>; > frame-master = <&dailink_master>; > > dailink_master: cpu { > sound-dai = <&ssi2>; > }; > codec { > sound-dai = <&codec>; > }; > }; I remember there is another style for a single dai-link. Could you please try that one? There is an example in: Documentation/devicetree/bindings/sound/simple-card.txt _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2017-09-05 22:52 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-03 11:05 [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Lukasz Majewski 2017-09-03 12:44 ` Fabio Estevam 2017-09-03 12:44 ` Fabio Estevam 2017-09-03 14:40 ` Łukasz Majewski 2017-09-03 15:29 ` Fabio Estevam 2017-09-03 15:29 ` Fabio Estevam 2017-09-03 15:29 ` Fabio Estevam 2017-09-05 5:20 ` Nicolin Chen 2017-09-05 8:35 ` Łukasz Majewski 2017-09-05 18:11 ` Nicolin Chen 2017-09-05 21:13 ` Łukasz Majewski 2017-09-05 21:13 ` Łukasz Majewski 2017-09-05 22:52 ` Nicolin Chen [this message] 2017-09-05 22:52 ` Nicolin Chen 2017-09-06 9:22 ` Łukasz Majewski 2017-09-06 9:22 ` Łukasz Majewski 2017-09-06 17:33 ` Nicolin Chen 2017-09-06 17:33 ` Nicolin Chen 2017-09-06 18:35 ` Łukasz Majewski 2017-09-06 19:47 ` Nicolin Chen 2017-09-06 19:47 ` Nicolin Chen 2017-09-06 21:18 ` Łukasz Majewski 2017-09-06 21:18 ` Łukasz Majewski 2017-09-07 23:10 ` Łukasz Majewski 2017-09-07 23:10 ` Łukasz Majewski 2017-09-08 0:39 ` Nicolin Chen 2017-09-08 0:39 ` Nicolin Chen 2017-09-05 23:20 ` Fabio Estevam 2017-09-05 23:20 ` Fabio Estevam 2017-09-05 23:20 ` Fabio Estevam 2017-09-06 8:44 ` Łukasz Majewski 2017-09-05 20:14 ` Fabio Estevam 2017-09-05 20:14 ` Fabio Estevam 2017-09-05 21:14 ` Łukasz Majewski 2017-09-05 5:06 ` Nicolin Chen 2017-09-05 7:37 ` Łukasz Majewski 2017-09-05 7:52 ` Nicolin Chen 2017-09-05 8:19 ` Łukasz Majewski 2017-09-05 8:19 ` Łukasz Majewski 2017-09-05 15:15 ` Mark Brown 2017-09-05 15:15 ` Mark Brown 2017-09-05 17:45 ` Nicolin Chen 2017-09-07 13:44 ` Mark Brown 2017-09-07 13:44 ` Mark Brown 2017-09-07 23:03 ` Nicolin Chen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170905225225.GA14132@Asurada-Nvidia \ --to=nicoleotsuka@gmail.com \ --cc=Xiubo.Lee@gmail.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=fabio.estevam@nxp.com \ --cc=festevam@gmail.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=lukma@denx.de \ --cc=perex@perex.cz \ --cc=timur@tabi.org \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.