All of lore.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Dong Aisheng <aisheng.dong@nxp.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, sboyd@codeaurora.org,
	vireshk@kernel.org, nm@ti.com, rjw@rjwysocki.net,
	shawnguo@kernel.org, Anson.Huang@nxp.com, ping.bai@nxp.com
Subject: Re: [PATCH 1/7] PM / OPP: Add platform specific set_clk function
Date: Tue, 19 Sep 2017 15:58:40 -0700	[thread overview]
Message-ID: <20170919225840.GI30848@ubuntu> (raw)
In-Reply-To: <1503504610-12880-2-git-send-email-aisheng.dong@nxp.com>

On 24-08-17, 00:10, Dong Aisheng wrote:
> This is useful to support platforms which only the clk setting is
> different from the generic OPP set rate but others like voltage
> setting are still the same.
> 
> Users can use this function to register a custom OPP set clk helper
> working in place of the default simple clk setting in the generic
> dev_pm_opp_set_rate(). Then user can still use dev_pm_opp_set_rate()
> with .set_clk() to save a lot duplicated work.

I am not inclined to add this support really. What prevents you to
register a clock for the device (which is CPU in your case) and the
generic clk_set_rate() will eventually call into the platform specific
routine. That's what everyone else is doing.

-- 
viresh

WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] PM / OPP: Add platform specific set_clk function
Date: Tue, 19 Sep 2017 15:58:40 -0700	[thread overview]
Message-ID: <20170919225840.GI30848@ubuntu> (raw)
In-Reply-To: <1503504610-12880-2-git-send-email-aisheng.dong@nxp.com>

On 24-08-17, 00:10, Dong Aisheng wrote:
> This is useful to support platforms which only the clk setting is
> different from the generic OPP set rate but others like voltage
> setting are still the same.
> 
> Users can use this function to register a custom OPP set clk helper
> working in place of the default simple clk setting in the generic
> dev_pm_opp_set_rate(). Then user can still use dev_pm_opp_set_rate()
> with .set_clk() to save a lot duplicated work.

I am not inclined to add this support really. What prevents you to
register a clock for the device (which is CPU in your case) and the
generic clk_set_rate() will eventually call into the platform specific
routine. That's what everyone else is doing.

-- 
viresh

  reply	other threads:[~2017-09-19 22:58 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23 16:10 [PATCH 0/7] PM / OPP: per OPP node clock support and imx7ulp cpufreq driver Dong Aisheng
2017-08-23 16:10 ` Dong Aisheng
2017-08-23 16:10 ` Dong Aisheng
2017-08-23 16:10 ` [PATCH 1/7] PM / OPP: Add platform specific set_clk function Dong Aisheng
2017-08-23 16:10   ` Dong Aisheng
2017-08-23 16:10   ` Dong Aisheng
2017-09-19 22:58   ` Viresh Kumar [this message]
2017-09-19 22:58     ` Viresh Kumar
2017-09-20  7:03     ` Dong Aisheng
2017-09-20  7:03       ` Dong Aisheng
2017-09-20 20:30       ` Viresh Kumar
2017-09-20 20:30         ` Viresh Kumar
2017-09-21  2:17         ` A.s. Dong
2017-09-21  2:17           ` A.s. Dong
2017-09-21  2:17           ` A.s. Dong
2017-08-23 16:10 ` [PATCH 2/7] dt-bindings: PM / OPP: add clocks per OPP node support Dong Aisheng
2017-08-23 16:10   ` Dong Aisheng
2017-08-23 16:10   ` Dong Aisheng
2017-08-31 17:39   ` Rob Herring
2017-08-31 17:39     ` Rob Herring
2017-09-01 13:01     ` Dong Aisheng
2017-09-01 13:01       ` Dong Aisheng
2017-08-23 16:10 ` [PATCH 3/7] PM / OPP: rename opp_table->clk to opp_table->cur_clk Dong Aisheng
2017-08-23 16:10   ` Dong Aisheng
2017-08-23 16:10   ` Dong Aisheng
2017-08-23 16:10 ` [PATCH 4/7] PM / OPP: use OPP node clock to set CPU frequency Dong Aisheng
2017-08-23 16:10   ` Dong Aisheng
2017-08-23 16:10   ` Dong Aisheng
2017-08-23 16:10 ` [PATCH 5/7] PM / OPP: Add dev_pm_opp_get_cur_clk() Dong Aisheng
2017-08-23 16:10   ` Dong Aisheng
2017-08-23 16:10   ` Dong Aisheng
2017-08-23 16:10 ` [PATCH 6/7] cpufreq: make cpufreq_generic_init transition_latency default to CPUFREQ_ETERNAL Dong Aisheng
2017-08-23 16:10   ` Dong Aisheng
2017-08-23 16:10   ` Dong Aisheng
2017-09-19 23:10   ` Viresh Kumar
2017-09-19 23:10     ` Viresh Kumar
2017-09-20  7:04     ` Dong Aisheng
2017-09-20  7:04       ` Dong Aisheng
2017-09-20 14:45       ` Viresh Kumar
2017-09-20 14:45         ` Viresh Kumar
2017-08-23 16:10 ` [PATCH 7/7] cpufreq: add imx7ulp cpufreq driver Dong Aisheng
2017-08-23 16:10   ` Dong Aisheng
2017-08-23 16:10   ` Dong Aisheng
2017-09-11  7:28 ` [PATCH 0/7] PM / OPP: per OPP node clock support and " Dong Aisheng
2017-09-11  7:28   ` Dong Aisheng
2017-09-19 22:54   ` Viresh Kumar
2017-09-19 22:54     ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170919225840.GI30848@ubuntu \
    --to=viresh.kumar@linaro.org \
    --cc=Anson.Huang@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=ping.bai@nxp.com \
    --cc=rjw@rjwysocki.net \
    --cc=sboyd@codeaurora.org \
    --cc=shawnguo@kernel.org \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.