From: Dong Aisheng <dongas86@gmail.com> To: Viresh Kumar <viresh.kumar@linaro.org> Cc: Dong Aisheng <aisheng.dong@nxp.com>, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sboyd@codeaurora.org, vireshk@kernel.org, nm@ti.com, rjw@rjwysocki.net, shawnguo@kernel.org, Anson.Huang@nxp.com, ping.bai@nxp.com Subject: Re: [PATCH 6/7] cpufreq: make cpufreq_generic_init transition_latency default to CPUFREQ_ETERNAL Date: Wed, 20 Sep 2017 15:04:50 +0800 [thread overview] Message-ID: <20170920070450.GB32187@b29396-OptiPlex-7040> (raw) In-Reply-To: <20170919231007.GJ30848@ubuntu> On Tue, Sep 19, 2017 at 04:10:07PM -0700, Viresh Kumar wrote: > On 24-08-17, 00:10, Dong Aisheng wrote: > > If no valid transition_latency specified, let's make it default to > > CPUFREQ_ETERNAL which is consistent with its definition. > > > > This can save some of the same checkings like this: > > transition_latency = dev_pm_opp_get_max_transition_latency(cpu_dev); > > - if (!transition_latency) > > - transition_latency = CPUFREQ_ETERNAL; > > ret = cpufreq_generic_init(policy, freq_table, transition_latency); > > > > Cc: Viresh Kumar <vireshk@kernel.org> > > Cc: Nishanth Menon <nm@ti.com> > > Cc: Stephen Boyd <sboyd@codeaurora.org> > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > --- > > drivers/cpufreq/cpufreq.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > > index 9bf97a3..da07de6 100644 > > --- a/drivers/cpufreq/cpufreq.c > > +++ b/drivers/cpufreq/cpufreq.c > > @@ -180,6 +180,8 @@ int cpufreq_generic_init(struct cpufreq_policy *policy, > > return ret; > > } > > > > + if (!transition_latency) > > + transition_latency = CPUFREQ_ETERNAL; > > policy->cpuinfo.transition_latency = transition_latency; > > > > /* > > Can you update all the existing drivers as well (in the same patch) > who can benefit from it? Yes, of course. Will do it in the updated version later. Thanks Regards Dong Aisheng > > -- > viresh
WARNING: multiple messages have this Message-ID (diff)
From: dongas86@gmail.com (Dong Aisheng) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 6/7] cpufreq: make cpufreq_generic_init transition_latency default to CPUFREQ_ETERNAL Date: Wed, 20 Sep 2017 15:04:50 +0800 [thread overview] Message-ID: <20170920070450.GB32187@b29396-OptiPlex-7040> (raw) In-Reply-To: <20170919231007.GJ30848@ubuntu> On Tue, Sep 19, 2017 at 04:10:07PM -0700, Viresh Kumar wrote: > On 24-08-17, 00:10, Dong Aisheng wrote: > > If no valid transition_latency specified, let's make it default to > > CPUFREQ_ETERNAL which is consistent with its definition. > > > > This can save some of the same checkings like this: > > transition_latency = dev_pm_opp_get_max_transition_latency(cpu_dev); > > - if (!transition_latency) > > - transition_latency = CPUFREQ_ETERNAL; > > ret = cpufreq_generic_init(policy, freq_table, transition_latency); > > > > Cc: Viresh Kumar <vireshk@kernel.org> > > Cc: Nishanth Menon <nm@ti.com> > > Cc: Stephen Boyd <sboyd@codeaurora.org> > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > --- > > drivers/cpufreq/cpufreq.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > > index 9bf97a3..da07de6 100644 > > --- a/drivers/cpufreq/cpufreq.c > > +++ b/drivers/cpufreq/cpufreq.c > > @@ -180,6 +180,8 @@ int cpufreq_generic_init(struct cpufreq_policy *policy, > > return ret; > > } > > > > + if (!transition_latency) > > + transition_latency = CPUFREQ_ETERNAL; > > policy->cpuinfo.transition_latency = transition_latency; > > > > /* > > Can you update all the existing drivers as well (in the same patch) > who can benefit from it? Yes, of course. Will do it in the updated version later. Thanks Regards Dong Aisheng > > -- > viresh
next prev parent reply other threads:[~2017-09-20 7:05 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-23 16:10 [PATCH 0/7] PM / OPP: per OPP node clock support and imx7ulp cpufreq driver Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` [PATCH 1/7] PM / OPP: Add platform specific set_clk function Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-09-19 22:58 ` Viresh Kumar 2017-09-19 22:58 ` Viresh Kumar 2017-09-20 7:03 ` Dong Aisheng 2017-09-20 7:03 ` Dong Aisheng 2017-09-20 20:30 ` Viresh Kumar 2017-09-20 20:30 ` Viresh Kumar 2017-09-21 2:17 ` A.s. Dong 2017-09-21 2:17 ` A.s. Dong 2017-09-21 2:17 ` A.s. Dong 2017-08-23 16:10 ` [PATCH 2/7] dt-bindings: PM / OPP: add clocks per OPP node support Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-31 17:39 ` Rob Herring 2017-08-31 17:39 ` Rob Herring 2017-09-01 13:01 ` Dong Aisheng 2017-09-01 13:01 ` Dong Aisheng 2017-08-23 16:10 ` [PATCH 3/7] PM / OPP: rename opp_table->clk to opp_table->cur_clk Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` [PATCH 4/7] PM / OPP: use OPP node clock to set CPU frequency Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` [PATCH 5/7] PM / OPP: Add dev_pm_opp_get_cur_clk() Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` [PATCH 6/7] cpufreq: make cpufreq_generic_init transition_latency default to CPUFREQ_ETERNAL Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-09-19 23:10 ` Viresh Kumar 2017-09-19 23:10 ` Viresh Kumar 2017-09-20 7:04 ` Dong Aisheng [this message] 2017-09-20 7:04 ` Dong Aisheng 2017-09-20 14:45 ` Viresh Kumar 2017-09-20 14:45 ` Viresh Kumar 2017-08-23 16:10 ` [PATCH 7/7] cpufreq: add imx7ulp cpufreq driver Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-09-11 7:28 ` [PATCH 0/7] PM / OPP: per OPP node clock support and " Dong Aisheng 2017-09-11 7:28 ` Dong Aisheng 2017-09-19 22:54 ` Viresh Kumar 2017-09-19 22:54 ` Viresh Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170920070450.GB32187@b29396-OptiPlex-7040 \ --to=dongas86@gmail.com \ --cc=Anson.Huang@nxp.com \ --cc=aisheng.dong@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=nm@ti.com \ --cc=ping.bai@nxp.com \ --cc=rjw@rjwysocki.net \ --cc=sboyd@codeaurora.org \ --cc=shawnguo@kernel.org \ --cc=viresh.kumar@linaro.org \ --cc=vireshk@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.