From: Jiri Benc <jbenc@redhat.com>
To: Simon Horman <simon.horman@netronome.com>
Cc: David Miller <davem@davemloft.net>,
Jiri Pirko <jiri@mellanox.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [PATCH v2 net-next 0/2] net/sched: support tunnel options in cls_flower and act_tunnel_key
Date: Wed, 27 Sep 2017 17:46:37 +0200 [thread overview]
Message-ID: <20170927174637.28654c72@griffin> (raw)
In-Reply-To: <1506500194-17637-1-git-send-email-simon.horman@netronome.com>
On Wed, 27 Sep 2017 10:16:32 +0200, Simon Horman wrote:
> * Geneve
>
> In the case of Geneve options are TLVs[1]. My reading is that in collect
> metadata mode the kernel does not appear to do anything other than pass
> them around as a bytestring.
>
> [1] https://tools.ietf.org/html/draft-ietf-nvo3-geneve-05#section-3.5
[...]
>
> Neither of the above appear to assume any structure for the data.
But that's not true. Geneve uses TLVs, you even mentioned that
yourself. Matching on a block of TLVs as a bytestring doesn't make
sense. The TLV fields may be in any order.
We need better matching here. Bytestring is useless for Geneve.
NACK for this direction of option matching. We'd need to introduce
matching on TLVs sooner or later anyway and this would be just a never
used compat cruft that we need to keep around forever.
Jiri
next prev parent reply other threads:[~2017-09-27 15:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 8:16 [PATCH v2 net-next 0/2] net/sched: support tunnel options in cls_flower and act_tunnel_key Simon Horman
2017-09-27 8:16 ` [PATCH v2 net-next 1/2] net/sched: add tunnel option support to act_tunnel_key Simon Horman
2017-09-27 8:16 ` [PATCH v2 net-next 2/2] net/sched: allow flower to match tunnel options Simon Horman
2017-09-27 9:10 ` Jiri Pirko
2017-09-27 9:27 ` Simon Horman
2017-09-27 11:08 ` Jiri Pirko
2017-09-27 11:54 ` Simon Horman
2017-09-27 12:52 ` Simon Horman
2017-09-27 12:56 ` Jiri Pirko
2017-09-27 13:37 ` Simon Horman
2017-09-27 13:47 ` Jiri Pirko
2017-09-27 13:50 ` Simon Horman
2017-09-27 14:00 ` Jiri Pirko
2017-09-27 14:09 ` Simon Horman
2017-09-27 14:19 ` Jiri Pirko
2017-09-27 15:46 ` Jiri Benc [this message]
2017-09-29 4:54 ` [PATCH v2 net-next 0/2] net/sched: support tunnel options in cls_flower and act_tunnel_key David Miller
2017-10-02 7:50 ` Simon Horman
2017-10-05 12:51 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927174637.28654c72@griffin \
--to=jbenc@redhat.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=simon.horman@netronome.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.