From: Jiri Benc <jbenc@redhat.com>
To: Simon Horman <simon.horman@netronome.com>
Cc: David Miller <davem@davemloft.net>,
jiri@mellanox.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [PATCH v2 net-next 0/2] net/sched: support tunnel options in cls_flower and act_tunnel_key
Date: Thu, 5 Oct 2017 14:51:30 +0200 [thread overview]
Message-ID: <20171005145130.1f9bd7c4@griffin> (raw)
In-Reply-To: <20171002075013.GA22179@netronome.com>
On Mon, 2 Oct 2017 09:50:15 +0200, Simon Horman wrote:
> I believe that in order to avoid per-packet overhead and at the same time
> code complexity the TLVs should be described in-order. So matching on
> TLV-A,TLV-B,TLV-C would be a different match to TLV-C,TLV-A,TLV-B. An
> order-independent match could be added if desired in future.
Although better than the binary format, I doubt that it would be
useful. I can't imagine a real use case where you would want such match.
Instead, what you want is a match on a particular TLV, wherever it is
in the data. For start, we can support just a single TLV.
I.e. when matching on TLV-A, all of these would match:
TLV-A,TLV-B,TLV-C; TLV-B,TLV-A,TLV-C; TLV-B,TLV-C,TLV-A. And this one
won't match: TLV-B,TLV-C,TLV-D.
Jiri
prev parent reply other threads:[~2017-10-05 12:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 8:16 [PATCH v2 net-next 0/2] net/sched: support tunnel options in cls_flower and act_tunnel_key Simon Horman
2017-09-27 8:16 ` [PATCH v2 net-next 1/2] net/sched: add tunnel option support to act_tunnel_key Simon Horman
2017-09-27 8:16 ` [PATCH v2 net-next 2/2] net/sched: allow flower to match tunnel options Simon Horman
2017-09-27 9:10 ` Jiri Pirko
2017-09-27 9:27 ` Simon Horman
2017-09-27 11:08 ` Jiri Pirko
2017-09-27 11:54 ` Simon Horman
2017-09-27 12:52 ` Simon Horman
2017-09-27 12:56 ` Jiri Pirko
2017-09-27 13:37 ` Simon Horman
2017-09-27 13:47 ` Jiri Pirko
2017-09-27 13:50 ` Simon Horman
2017-09-27 14:00 ` Jiri Pirko
2017-09-27 14:09 ` Simon Horman
2017-09-27 14:19 ` Jiri Pirko
2017-09-27 15:46 ` [PATCH v2 net-next 0/2] net/sched: support tunnel options in cls_flower and act_tunnel_key Jiri Benc
2017-09-29 4:54 ` David Miller
2017-10-02 7:50 ` Simon Horman
2017-10-05 12:51 ` Jiri Benc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005145130.1f9bd7c4@griffin \
--to=jbenc@redhat.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=simon.horman@netronome.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.