From: Ingo Molnar <email@example.com> To: Josh Poimboeuf <firstname.lastname@example.org> Cc: Linus Torvalds <email@example.com>, the arch/x86 maintainers <firstname.lastname@example.org>, kernel test robot <email@example.com>, Andrey Ryabinin <firstname.lastname@example.org>, Matthias Kaehlcke <email@example.com>, Alexander Potapenko <firstname.lastname@example.org>, Andy Lutomirski <email@example.com>, Arnd Bergmann <firstname.lastname@example.org>, Dmitriy Vyukov <email@example.com>, Miguel Bernal Marin <firstname.lastname@example.org>, Peter Zijlstra <email@example.com>, Thomas Gleixner <firstname.lastname@example.org>, LKML <email@example.com>, LKP <firstname.lastname@example.org> Subject: Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4 Date: Fri, 29 Sep 2017 10:01:28 +0200 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20170929014056.gzfge2efgwfxkokj@treble> * Josh Poimboeuf <firstname.lastname@example.org> wrote: > On Thu, Sep 28, 2017 at 04:53:09PM -0700, Linus Torvalds wrote: > > On Thu, Sep 28, 2017 at 2:58 PM, Josh Poimboeuf <email@example.com> wrote: > > > > > > Reported-by: kernel test robot <firstname.lastname@example.org> > > > Fixes: f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Clang") > > > Signed-off-by: Josh Poimboeuf <email@example.com> > > > > Side note: it's not like I personally need the credit, but in general > > I really want people to pick up on who debugged the code and pointed > > to the solution. That's often more of the work than the fix itself. > > > > The kernel test robot report looked to be ignored as a "gcc-4.4 is too > > old to worry about" thing. People who then step up and analyze the > > problem are rare as it is. They need to be credited in the commit > > logs. > > > > We don't have any fixed format for that, but it's pretty free-form. So > > we have tags like > > > > Root-caused-by: > > Diagnosed-by: > > Analyzed-by: > > Debugged-by: > > Bisected-by: > > Fix-suggested-by: > > > > etc for giving credit to people who figured out some part of a bug > > (and, having grepped for this, we also a _shitload_ of miss-spellings > > of various things ;) > > Indeed, credit is important and I try to give it where it's due. Sorry > for the snub! I anoint you with: > > Debugged-by: Linus Torvalds <firstname.lastname@example.org> When applying the fix I went with: Diagnosed-by: Linus Torvalds <email@example.com> Because I think 'diagnosing' a bug is a higher category, which implies debugging. ( Sometimes we refer to 'debugging a bug' as the reporter adding printks on request and printing out key state that helps understand the bug. It does not necessarily imply root-causing the bug. ) Also note that I added a "Reported-and-Bisected-by:" tag for the ktest robot, to further credit the fact that in addition to reporting a kernel crash, a specific commit was bisected to as well. I'll wait for another round of ktest robot testing to make sure the crash is indeed fixed. Thanks, Ingo
next prev parent reply other threads:[~2017-09-29 8:01 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-28 7:47 [lkp-robot] [x86/asm] f5caf621ee: PANIC:double_fault kernel test robot 2017-09-28 7:59 ` Ingo Molnar 2017-09-28 8:18 ` Peter Zijlstra 2017-09-28 8:49 ` Ingo Molnar 2017-09-28 11:49 ` Peter Zijlstra 2017-09-28 16:21 ` Linus Torvalds 2017-09-28 16:44 ` Josh Poimboeuf 2017-09-28 17:01 ` Josh Poimboeuf 2017-09-28 19:10 ` Josh Poimboeuf 2017-09-28 21:58 ` [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4 Josh Poimboeuf 2017-09-28 23:53 ` Linus Torvalds 2017-09-29 1:40 ` Josh Poimboeuf 2017-09-29 8:01 ` Ingo Molnar [this message] 2017-09-29 10:32 ` Ye Xiaolong 2017-09-29 7:51 ` Ingo Molnar 2017-09-29 15:29 ` Arnd Bergmann 2017-09-29 9:27 ` [tip:x86/urgent] " tip-bot for Josh Poimboeuf 2017-09-29 11:18 ` tip-bot for Josh Poimboeuf
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.