From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> To: Sebastian Reichel <sre-GFxCN5SEZAc@public.gmane.org> Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, "Benoît Cousson" <bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Dave Gerlach" <d-gerlach-l0cyMroinI0@public.gmane.org>, "Laurent Pinchart" <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>, "Liam Girdwood" <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "Mark Brown" <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>, "Mauro Carvalho Chehab" <mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Nishanth Menon" <nm-l0cyMroinI0@public.gmane.org>, "Matthijs van Duin" <matthijsvanduin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "Paul Walmsley" <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>, "Peter Ujfalusi" <peter.ujfalusi-l0cyMroinI0@public.gmane.org>, "Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Sakari Ailus" <sakari.ailus-X3B1VOXEql0@public.gmane.org>, "Suman Anna" <s-anna-l0cyMroinI0@public.gmane.org>, "Tero Kristo" <t-kristo-l0cyMroinI0@public.gmane.org>, "Tomi Valkeinen" <tomi.valkeinen-l0cyMroinI0@public.gmane.org> Subject: Re: [PATCH 1/7] dt-bindings: bus: Minimal TI sysc interconnect target module binding Date: Sun, 1 Oct 2017 10:14:07 -0700 [thread overview] Message-ID: <20171001171406.GL4394@atomide.com> (raw) In-Reply-To: <20171001131151.loanjnvarkihbhik@earth> * Sebastian Reichel <sre-GFxCN5SEZAc@public.gmane.org> [171001 06:12]: > On Fri, Sep 29, 2017 at 03:34:05PM -0700, Tony Lindgren wrote: > > Note that additional properties for sysc capabilities will be added > > later on. For now, we can already use this binding for interconnect > > target modules that do not have any child device drivers available. > > This allows us to idle the unused interconnect target modules during > > init without the need for legacy hwmod platform data for doing it. > > DT backwards compatibility is about booting an old DT file with a > newer kernel. Since old DT file does not contain a "ti,sysc-omap*" > node you don't need to add "ti,hwmod = *" support to it. Instead a > DT file, that uses ti,hwmod in the device node and does not have a > "ti,sysc-omap*" at all should still work. Not sure if I parse that right, but I'm assuming you suggest leaving out ti,hwmod to start with. Well I considered that, but it causes the "waiting for a magical flip issue". So initially we need to use both ti,sysc and ti,hwmod until ti,sysc alone has the equal functionality. That's because then we can do the following steps: 1. We want to add compatible = ti,sysc so we can define the nodes and get the parent-children hierarhcy right. We can already use the parent-child features even with ti,hwmods before we have complete dts based data. We are currently missing that capability without doing device specific parent drivers like we do with drivers/usb/musb/musb_am335x.c. Note that in this step we are moving the ti,hwmod to the parent node 2. When ti,sysc can configure things based on dts data alone the same way as the legacy platform data, we can just drop the ti,hwmod property. We also want to be able to test one driver at a time between ti,sysc + ti,hwmod vs ti,sysc only 3. Once ti,hwmod properties have been removed from the mainline kernel, we can add a warning about ti,hwmod properties being deprecated 4. Then later on, we can also drop the hwmod platform data and continue produce warnings if ti,hwmod is seen > IMHO we should break DT ABI for OMAP at some point, so that we can > get rid of the hwmod database. My suggestion would be, that > simple-bus checks if any child device is != "ti,omap-sysc*" and > does panic("please update DT!"). Yes we can eventually drop the static data and ti,hwmod while providing helpful information to the users. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/7] dt-bindings: bus: Minimal TI sysc interconnect target module binding Date: Sun, 1 Oct 2017 10:14:07 -0700 [thread overview] Message-ID: <20171001171406.GL4394@atomide.com> (raw) In-Reply-To: <20171001131151.loanjnvarkihbhik@earth> * Sebastian Reichel <sre@ring0.de> [171001 06:12]: > On Fri, Sep 29, 2017 at 03:34:05PM -0700, Tony Lindgren wrote: > > Note that additional properties for sysc capabilities will be added > > later on. For now, we can already use this binding for interconnect > > target modules that do not have any child device drivers available. > > This allows us to idle the unused interconnect target modules during > > init without the need for legacy hwmod platform data for doing it. > > DT backwards compatibility is about booting an old DT file with a > newer kernel. Since old DT file does not contain a "ti,sysc-omap*" > node you don't need to add "ti,hwmod = *" support to it. Instead a > DT file, that uses ti,hwmod in the device node and does not have a > "ti,sysc-omap*" at all should still work. Not sure if I parse that right, but I'm assuming you suggest leaving out ti,hwmod to start with. Well I considered that, but it causes the "waiting for a magical flip issue". So initially we need to use both ti,sysc and ti,hwmod until ti,sysc alone has the equal functionality. That's because then we can do the following steps: 1. We want to add compatible = ti,sysc so we can define the nodes and get the parent-children hierarhcy right. We can already use the parent-child features even with ti,hwmods before we have complete dts based data. We are currently missing that capability without doing device specific parent drivers like we do with drivers/usb/musb/musb_am335x.c. Note that in this step we are moving the ti,hwmod to the parent node 2. When ti,sysc can configure things based on dts data alone the same way as the legacy platform data, we can just drop the ti,hwmod property. We also want to be able to test one driver at a time between ti,sysc + ti,hwmod vs ti,sysc only 3. Once ti,hwmod properties have been removed from the mainline kernel, we can add a warning about ti,hwmod properties being deprecated 4. Then later on, we can also drop the hwmod platform data and continue produce warnings if ti,hwmod is seen > IMHO we should break DT ABI for OMAP at some point, so that we can > get rid of the hwmod database. My suggestion would be, that > simple-bus checks if any child device is != "ti,omap-sysc*" and > does panic("please update DT!"). Yes we can eventually drop the static data and ti,hwmod while providing helpful information to the users. Regards, Tony
next prev parent reply other threads:[~2017-10-01 17:14 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-29 22:34 [PATCHv4 0/7] Fix remaining issues to drop more omap platform data Tony Lindgren 2017-09-29 22:34 ` Tony Lindgren [not found] ` <20170929223411.9691-1-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2017-09-29 22:34 ` [PATCH 1/7] dt-bindings: bus: Minimal TI sysc interconnect target module binding Tony Lindgren 2017-09-29 22:34 ` Tony Lindgren 2017-10-01 13:11 ` Sebastian Reichel 2017-10-01 13:11 ` Sebastian Reichel 2017-10-01 17:14 ` Tony Lindgren [this message] 2017-10-01 17:14 ` Tony Lindgren [not found] ` <20171001171406.GL4394-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2017-10-01 20:48 ` Sebastian Reichel 2017-10-01 20:48 ` Sebastian Reichel 2017-10-01 21:03 ` Tony Lindgren 2017-10-01 21:03 ` Tony Lindgren [not found] ` <20170929223411.9691-2-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2017-10-10 15:46 ` Rob Herring 2017-10-10 15:46 ` Rob Herring 2017-10-10 16:45 ` Tony Lindgren 2017-10-10 16:45 ` Tony Lindgren 2017-09-29 22:34 ` [PATCH 2/7] ARM: OMAP2+: Parse module IO range from dts for legacy "ti,hwmods" support Tony Lindgren 2017-09-29 22:34 ` [PATCH 2/7] ARM: OMAP2+: Parse module IO range from dts for legacy "ti, hwmods" support Tony Lindgren 2017-09-29 22:34 ` [PATCH 3/7] ARM: OMAP2+: Populate legacy resources for dma and smartreflex Tony Lindgren 2017-09-29 22:34 ` Tony Lindgren 2017-09-29 22:34 ` [PATCH 5/7] ARM: dts: Add nodes for missing omap4 interconnect target modules Tony Lindgren 2017-09-29 22:34 ` Tony Lindgren [not found] ` <20170929223411.9691-6-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2017-10-11 15:54 ` Peter Ujfalusi 2017-10-11 15:54 ` Peter Ujfalusi [not found] ` <f5c57f0b-1423-c362-0fda-4069b77a2e38-l0cyMroinI0@public.gmane.org> 2017-10-11 16:58 ` Sebastian Reichel 2017-10-11 16:58 ` Sebastian Reichel 2017-10-12 6:07 ` Peter Ujfalusi 2017-10-12 6:07 ` Peter Ujfalusi [not found] ` <da8d1d7f-f16d-8d71-cf49-acff79614610-l0cyMroinI0@public.gmane.org> 2017-10-12 8:40 ` Matthijs van Duin 2017-10-12 8:40 ` Matthijs van Duin 2017-10-12 9:10 ` Peter Ujfalusi 2017-10-12 9:10 ` Peter Ujfalusi 2017-10-13 16:46 ` Tony Lindgren 2017-10-13 16:46 ` Tony Lindgren 2017-09-29 22:34 ` [PATCH 6/7] ARM: dts: Configure SmartReflex only to idle the interconnect target module Tony Lindgren 2017-09-29 22:34 ` Tony Lindgren 2017-09-29 22:34 ` [PATCH 7/7] ARM: dts: Use ti-sysc module driver for omap4 musb Tony Lindgren 2017-09-29 22:34 ` Tony Lindgren [not found] ` <20170929223411.9691-8-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2017-10-10 17:01 ` Tony Lindgren 2017-10-10 17:01 ` Tony Lindgren 2017-09-29 22:34 ` [PATCH 4/7] bus: ti-sysc: Add minimal TI sysc interconnect target driver Tony Lindgren 2017-09-29 22:34 ` Tony Lindgren 2017-09-29 22:34 ` Tony Lindgren 2017-10-13 17:51 ` Tony Lindgren 2017-10-13 17:51 ` Tony Lindgren 2017-10-13 17:51 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171001171406.GL4394@atomide.com \ --to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \ --cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \ --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=d-gerlach-l0cyMroinI0@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \ --cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=matthijsvanduin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=nm-l0cyMroinI0@public.gmane.org \ --cc=paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org \ --cc=peter.ujfalusi-l0cyMroinI0@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=s-anna-l0cyMroinI0@public.gmane.org \ --cc=sakari.ailus-X3B1VOXEql0@public.gmane.org \ --cc=sre-GFxCN5SEZAc@public.gmane.org \ --cc=t-kristo-l0cyMroinI0@public.gmane.org \ --cc=tomi.valkeinen-l0cyMroinI0@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.