From: Alan Cox <alan@llwyncelyn.cymru>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@suse.com>, Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: tty crash due to auto-failing vmalloc
Date: Wed, 4 Oct 2017 00:51:27 +0100 [thread overview]
Message-ID: <20171004005127.398be9ab@alans-desktop> (raw)
In-Reply-To: <20171003225504.GA966@cmpxchg.org>
> I think this patch should be reverted. If somebody is vmallocing crazy
> amounts of memory in the exit path we should probably track them down
> individually; the patch doesn't reference any real instances of that.
> But we cannot start failing allocations that have never failed before.
>
> That said, maybe we want Alan's N_NULL failover in the hangup path too?
I think that would be best. There's always going to be a failure case
even if the vmalloc change makes it rarer. Dropping back to N_NULL fixes
all of the cases.
Alan
WARNING: multiple messages have this Message-ID (diff)
From: Alan Cox <alan@llwyncelyn.cymru>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@suse.com>, Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: tty crash due to auto-failing vmalloc
Date: Wed, 4 Oct 2017 00:51:27 +0100 [thread overview]
Message-ID: <20171004005127.398be9ab@alans-desktop> (raw)
In-Reply-To: <20171003225504.GA966@cmpxchg.org>
> I think this patch should be reverted. If somebody is vmallocing crazy
> amounts of memory in the exit path we should probably track them down
> individually; the patch doesn't reference any real instances of that.
> But we cannot start failing allocations that have never failed before.
>
> That said, maybe we want Alan's N_NULL failover in the hangup path too?
I think that would be best. There's always going to be a failure case
even if the vmalloc change makes it rarer. Dropping back to N_NULL fixes
all of the cases.
Alan
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-10-03 23:51 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 22:55 tty crash due to auto-failing vmalloc Johannes Weiner
2017-10-03 22:55 ` Johannes Weiner
2017-10-03 23:51 ` Alan Cox [this message]
2017-10-03 23:51 ` Alan Cox
2017-10-04 8:33 ` Michal Hocko
2017-10-04 8:33 ` Michal Hocko
2017-10-04 18:58 ` Johannes Weiner
2017-10-04 18:58 ` Johannes Weiner
2017-10-04 18:59 ` [PATCH 1/2] Revert "vmalloc: back off when the current task is killed" Johannes Weiner
2017-10-04 18:59 ` Johannes Weiner
2017-10-04 20:49 ` Tetsuo Handa
2017-10-04 20:49 ` Tetsuo Handa
2017-10-04 21:00 ` Johannes Weiner
2017-10-04 21:00 ` Johannes Weiner
2017-10-04 21:42 ` Tetsuo Handa
2017-10-04 21:42 ` Tetsuo Handa
2017-10-04 23:21 ` Johannes Weiner
2017-10-04 23:21 ` Johannes Weiner
2017-10-04 22:32 ` Andrew Morton
2017-10-04 22:32 ` Andrew Morton
2017-10-04 23:18 ` Johannes Weiner
2017-10-04 23:18 ` Johannes Weiner
2017-10-05 7:57 ` Michal Hocko
2017-10-05 7:57 ` Michal Hocko
2017-10-05 10:36 ` Tetsuo Handa
2017-10-05 10:36 ` Tetsuo Handa
2017-10-05 10:49 ` Michal Hocko
2017-10-05 10:49 ` Michal Hocko
2017-10-07 2:21 ` Tetsuo Handa
2017-10-07 2:21 ` Tetsuo Handa
2017-10-07 2:51 ` Johannes Weiner
2017-10-07 2:51 ` Johannes Weiner
2017-10-07 4:05 ` Tetsuo Handa
2017-10-07 4:05 ` Tetsuo Handa
2017-10-07 7:59 ` Michal Hocko
2017-10-07 7:59 ` Michal Hocko
2017-10-07 9:57 ` Tetsuo Handa
2017-10-07 9:57 ` Tetsuo Handa
2017-10-05 6:49 ` Vlastimil Babka
2017-10-05 6:49 ` Vlastimil Babka
2017-10-05 7:54 ` Michal Hocko
2017-10-05 7:54 ` Michal Hocko
2017-10-04 18:59 ` [PATCH 2/2] tty: fall back to N_NULL if switching to N_TTY fails during hangup Johannes Weiner
2017-10-04 18:59 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171004005127.398be9ab@alans-desktop \
--to=alan@llwyncelyn.cymru \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hch@lst.de \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.