* [Qemu-devel] [PATCH] option: Drop unused get_param_value(), get_next_param_value()
@ 2017-10-06 13:16 Markus Armbruster
2017-10-06 14:01 ` Eric Blake
0 siblings, 1 reply; 2+ messages in thread
From: Markus Armbruster @ 2017-10-06 13:16 UTC (permalink / raw)
To: qemu-devel
Their last user went away in commit f51074cdc6, "pci-hotplug-old: Has
been dead for five major releases, bury", v2.3.0. Remove them, as new
code should use QemuOpts or maybe keyval_parse() instead.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
include/qemu/option.h | 5 -----
util/qemu-option.c | 34 ----------------------------------
2 files changed, 39 deletions(-)
diff --git a/include/qemu/option.h b/include/qemu/option.h
index f7338dbe80..a88c5f02b1 100644
--- a/include/qemu/option.h
+++ b/include/qemu/option.h
@@ -31,11 +31,6 @@
const char *get_opt_name(char *buf, int buf_size, const char *p, char delim);
const char *get_opt_value(char *buf, int buf_size, const char *p);
-int get_next_param_value(char *buf, int buf_size,
- const char *tag, const char **pstr);
-int get_param_value(char *buf, int buf_size,
- const char *tag, const char *str);
-
void parse_option_size(const char *name, const char *value,
uint64_t *ret, Error **errp);
diff --git a/util/qemu-option.c b/util/qemu-option.c
index 9b1dc8093b..9723a0b34d 100644
--- a/util/qemu-option.c
+++ b/util/qemu-option.c
@@ -91,40 +91,6 @@ const char *get_opt_value(char *buf, int buf_size, const char *p)
return p;
}
-int get_next_param_value(char *buf, int buf_size,
- const char *tag, const char **pstr)
-{
- const char *p;
- char option[128];
-
- p = *pstr;
- for(;;) {
- p = get_opt_name(option, sizeof(option), p, '=');
- if (*p != '=')
- break;
- p++;
- if (!strcmp(tag, option)) {
- *pstr = get_opt_value(buf, buf_size, p);
- if (**pstr == ',') {
- (*pstr)++;
- }
- return strlen(buf);
- } else {
- p = get_opt_value(NULL, 0, p);
- }
- if (*p != ',')
- break;
- p++;
- }
- return 0;
-}
-
-int get_param_value(char *buf, int buf_size,
- const char *tag, const char *str)
-{
- return get_next_param_value(buf, buf_size, tag, &str);
-}
-
static void parse_option_bool(const char *name, const char *value, bool *ret,
Error **errp)
{
--
2.13.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] option: Drop unused get_param_value(), get_next_param_value()
2017-10-06 13:16 [Qemu-devel] [PATCH] option: Drop unused get_param_value(), get_next_param_value() Markus Armbruster
@ 2017-10-06 14:01 ` Eric Blake
0 siblings, 0 replies; 2+ messages in thread
From: Eric Blake @ 2017-10-06 14:01 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
On 10/06/2017 08:16 AM, Markus Armbruster wrote:
> Their last user went away in commit f51074cdc6, "pci-hotplug-old: Has
> been dead for five major releases, bury", v2.3.0. Remove them, as new
> code should use QemuOpts or maybe keyval_parse() instead.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> include/qemu/option.h | 5 -----
> util/qemu-option.c | 34 ----------------------------------
> 2 files changed, 39 deletions(-)
Always fun to kill dead code ;-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-06 14:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-06 13:16 [Qemu-devel] [PATCH] option: Drop unused get_param_value(), get_next_param_value() Markus Armbruster
2017-10-06 14:01 ` Eric Blake
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.