From: Miquel RAYNAL <miquel.raynal@free-electrons.com> To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linus Walleij <linus.walleij@linaro.org>, Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Jiri Slaby <jslaby@suse.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Antoine Tenart <antoine.tenart@free-electrons.com>, Nadav Haklai <nadavh@marvell.com>, Wilson Ding <dingwei@marvell.com> Subject: Re: [PATCH 16/16] arm64: dts: marvell: armada-3720-espressobin: fill UART nodes Date: Mon, 9 Oct 2017 09:30:25 +0200 [thread overview] Message-ID: <20171009093025.78d45a9a@xps13> (raw) In-Reply-To: <20171006151521.440418a2@windsurf.lan> Hi Thomas, Gregory, On Fri, 6 Oct 2017 15:15:21 +0200 Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Hello, > > On Fri, 06 Oct 2017 15:01:18 +0200, Gregory CLEMENT wrote: > > > /* > > * To enable the second UART on J17 (pins 24,26) refer to the uart1 > > * node from armada-3720-db.dts. > > * Note that TX and RX signal are the ones coming directly from > > the SoC: > > * 1.8V TTL. > > */ > > One issue with this comment (and Miquèl's version as well) is that it > does not explain why you don't enable this UART by default. > > The real reason is in the commit log from Miquèl, and should probably > be part of the comment. Perhaps something like: > > /* > > * Connector J17 (pins X, Y, Z) exposes a number of different > * features: > * - UART1 (pins 24 = RX, pins 26 = TX), see armada-3720-db.dts for > an > * example on how to enable UART1. Beware that the signals are 1.8V > * TTL. > * - SPIxyz > * - I2Cxyz > */ Thanks for both your comments, there is my version, inspired from both comments: /* * Connector J17 exposes a number of different features. Some pins are * multiplexed. This is the case for the UART1 feature (pins 24 = RX, * pins 26 = TX). See armada-3720-db.dts for an example of how to enable it. * Beware that the signals are 1.8V TTL. */ Thanks, Miquèl > > Otherwise, it's not clear at all why you don't just enable UART1. Or > perhaps I misunderstood Miquèl's commit log ? > > Best regards, > > Thomas -- Miquel Raynal, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: miquel.raynal@free-electrons.com (Miquel RAYNAL) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 16/16] arm64: dts: marvell: armada-3720-espressobin: fill UART nodes Date: Mon, 9 Oct 2017 09:30:25 +0200 [thread overview] Message-ID: <20171009093025.78d45a9a@xps13> (raw) In-Reply-To: <20171006151521.440418a2@windsurf.lan> Hi Thomas, Gregory, On Fri, 6 Oct 2017 15:15:21 +0200 Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Hello, > > On Fri, 06 Oct 2017 15:01:18 +0200, Gregory CLEMENT wrote: > > > /* > > * To enable the second UART on J17 (pins 24,26) refer to the uart1 > > * node from armada-3720-db.dts. > > * Note that TX and RX signal are the ones coming directly from > > the SoC: > > * 1.8V TTL. > > */ > > One issue with this comment (and Miqu?l's version as well) is that it > does not explain why you don't enable this UART by default. > > The real reason is in the commit log from Miqu?l, and should probably > be part of the comment. Perhaps something like: > > /* > > * Connector J17 (pins X, Y, Z) exposes a number of different > * features: > * - UART1 (pins 24 = RX, pins 26 = TX), see armada-3720-db.dts for > an > * example on how to enable UART1. Beware that the signals are 1.8V > * TTL. > * - SPIxyz > * - I2Cxyz > */ Thanks for both your comments, there is my version, inspired from both comments: /* * Connector J17 exposes a number of different features. Some pins are * multiplexed. This is the case for the UART1 feature (pins 24 = RX, * pins 26 = TX). See armada-3720-db.dts for an example of how to enable it. * Beware that the signals are 1.8V TTL. */ Thanks, Miqu?l > > Otherwise, it's not clear at all why you don't just enable UART1. Or > perhaps I misunderstood Miqu?l's commit log ? > > Best regards, > > Thomas -- Miquel Raynal, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
next prev parent reply other threads:[~2017-10-09 7:30 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-06 10:13 [PATCH 00/16] Support armada-37xx second UART port Miquel Raynal 2017-10-06 10:13 ` Miquel Raynal 2017-10-06 10:13 ` [PATCH 04/16] serial: mvebu-uart: support probe of multiple ports Miquel Raynal 2017-10-06 10:13 ` Miquel Raynal [not found] ` <20171006101344.15590-5-miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2017-10-06 12:23 ` Gregory CLEMENT 2017-10-06 12:23 ` Gregory CLEMENT [not found] ` <87poa0foro.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2017-10-09 7:17 ` Miquel RAYNAL 2017-10-09 7:17 ` Miquel RAYNAL 2017-10-12 12:22 ` Gregory CLEMENT 2017-10-12 12:22 ` Gregory CLEMENT [not found] ` <87vajkblol.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2017-10-13 7:29 ` Miquel RAYNAL 2017-10-13 7:29 ` Miquel RAYNAL 2017-10-06 10:13 ` [PATCH 06/16] serial: mvebu-uart: add soft reset at probe Miquel Raynal 2017-10-06 10:13 ` Miquel Raynal 2017-10-06 12:33 ` Gregory CLEMENT 2017-10-06 12:33 ` Gregory CLEMENT 2017-10-06 10:13 ` [PATCH 07/16] serial: mvebu-uart: add function to change baudrate Miquel Raynal 2017-10-06 10:13 ` Miquel Raynal 2017-10-06 12:39 ` Gregory CLEMENT 2017-10-06 12:39 ` Gregory CLEMENT 2017-10-06 10:13 ` [PATCH 09/16] serial: mvebu-uart: add TX interrupt trigger for pulse interrupts Miquel Raynal 2017-10-06 10:13 ` Miquel Raynal [not found] ` <20171006101344.15590-10-miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2017-10-06 20:22 ` Gregory CLEMENT 2017-10-06 20:22 ` Gregory CLEMENT 2017-10-06 10:13 ` [PATCH 10/16] serial: mvebu-uart: dissociate RX and TX interrupts Miquel Raynal 2017-10-06 10:13 ` Miquel Raynal 2017-10-06 13:11 ` Gregory CLEMENT 2017-10-06 13:11 ` Gregory CLEMENT 2017-10-06 10:13 ` [PATCH 11/16] serial: mvebu-uart: augment the maximum number of ports Miquel Raynal 2017-10-06 10:13 ` Miquel Raynal 2017-10-06 12:45 ` Gregory CLEMENT 2017-10-06 12:45 ` Gregory CLEMENT [not found] ` <20171006101344.15590-1-miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2017-10-06 10:13 ` [PATCH 01/16] dt-bindings: mvebu-uart: update documentation with extended UART Miquel Raynal 2017-10-06 10:13 ` Miquel Raynal 2017-10-06 12:17 ` Gregory CLEMENT 2017-10-06 12:17 ` Gregory CLEMENT 2017-10-06 10:13 ` [PATCH 02/16] pinctrl: dt-bindings: Fix A37xx uart2 group name Miquel Raynal 2017-10-06 10:13 ` Miquel Raynal [not found] ` <20171006101344.15590-3-miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2017-10-06 12:18 ` Gregory CLEMENT 2017-10-06 12:18 ` Gregory CLEMENT 2017-10-06 10:13 ` [PATCH 03/16] serial: mvebu-uart: use driver name when requesting an interrupt Miquel Raynal 2017-10-06 10:13 ` Miquel Raynal [not found] ` <20171006101344.15590-4-miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2017-10-06 12:19 ` Gregory CLEMENT 2017-10-06 12:19 ` Gregory CLEMENT 2017-10-06 10:13 ` [PATCH 05/16] serial: mvebu-uart: use a generic way to access the registers Miquel Raynal 2017-10-06 10:13 ` Miquel Raynal 2017-10-06 12:32 ` Gregory CLEMENT 2017-10-06 12:32 ` Gregory CLEMENT 2017-10-06 10:13 ` [PATCH 08/16] serial: mvebu-uart: clear state register before IRQ request Miquel Raynal 2017-10-06 10:13 ` Miquel Raynal [not found] ` <20171006101344.15590-9-miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2017-10-06 12:40 ` Gregory CLEMENT 2017-10-06 12:40 ` Gregory CLEMENT 2017-10-06 10:13 ` [PATCH 12/16] serial: mvebu-uart: support extended port registers layout Miquel Raynal 2017-10-06 10:13 ` Miquel Raynal 2017-10-06 12:46 ` Gregory CLEMENT 2017-10-06 12:46 ` Gregory CLEMENT 2017-10-06 10:13 ` [PATCH 13/16] arm64: dts: marvell: armada-37xx: add UART clock Miquel Raynal 2017-10-06 10:13 ` Miquel Raynal [not found] ` <20171006101344.15590-14-miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2017-10-06 12:48 ` Gregory CLEMENT 2017-10-06 12:48 ` Gregory CLEMENT 2017-10-06 10:13 ` [PATCH 14/16] arm64: dts: marvell: armada-37xx: add second UART port Miquel Raynal 2017-10-06 10:13 ` Miquel Raynal 2017-10-06 12:49 ` Gregory CLEMENT 2017-10-06 12:49 ` Gregory CLEMENT 2017-10-06 10:13 ` [PATCH 15/16] arm64: dts: marvell: armada-3720-db: enable " Miquel Raynal 2017-10-06 10:13 ` Miquel Raynal [not found] ` <20171006101344.15590-16-miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2017-10-06 12:51 ` Gregory CLEMENT 2017-10-06 12:51 ` Gregory CLEMENT 2017-10-06 10:13 ` [PATCH 16/16] arm64: dts: marvell: armada-3720-espressobin: fill UART nodes Miquel Raynal 2017-10-06 10:13 ` Miquel Raynal [not found] ` <20171006101344.15590-17-miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2017-10-06 13:01 ` Gregory CLEMENT 2017-10-06 13:01 ` Gregory CLEMENT [not found] ` <87fuawe8gx.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2017-10-06 13:15 ` Thomas Petazzoni 2017-10-06 13:15 ` Thomas Petazzoni 2017-10-09 7:30 ` Miquel RAYNAL [this message] 2017-10-09 7:30 ` Miquel RAYNAL 2017-10-12 11:24 ` Gregory CLEMENT 2017-10-12 11:24 ` Gregory CLEMENT [not found] ` <87zi8wbocl.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2017-10-13 7:01 ` Miquel RAYNAL 2017-10-13 7:01 ` Miquel RAYNAL
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171009093025.78d45a9a@xps13 \ --to=miquel.raynal@free-electrons.com \ --cc=andrew@lunn.ch \ --cc=antoine.tenart@free-electrons.com \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=dingwei@marvell.com \ --cc=gregkh@linuxfoundation.org \ --cc=gregory.clement@free-electrons.com \ --cc=jason@lakedaemon.net \ --cc=jslaby@suse.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=nadavh@marvell.com \ --cc=sebastian.hesselbarth@gmail.com \ --cc=thomas.petazzoni@free-electrons.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.