* [PATCH] drm/i915: remove redundant check on has_aliasing_ppgtt
@ 2017-10-10 13:47 ` Colin King
0 siblings, 0 replies; 10+ messages in thread
From: Colin King @ 2017-10-10 13:47 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
intel-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is a previous check to on has_aliasing_ppgtt that returns
0 if it is false, so it is impossible for has_aliasing_ppgtt to
be false on the final return of function intel_sanitize_enable_ppgtt,
so final return in the function always will return 1. Hence the
redundant ternary operator can be replaced with a return 1.
Detected by CoverityScan, CID#1357136 ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 4c82ceb8d318..e1a318ea4327 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -188,7 +188,7 @@ int intel_sanitize_enable_ppgtt(struct drm_i915_private *dev_priv,
return 2;
}
- return has_aliasing_ppgtt ? 1 : 0;
+ return 1;
}
static int ppgtt_bind_vma(struct i915_vma *vma,
--
2.14.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] drm/i915: remove redundant check on has_aliasing_ppgtt
@ 2017-10-10 13:47 ` Colin King
0 siblings, 0 replies; 10+ messages in thread
From: Colin King @ 2017-10-10 13:47 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
intel-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is a previous check to on has_aliasing_ppgtt that returns
0 if it is false, so it is impossible for has_aliasing_ppgtt to
be false on the final return of function intel_sanitize_enable_ppgtt,
so final return in the function always will return 1. Hence the
redundant ternary operator can be replaced with a return 1.
Detected by CoverityScan, CID#1357136 ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 4c82ceb8d318..e1a318ea4327 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -188,7 +188,7 @@ int intel_sanitize_enable_ppgtt(struct drm_i915_private *dev_priv,
return 2;
}
- return has_aliasing_ppgtt ? 1 : 0;
+ return 1;
}
static int ppgtt_bind_vma(struct i915_vma *vma,
--
2.14.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] drm/i915: remove redundant check on has_aliasing_ppgtt
2017-10-10 13:47 ` Colin King
@ 2017-10-10 14:35 ` Joonas Lahtinen
-1 siblings, 0 replies; 10+ messages in thread
From: Joonas Lahtinen @ 2017-10-10 14:35 UTC (permalink / raw)
To: Colin King, Jani Nikula, Rodrigo Vivi, David Airlie, intel-gfx,
dri-devel
Cc: kernel-janitors, linux-kernel
On Tue, 2017-10-10 at 14:47 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a previous check to on has_aliasing_ppgtt that returns
> 0 if it is false, so it is impossible for has_aliasing_ppgtt to
> be false on the final return of function intel_sanitize_enable_ppgtt,
> so final return in the function always will return 1. Hence the
> redundant ternary operator can be replaced with a return 1.
>
> Detected by CoverityScan, CID#1357136 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, I took it a few steps further and removed the variable
altogether. I Cc'd you on the patch.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] drm/i915: remove redundant check on has_aliasing_ppgtt
@ 2017-10-10 14:35 ` Joonas Lahtinen
0 siblings, 0 replies; 10+ messages in thread
From: Joonas Lahtinen @ 2017-10-10 14:35 UTC (permalink / raw)
To: Colin King, Jani Nikula, Rodrigo Vivi, David Airlie, intel-gfx,
dri-devel
Cc: kernel-janitors, linux-kernel
On Tue, 2017-10-10 at 14:47 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a previous check to on has_aliasing_ppgtt that returns
> 0 if it is false, so it is impossible for has_aliasing_ppgtt to
> be false on the final return of function intel_sanitize_enable_ppgtt,
> so final return in the function always will return 1. Hence the
> redundant ternary operator can be replaced with a return 1.
>
> Detected by CoverityScan, CID#1357136 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, I took it a few steps further and removed the variable
altogether. I Cc'd you on the patch.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] drm/i915: remove redundant check on has_aliasing_ppgtt
2017-10-10 14:35 ` Joonas Lahtinen
(?)
@ 2017-10-10 14:36 ` Colin Ian King
-1 siblings, 0 replies; 10+ messages in thread
From: Colin Ian King @ 2017-10-10 14:36 UTC (permalink / raw)
To: Joonas Lahtinen, Jani Nikula, Rodrigo Vivi, David Airlie,
intel-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
On 10/10/17 15:35, Joonas Lahtinen wrote:
> On Tue, 2017-10-10 at 14:47 +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There is a previous check to on has_aliasing_ppgtt that returns
>> 0 if it is false, so it is impossible for has_aliasing_ppgtt to
>> be false on the final return of function intel_sanitize_enable_ppgtt,
>> so final return in the function always will return 1. Hence the
>> redundant ternary operator can be replaced with a return 1.
>>
>> Detected by CoverityScan, CID#1357136 ("Logically dead code")
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Thanks, I took it a few steps further and removed the variable
> altogether. I Cc'd you on the patch.
Yep, it's an improvement on my fix. Thanks for sorting that out.
Colin
>
> Regards, Joonas
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] drm/i915: remove redundant check on has_aliasing_ppgtt
@ 2017-10-10 14:36 ` Colin Ian King
0 siblings, 0 replies; 10+ messages in thread
From: Colin Ian King @ 2017-10-10 14:36 UTC (permalink / raw)
To: Joonas Lahtinen, Jani Nikula, Rodrigo Vivi, David Airlie,
intel-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
On 10/10/17 15:35, Joonas Lahtinen wrote:
> On Tue, 2017-10-10 at 14:47 +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There is a previous check to on has_aliasing_ppgtt that returns
>> 0 if it is false, so it is impossible for has_aliasing_ppgtt to
>> be false on the final return of function intel_sanitize_enable_ppgtt,
>> so final return in the function always will return 1. Hence the
>> redundant ternary operator can be replaced with a return 1.
>>
>> Detected by CoverityScan, CID#1357136 ("Logically dead code")
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Thanks, I took it a few steps further and removed the variable
> altogether. I Cc'd you on the patch.
Yep, it's an improvement on my fix. Thanks for sorting that out.
Colin
>
> Regards, Joonas
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] drm/i915: remove redundant check on has_aliasing_ppgtt
@ 2017-10-10 14:36 ` Colin Ian King
0 siblings, 0 replies; 10+ messages in thread
From: Colin Ian King @ 2017-10-10 14:36 UTC (permalink / raw)
To: Joonas Lahtinen, Jani Nikula, Rodrigo Vivi, David Airlie,
intel-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
On 10/10/17 15:35, Joonas Lahtinen wrote:
> On Tue, 2017-10-10 at 14:47 +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There is a previous check to on has_aliasing_ppgtt that returns
>> 0 if it is false, so it is impossible for has_aliasing_ppgtt to
>> be false on the final return of function intel_sanitize_enable_ppgtt,
>> so final return in the function always will return 1. Hence the
>> redundant ternary operator can be replaced with a return 1.
>>
>> Detected by CoverityScan, CID#1357136 ("Logically dead code")
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Thanks, I took it a few steps further and removed the variable
> altogether. I Cc'd you on the patch.
Yep, it's an improvement on my fix. Thanks for sorting that out.
Colin
>
> Regards, Joonas
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: remove redundant check on has_aliasing_ppgtt
2017-10-10 13:47 ` Colin King
` (2 preceding siblings ...)
(?)
@ 2017-10-10 15:12 ` Patchwork
-1 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2017-10-10 15:12 UTC (permalink / raw)
To: Colin Ian King; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: remove redundant check on has_aliasing_ppgtt
URL : https://patchwork.freedesktop.org/series/31661/
State : success
== Summary ==
Series 31661v1 drm/i915: remove redundant check on has_aliasing_ppgtt
https://patchwork.freedesktop.org/api/1.0/series/31661/revisions/1/mbox/
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-c:
incomplete -> PASS (fi-kbl-7560u) fdo#102846
fdo#102846 https://bugs.freedesktop.org/show_bug.cgi?id=102846
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:446s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:464s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:391s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:581s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:287s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:518s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:522s
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:531s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:521s
fi-cfl-s total:289 pass:256 dwarn:1 dfail:0 fail:0 skip:32 time:556s
fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:612s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:431s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:601s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:436s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:426s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:460s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:505s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:470s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:503s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:581s
fi-kbl-7567u total:289 pass:265 dwarn:4 dfail:0 fail:0 skip:20 time:492s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:594s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:656s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:468s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:655s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:527s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:516s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:472s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:580s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:432s
1071dc8e15487dd849401c5842d94b312e23d111 drm-tip: 2017y-10m-10d-14h-03m-19s UTC integration manifest
952f61fb759b drm/i915: remove redundant check on has_aliasing_ppgtt
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5975/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread* ✗ Fi.CI.IGT: failure for drm/i915: remove redundant check on has_aliasing_ppgtt
2017-10-10 13:47 ` Colin King
` (3 preceding siblings ...)
(?)
@ 2017-10-10 20:08 ` Patchwork
-1 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2017-10-10 20:08 UTC (permalink / raw)
To: Colin Ian King; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: remove redundant check on has_aliasing_ppgtt
URL : https://patchwork.freedesktop.org/series/31661/
State : failure
== Summary ==
Test gem_flink_race:
Subgroup flink_close:
fail -> PASS (shard-hsw) fdo#102655
Test perf:
Subgroup polling:
pass -> FAIL (shard-hsw) fdo#102252
Test kms_flip:
Subgroup basic-flip-vs-wf_vblank:
pass -> FAIL (shard-hsw)
Test pm_rpm:
Subgroup modeset-non-lpsp:
pass -> SKIP (shard-hsw)
Test gem_userptr_blits:
Subgroup sync-unmap-cycles:
pass -> DMESG-WARN (shard-hsw) fdo#102886
fdo#102655 https://bugs.freedesktop.org/show_bug.cgi?id=102655
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102886 https://bugs.freedesktop.org/show_bug.cgi?id=102886
shard-hsw total:2552 pass:1427 dwarn:6 dfail:0 fail:15 skip:1104 time:9613s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5975/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread