[Buildroot] [PATCH 0/3] Add support for Meson build

[Buildroot] [PATCH 0/3] Add support for Meson build

[Jörg Krause]

Last year, Eric Le Bihan already proposed patches to support the Meson build
system [1], but the patches were rejected, as no package in Buildroot
required a Meson build.

This has changed, as the libmpdclient package has switched from autotools to
Meson.

Therefore, the patches from Eric are resubmitted with some changes as suggested
by Yann E. Morin.

[1] http://patchwork.ozlabs.org/patch/646685/

Eric Le Bihan (2):
  meson: new package
  docs/manual: document meson-based packages

J?rg Krause (1):
  libmpdclient: bump to version 2.13

 docs/manual/adding-packages-meson.txt   | 80 +++++++++++++++++++++++++++++++++
 docs/manual/adding-packages.txt         |  2 +
 package/libmpdclient/libmpdclient.hash  |  4 +-
 package/libmpdclient/libmpdclient.mk    | 26 +++++++++--
 package/meson/cross-compilation.conf.in | 15 +++++++
 package/meson/meson.hash                |  2 +
 package/meson/meson.mk                  | 30 +++++++++++++
 7 files changed, 154 insertions(+), 5 deletions(-)
 create mode 100644 docs/manual/adding-packages-meson.txt
 create mode 100644 package/meson/cross-compilation.conf.in
 create mode 100644 package/meson/meson.hash
 create mode 100644 package/meson/meson.mk

-- 
2.13.3

[Buildroot] [PATCH v2 1/3] meson: new package

[Jörg Krause]

From: Eric Le Bihan <eric.le.bihan.dev@free.fr>

This new package provides the host variant of the Meson Build System, an
open source build system meant to be both extremely fast, and as user
friendly as possible.

More precisely, Meson creates configuration files for the Ninja build
system.

Besides building Meson, it generates a configuration file
("$(HOST_DIR)/etc/meson/cross-compilation.conf") to be used when
cross-compiling a Meson-based project.

Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
[J?rg Krause:
 * bump to version 0.41.2
 * use explicit tarball release instead of github helper
 * use explicit sed
 * pass BR2_GCC_TARGET_CPU to cross file]
Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
---
 package/meson/cross-compilation.conf.in | 15 +++++++++++++++
 package/meson/meson.hash                |  2 ++
 package/meson/meson.mk                  | 30 ++++++++++++++++++++++++++++++
 3 files changed, 47 insertions(+)
 create mode 100644 package/meson/cross-compilation.conf.in
 create mode 100644 package/meson/meson.hash
 create mode 100644 package/meson/meson.mk

diff --git a/package/meson/cross-compilation.conf.in b/package/meson/cross-compilation.conf.in
new file mode 100644
index 0000000000..d38fbb03cc
--- /dev/null
+++ b/package/meson/cross-compilation.conf.in
@@ -0,0 +1,15 @@
+# Note: in Meson terminology, what Buildroot calls the "host" system is the
+# "build" system and the "target" system is called the "host" system.
+
+[binaries]
+c = '@TARGET_CROSS at gcc'
+cpp = '@TARGET_CROSS at g++'
+ar = '@TARGET_CROSS at ar'
+strip = '@TARGET_CROSS at strip'
+pkgconfig = '@HOST_DIR@/usr/bin/pkg-config'
+
+[host_machine]
+system = 'linux'
+cpu_family ='@TARGET_ARCH@'
+cpu = '@TARGET_CPU@'
+endian = '@TARGET_ENDIAN@'
diff --git a/package/meson/meson.hash b/package/meson/meson.hash
new file mode 100644
index 0000000000..7f0de1d437
--- /dev/null
+++ b/package/meson/meson.hash
@@ -0,0 +1,2 @@
+# Locally generated
+sha256  074dd24fd068be0893e2e45bcc35c919d8e12777e9d6a7efdf72d4dc300867ca  meson-0.41.2.tar.gz
diff --git a/package/meson/meson.mk b/package/meson/meson.mk
new file mode 100644
index 0000000000..7cf287df82
--- /dev/null
+++ b/package/meson/meson.mk
@@ -0,0 +1,30 @@
+################################################################################
+#
+# meson
+#
+################################################################################
+
+MESON_VERSION = 0.41.2
+MESON_SITE = https://github.com/mesonbuild/meson/releases/download/$(MESON_VERSION)
+MESON_LICENSE = Apache-2.0
+MESON_LICENSE_FILES = COPYING
+MESON_SETUP_TYPE = setuptools
+
+HOST_MESON_DEPENDENCIES = host-ninja
+HOST_MESON_NEEDS_HOST_PYTHON = python3
+
+HOST_MESON_TARGET_ENDIAN = $(shell echo $(BR2_ENDIAN) | tr 'A-Z' 'a-z')
+
+define HOST_MESON_INSTALL_CROSS_CONF
+	sed -e 's;@TARGET_CROSS@;$(TARGET_CROSS);g' \
+	    -e 's;@TARGET_ARCH@;$(ARCH);g' \
+	    -e 's;@TARGET_CPU@;$(BR2_GCC_TARGET_CPU);g' \
+	    -e 's;@TARGET_ENDIAN@;$(HOST_MESON_TARGET_ENDIAN);g' \
+	    -e 's;@HOST_DIR@;$(HOST_DIR);g' \
+	    $(HOST_MESON_PKGDIR)/cross-compilation.conf.in \
+	    > $(HOST_DIR)/etc/meson/cross-compilation.conf
+endef
+
+HOST_MESON_POST_INSTALL_HOOKS += HOST_MESON_INSTALL_CROSS_CONF
+
+$(eval $(host-python-package))
-- 
2.13.3

[Buildroot] [PATCH v2 2/3] docs/manual: document meson-based packages

[Jörg Krause]

From: Eric Le Bihan <eric.le.bihan.dev@free.fr>

Add instructions for adding a package which uses the Meson build system.

Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
[J?rg Krause:
 * use one-liner for buildtype]
Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
---
 docs/manual/adding-packages-meson.txt | 80 +++++++++++++++++++++++++++++++++++
 docs/manual/adding-packages.txt       |  2 +
 2 files changed, 82 insertions(+)
 create mode 100644 docs/manual/adding-packages-meson.txt

diff --git a/docs/manual/adding-packages-meson.txt b/docs/manual/adding-packages-meson.txt
new file mode 100644
index 0000000000..697f2520c7
--- /dev/null
+++ b/docs/manual/adding-packages-meson.txt
@@ -0,0 +1,80 @@
+// -*- mode:doc; -*-
+// vim: set syntax=asciidoc:
+
+=== Integration of Meson-based packages
+
+[[meson-package-tutorial]]
+
+==== +meson-package+ tutorial
+
+http://mesonbuild.com[Meson] is an open source build system meant to be both
+extremely fast, and, even more importantly, as user friendly as possible.
+
+Buildroot does not (yet) provide a dedicated package infrastructure for
+meson-based packages. So, we will explain how to write a +.mk+ file for such a
+package. Let's start with an example:
+
+------------------------------
+01: ################################################################################
+02: #
+03: # foo
+04: #
+05: ################################################################################
+06:
+07: FOO_VERSION = 1.0
+08: FOO_SOURCE = foo-$(FOO_VERSION).tar.gz
+09: FOO_SITE = http://www.foosoftware.org/download
+10: FOO_LICENSE = GPLv3+
+11: FOO_LICENSE_FILES = COPYING
+12:
+13: FOO_DEPENDENCIES = host-meson host-pkgconf bar
+14:
+15: FOO_MESON_OPTS += \
+16: 	--prefix=/usr \
+17: 	--buildtype $(if $(BR2_ENABLE_DEBUG),debug,release) \
+18: 	--cross-file $(HOST_DIR)/etc/meson/cross-compilation.conf
+19:
+20: define FOO_CONFIGURE_CMDS
+21: 	rm -rf $(@D)/build
+22: 	mkdir -p $(@D)/build
+23: 	$(TARGET_MAKE_ENV) meson.py $(FOO_MESON_OPTS) $(@D) $(@D)/build
+24: endef
+25:
+26: define FOO_BUILD_CMDS
+27: 	$(TARGET_MAKE_ENV) ninja -C $(@D)/build
+28: endef
+29:
+30: define FOO_INSTALL_TARGET_CMDS
+31: 	$(TARGET_MAKE_ENV) DESTDIR=$(TARGET_DIR) ninja -C $(@D)/build install
+32: endef
+33:
+34: $(eval $(generic-package))
+--------------------------------
+
+The Makefile starts with the definition of the standard variables for package
+declaration (lines 7 to 11).
+
+As seen in line 34, it is based on the
+xref:generic-package-tutorial[+generic-package+ infrastructure]. So, it defines
+the variables required by this particular infrastructure, where Meson and its
+companion tool, Ninja, are invoked:
+
+* +FOO_CONFIGURE_CMDS+: the build directory required by Meson is created, and
+  Meson is invoked to generate the Ninja build file. The options required to
+  configure the cross-compilation of the package are passed via
+  +FOO_MESON_OPTS+.
+
+* +FOO_BUILD_CMDS+: Ninja is invoked to perform the build.
+
+* +FOO_INSTALL_TARGET_CMDS+: Ninja is invoked to install the files generated
+  during the build step.
+
+In order to have Meson available for the build, +FOO_DEPENDENCIES+ needs to
+contain +host-meson+. In the example, +host-pkgconf+ and +bar+ are also
+declared as dependencies because the Meson build file of +foo+ uses `pkg-config`
+to determine the compilation flags and libraries of package +bar+.
+
+To sum it up, to add a new meson-based package, the Makefile example can be
+copied verbatim then edited to replace all occurences of +FOO+ with the
+uppercase name of the new package and update the values of the standard
+variables.
diff --git a/docs/manual/adding-packages.txt b/docs/manual/adding-packages.txt
index d577ff030e..e542124cf9 100644
--- a/docs/manual/adding-packages.txt
+++ b/docs/manual/adding-packages.txt
@@ -34,6 +34,8 @@ include::adding-packages-rebar.txt[]
 
 include::adding-packages-waf.txt[]
 
+include::adding-packages-meson.txt[]
+
 include::adding-packages-kernel-module.txt[]
 
 include::adding-packages-asciidoc.txt[]
-- 
2.13.3

[Buildroot] [PATCH 3/3] libmpdclient: bump to version 2.13

[Jörg Krause]

libmpdclient has switched from autotools to meson.

Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
---
 package/libmpdclient/libmpdclient.hash |  4 ++--
 package/libmpdclient/libmpdclient.mk   | 26 +++++++++++++++++++++++---
 2 files changed, 25 insertions(+), 5 deletions(-)

diff --git a/package/libmpdclient/libmpdclient.hash b/package/libmpdclient/libmpdclient.hash
index 2fd20a41fb..aa9434098f 100644
--- a/package/libmpdclient/libmpdclient.hash
+++ b/package/libmpdclient/libmpdclient.hash
@@ -1,2 +1,2 @@
-# Verified against http://www.musicpd.org/download/libmpdclient/2/libmpdclient-2.10.tar.xz.sig, sha256 locally computed
-sha256 4f08cde82dae70895f8e4532a6e9b54b201efd5591c6b5d6834895807ed2ff82  libmpdclient-2.10.tar.xz
+# Verified against http://www.musicpd.org/download/libmpdclient/2/libmpdclient-2.13.tar.xz.sig, sha256 locally computed
+sha256  5115bd52bc20a707c1ecc7587e6389c17305348e2132a66cf767c62fc55ed45d  libmpdclient-2.13.tar.xz
diff --git a/package/libmpdclient/libmpdclient.mk b/package/libmpdclient/libmpdclient.mk
index 691aba9f71..9cd4f2bd2e 100644
--- a/package/libmpdclient/libmpdclient.mk
+++ b/package/libmpdclient/libmpdclient.mk
@@ -5,12 +5,32 @@
 ################################################################################
 
 LIBMPDCLIENT_VERSION_MAJOR = 2
-LIBMPDCLIENT_VERSION = $(LIBMPDCLIENT_VERSION_MAJOR).10
+LIBMPDCLIENT_VERSION = $(LIBMPDCLIENT_VERSION_MAJOR).13
 LIBMPDCLIENT_SOURCE = libmpdclient-$(LIBMPDCLIENT_VERSION).tar.xz
 LIBMPDCLIENT_SITE = http://www.musicpd.org/download/libmpdclient/$(LIBMPDCLIENT_VERSION_MAJOR)
-LIBMPDCLIENT_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99'
 LIBMPDCLIENT_INSTALL_STAGING = YES
 LIBMPDCLIENT_LICENSE = BSD-3-Clause
 LIBMPDCLIENT_LICENSE_FILES = COPYING
 
-$(eval $(autotools-package))
+LIBMPDCLIENT_DEPENDENCIES = host-meson host-pkgconf
+
+LIBMPDCLIENT_MESON_OPTS += \
+	--prefix=/usr \
+	--buildtype $(if $(BR2_ENABLE_DEBUG),debug,release) \
+	--cross-file $(HOST_DIR)/etc/meson/cross-compilation.conf
+
+define LIBMPDCLIENT_CONFIGURE_CMDS
+	rm -rf $(@D)/build
+	mkdir -p $(@D)/build
+	$(TARGET_MAKE_ENV) meson $(LIBMPDCLIENT_MESON_OPTS) $(@D) $(@D)/build
+endef
+
+define LIBMPDCLIENT_BUILD_CMDS
+	$(TARGET_MAKE_ENV) ninja -C $(@D)/build
+endef
+
+define LIBMPDCLIENT_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) DESTDIR=$(TARGET_DIR) ninja -C $(@D)/build install
+endef
+
+$(eval $(generic-package))
-- 
2.13.3

[Buildroot] [PATCH 0/3] Add support for Meson build

[Vicente Olivert Riera]

Hello J?rg, maintainers,

shouldn't we add a "package/pkg-meson.mk" file and then use "$(eval
$(meson-package))" for Meson packages?

Vincent

On 27/07/17 10:45, J?rg Krause wrote:
> Last year, Eric Le Bihan already proposed patches to support the Meson build
> system [1], but the patches were rejected, as no package in Buildroot
> required a Meson build.
> 
> This has changed, as the libmpdclient package has switched from autotools to
> Meson.
> 
> Therefore, the patches from Eric are resubmitted with some changes as suggested
> by Yann E. Morin.
> 
> [1] http://patchwork.ozlabs.org/patch/646685/
> 
> Eric Le Bihan (2):
>   meson: new package
>   docs/manual: document meson-based packages
> 
> J?rg Krause (1):
>   libmpdclient: bump to version 2.13
> 
>  docs/manual/adding-packages-meson.txt   | 80 +++++++++++++++++++++++++++++++++
>  docs/manual/adding-packages.txt         |  2 +
>  package/libmpdclient/libmpdclient.hash  |  4 +-
>  package/libmpdclient/libmpdclient.mk    | 26 +++++++++--
>  package/meson/cross-compilation.conf.in | 15 +++++++
>  package/meson/meson.hash                |  2 +
>  package/meson/meson.mk                  | 30 +++++++++++++
>  7 files changed, 154 insertions(+), 5 deletions(-)
>  create mode 100644 docs/manual/adding-packages-meson.txt
>  create mode 100644 package/meson/cross-compilation.conf.in
>  create mode 100644 package/meson/meson.hash
>  create mode 100644 package/meson/meson.mk
> 

[Buildroot] [PATCH 0/3] Add support for Meson build

[Jörg Krause]

Hello Vincent,

On Thu, 2017-07-27 at 11:11 +0100, Vicente Olivert Riera wrote:
> Hello J?rg, maintainers,
> 
> shouldn't we add a "package/pkg-meson.mk" file and then use "$(eval
> $(meson-package))" for Meson packages?

Maybe, if there are more than one package. At least, that was the
opinion of Yann when he reviewed the patch last year.

J?rg

[Buildroot] [PATCH 0/3] Add support for Meson build

[Vicente Olivert Riera]

Hi J?rg,

On 27/07/17 11:13, J?rg Krause wrote:
> Hello Vincent,
> 
> On Thu, 2017-07-27 at 11:11 +0100, Vicente Olivert Riera wrote:
>> Hello J?rg, maintainers,
>>
>> shouldn't we add a "package/pkg-meson.mk" file and then use "$(eval
>> $(meson-package))" for Meson packages?
> 
> Maybe, if there are more than one package. At least, that was the
> opinion of Yann when he reviewed the patch last year.

There will be more packages moving to Meson, and some of them quite
important: http://mesonbuild.com/Users.html

I think we should add proper Meson support in BR infra from the beginning.

Vincent

> 
> J?rg
> 

[Buildroot] [PATCH 0/3] Add support for Meson build

[Thomas Petazzoni]

Hello,

On Thu, 27 Jul 2017 11:19:02 +0100, Vicente Olivert Riera wrote:

> >> shouldn't we add a "package/pkg-meson.mk" file and then use "$(eval
> >> $(meson-package))" for Meson packages?  
> > 
> > Maybe, if there are more than one package. At least, that was the
> > opinion of Yann when he reviewed the patch last year.  
> 
> There will be more packages moving to Meson, and some of them quite
> important: http://mesonbuild.com/Users.html
> 
> I think we should add proper Meson support in BR infra from the beginning.

No, let's wait to have a few Meson-based packages in Buildroot, and
then we'll have a package infrastructure. This will allow us to see
what are the commonalities, what are the differences, etc.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 0/3] Add support for Meson build

[Andrey Yurovsky]

Hi,

On Thu, Jul 27, 2017 at 7:51 AM Thomas Petazzoni <
thomas.petazzoni@free-electrons.com> wrote:

>
> No, let's wait to have a few Meson-based packages in Buildroot, and
> then we'll have a package infrastructure. This will allow us to see
> what are the commonalities, what are the differences, etc.
>


systemd 235 is released (https://lwn.net/Articles/735691/) and it drops
autoconf/automake and only has meson as the build system (in 234 they
warned this would happen next) so perhaps that's a good starting point for
buildroot to integrate meson support? I'm happy to help out if no one else
was already working on it.

  -Andrey
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20171006/f1ba2494/attachment.html>

[Buildroot] [PATCH 0/3] Add support for Meson build

[Andrey Yurovsky]

Hi,

On Thu, Jul 27, 2017 at 7:50 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> No, let's wait to have a few Meson-based packages in Buildroot, and
> then we'll have a package infrastructure. This will allow us to see
> what are the commonalities, what are the differences, etc.

systemd 235 is released (https://lwn.net/Articles/735691/) and it
drops autoconf/automake and only has meson as the build system (in 234
they warned this would happen next) so perhaps that's a good starting
point for buildroot to integrate meson support? I'm happy to help out
if no one else was already working on it.

[Buildroot] [PATCH 0/3] Add support for Meson build

[Thomas Petazzoni]

Hello,

On Fri, 6 Oct 2017 15:39:03 -0700, Andrey Yurovsky wrote:

> On Thu, Jul 27, 2017 at 7:50 AM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
> > No, let's wait to have a few Meson-based packages in Buildroot, and
> > then we'll have a package infrastructure. This will allow us to see
> > what are the commonalities, what are the differences, etc.  
> 
> systemd 235 is released (https://lwn.net/Articles/735691/) and it
> drops autoconf/automake and only has meson as the build system (in 234
> they warned this would happen next) so perhaps that's a good starting
> point for buildroot to integrate meson support? I'm happy to help out
> if no one else was already working on it.

This would indeed be a very compelling reason to support meson.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 0/3] Add support for Meson build

[Romain Naour]

Thomas, Andrey, All,

Le 07/10/2017 ? 13:58, Thomas Petazzoni a ?crit?:
> Hello,
> 
> On Fri, 6 Oct 2017 15:39:03 -0700, Andrey Yurovsky wrote:
> 
>> On Thu, Jul 27, 2017 at 7:50 AM, Thomas Petazzoni
>> <thomas.petazzoni@free-electrons.com> wrote:
>>> No, let's wait to have a few Meson-based packages in Buildroot, and
>>> then we'll have a package infrastructure. This will allow us to see
>>> what are the commonalities, what are the differences, etc.  
>>
>> systemd 235 is released (https://lwn.net/Articles/735691/) and it
>> drops autoconf/automake and only has meson as the build system (in 234
>> they warned this would happen next) so perhaps that's a good starting
>> point for buildroot to integrate meson support? I'm happy to help out
>> if no one else was already working on it.
> 
> This would indeed be a very compelling reason to support meson.

Also the next enlightenment release (0.22) will only support meson.

Best regards,
Romain

> 
> Best regards,
> 
> Thomas
> 

[Buildroot] [PATCH 0/3] Add support for Meson build

[Andrey Yurovsky]

Hi,

On Sat, Oct 7, 2017 at 6:06 AM, Romain Naour <romain.naour@smile.fr> wrote:
> Thomas, Andrey, All,
>
> Le 07/10/2017 ? 13:58, Thomas Petazzoni a ?crit :
>> Hello,
>>
>> On Fri, 6 Oct 2017 15:39:03 -0700, Andrey Yurovsky wrote:
>>
>>> On Thu, Jul 27, 2017 at 7:50 AM, Thomas Petazzoni
>>> <thomas.petazzoni@free-electrons.com> wrote:
>>>> No, let's wait to have a few Meson-based packages in Buildroot, and
>>>> then we'll have a package infrastructure. This will allow us to see
>>>> what are the commonalities, what are the differences, etc.
>>>
>>> systemd 235 is released (https://lwn.net/Articles/735691/) and it
>>> drops autoconf/automake and only has meson as the build system (in 234
>>> they warned this would happen next) so perhaps that's a good starting
>>> point for buildroot to integrate meson support? I'm happy to help out
>>> if no one else was already working on it.
>>
>> This would indeed be a very compelling reason to support meson.
>
> Also the next enlightenment release (0.22) will only support meson.
>

I was able to add a package/pkg-meson.mk wrapper (that seems to be
missing from the Meson patch set, or did I completely miss it?) and
built the previously submitted libmpdclient version bump via the
$(eval $(meson-package)) wrapper. I'll work on version bumping systemd
and converting it to use that wrapper as well. If possible I'd like to
get this more or less right, what would a reasonable patch set look
like? I was thinking, as a patch set:
1. resubmit the Meson patches (package/meson, documentation) by J?rg Krause
2. add package/pkg-meson.mk
3. resubmit the libmpdclient version bump patch by J?rg Krause but
with $(eval $(meson-package)) changes
4. submit the systemd version bump and meson conversion patch(es)

That way we have the infrastructure, documentation, and two packages
utilizing the infrastructure in one set to review. Does that sound
alright?

[Buildroot] [PATCH 0/3] Add support for Meson build

[Eric Le Bihan]

Hi all!

On 17-10-10 20:51:55, Andrey Yurovsky wrote:
> Hi,
>
> On Sat, Oct 7, 2017 at 6:06 AM, Romain Naour <romain.naour@smile.fr> wrote:
> > Thomas, Andrey, All,
> >
> > Le 07/10/2017 ? 13:58, Thomas Petazzoni a ?crit :
> >> Hello,
> >>
> >> On Fri, 6 Oct 2017 15:39:03 -0700, Andrey Yurovsky wrote:
> >>
> >>> On Thu, Jul 27, 2017 at 7:50 AM, Thomas Petazzoni
> >>> <thomas.petazzoni@free-electrons.com> wrote:
> >>>> No, let's wait to have a few Meson-based packages in Buildroot, and
> >>>> then we'll have a package infrastructure. This will allow us to see
> >>>> what are the commonalities, what are the differences, etc.
> >>>
> >>> systemd 235 is released (https://lwn.net/Articles/735691/) and it
> >>> drops autoconf/automake and only has meson as the build system (in 234
> >>> they warned this would happen next) so perhaps that's a good starting
> >>> point for buildroot to integrate meson support? I'm happy to help out
> >>> if no one else was already working on it.
> >>
> >> This would indeed be a very compelling reason to support meson.
> >
> > Also the next enlightenment release (0.22) will only support meson.
> >
>
> I was able to add a package/pkg-meson.mk wrapper (that seems to be
> missing from the Meson patch set, or did I completely miss it?) and
> built the previously submitted libmpdclient version bump via the
> $(eval $(meson-package)) wrapper. I'll work on version bumping systemd
> and converting it to use that wrapper as well. If possible I'd like to
> get this more or less right, what would a reasonable patch set look
> like? I was thinking, as a patch set:
> 1. resubmit the Meson patches (package/meson, documentation) by J?rg Krause

I resubmitted the series, with a version bump to 0.43.0 and other
suggested changes.

@J?rg: in your respin of the series, why was the github helper dropped
in favor of a direct tarball download?

> 2. add package/pkg-meson.mk
> 3. resubmit the libmpdclient version bump patch by J?rg Krause but
> with $(eval $(meson-package)) changes
> 4. submit the systemd version bump and meson conversion patch(es)
>
> That way we have the infrastructure, documentation, and two packages
> utilizing the infrastructure in one set to review. Does that sound
> alright?

@Andrey: I'll be happy to test your patches.

Regards,

--
ELB

[Buildroot] [PATCH 0/3] Add support for Meson build

[Arnout Vandecappelle]

On 11-10-17 05:51, Andrey Yurovsky wrote:
> Hi,
> 
> On Sat, Oct 7, 2017 at 6:06 AM, Romain Naour <romain.naour@smile.fr> wrote:
>> Thomas, Andrey, All,
>>
>> Le 07/10/2017 ? 13:58, Thomas Petazzoni a ?crit :
>>> Hello,
>>>
>>> On Fri, 6 Oct 2017 15:39:03 -0700, Andrey Yurovsky wrote:
>>>
>>>> On Thu, Jul 27, 2017 at 7:50 AM, Thomas Petazzoni
>>>> <thomas.petazzoni@free-electrons.com> wrote:
>>>>> No, let's wait to have a few Meson-based packages in Buildroot, and
>>>>> then we'll have a package infrastructure. This will allow us to see
>>>>> what are the commonalities, what are the differences, etc.
>>>>
>>>> systemd 235 is released (https://lwn.net/Articles/735691/) and it
>>>> drops autoconf/automake and only has meson as the build system (in 234
>>>> they warned this would happen next) so perhaps that's a good starting
>>>> point for buildroot to integrate meson support? I'm happy to help out
>>>> if no one else was already working on it.
>>>
>>> This would indeed be a very compelling reason to support meson.
>>
>> Also the next enlightenment release (0.22) will only support meson.
>>
> 
> I was able to add a package/pkg-meson.mk wrapper (that seems to be
> missing from the Meson patch set, or did I completely miss it?) and

 Yes, our original idea was that there should be a few packages using meson
before we add an infra for it. But since there are quite a few packages that
will use the meson infra, and since it seems pretty straightforward, it can
indeed be done right away (at least according to me, Thomas may have a different
opinion).

> built the previously submitted libmpdclient version bump via the
> $(eval $(meson-package)) wrapper. I'll work on version bumping systemd
> and converting it to use that wrapper as well. If possible I'd like to
> get this more or less right, what would a reasonable patch set look
> like? I was thinking, as a patch set:
> 1. resubmit the Meson patches (package/meson, documentation) by J?rg Krause

 If you're anyway adding pkg-meson.mk, then the documentation doesn't make much
sense (in that form). Better do it after pkg-meson.mk.

> 2. add package/pkg-meson.mk
> 3. resubmit the libmpdclient version bump patch by J?rg Krause but
> with $(eval $(meson-package)) changes
> 4. submit the systemd version bump and meson conversion patch(es)
> 
> That way we have the infrastructure, documentation, and two packages
> utilizing the infrastructure in one set to review. Does that sound
> alright?

 Yes it does!

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 0/3] Add support for Meson build

[Thomas Petazzoni]

Hello,

On Wed, 11 Oct 2017 22:38:39 +0200, Arnout Vandecappelle wrote:

>  Yes, our original idea was that there should be a few packages using meson
> before we add an infra for it. But since there are quite a few packages that
> will use the meson infra, and since it seems pretty straightforward, it can
> indeed be done right away (at least according to me, Thomas may have a different
> opinion).

Yes, I believe it's fine to have a Meson package infrastructure right
away. There is a clear trend towards using Meson, so I'm fine with
merging a package infrastructure for it.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 0/3] Add support for Meson build

[Jörg Krause]

Hi Eric,

On Wed, 2017-10-11 at 08:55 +0200, Eric Le Bihan wrote:
> Hi all!
> 
> On 17-10-10 20:51:55, Andrey Yurovsky wrote:
> > Hi,
> > 
> > On Sat, Oct 7, 2017 at 6:06 AM, Romain Naour <romain.naour@smile.fr> wrote:
> > > Thomas, Andrey, All,
> > > 
> > > Le 07/10/2017 ? 13:58, Thomas Petazzoni a ?crit :
> > > > Hello,
> > > > 
> > > > On Fri, 6 Oct 2017 15:39:03 -0700, Andrey Yurovsky wrote:
> > > > 
> > > > > On Thu, Jul 27, 2017 at 7:50 AM, Thomas Petazzoni
> > > > > <thomas.petazzoni@free-electrons.com> wrote:
> > > > > > No, let's wait to have a few Meson-based packages in Buildroot, and
> > > > > > then we'll have a package infrastructure. This will allow us to see
> > > > > > what are the commonalities, what are the differences, etc.
> > > > > 
> > > > > systemd 235 is released (https://lwn.net/Articles/735691/) and it
> > > > > drops autoconf/automake and only has meson as the build system (in 234
> > > > > they warned this would happen next) so perhaps that's a good starting
> > > > > point for buildroot to integrate meson support? I'm happy to help out
> > > > > if no one else was already working on it.
> > > > 
> > > > This would indeed be a very compelling reason to support meson.
> > > 
> > > Also the next enlightenment release (0.22) will only support meson.
> > > 
> > 
> > I was able to add a package/pkg-meson.mk wrapper (that seems to be
> > missing from the Meson patch set, or did I completely miss it?) and
> > built the previously submitted libmpdclient version bump via the
> > $(eval $(meson-package)) wrapper. I'll work on version bumping systemd
> > and converting it to use that wrapper as well. If possible I'd like to
> > get this more or less right, what would a reasonable patch set look
> > like? I was thinking, as a patch set:
> > 1. resubmit the Meson patches (package/meson, documentation) by J?rg Krause
> 
> I resubmitted the series, with a version bump to 0.43.0 and other
> suggested changes.
> 
> @J?rg: in your respin of the series, why was the github helper dropped
> in favor of a direct tarball download?
> 

As Arnout has responded in a follow-up review, we prefer an uploaded
tarball because the github tarballs might change from time to time.
Furthermore, the uploaded tarballs often contains autogenerated files
which frees us from doing autoreconf for the package.

> > 2. add package/pkg-meson.mk
> > 3. resubmit the libmpdclient version bump patch by J?rg Krause but
> > with $(eval $(meson-package)) changes
> > 4. submit the systemd version bump and meson conversion patch(es)
> > 
> > That way we have the infrastructure, documentation, and two packages
> > utilizing the infrastructure in one set to review. Does that sound
> > alright?
> 
> @Andrey: I'll be happy to test your patches.
> 

Best regards,
J?rg Krause

[Buildroot] [PATCH 0/3] Add support for Meson build

[Adam Duskett]

Hey all;

gstreamer is also moving to meson as well, so I am glad to see this
hapening sooner than later!


Adam

On Thu, Oct 12, 2017 at 2:42 AM, J?rg Krause
<joerg.krause@embedded.rocks> wrote:
> Hi Eric,
>
> On Wed, 2017-10-11 at 08:55 +0200, Eric Le Bihan wrote:
>> Hi all!
>>
>> On 17-10-10 20:51:55, Andrey Yurovsky wrote:
>> > Hi,
>> >
>> > On Sat, Oct 7, 2017 at 6:06 AM, Romain Naour <romain.naour@smile.fr> wrote:
>> > > Thomas, Andrey, All,
>> > >
>> > > Le 07/10/2017 ? 13:58, Thomas Petazzoni a ?crit :
>> > > > Hello,
>> > > >
>> > > > On Fri, 6 Oct 2017 15:39:03 -0700, Andrey Yurovsky wrote:
>> > > >
>> > > > > On Thu, Jul 27, 2017 at 7:50 AM, Thomas Petazzoni
>> > > > > <thomas.petazzoni@free-electrons.com> wrote:
>> > > > > > No, let's wait to have a few Meson-based packages in Buildroot, and
>> > > > > > then we'll have a package infrastructure. This will allow us to see
>> > > > > > what are the commonalities, what are the differences, etc.
>> > > > >
>> > > > > systemd 235 is released (https://lwn.net/Articles/735691/) and it
>> > > > > drops autoconf/automake and only has meson as the build system (in 234
>> > > > > they warned this would happen next) so perhaps that's a good starting
>> > > > > point for buildroot to integrate meson support? I'm happy to help out
>> > > > > if no one else was already working on it.
>> > > >
>> > > > This would indeed be a very compelling reason to support meson.
>> > >
>> > > Also the next enlightenment release (0.22) will only support meson.
>> > >
>> >
>> > I was able to add a package/pkg-meson.mk wrapper (that seems to be
>> > missing from the Meson patch set, or did I completely miss it?) and
>> > built the previously submitted libmpdclient version bump via the
>> > $(eval $(meson-package)) wrapper. I'll work on version bumping systemd
>> > and converting it to use that wrapper as well. If possible I'd like to
>> > get this more or less right, what would a reasonable patch set look
>> > like? I was thinking, as a patch set:
>> > 1. resubmit the Meson patches (package/meson, documentation) by J?rg Krause
>>
>> I resubmitted the series, with a version bump to 0.43.0 and other
>> suggested changes.
>>
>> @J?rg: in your respin of the series, why was the github helper dropped
>> in favor of a direct tarball download?
>>
>
> As Arnout has responded in a follow-up review, we prefer an uploaded
> tarball because the github tarballs might change from time to time.
> Furthermore, the uploaded tarballs often contains autogenerated files
> which frees us from doing autoreconf for the package.
>
>> > 2. add package/pkg-meson.mk
>> > 3. resubmit the libmpdclient version bump patch by J?rg Krause but
>> > with $(eval $(meson-package)) changes
>> > 4. submit the systemd version bump and meson conversion patch(es)
>> >
>> > That way we have the infrastructure, documentation, and two packages
>> > utilizing the infrastructure in one set to review. Does that sound
>> > alright?
>>
>> @Andrey: I'll be happy to test your patches.
>>
>
> Best regards,
> J?rg Krause
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot