From: Lee Jones <lee.jones@linaro.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Marek Vasut <marek.vasut+renesas@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC 1/5] dt-bindings: mfd: bd9571mwv: Document rohm,ddr-backup-power
Date: Fri, 13 Oct 2017 09:55:04 +0100 [thread overview]
Message-ID: <20171013085504.i65ohil6dqdzrd2q@dell> (raw)
In-Reply-To: <1507649178-31473-2-git-send-email-geert+renesas@glider.be>
On Tue, 10 Oct 2017, Geert Uytterhoeven wrote:
> Document the new optional "rohm,ddr-backup-power" property.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt b/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
> index 9ab216a851d5619b..7ea3f2db41d4e501 100644
> --- a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
> +++ b/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
> @@ -25,6 +25,12 @@ Required properties:
> Each child node is defined using the standard
> binding for regulators.
>
> +Optional properties:
> + - rohm,ddr-backup-power : Value to use for DDR-Backup Power. This controls
> + which DDR rails need to be kept powered when backup
> + mode is enabled, cfr. the KEEPON_DDR* bits in the
Perhaps it's just me, but I'm confused by this line.
Can you word it another way?
> + documentation for the "BKUP Mode Cnt" register.
> +
> Example:
>
> pmic: pmic@30 {
> @@ -36,6 +42,7 @@ Example:
> #interrupt-cells = <2>;
> gpio-controller;
> #gpio-cells = <2>;
> + rohm,ddr-backup-power = <15>;
Can you explain what this means? Is it a mask, or does line 15 need
to be kept on? What is the range? Is 0 acceptable? Clarification
required please.
> regulators {
> dvfs: dvfs {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH/RFC 1/5] dt-bindings: mfd: bd9571mwv: Document rohm,ddr-backup-power
Date: Fri, 13 Oct 2017 09:55:04 +0100 [thread overview]
Message-ID: <20171013085504.i65ohil6dqdzrd2q@dell> (raw)
In-Reply-To: <1507649178-31473-2-git-send-email-geert+renesas@glider.be>
On Tue, 10 Oct 2017, Geert Uytterhoeven wrote:
> Document the new optional "rohm,ddr-backup-power" property.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt b/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
> index 9ab216a851d5619b..7ea3f2db41d4e501 100644
> --- a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
> +++ b/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
> @@ -25,6 +25,12 @@ Required properties:
> Each child node is defined using the standard
> binding for regulators.
>
> +Optional properties:
> + - rohm,ddr-backup-power : Value to use for DDR-Backup Power. This controls
> + which DDR rails need to be kept powered when backup
> + mode is enabled, cfr. the KEEPON_DDR* bits in the
Perhaps it's just me, but I'm confused by this line.
Can you word it another way?
> + documentation for the "BKUP Mode Cnt" register.
> +
> Example:
>
> pmic: pmic at 30 {
> @@ -36,6 +42,7 @@ Example:
> #interrupt-cells = <2>;
> gpio-controller;
> #gpio-cells = <2>;
> + rohm,ddr-backup-power = <15>;
Can you explain what this means? Is it a mask, or does line 15 need
to be kept on? What is the range? Is 0 acceptable? Clarification
required please.
> regulators {
> dvfs: dvfs {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-10-13 8:55 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 15:26 [PATCH/RFC 0/5] arm64: dts: renesas: Salvator-X/XS: Enable DDR Backup Mode Geert Uytterhoeven
2017-10-10 15:26 ` [PATCH/RFC 1/5] dt-bindings: mfd: bd9571mwv: Document rohm,ddr-backup-power Geert Uytterhoeven
2017-10-10 15:26 ` Geert Uytterhoeven
2017-10-13 8:55 ` Lee Jones [this message]
2017-10-13 8:55 ` Lee Jones
2017-10-13 9:02 ` Geert Uytterhoeven
2017-10-13 9:02 ` [PATCH/RFC 1/5] dt-bindings: mfd: bd9571mwv: Document rohm, ddr-backup-power Geert Uytterhoeven
2017-10-13 9:02 ` [PATCH/RFC 1/5] dt-bindings: mfd: bd9571mwv: Document rohm,ddr-backup-power Geert Uytterhoeven
2017-10-13 10:00 ` Lee Jones
2017-10-13 10:00 ` Lee Jones
2017-10-13 10:00 ` Lee Jones
2017-10-10 15:26 ` [PATCH/RFC 2/5] mfd: bd9571mwv: Add DDR Backup Power register bit definitions Geert Uytterhoeven
2017-10-13 8:51 ` Lee Jones
2017-10-13 8:51 ` Lee Jones
2018-04-23 18:05 ` Applied "mfd: bd9571mwv: Add DDR Backup Power register bit definitions" to the regulator tree Mark Brown
2018-04-23 18:05 ` Mark Brown
2018-04-23 18:05 ` Mark Brown
2017-10-10 15:26 ` [PATCH/RFC 3/5] mfd: bd9571mwv: Allow DDR Backup Power register access Geert Uytterhoeven
2017-10-13 8:58 ` Lee Jones
2017-10-13 8:58 ` Lee Jones
2017-10-13 8:58 ` Lee Jones
2017-10-13 9:06 ` Geert Uytterhoeven
2017-10-13 9:06 ` Geert Uytterhoeven
2017-10-13 9:06 ` Geert Uytterhoeven
2017-10-13 9:56 ` Lee Jones
2017-10-13 9:56 ` Lee Jones
2017-10-13 9:56 ` Lee Jones
2018-04-23 18:05 ` Applied "mfd: bd9571mwv: Allow DDR Backup Power register access" to the regulator tree Mark Brown
2018-04-23 18:05 ` Mark Brown
2018-04-23 18:05 ` Mark Brown
2017-10-10 15:26 ` [PATCH/RFC 4/5] regulator: bd9571mwv: Add support for backup mode Geert Uytterhoeven
2017-10-10 15:26 ` Geert Uytterhoeven
2017-10-18 11:02 ` Mark Brown
2017-10-18 11:02 ` Mark Brown
2017-10-18 11:02 ` Mark Brown
2017-10-18 11:19 ` Geert Uytterhoeven
2017-10-18 11:19 ` Geert Uytterhoeven
2017-10-18 11:19 ` Geert Uytterhoeven
2017-10-18 11:24 ` Mark Brown
2017-10-18 11:24 ` Mark Brown
2017-10-18 11:24 ` Mark Brown
2017-10-18 11:28 ` Geert Uytterhoeven
2017-10-18 11:28 ` Geert Uytterhoeven
2017-10-18 11:28 ` Geert Uytterhoeven
2017-10-24 8:34 ` Mark Brown
2017-10-24 8:34 ` Mark Brown
2017-10-24 8:34 ` Mark Brown
2017-10-10 15:26 ` [PATCH/RFC 5/5] arm64: dts: renesas: salvator-common: Configure PMIC for DDR Backup Power Geert Uytterhoeven
2017-10-16 7:09 ` Simon Horman
2017-10-16 7:09 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013085504.i65ohil6dqdzrd2q@dell \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.