All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/gvt: Fix error handling bug in perform_bb_shadow
@ 2017-10-15 22:17 Christos Gkekas
  2017-10-16  6:04   ` Wang, Zhi A
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Christos Gkekas @ 2017-10-15 22:17 UTC (permalink / raw)
  To: fred gao, Zhenyu Wang, Zhi Wang, Jani Nikula, Joonas Lahtinen,
	Rodrigo Vivi, David Airlie, intel-gvt-dev, intel-gfx, dri-devel,
	linux-kernel
  Cc: Christos Gkekas

Change the type of variable 'bb_size' from uint32_t to int to be able to
hold error return values from find_bb_size(). This change seems to have
been missed from previous commit 1e3197d6ad73.

Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
 drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
index 2c0ccbb..f41cbf6 100644
--- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
+++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
@@ -1628,7 +1628,7 @@ static int perform_bb_shadow(struct parser_exec_state *s)
 	struct intel_shadow_bb_entry *entry_obj;
 	struct intel_vgpu *vgpu = s->vgpu;
 	unsigned long gma = 0;
-	uint32_t bb_size;
+	int bb_size;
 	void *dst = NULL;
 	int ret = 0;
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* RE: [PATCH] drm/i915/gvt: Fix error handling bug in perform_bb_shadow
  2017-10-15 22:17 [PATCH] drm/i915/gvt: Fix error handling bug in perform_bb_shadow Christos Gkekas
@ 2017-10-16  6:04   ` Wang, Zhi A
  2017-10-16 10:51 ` ✓ Fi.CI.BAT: success for " Patchwork
  2017-10-16 17:11 ` ✓ Fi.CI.IGT: " Patchwork
  2 siblings, 0 replies; 5+ messages in thread
From: Wang, Zhi A @ 2017-10-16  6:04 UTC (permalink / raw)
  To: Christos Gkekas, Gao, Fred, Zhenyu Wang, Jani Nikula,
	Joonas Lahtinen, Vivi, Rodrigo, David Airlie, intel-gvt-dev,
	intel-gfx, dri-devel, linux-kernel

Hi：
    Thanks for the patch. This problem has been fixed on staging branch with:

a8e18bfc854141621a29600a6c13e5f40c6e9f19

drm/i915/gvt: Refine shadow batch buffer

Thanks,
Zhi.

-----Original Message-----
From: Christos Gkekas [mailto:chris.gekas@gmail.com] 
Sent: Monday, October 16, 2017 1:18 AM
To: Gao, Fred <fred.gao@intel.com>; Zhenyu Wang <zhenyuw@linux.intel.com>; Wang, Zhi A <zhi.a.wang@intel.com>; Jani Nikula <jani.nikula@linux.intel.com>; Joonas Lahtinen <joonas.lahtinen@linux.intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>; David Airlie <airlied@linux.ie>; intel-gvt-dev@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
Cc: Christos Gkekas <chris.gekas@gmail.com>
Subject: [PATCH] drm/i915/gvt: Fix error handling bug in perform_bb_shadow

Change the type of variable 'bb_size' from uint32_t to int to be able to hold error return values from find_bb_size(). This change seems to have been missed from previous commit 1e3197d6ad73.

Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
 drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
index 2c0ccbb..f41cbf6 100644
--- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
+++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
@@ -1628,7 +1628,7 @@ static int perform_bb_shadow(struct parser_exec_state *s)
 	struct intel_shadow_bb_entry *entry_obj;
 	struct intel_vgpu *vgpu = s->vgpu;
 	unsigned long gma = 0;
-	uint32_t bb_size;
+	int bb_size;
 	void *dst = NULL;
 	int ret = 0;
 
--
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* RE: [PATCH] drm/i915/gvt: Fix error handling bug in perform_bb_shadow
@ 2017-10-16  6:04   ` Wang, Zhi A
  0 siblings, 0 replies; 5+ messages in thread
From: Wang, Zhi A @ 2017-10-16  6:04 UTC (permalink / raw)
  To: Christos Gkekas, Gao, Fred, Zhenyu Wang, Jani Nikula,
	Joonas Lahtinen, Vivi, Rodrigo, David Airlie, intel-gvt-dev,
	intel-gfx, dri-devel, linux-kernel

Hi：
    Thanks for the patch. This problem has been fixed on staging branch with:

a8e18bfc854141621a29600a6c13e5f40c6e9f19

drm/i915/gvt: Refine shadow batch buffer

Thanks,
Zhi.

-----Original Message-----
From: Christos Gkekas [mailto:chris.gekas@gmail.com] 
Sent: Monday, October 16, 2017 1:18 AM
To: Gao, Fred <fred.gao@intel.com>; Zhenyu Wang <zhenyuw@linux.intel.com>; Wang, Zhi A <zhi.a.wang@intel.com>; Jani Nikula <jani.nikula@linux.intel.com>; Joonas Lahtinen <joonas.lahtinen@linux.intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>; David Airlie <airlied@linux.ie>; intel-gvt-dev@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
Cc: Christos Gkekas <chris.gekas@gmail.com>
Subject: [PATCH] drm/i915/gvt: Fix error handling bug in perform_bb_shadow

Change the type of variable 'bb_size' from uint32_t to int to be able to hold error return values from find_bb_size(). This change seems to have been missed from previous commit 1e3197d6ad73.

Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
 drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
index 2c0ccbb..f41cbf6 100644
--- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
+++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
@@ -1628,7 +1628,7 @@ static int perform_bb_shadow(struct parser_exec_state *s)
 	struct intel_shadow_bb_entry *entry_obj;
 	struct intel_vgpu *vgpu = s->vgpu;
 	unsigned long gma = 0;
-	uint32_t bb_size;
+	int bb_size;
 	void *dst = NULL;
 	int ret = 0;
 
--
2.7.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/gvt: Fix error handling bug in perform_bb_shadow
  2017-10-15 22:17 [PATCH] drm/i915/gvt: Fix error handling bug in perform_bb_shadow Christos Gkekas
  2017-10-16  6:04   ` Wang, Zhi A
@ 2017-10-16 10:51 ` Patchwork
  2017-10-16 17:11 ` ✓ Fi.CI.IGT: " Patchwork
  2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-10-16 10:51 UTC (permalink / raw)
  To: Christos Gkekas; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/gvt: Fix error handling bug in perform_bb_shadow
URL   : https://patchwork.freedesktop.org/series/32006/
State : success

== Summary ==

Series 32006v1 drm/i915/gvt: Fix error handling bug in perform_bb_shadow
https://patchwork.freedesktop.org/api/1.0/series/32006/revisions/1/mbox/

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:452s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:470s
fi-blb-e6850     total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:388s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:565s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:287s
fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:518s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:525s
fi-byt-j1900     total:289  pass:253  dwarn:1   dfail:0   fail:0   skip:35  time:537s
fi-byt-n2820     total:289  pass:249  dwarn:1   dfail:0   fail:0   skip:39  time:524s
fi-cfl-s         total:289  pass:253  dwarn:4   dfail:0   fail:0   skip:32  time:558s
fi-elk-e7500     total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:434s
fi-gdg-551       total:289  pass:178  dwarn:1   dfail:0   fail:1   skip:109 time:273s
fi-glk-1         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:600s
fi-hsw-4770r     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:437s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:470s
fi-ivb-3520m     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:502s
fi-ivb-3770      total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:471s
fi-kbl-7500u     total:289  pass:264  dwarn:1   dfail:0   fail:0   skip:24  time:500s
fi-kbl-7567u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:490s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:593s
fi-pnv-d510      total:289  pass:222  dwarn:1   dfail:0   fail:0   skip:66  time:648s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:466s
fi-skl-6700hq    total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:662s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:536s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:514s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:478s
fi-snb-2520m     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:586s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:428s

32c6bd6dc86e74ea335f8842e62a90ae0a617587 drm-tip: 2017y-10m-16d-09h-30m-45s UTC integration manifest
bcde95b5763a drm/i915/gvt: Fix error handling bug in perform_bb_shadow

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6047/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/gvt: Fix error handling bug in perform_bb_shadow
  2017-10-15 22:17 [PATCH] drm/i915/gvt: Fix error handling bug in perform_bb_shadow Christos Gkekas
  2017-10-16  6:04   ` Wang, Zhi A
  2017-10-16 10:51 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-10-16 17:11 ` Patchwork
  2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-10-16 17:11 UTC (permalink / raw)
  To: Christos Gkekas; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/gvt: Fix error handling bug in perform_bb_shadow
URL   : https://patchwork.freedesktop.org/series/32006/
State : success

== Summary ==

shard-hsw        total:2553 pass:1441 dwarn:0   dfail:0   fail:9   skip:1103 time:9666s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6047/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-16 17:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-15 22:17 [PATCH] drm/i915/gvt: Fix error handling bug in perform_bb_shadow Christos Gkekas
2017-10-16  6:04 ` Wang, Zhi A
2017-10-16  6:04   ` Wang, Zhi A
2017-10-16 10:51 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-16 17:11 ` ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.