All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michal Suchánek" <msuchanek@suse.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "SF Markus Elfring" <elfring@users.sourceforge.net>,
	"Jarkko Sakkinen" <jarkko.sakkinen@linux.intel.com>,
	linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
	"Alexander Steffen" <Alexander.Steffen@infineon.com>,
	"Nayna Jain" <nayna@linux.vnet.ibm.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Jerry Snitselaar" <jsnitsel@redhat.com>,
	"Jason Gunthorpe" <jgunthorpe@obsidianresearch.com>,
	"Julia Lawall" <julia.lawall@lip6.fr>,
	"Corentin Labbe" <clabbe.montjoie@gmail.com>,
	"Kenneth Goldman" <kgold@linux.vnet.ibm.com>,
	"Paul Mackerras" <paulus@samba.org>,
	"Peter Hüwe" <PeterHuewe@gmx.de>,
	"Mimi Zohar" <zohar@linux.vnet.ibm.com>
Subject: Re: char/tpm: Improve a size determination in nine functions
Date: Thu, 19 Oct 2017 14:04:06 +0200	[thread overview]
Message-ID: <20171019140406.046d2714@kitsune.suse.cz> (raw)
In-Reply-To: <1508349793.16112.507.camel@linux.intel.com>

On Wed, 18 Oct 2017 21:03:13 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Wed, 2017-10-18 at 19:48 +0200, SF Markus Elfring wrote:
> > > For 1/4 and 2/4: explain why the message can be omitted.  
> 
> > > That's all.  
> > 
> > I assume that there might be also some communication challenges
> > involved.
> > 
> >   
> > > 3/4: definitive NAK, too much noise compared to value.  
> > 
> > I tried to reduce deviations from the Linux coding style again.
> > You do not like such an attempt for this software area so far.  
> 
> The problem here in a time line or what comes first. Definitely, you
> are trying to fix the code which _is_ upstream vs. the code which
> _might be_ upstream (exception is drivers/staging).
> 
> Why didn't you listen to what people are telling you?
> 
> Why are you spending too much time on little sense crap instead of
> doing real fixes?
> 

People are free to spend their time on what they like.

Even if no commit of this series lands in mainline it has been useful
to clarify what is preferred style and what is useful fix.

Thanks

Michal

WARNING: multiple messages have this Message-ID (diff)
From: "Michal Suchánek" <msuchanek@suse.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "SF Markus Elfring" <elfring@users.sourceforge.net>,
	"Jarkko Sakkinen" <jarkko.sakkinen@linux.intel.com>,
	linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
	"Alexander Steffen" <Alexander.Steffen@infineon.com>,
	"Nayna Jain" <nayna@linux.vnet.ibm.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Jerry Snitselaar" <jsnitsel@redhat.com>,
	"Jason Gunthorpe" <jgunthorpe@obsidianresearch.com>,
	"Julia Lawall" <julia.lawall@lip6.fr>,
	"Corentin Labbe" <clabbe.montjoie@gmail.com>,
	"Kenneth Goldman" <kgold@linux.vnet.ibm.com>,
	"Paul Mackerras" <paulus@samba.org>,
	"Peter Hüwe" <PeterHuewe@gmx.de>,
	"Mimi Zohar" <zohar@linux.vnet.ibm.com>
Subject: Re: char/tpm: Improve a size determination in nine functions
Date: Thu, 19 Oct 2017 12:04:06 +0000	[thread overview]
Message-ID: <20171019140406.046d2714@kitsune.suse.cz> (raw)
In-Reply-To: <1508349793.16112.507.camel@linux.intel.com>

On Wed, 18 Oct 2017 21:03:13 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Wed, 2017-10-18 at 19:48 +0200, SF Markus Elfring wrote:
> > > For 1/4 and 2/4: explain why the message can be omitted.  
> 
> > > That's all.  
> > 
> > I assume that there might be also some communication challenges
> > involved.
> > 
> >   
> > > 3/4: definitive NAK, too much noise compared to value.  
> > 
> > I tried to reduce deviations from the Linux coding style again.
> > You do not like such an attempt for this software area so far.  
> 
> The problem here in a time line or what comes first. Definitely, you
> are trying to fix the code which _is_ upstream vs. the code which
> _might be_ upstream (exception is drivers/staging).
> 
> Why didn't you listen to what people are telling you?
> 
> Why are you spending too much time on little sense crap instead of
> doing real fixes?
> 

People are free to spend their time on what they like.

Even if no commit of this series lands in mainline it has been useful
to clarify what is preferred style and what is useful fix.

Thanks

Michal

  reply	other threads:[~2017-10-19 12:04 UTC|newest]

Thread overview: 221+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16 17:30 [PATCH 0/4] char-TPM: Adjustments for ten function implementations SF Markus Elfring
2017-10-16 17:30 ` SF Markus Elfring
2017-10-16 17:31 ` [PATCH 1/4] char/tpm: Delete an error message for a failed memory allocation in tpm_ascii_bios_measurements_show() SF Markus Elfring
2017-10-16 17:31   ` [PATCH 1/4] char/tpm: Delete an error message for a failed memory allocation in tpm_ascii_bios_measu SF Markus Elfring
2017-10-16 17:32 ` [PATCH 2/4] char/tpm: Delete an error message for a failed memory allocation in tpm_ibmvtpm_probe() SF Markus Elfring
2017-10-16 17:32   ` SF Markus Elfring
2017-10-16 17:33 ` [PATCH 3/4] char/tpm: Improve a size determination in nine functions SF Markus Elfring
2017-10-16 17:33   ` SF Markus Elfring
2017-10-17 11:03   ` Andy Shevchenko
2017-10-17 11:03     ` Andy Shevchenko
2017-10-17 11:50     ` Alexander.Steffen
2017-10-17 11:50       ` Alexander.Steffen
2017-10-17 11:50       ` Alexander.Steffen
2017-10-17 12:52       ` Mimi Zohar
2017-10-17 12:52         ` Mimi Zohar
2017-10-17 12:52         ` Mimi Zohar
2017-10-17 12:58         ` Julia Lawall
2017-10-17 12:58           ` Julia Lawall
2017-10-17 12:58           ` Julia Lawall
2017-10-17 15:17           ` Mimi Zohar
2017-10-17 15:17             ` Mimi Zohar
2017-10-17 15:17             ` Mimi Zohar
2017-10-17 15:29             ` Julia Lawall
2017-10-17 15:29               ` Julia Lawall
2017-10-17 15:29               ` Julia Lawall
2017-10-18  9:16               ` Alexander.Steffen
2017-10-18  9:16                 ` Alexander.Steffen
2017-10-18  9:16                 ` Alexander.Steffen
2017-10-18  9:16                 ` Alexander.Steffen
2017-10-17 18:41             ` SF Markus Elfring
2017-10-17 18:41               ` SF Markus Elfring
2017-10-17 18:41               ` SF Markus Elfring
2017-10-17 19:28               ` Mimi Zohar
2017-10-17 19:28                 ` Mimi Zohar
2017-10-17 19:28                 ` Mimi Zohar
2017-10-17 20:04                 ` SF Markus Elfring
2017-10-17 20:04                   ` SF Markus Elfring
2017-10-17 20:04                   ` SF Markus Elfring
2017-10-17 19:36               ` Andy Shevchenko
2017-10-17 19:36                 ` Andy Shevchenko
2017-10-17 20:24                 ` SF Markus Elfring
2017-10-17 20:24                   ` SF Markus Elfring
2017-10-18 14:57               ` Jarkko Sakkinen
2017-10-18 14:57                 ` Jarkko Sakkinen
2017-10-18 14:57                 ` Jarkko Sakkinen
2017-10-18 15:22                 ` SF Markus Elfring
2017-10-18 15:22                   ` SF Markus Elfring
2017-10-18 15:22                   ` SF Markus Elfring
2017-10-18 15:59                   ` Jarkko Sakkinen
2017-10-18 15:59                     ` Jarkko Sakkinen
2017-10-18 15:59                     ` Jarkko Sakkinen
2017-10-18 16:43                     ` SF Markus Elfring
2017-10-18 16:43                       ` SF Markus Elfring
2017-10-18 16:43                       ` SF Markus Elfring
2017-10-18 17:18                       ` Jarkko Sakkinen
2017-10-18 17:18                         ` Jarkko Sakkinen
2017-10-18 17:18                         ` Jarkko Sakkinen
2017-10-18 17:22                         ` Jarkko Sakkinen
2017-10-18 17:22                           ` Jarkko Sakkinen
2017-10-18 17:22                           ` Jarkko Sakkinen
2017-10-18 17:54                           ` SF Markus Elfring
2017-10-18 17:54                             ` SF Markus Elfring
2017-10-18 17:48                         ` SF Markus Elfring
2017-10-18 17:48                           ` SF Markus Elfring
2017-10-18 17:48                           ` SF Markus Elfring
2017-10-18 17:54                           ` Jerry Snitselaar
2017-10-18 17:54                             ` Jerry Snitselaar
2017-10-18 17:54                             ` Jerry Snitselaar
2017-10-18 18:11                             ` char/tpm: Delete an error message for a failed memory allocation in tpm_…() SF Markus Elfring
2017-10-18 18:11                               ` SF Markus Elfring
2017-10-18 18:11                               ` char/tpm: Delete an error message for a failed memory =?UTF-8?B?IGFsbG9jYXRpb24gaW4g SF Markus Elfring
2017-10-18 18:03                           ` char/tpm: Improve a size determination in nine functions Andy Shevchenko
2017-10-18 18:03                             ` Andy Shevchenko
2017-10-19 12:04                             ` Michal Suchánek [this message]
2017-10-19 12:04                               ` Michal Suchánek
2017-10-19 12:16                           ` Jarkko Sakkinen
2017-10-19 12:16                             ` Jarkko Sakkinen
2017-10-19 12:16                             ` Jarkko Sakkinen
2017-10-17 13:02         ` [PATCH 3/4] " Andy Shevchenko
2017-10-17 13:02           ` Andy Shevchenko
2017-10-17 13:02           ` Andy Shevchenko
2017-10-18 14:52           ` Jarkko Sakkinen
2017-10-18 14:52             ` Jarkko Sakkinen
2017-10-17 15:22         ` Alexander.Steffen
2017-10-17 15:22           ` Alexander.Steffen
2017-10-17 15:22           ` Alexander.Steffen
2017-10-17 15:22           ` Alexander.Steffen
2017-10-18 14:48       ` Jarkko Sakkinen
2017-10-18 14:48         ` Jarkko Sakkinen
2017-10-19 16:58         ` Alexander.Steffen
2017-10-19 16:58           ` Alexander.Steffen
2017-10-19 16:58           ` Alexander.Steffen
2017-10-20  9:01           ` Jarkko Sakkinen
2017-10-20  9:01             ` Jarkko Sakkinen
2017-10-20 10:23             ` Jarkko Sakkinen
2017-10-20 10:23               ` Jarkko Sakkinen
2017-10-20 12:03               ` Alexander.Steffen
2017-10-20 12:03                 ` Alexander.Steffen
2017-10-20 12:03                 ` Alexander.Steffen
2017-10-23 13:20           ` Dan Carpenter
2017-10-23 13:20             ` Dan Carpenter
2017-10-18 14:40     ` Jarkko Sakkinen
2017-10-18 14:40       ` Jarkko Sakkinen
2017-10-16 17:34 ` [PATCH 4/4] char/tpm: Less checks in tpm_ibmvtpm_probe() after error detection SF Markus Elfring
2017-10-16 17:34   ` SF Markus Elfring
2017-10-19 11:56   ` Michal Suchánek
2017-10-19 11:56     ` Michal Suchánek
2017-10-19 12:36     ` SF Markus Elfring
2017-10-19 12:36       ` SF Markus Elfring
2017-10-19 12:46       ` Michal Suchánek
2017-10-19 12:46         ` Michal Suchánek
2017-10-19 14:26         ` Dan Carpenter
2017-10-19 14:26           ` Dan Carpenter
2017-10-19 13:36     ` Dan Carpenter
2017-10-19 13:36       ` Dan Carpenter
2017-10-19 13:36       ` Dan Carpenter
2017-10-19 14:16       ` Michal Suchánek
2017-10-19 14:16         ` Michal Suchánek
2017-10-19 14:16         ` Michal Suchánek
2017-10-19 14:16         ` Michal Suchánek
2017-10-19 14:59         ` Dan Carpenter
2017-10-19 14:59           ` Dan Carpenter
2017-10-19 14:59           ` Dan Carpenter
2017-10-19 20:44       ` SF Markus Elfring
2017-10-19 20:44         ` SF Markus Elfring
2017-10-19 20:44         ` SF Markus Elfring
2017-10-16 18:31 ` [PATCH 0/4] char-TPM: Adjustments for ten function implementations Jarkko Sakkinen
2017-10-16 18:31   ` Jarkko Sakkinen
2017-10-16 18:35   ` Jarkko Sakkinen
2017-10-16 18:35     ` Jarkko Sakkinen
2017-10-16 20:44     ` SF Markus Elfring
2017-10-16 20:44       ` SF Markus Elfring
2017-10-18 15:04       ` Jarkko Sakkinen
2017-10-18 15:04         ` Jarkko Sakkinen
2017-10-18 15:43         ` SF Markus Elfring
2017-10-18 15:43           ` SF Markus Elfring
2017-10-18 15:43           ` SF Markus Elfring
2017-10-16 22:46     ` [PATCH 0/4] " Joe Perches
2017-10-16 22:46       ` Joe Perches
2017-10-17  7:20       ` SF Markus Elfring
2017-10-17  7:20         ` SF Markus Elfring
2017-10-17  8:51     ` Dan Carpenter
2017-10-17  8:51       ` Dan Carpenter
2017-10-17  8:56       ` Julia Lawall
2017-10-17  8:56         ` Julia Lawall
2017-10-17  9:44         ` Dan Carpenter
2017-10-17  9:44           ` Dan Carpenter
2017-10-17 10:11           ` Julia Lawall
2017-10-17 10:11             ` Julia Lawall
2017-10-17 11:52             ` Mimi Zohar
2017-10-17 11:52               ` Mimi Zohar
2017-10-17 11:52               ` Mimi Zohar
2017-10-18  3:18               ` Michael Ellerman
2017-10-18  3:18                 ` Michael Ellerman
2017-10-19 13:16                 ` Mimi Zohar
2017-10-19 13:16                   ` Mimi Zohar
2017-10-19 16:08                   ` Circumstances for using the tag “Fixes” (or not) SF Markus Elfring
2017-10-19 16:08                     ` SF Markus Elfring
2017-10-17 12:26           ` [PATCH 0/4] char-TPM: Adjustments for ten function implementations Michael Ellerman
2017-10-17 12:26             ` Michael Ellerman
2017-10-18 15:07           ` Jarkko Sakkinen
2017-10-18 15:07             ` Jarkko Sakkinen
2017-10-17  9:25       ` SF Markus Elfring
2017-10-17  9:25         ` SF Markus Elfring
2017-10-17 15:57         ` James Bottomley
2017-10-17 15:57           ` James Bottomley
2017-10-17 16:32           ` SF Markus Elfring
2017-10-17 16:32             ` SF Markus Elfring
2017-10-17 16:32             ` SF Markus Elfring
2017-10-17 22:43           ` Joe Perches
2017-10-17 22:43             ` Joe Perches
2017-10-17 22:43             ` Joe Perches
2017-10-17 22:43             ` Joe Perches
2017-10-18  9:00             ` SF Markus Elfring
2017-10-18  9:00               ` SF Markus Elfring
2017-10-18  9:18               ` Joe Perches
2017-10-18  9:18                 ` Joe Perches
2017-10-18  9:50                 ` Alexander.Steffen
2017-10-18  9:50                   ` Alexander.Steffen
2017-10-18  9:50                   ` Alexander.Steffen
2017-10-18 10:00                   ` Julia Lawall
2017-10-18 10:00                     ` Julia Lawall
2017-10-18 10:28                     ` Joe Perches
2017-10-18 10:28                       ` Joe Perches
2017-10-18 10:28                       ` Joe Perches
2017-10-18 11:00                       ` Adjusting further size determinations? SF Markus Elfring
2017-10-18 11:00                         ` SF Markus Elfring
2017-10-18 11:49                         ` Joe Perches
2017-10-18 11:49                           ` Joe Perches
2017-10-18 12:07                           ` SF Markus Elfring
2017-10-18 12:07                             ` SF Markus Elfring
2017-10-18 12:58                             ` David Laight
2017-10-18 12:58                               ` David Laight
2017-10-18 12:58                               ` David Laight
2017-10-18 13:32                               ` Julia Lawall
2017-10-18 13:32                                 ` Julia Lawall
2017-10-18 13:50                                 ` SF Markus Elfring
2017-10-18 13:50                                   ` SF Markus Elfring
2017-10-18 13:50                                   ` SF Markus Elfring
2017-10-18 10:44                     ` char-TPM: Adjustments for ten function implementations Alexander.Steffen
2017-10-18 10:44                       ` Alexander.Steffen
2017-10-18 10:44                       ` Alexander.Steffen
2017-10-18 10:49                       ` Joe Perches
2017-10-18 10:49                         ` Joe Perches
2017-10-18 10:49                         ` Joe Perches
2017-10-18 11:07                         ` Alexander.Steffen
2017-10-18 11:07                           ` Alexander.Steffen
2017-10-18 11:07                           ` Alexander.Steffen
2017-10-18  9:55                 ` SF Markus Elfring
2017-10-18  9:55                   ` SF Markus Elfring
2017-10-18 18:27                 ` Michal Suchánek
2017-10-18 18:27                   ` Michal Suchánek
2017-10-18 15:10           ` [PATCH 0/4] " Jarkko Sakkinen
2017-10-18 15:10             ` Jarkko Sakkinen
2017-10-18 15:10             ` Jarkko Sakkinen
2017-10-18 16:09             ` James Bottomley
2017-10-18 16:09               ` James Bottomley
2017-10-18 16:09               ` James Bottomley
2017-10-18 17:13               ` Jarkko Sakkinen
2017-10-18 17:13                 ` Jarkko Sakkinen
2017-10-18 17:13                 ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171019140406.046d2714@kitsune.suse.cz \
    --to=msuchanek@suse.de \
    --cc=Alexander.Steffen@infineon.com \
    --cc=PeterHuewe@gmx.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=clabbe.montjoie@gmail.com \
    --cc=elfring@users.sourceforge.net \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=jsnitsel@redhat.com \
    --cc=julia.lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kgold@linux.vnet.ibm.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nayna@linux.vnet.ibm.com \
    --cc=paulus@samba.org \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.