From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: akpm@linux-foundation.org, Jan Kara <jack@suse.cz>,
linux-nvdimm@lists.01.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, Jeff Moyer <jmoyer@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-fsdevel@vger.kernel.org,
Ross Zwisler <ross.zwisler@linux.intel.com>,
hch@lst.de, Gerald Schaefer <gerald.schaefer@de.ibm.com>
Subject: Re: [PATCH v3 02/13] dax: require 'struct page' for filesystem dax
Date: Fri, 20 Oct 2017 09:57:35 +0200 [thread overview]
Message-ID: <20171020075735.GA14378@lst.de> (raw)
In-Reply-To: <150846714747.24336.14704246566580871364.stgit@dwillia2-desk3.amr.corp.intel.com>
> --- a/arch/powerpc/sysdev/axonram.c
> +++ b/arch/powerpc/sysdev/axonram.c
> @@ -172,6 +172,7 @@ static size_t axon_ram_copy_from_iter(struct dax_device *dax_dev, pgoff_t pgoff,
>
> static const struct dax_operations axon_ram_dax_ops = {
> .direct_access = axon_ram_dax_direct_access,
> +
> .copy_from_iter = axon_ram_copy_from_iter,
Unrelated whitespace change. That being said - I don't think axonram has
devmap support in any form, so this basically becomes dead code, doesn't
it?
> diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c
> index 7abb240847c0..e7e5db07e339 100644
> --- a/drivers/s390/block/dcssblk.c
> +++ b/drivers/s390/block/dcssblk.c
> @@ -52,6 +52,7 @@ static size_t dcssblk_dax_copy_from_iter(struct dax_device *dax_dev,
>
> static const struct dax_operations dcssblk_dax_ops = {
> .direct_access = dcssblk_dax_direct_access,
> +
> .copy_from_iter = dcssblk_dax_copy_from_iter,
Same comments apply here.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: akpm@linux-foundation.org, Jan Kara <jack@suse.cz>,
linux-nvdimm@lists.01.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, Jeff Moyer <jmoyer@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-fsdevel@vger.kernel.org,
Ross Zwisler <ross.zwisler@linux.intel.com>,
hch@lst.de, Gerald Schaefer <gerald.schaefer@de.ibm.com>
Subject: Re: [PATCH v3 02/13] dax: require 'struct page' for filesystem dax
Date: Fri, 20 Oct 2017 09:57:35 +0200 [thread overview]
Message-ID: <20171020075735.GA14378@lst.de> (raw)
In-Reply-To: <150846714747.24336.14704246566580871364.stgit@dwillia2-desk3.amr.corp.intel.com>
> --- a/arch/powerpc/sysdev/axonram.c
> +++ b/arch/powerpc/sysdev/axonram.c
> @@ -172,6 +172,7 @@ static size_t axon_ram_copy_from_iter(struct dax_device *dax_dev, pgoff_t pgoff,
>
> static const struct dax_operations axon_ram_dax_ops = {
> .direct_access = axon_ram_dax_direct_access,
> +
> .copy_from_iter = axon_ram_copy_from_iter,
Unrelated whitespace change. That being said - I don't think axonram has
devmap support in any form, so this basically becomes dead code, doesn't
it?
> diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c
> index 7abb240847c0..e7e5db07e339 100644
> --- a/drivers/s390/block/dcssblk.c
> +++ b/drivers/s390/block/dcssblk.c
> @@ -52,6 +52,7 @@ static size_t dcssblk_dax_copy_from_iter(struct dax_device *dax_dev,
>
> static const struct dax_operations dcssblk_dax_ops = {
> .direct_access = dcssblk_dax_direct_access,
> +
> .copy_from_iter = dcssblk_dax_copy_from_iter,
Same comments apply here.
next prev parent reply other threads:[~2017-10-20 7:57 UTC|newest]
Thread overview: 143+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 2:38 [PATCH v3 00/13] dax: fix dma vs truncate and remove 'page-less' support Dan Williams
2017-10-20 2:38 ` Dan Williams
2017-10-20 2:38 ` Dan Williams
2017-10-20 2:38 ` Dan Williams
2017-10-20 2:39 ` [PATCH v3 01/13] dax: quiet bdev_dax_supported() Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` [PATCH v3 02/13] dax: require 'struct page' for filesystem dax Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 7:57 ` Christoph Hellwig [this message]
2017-10-20 7:57 ` Christoph Hellwig
2017-10-20 15:23 ` Dan Williams
2017-10-20 15:23 ` Dan Williams
2017-10-20 15:23 ` Dan Williams
2017-10-20 16:29 ` Christoph Hellwig
2017-10-20 16:29 ` Christoph Hellwig
2017-10-20 16:29 ` Christoph Hellwig
2017-10-20 16:29 ` Christoph Hellwig
2017-10-20 22:29 ` Dan Williams
2017-10-20 22:29 ` Dan Williams
2017-10-20 22:29 ` Dan Williams
2017-10-21 3:20 ` Matthew Wilcox
2017-10-21 3:20 ` Matthew Wilcox
2017-10-21 3:20 ` Matthew Wilcox
2017-10-21 4:16 ` Dan Williams
2017-10-21 4:16 ` Dan Williams
2017-10-21 4:16 ` Dan Williams
2017-10-21 8:15 ` Christoph Hellwig
2017-10-21 8:15 ` Christoph Hellwig
2017-10-21 8:15 ` Christoph Hellwig
2017-10-23 5:18 ` Martin Schwidefsky
2017-10-23 5:18 ` Martin Schwidefsky
2017-10-23 5:18 ` Martin Schwidefsky
2017-10-23 8:55 ` Dan Williams
2017-10-23 8:55 ` Dan Williams
2017-10-23 10:44 ` Martin Schwidefsky
2017-10-23 10:44 ` Martin Schwidefsky
2017-10-23 10:44 ` Martin Schwidefsky
2017-10-23 11:20 ` Dan Williams
2017-10-23 11:20 ` Dan Williams
2017-10-23 11:20 ` Dan Williams
2017-10-20 2:39 ` [PATCH v3 03/13] dax: stop using VM_MIXEDMAP for dax Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` [PATCH v3 04/13] dax: stop using VM_HUGEPAGE " Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` [PATCH v3 05/13] dax: stop requiring a live device for dax_flush() Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` [PATCH v3 06/13] dax: store pfns in the radix Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` [PATCH v3 07/13] dax: warn if dma collides with truncate Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` [PATCH v3 08/13] tools/testing/nvdimm: add 'bio_delay' mechanism Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` [PATCH v3 09/13] IB/core: disable memory registration of fileystem-dax vmas Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` [PATCH v3 10/13] mm: disable get_user_pages_fast() for dax Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` [PATCH v3 11/13] fs: use smp_load_acquire in break_{layout,lease} Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 2:39 ` Dan Williams
2017-10-20 12:39 ` Jeffrey Layton
2017-10-20 12:39 ` Jeffrey Layton
2017-10-20 12:39 ` Jeffrey Layton
2017-10-20 12:39 ` Jeffrey Layton
2017-10-20 2:40 ` [PATCH v3 12/13] dax: handle truncate of dma-busy pages Dan Williams
2017-10-20 2:40 ` Dan Williams
2017-10-20 2:40 ` Dan Williams
2017-10-20 13:05 ` Jeff Layton
2017-10-20 13:05 ` Jeff Layton
2017-10-20 13:05 ` Jeff Layton
2017-10-20 15:42 ` Dan Williams
2017-10-20 15:42 ` Dan Williams
2017-10-20 15:42 ` Dan Williams
2017-10-20 16:32 ` Christoph Hellwig
2017-10-20 16:32 ` Christoph Hellwig
2017-10-20 16:32 ` Christoph Hellwig
2017-10-20 17:27 ` Dan Williams
2017-10-20 17:27 ` Dan Williams
2017-10-20 17:27 ` Dan Williams
2017-10-20 20:36 ` Brian Foster
2017-10-20 20:36 ` Brian Foster
2017-10-20 20:36 ` Brian Foster
2017-10-21 8:11 ` Christoph Hellwig
2017-10-21 8:11 ` Christoph Hellwig
2017-10-20 2:40 ` [PATCH v3 13/13] xfs: wire up FL_ALLOCATED support Dan Williams
2017-10-20 2:40 ` Dan Williams
2017-10-20 2:40 ` Dan Williams
2017-10-20 7:47 ` [PATCH v3 00/13] dax: fix dma vs truncate and remove 'page-less' support Christoph Hellwig
2017-10-20 7:47 ` Christoph Hellwig
2017-10-20 7:47 ` Christoph Hellwig
2017-10-20 7:47 ` Christoph Hellwig
2017-10-20 9:31 ` Christoph Hellwig
2017-10-20 9:31 ` Christoph Hellwig
2017-10-20 9:31 ` Christoph Hellwig
2017-10-26 10:58 ` Jan Kara
2017-10-26 10:58 ` Jan Kara
2017-10-26 10:58 ` Jan Kara
2017-10-26 10:58 ` Jan Kara
2017-10-26 23:51 ` Williams, Dan J
2017-10-26 23:51 ` Williams, Dan J
2017-10-26 23:51 ` Williams, Dan J
2017-10-26 23:51 ` Williams, Dan J
2017-10-27 6:48 ` Dave Chinner
2017-10-27 6:48 ` Dave Chinner
2017-10-27 6:48 ` Dave Chinner
2017-10-27 6:48 ` Dave Chinner
2017-10-27 6:48 ` Dave Chinner
2017-10-27 11:42 ` Dan Williams
2017-10-27 11:42 ` Dan Williams
2017-10-27 11:42 ` Dan Williams
2017-10-29 21:52 ` Dave Chinner
2017-10-29 21:52 ` Dave Chinner
2017-10-29 21:52 ` Dave Chinner
2017-10-27 6:45 ` Christoph Hellwig
2017-10-27 6:45 ` Christoph Hellwig
2017-10-27 6:45 ` Christoph Hellwig
2017-10-29 23:46 ` Dan Williams
2017-10-29 23:46 ` Dan Williams
2017-10-29 23:46 ` Dan Williams
2017-10-30 2:00 ` Dave Chinner
2017-10-30 2:00 ` Dave Chinner
2017-10-30 2:00 ` Dave Chinner
2017-10-30 2:00 ` Dave Chinner
2017-10-30 8:38 ` Jan Kara
2017-10-30 8:38 ` Jan Kara
2017-10-30 8:38 ` Jan Kara
2017-10-30 11:20 ` Dave Chinner
2017-10-30 11:20 ` Dave Chinner
2017-10-30 11:20 ` Dave Chinner
2017-10-30 11:20 ` Dave Chinner
2017-10-30 17:51 ` Dan Williams
2017-10-30 17:51 ` Dan Williams
2017-10-30 17:51 ` Dan Williams
2017-10-30 17:51 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020075735.GA14378@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=dan.j.williams@intel.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=ross.zwisler@linux.intel.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.