* [PATCH 1/2] drivers: fix shared build error for DPAA crypto
@ 2017-10-26 14:09 Shreyansh Jain
2017-10-26 14:09 ` [PATCH 2/2] drivers: fix shared build error for dpaa2 event Shreyansh Jain
2017-10-26 14:10 ` [PATCH 1/2] drivers: fix shared build error for DPAA crypto Akhil Goyal
0 siblings, 2 replies; 4+ messages in thread
From: Shreyansh Jain @ 2017-10-26 14:09 UTC (permalink / raw)
To: dev; +Cc: olivier.matz, akhil.goyal, thomas, ferruh.yigit, Shreyansh Jain
Various symbols are being used by DPAA Crypto driver which were not exposed
from DPAA bus during initial version. This breaks the shared build.
This patch also adds the LDLIBS line required after (cbc12b0a9) patch.
Fixes: c3e85bdcc6e6 ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform")
Cc: akhil.goyal@nxp.com
Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
drivers/bus/dpaa/rte_bus_dpaa_version.map | 9 +++++++++
drivers/crypto/dpaa_sec/Makefile | 2 ++
2 files changed, 11 insertions(+)
diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map b/drivers/bus/dpaa/rte_bus_dpaa_version.map
index 64a05a9..fb9d532 100644
--- a/drivers/bus/dpaa/rte_bus_dpaa_version.map
+++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map
@@ -40,14 +40,23 @@ DPDK_17.11 {
fman_ip_rev;
netcfg_acquire;
netcfg_release;
+ of_find_compatible_node;
+ of_get_property;
+ qm_channel_caam;
qman_create_fq;
qman_dequeue;
qman_dqrr_consume;
+ qman_enqueue;
qman_enqueue_multi;
+ qman_fq_fqid;
+ qman_fq_state;
qman_global_init;
qman_init_fq;
+ qman_poll_dqrr;
+ qman_query_fq_np;
qman_set_vdq;
qman_reserve_fqid_range;
+ qman_volatile_dequeue;
rte_dpaa_driver_register;
rte_dpaa_driver_unregister;
rte_dpaa_mem_ptov;
diff --git a/drivers/crypto/dpaa_sec/Makefile b/drivers/crypto/dpaa_sec/Makefile
index 9a061b4..17bc79c 100644
--- a/drivers/crypto/dpaa_sec/Makefile
+++ b/drivers/crypto/dpaa_sec/Makefile
@@ -53,6 +53,8 @@ CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa_sec/
CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa2_sec/
CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linuxapp/eal
+LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
+LDLIBS += -lrte_cryptodev
# versioning export map
EXPORT_MAP := rte_pmd_dpaa_sec_version.map
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] drivers: fix shared build error for dpaa2 event
2017-10-26 14:09 [PATCH 1/2] drivers: fix shared build error for DPAA crypto Shreyansh Jain
@ 2017-10-26 14:09 ` Shreyansh Jain
2017-10-26 14:10 ` [PATCH 1/2] drivers: fix shared build error for DPAA crypto Akhil Goyal
1 sibling, 0 replies; 4+ messages in thread
From: Shreyansh Jain @ 2017-10-26 14:09 UTC (permalink / raw)
To: dev
Cc: olivier.matz, akhil.goyal, thomas, ferruh.yigit, Shreyansh Jain,
nipun.gupta
Fixes: cbc12b0a96f5 ("mk: do not generate LDLIBS from directory dependencies")
Cc: olivier.matz@6wind.com
Fixes: b677d4c6d281 ("net/dpaa2: add API for event Rx adapter")
Cc: nipun.gupta@nxp.com
Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
* This change should have been originally part of cbc12b0a96 but was not
caught in review.
* Also, map file changes too should have been part of original event
patches.
drivers/event/dpaa2/Makefile | 2 +-
drivers/net/dpaa2/rte_pmd_dpaa2_version.map | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/event/dpaa2/Makefile b/drivers/event/dpaa2/Makefile
index b23c18e..d268e33 100644
--- a/drivers/event/dpaa2/Makefile
+++ b/drivers/event/dpaa2/Makefile
@@ -45,7 +45,7 @@ CFLAGS += -I$(RTE_SDK)/drivers/bus/fslmc/portal
CFLAGS += -I$(RTE_SDK)/drivers/mempool/dpaa2
CFLAGS += -I$(RTE_SDK)/drivers/event/dpaa2
CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linuxapp/eal
-LDLIBS += -lrte_eal -lrte_eventdev -lrte_bus_fslmc
+LDLIBS += -lrte_eal -lrte_eventdev -lrte_bus_fslmc -lrte_pmd_dpaa2
CFLAGS += -I$(RTE_SDK)/drivers/net/dpaa2
CFLAGS += -I$(RTE_SDK)/drivers/net/dpaa2/mc
diff --git a/drivers/net/dpaa2/rte_pmd_dpaa2_version.map b/drivers/net/dpaa2/rte_pmd_dpaa2_version.map
index b741bc0..09f4364 100644
--- a/drivers/net/dpaa2/rte_pmd_dpaa2_version.map
+++ b/drivers/net/dpaa2/rte_pmd_dpaa2_version.map
@@ -8,4 +8,5 @@ DPDK_17.11 {
dpaa2_eth_eventq_attach;
dpaa2_eth_eventq_detach;
-};
+
+} DPDK_17.05;
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] drivers: fix shared build error for DPAA crypto
2017-10-26 14:09 [PATCH 1/2] drivers: fix shared build error for DPAA crypto Shreyansh Jain
2017-10-26 14:09 ` [PATCH 2/2] drivers: fix shared build error for dpaa2 event Shreyansh Jain
@ 2017-10-26 14:10 ` Akhil Goyal
2017-10-26 21:06 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Akhil Goyal @ 2017-10-26 14:10 UTC (permalink / raw)
To: Shreyansh Jain, dev; +Cc: olivier.matz, thomas, ferruh.yigit
On 10/26/2017 7:39 PM, Shreyansh Jain wrote:
> Various symbols are being used by DPAA Crypto driver which were not exposed
> from DPAA bus during initial version. This breaks the shared build.
>
> This patch also adds the LDLIBS line required after (cbc12b0a9) patch.
>
> Fixes: c3e85bdcc6e6 ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform")
> Cc: akhil.goyal@nxp.com
>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---
> drivers/bus/dpaa/rte_bus_dpaa_version.map | 9 +++++++++
> drivers/crypto/dpaa_sec/Makefile | 2 ++
> 2 files changed, 11 insertions(+)
>
> diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map b/drivers/bus/dpaa/rte_bus_dpaa_version.map
> index 64a05a9..fb9d532 100644
> --- a/drivers/bus/dpaa/rte_bus_dpaa_version.map
> +++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map
> @@ -40,14 +40,23 @@ DPDK_17.11 {
> fman_ip_rev;
> netcfg_acquire;
> netcfg_release;
> + of_find_compatible_node;
> + of_get_property;
> + qm_channel_caam;
> qman_create_fq;
> qman_dequeue;
> qman_dqrr_consume;
> + qman_enqueue;
> qman_enqueue_multi;
> + qman_fq_fqid;
> + qman_fq_state;
> qman_global_init;
> qman_init_fq;
> + qman_poll_dqrr;
> + qman_query_fq_np;
> qman_set_vdq;
> qman_reserve_fqid_range;
> + qman_volatile_dequeue;
> rte_dpaa_driver_register;
> rte_dpaa_driver_unregister;
> rte_dpaa_mem_ptov;
> diff --git a/drivers/crypto/dpaa_sec/Makefile b/drivers/crypto/dpaa_sec/Makefile
> index 9a061b4..17bc79c 100644
> --- a/drivers/crypto/dpaa_sec/Makefile
> +++ b/drivers/crypto/dpaa_sec/Makefile
> @@ -53,6 +53,8 @@ CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa_sec/
> CFLAGS += -I$(RTE_SDK)/drivers/crypto/dpaa2_sec/
> CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
> CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linuxapp/eal
> +LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
> +LDLIBS += -lrte_cryptodev
>
> # versioning export map
> EXPORT_MAP := rte_pmd_dpaa_sec_version.map
>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] drivers: fix shared build error for DPAA crypto
2017-10-26 14:10 ` [PATCH 1/2] drivers: fix shared build error for DPAA crypto Akhil Goyal
@ 2017-10-26 21:06 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2017-10-26 21:06 UTC (permalink / raw)
To: Shreyansh Jain; +Cc: dev, Akhil Goyal, olivier.matz, ferruh.yigit
26/10/2017 16:10, Akhil Goyal:
> On 10/26/2017 7:39 PM, Shreyansh Jain wrote:
> > Various symbols are being used by DPAA Crypto driver which were not exposed
> > from DPAA bus during initial version. This breaks the shared build.
> >
> > This patch also adds the LDLIBS line required after (cbc12b0a9) patch.
> >
> > Fixes: c3e85bdcc6e6 ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform")
> > Cc: akhil.goyal@nxp.com
> >
> > Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> >
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-26 21:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-26 14:09 [PATCH 1/2] drivers: fix shared build error for DPAA crypto Shreyansh Jain
2017-10-26 14:09 ` [PATCH 2/2] drivers: fix shared build error for dpaa2 event Shreyansh Jain
2017-10-26 14:10 ` [PATCH 1/2] drivers: fix shared build error for DPAA crypto Akhil Goyal
2017-10-26 21:06 ` Thomas Monjalon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.