From: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>,
dev@dpdk.org, Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v4] bus/pci: fix vfio mode
Date: Tue, 31 Oct 2017 15:11:38 +0100 [thread overview]
Message-ID: <20171031141138.GJ10890@bidouze.vm.6wind.com> (raw)
In-Reply-To: <20171030223227.8852-1-ferruh.yigit@intel.com>
Hi Ferruh,
On Mon, Oct 30, 2017 at 10:32:27PM +0000, Ferruh Yigit wrote:
> Revert back to using VFIO_PRESENT as a marker to enable compilation
> of VFIO-related segments.
>
> VFIO_PRESENT is the combination of user configuration RTE_EAL_VFIO and
> kernel version support check.
>
> eal_vfio.h VFIO_PRESENT related check ordered to be compatible with
> rte_vfio.h one, no functional modification.
>
> Fixes: 279b581c897d ("vfio: expose functions")
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> v4:
>
> * Alternative to v3, not superseding it, need to decide which one to
> get. This one:
> * fixes vfio for new kernels
> * fixes build for old kernels for vfio enabled in config case
> * print warning if vfio enabled in config but not supported by kernel
>
Thanks for the v4.
Well, as I stated before, I am more of the opinion of letting the
VFIO_PRESENT define only within eal_vfio.h.
But in the end, as long as everything is working, I'm fine with it.
Unless someone is explicitly interested in going with my version, let's
keep yours. If needed I can always submit a new v4 that would actually
work with old kernels.
Sorry about the mess concerning VFIO. I found late in the work that I
needed to touch it, and did not have the test-bed for it.
prev parent reply other threads:[~2017-10-31 14:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-28 6:20 [PATCH] bus/pci: fix vfio mode Jerin Jacob
2017-10-30 8:06 ` Gaëtan Rivet
2017-10-30 9:00 ` Ferruh Yigit
2017-10-30 9:17 ` Gaëtan Rivet
2017-10-30 9:27 ` Thomas Monjalon
2017-10-30 11:24 ` Thomas Monjalon
2017-10-30 16:57 ` Ferruh Yigit
2017-10-30 17:13 ` Gaëtan Rivet
2017-10-30 9:10 ` Jerin Jacob
2017-10-30 12:55 ` [PATCH v2 1/2] " Gaetan Rivet
2017-10-30 12:55 ` [PATCH v2 2/2] eal: warn user that VFIO is disabled Gaetan Rivet
2017-10-30 16:36 ` [PATCH v3 1/2] bus/pci: fix vfio mode Gaetan Rivet
2017-10-30 16:36 ` [PATCH v3 2/2] eal: warn user that VFIO is disabled Gaetan Rivet
2017-10-30 17:31 ` Ferruh Yigit
2017-10-30 17:26 ` [PATCH v3 1/2] bus/pci: fix vfio mode Ferruh Yigit
2017-10-30 19:07 ` Ferruh Yigit
2017-10-30 22:32 ` [PATCH v4] " Ferruh Yigit
2017-10-31 12:03 ` Bruce Richardson
2017-10-31 16:58 ` Ferruh Yigit
2017-10-31 18:21 ` Thomas Monjalon
2017-10-31 14:11 ` Gaëtan Rivet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031141138.GJ10890@bidouze.vm.6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.