Re: [PATCH v4] bus/pci: fix vfio mode

From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>,
	dev@dpdk.org, Jerin Jacob <jerin.jacob@caviumnetworks.com>,
	Gaetan Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v4] bus/pci: fix vfio mode
Date: Tue, 31 Oct 2017 09:58:29 -0700	[thread overview]
Message-ID: <f34b15a8-7fc5-8b3c-7d5e-606430bfa455@intel.com> (raw)
In-Reply-To: <20171031120338.GA6052@bricha3-MOBL3.ger.corp.intel.com>

On 10/31/2017 5:03 AM, Bruce Richardson wrote:
> On Mon, Oct 30, 2017 at 10:32:27PM +0000, Ferruh Yigit wrote:
>> Revert back to using VFIO_PRESENT as a marker to enable compilation
>> of VFIO-related segments.
>>
>> VFIO_PRESENT is the combination of user configuration RTE_EAL_VFIO and
>> kernel version support check.
>>
>> eal_vfio.h VFIO_PRESENT related check ordered to be compatible with
>> rte_vfio.h one, no functional modification.
>>
>> Fixes: 279b581c897d ("vfio: expose functions")
>>
>> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> v4:
>>
>> * Alternative to v3, not superseding it, need to decide which one to
>> get. This one:
>>   * fixes vfio for new kernels
>>   * fixes build for old kernels for vfio enabled in config case
>>   * print warning if vfio enabled in config but not supported by kernel
>>
>> * Independent from this patch, following may need fixing later
>>   * Kernel version check for vfio is broken for RTE_KERNELDIR
>>   * Kernel VFIO support check can be improved
>> ---
>>  drivers/bus/pci/linux/pci_init.h             |  2 +-
>>  drivers/bus/pci/linux/pci_vfio.c             |  2 +-
>>  lib/librte_eal/common/include/rte_vfio.h     | 14 ++++++++++++++
>>  lib/librte_eal/linuxapp/eal/eal_interrupts.c |  1 -
>>  lib/librte_eal/linuxapp/eal/eal_vfio.h       | 14 ++++++++++----
>>  5 files changed, 26 insertions(+), 7 deletions(-)
>>
> Hi,
> 
> just to confirm that applying this patch fixes DPDK on my system at
> least.
> 
> From the discussion, I understood that this was a "compilation problem",
> but in practice it manifests itself as compile working ok but your app
> won't work with ports bound to vfio-pci. So please apply some fix for
> this soon.

The main reason of the patch is vfio issue. All three of patches from Jerin,
Gaetan, and this are fixing that issue.

Difference is:
- Create or not dependency to eal_vfio.h again
- Break or not build for old kernels

> 
> Thanks for the work on this, all.
> 
> Tested-by: Bruce Richardson <bruce.richardson@intel.com>
> 