From: Steven Rostedt <rostedt@goodmis.org> To: Petr Mladek <pmladek@suse.com> Cc: Vlastimil Babka <vbabka@suse.cz>, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Cong Wang <xiyou.wangcong@gmail.com>, Dave Hansen <dave.hansen@intel.com>, Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@kernel.org>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, "yuwang.yuwang" <yuwang.yuwang@alibaba-inc.com> Subject: Re: [PATCH] mm: don't warn about allocations which stall for too long Date: Wed, 1 Nov 2017 11:36:47 -0400 [thread overview] Message-ID: <20171101113647.243eecf8@gandalf.local.home> (raw) In-Reply-To: <20171101133845.GF20040@pathway.suse.cz> On Wed, 1 Nov 2017 14:38:45 +0100 Petr Mladek <pmladek@suse.com> wrote: > This was my fear as well. Steven argued that this was theoretical. > And I do not have a real-life bullets against this argument at > the moment. And my argument is still if such a situation happens, the system is so fscked up that it should just crash. > > My current main worry with Steven's approach is a risk of deadlocks > that Jan Kara saw when he played with similar solution. And if there exists such a deadlock, then the deadlock exists today. > > Also I am afraid that it would add yet another twist to the console > locking operations. It is already quite hard to follow the logic, > see the games with: > > + console_locked > + console_suspended > + can_use_console() > + exclusive_console > > And Steven is going to add: > > + console_owner > + waiter Agreed. Console_lock is just ugly. And this may just make it uglier :-/ > > But let's wait for the patch. It might look and work nicely > in the end. Oh, I need to write a patch? Bah, I guess I should. Where's all those developers dying to do kernel programing where I can pass this off to? -- Steve
WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt@goodmis.org> To: Petr Mladek <pmladek@suse.com> Cc: Vlastimil Babka <vbabka@suse.cz>, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Cong Wang <xiyou.wangcong@gmail.com>, Dave Hansen <dave.hansen@intel.com>, Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@kernel.org>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, "yuwang.yuwang" <yuwang.yuwang@alibaba-inc.com> Subject: Re: [PATCH] mm: don't warn about allocations which stall for too long Date: Wed, 1 Nov 2017 11:36:47 -0400 [thread overview] Message-ID: <20171101113647.243eecf8@gandalf.local.home> (raw) In-Reply-To: <20171101133845.GF20040@pathway.suse.cz> On Wed, 1 Nov 2017 14:38:45 +0100 Petr Mladek <pmladek@suse.com> wrote: > This was my fear as well. Steven argued that this was theoretical. > And I do not have a real-life bullets against this argument at > the moment. And my argument is still if such a situation happens, the system is so fscked up that it should just crash. > > My current main worry with Steven's approach is a risk of deadlocks > that Jan Kara saw when he played with similar solution. And if there exists such a deadlock, then the deadlock exists today. > > Also I am afraid that it would add yet another twist to the console > locking operations. It is already quite hard to follow the logic, > see the games with: > > + console_locked > + console_suspended > + can_use_console() > + exclusive_console > > And Steven is going to add: > > + console_owner > + waiter Agreed. Console_lock is just ugly. And this may just make it uglier :-/ > > But let's wait for the patch. It might look and work nicely > in the end. Oh, I need to write a patch? Bah, I guess I should. Where's all those developers dying to do kernel programing where I can pass this off to? -- Steve -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-11-01 15:36 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-26 11:28 [PATCH] mm: don't warn about allocations which stall for too long Tetsuo Handa 2017-10-26 11:28 ` Tetsuo Handa 2017-10-26 11:41 ` Michal Hocko 2017-10-26 11:41 ` Michal Hocko 2017-11-08 10:30 ` peter enderborg 2017-11-09 8:52 ` Michal Hocko 2017-11-09 8:52 ` Michal Hocko 2017-11-09 9:34 ` peter enderborg 2017-11-09 10:09 ` Michal Hocko 2017-11-09 10:09 ` Michal Hocko 2017-11-09 10:19 ` Tetsuo Handa 2017-11-09 10:19 ` Tetsuo Handa 2017-10-26 14:37 ` Johannes Weiner 2017-10-26 14:37 ` Johannes Weiner 2017-10-31 19:32 ` Steven Rostedt 2017-11-01 8:30 ` Vlastimil Babka 2017-11-01 8:30 ` Vlastimil Babka 2017-11-01 13:38 ` Petr Mladek 2017-11-01 13:38 ` Petr Mladek 2017-11-01 15:36 ` Steven Rostedt [this message] 2017-11-01 15:36 ` Steven Rostedt 2017-11-02 11:46 ` Petr Mladek 2017-11-02 11:46 ` Petr Mladek 2017-11-02 14:49 ` Steven Rostedt 2017-11-02 14:49 ` Steven Rostedt 2017-11-01 15:33 ` Steven Rostedt 2017-11-01 15:33 ` Steven Rostedt 2017-11-01 17:42 ` Vlastimil Babka 2017-11-01 17:42 ` Vlastimil Babka 2017-11-01 17:54 ` Steven Rostedt 2017-11-01 17:54 ` Steven Rostedt 2017-11-02 8:53 ` Sergey Senozhatsky 2017-11-02 8:53 ` Sergey Senozhatsky 2017-11-02 9:14 ` Sergey Senozhatsky 2017-11-02 9:14 ` Sergey Senozhatsky 2017-11-02 14:55 ` Steven Rostedt 2017-11-02 14:55 ` Steven Rostedt 2017-11-02 12:55 ` Michal Hocko 2017-11-02 12:55 ` Michal Hocko 2017-11-02 15:56 ` Steven Rostedt 2017-11-02 15:56 ` Steven Rostedt 2017-11-02 17:06 ` [PATCH v2] printk: Add console owner and waiter logic to load balance console writes Steven Rostedt 2017-11-02 17:06 ` Steven Rostedt 2017-11-02 17:10 ` Steven Rostedt 2017-11-02 17:10 ` Steven Rostedt 2017-11-02 17:38 ` Steven Rostedt 2017-11-02 17:38 ` Steven Rostedt 2017-11-03 10:19 ` Jan Kara 2017-11-03 10:19 ` Jan Kara 2017-11-03 11:18 ` Steven Rostedt 2017-11-03 11:18 ` Steven Rostedt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171101113647.243eecf8@gandalf.local.home \ --to=rostedt@goodmis.org \ --cc=akpm@linux-foundation.org \ --cc=dave.hansen@intel.com \ --cc=hannes@cmpxchg.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=mhocko@kernel.org \ --cc=penguin-kernel@I-love.SAKURA.ne.jp \ --cc=pmladek@suse.com \ --cc=sergey.senozhatsky@gmail.com \ --cc=vbabka@suse.cz \ --cc=xiyou.wangcong@gmail.com \ --cc=yuwang.yuwang@alibaba-inc.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.