From: Steven Rostedt <rostedt@goodmis.org> To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Cong Wang <xiyou.wangcong@gmail.com>, Dave Hansen <dave.hansen@intel.com>, Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@kernel.org>, Petr Mladek <pmladek@suse.com>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, Vlastimil Babka <vbabka@suse.cz>, "yuwang.yuwang" <yuwang.yuwang@alibaba-inc.com>, Peter Zijlstra <peterz@infradead.org>, Linus Torvalds <torvalds@linux-foundation.org>, Jan Kara <jack@suse.cz>, Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Subject: Re: [PATCH v2] printk: Add console owner and waiter logic to load balance console writes Date: Thu, 2 Nov 2017 13:38:36 -0400 [thread overview] Message-ID: <20171102133836.01208f60@gandalf.local.home> (raw) In-Reply-To: <20171102130605.05e987e8@gandalf.local.home> On Thu, 2 Nov 2017 13:06:05 -0400 Steven Rostedt <rostedt@goodmis.org> wrote: > + raw_spin_lock(&console_owner_lock); > + waiter = console_waiter; > + console_owner = NULL; > + raw_spin_unlock(&console_owner_lock); > + > + /* > + * If there is a waiter waiting for us, then pass the > + * rest of the work load over to that waiter. > + */ > + if (waiter) > + break; OK, the spin_unlock() wont let the load leak. Thus it is fine as is. > + raw_spin_lock(&console_owner_lock); > + owner = console_owner; > + waiter = console_waiter; > + if (!waiter && owner && owner != current) { But Mathieu Desnoyers pointed out that usage of variables within a spinlock may be an issue. Although, it shouldn't affect the code as is, I think I'll add back READ/WRITE_ONCE() just to be on the safe side. I may add the waiter = READ_ONCE(console_waiter) to the first one too, more as documentation. It should cause any issues to add it. -- Steve > + console_waiter = true; > + spin = true; > + } > + raw_spin_unlock(&console_owner_lock);
WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt@goodmis.org> To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Cong Wang <xiyou.wangcong@gmail.com>, Dave Hansen <dave.hansen@intel.com>, Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@kernel.org>, Petr Mladek <pmladek@suse.com>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, Vlastimil Babka <vbabka@suse.cz>, "yuwang.yuwang" <yuwang.yuwang@alibaba-inc.com>, Peter Zijlstra <peterz@infradead.org>, Linus Torvalds <torvalds@linux-foundation.org>, Jan Kara <jack@suse.cz>, Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Subject: Re: [PATCH v2] printk: Add console owner and waiter logic to load balance console writes Date: Thu, 2 Nov 2017 13:38:36 -0400 [thread overview] Message-ID: <20171102133836.01208f60@gandalf.local.home> (raw) In-Reply-To: <20171102130605.05e987e8@gandalf.local.home> On Thu, 2 Nov 2017 13:06:05 -0400 Steven Rostedt <rostedt@goodmis.org> wrote: > + raw_spin_lock(&console_owner_lock); > + waiter = console_waiter; > + console_owner = NULL; > + raw_spin_unlock(&console_owner_lock); > + > + /* > + * If there is a waiter waiting for us, then pass the > + * rest of the work load over to that waiter. > + */ > + if (waiter) > + break; OK, the spin_unlock() wont let the load leak. Thus it is fine as is. > + raw_spin_lock(&console_owner_lock); > + owner = console_owner; > + waiter = console_waiter; > + if (!waiter && owner && owner != current) { But Mathieu Desnoyers pointed out that usage of variables within a spinlock may be an issue. Although, it shouldn't affect the code as is, I think I'll add back READ/WRITE_ONCE() just to be on the safe side. I may add the waiter = READ_ONCE(console_waiter) to the first one too, more as documentation. It should cause any issues to add it. -- Steve > + console_waiter = true; > + spin = true; > + } > + raw_spin_unlock(&console_owner_lock); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-11-02 17:38 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-26 11:28 [PATCH] mm: don't warn about allocations which stall for too long Tetsuo Handa 2017-10-26 11:28 ` Tetsuo Handa 2017-10-26 11:41 ` Michal Hocko 2017-10-26 11:41 ` Michal Hocko 2017-11-08 10:30 ` peter enderborg 2017-11-09 8:52 ` Michal Hocko 2017-11-09 8:52 ` Michal Hocko 2017-11-09 9:34 ` peter enderborg 2017-11-09 10:09 ` Michal Hocko 2017-11-09 10:09 ` Michal Hocko 2017-11-09 10:19 ` Tetsuo Handa 2017-11-09 10:19 ` Tetsuo Handa 2017-10-26 14:37 ` Johannes Weiner 2017-10-26 14:37 ` Johannes Weiner 2017-10-31 19:32 ` Steven Rostedt 2017-11-01 8:30 ` Vlastimil Babka 2017-11-01 8:30 ` Vlastimil Babka 2017-11-01 13:38 ` Petr Mladek 2017-11-01 13:38 ` Petr Mladek 2017-11-01 15:36 ` Steven Rostedt 2017-11-01 15:36 ` Steven Rostedt 2017-11-02 11:46 ` Petr Mladek 2017-11-02 11:46 ` Petr Mladek 2017-11-02 14:49 ` Steven Rostedt 2017-11-02 14:49 ` Steven Rostedt 2017-11-01 15:33 ` Steven Rostedt 2017-11-01 15:33 ` Steven Rostedt 2017-11-01 17:42 ` Vlastimil Babka 2017-11-01 17:42 ` Vlastimil Babka 2017-11-01 17:54 ` Steven Rostedt 2017-11-01 17:54 ` Steven Rostedt 2017-11-02 8:53 ` Sergey Senozhatsky 2017-11-02 8:53 ` Sergey Senozhatsky 2017-11-02 9:14 ` Sergey Senozhatsky 2017-11-02 9:14 ` Sergey Senozhatsky 2017-11-02 14:55 ` Steven Rostedt 2017-11-02 14:55 ` Steven Rostedt 2017-11-02 12:55 ` Michal Hocko 2017-11-02 12:55 ` Michal Hocko 2017-11-02 15:56 ` Steven Rostedt 2017-11-02 15:56 ` Steven Rostedt 2017-11-02 17:06 ` [PATCH v2] printk: Add console owner and waiter logic to load balance console writes Steven Rostedt 2017-11-02 17:06 ` Steven Rostedt 2017-11-02 17:10 ` Steven Rostedt 2017-11-02 17:10 ` Steven Rostedt 2017-11-02 17:38 ` Steven Rostedt [this message] 2017-11-02 17:38 ` Steven Rostedt 2017-11-03 10:19 ` Jan Kara 2017-11-03 10:19 ` Jan Kara 2017-11-03 11:18 ` Steven Rostedt 2017-11-03 11:18 ` Steven Rostedt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171102133836.01208f60@gandalf.local.home \ --to=rostedt@goodmis.org \ --cc=akpm@linux-foundation.org \ --cc=dave.hansen@intel.com \ --cc=hannes@cmpxchg.org \ --cc=jack@suse.cz \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mathieu.desnoyers@efficios.com \ --cc=mgorman@suse.de \ --cc=mhocko@kernel.org \ --cc=penguin-kernel@I-love.SAKURA.ne.jp \ --cc=peterz@infradead.org \ --cc=pmladek@suse.com \ --cc=sergey.senozhatsky@gmail.com \ --cc=torvalds@linux-foundation.org \ --cc=vbabka@suse.cz \ --cc=xiyou.wangcong@gmail.com \ --cc=yuwang.yuwang@alibaba-inc.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.