All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 1/3] clocksource/drivers/atcpit100: Add andestech atcpit100 timer
@ 2017-10-30  5:18 ` Rick Chen
  0 siblings, 0 replies; 8+ messages in thread
From: Rick Chen @ 2017-10-30  5:18 UTC (permalink / raw)
  To: daniel.lezcano, tglx, robh, linux-kernel, devicetree, rick
  Cc: Rick Chen, Greentime Hu

ATCPIT100 is often used on the Andes architecture,
This timer provide 4 PIT channels. Each PIT channel is a
multi-function timer, can be configured as 32,16,8 bit timers
or PWM as well.

For system timer it will set 32-bit timer0 as clock source
and count downwards until underflow and restart again.

It also set 32-bit timer1 as clock event and count downwards
until condition match. It will generate an interrupt for
handling periodically.

Signed-off-by: Greentime Hu <green.hu@gmail.com>
Signed-off-by: Rick Chen <rickchen36@gmail.com>
---
 drivers/clocksource/timer-atcpit100.c | 199 ++++++++++++++++++++++++++++++++++
 1 file changed, 199 insertions(+)
 create mode 100644 drivers/clocksource/timer-atcpit100.c

diff --git a/drivers/clocksource/timer-atcpit100.c b/drivers/clocksource/timer-atcpit100.c
new file mode 100644
index 0000000..6b224c4
--- /dev/null
+++ b/drivers/clocksource/timer-atcpit100.c
@@ -0,0 +1,199 @@
+/*
+ *  Andestech ATCPIT100 Timer Device Driver Implementation
+ *
+ *  Copyright (C) 2016 Andes Technology Corporation
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ *
+ */
+#include <linux/irq.h>
+#include <linux/clocksource.h>
+#include <linux/clockchips.h>
+#include <linux/interrupt.h>
+#include <linux/ioport.h>
+#include <linux/cpufreq.h>
+#include <linux/sched.h>
+#include <linux/sched_clock.h>
+#include <linux/of_address.h>
+#include <linux/of_irq.h>
+#include <linux/of_platform.h>
+
+void __iomem *base;
+static u32 freq;
+
+/*
+ * Definition of register offsets
+ */
+
+/* ID and Revision Register */
+#define ID_REV		0x0
+
+/* Configuration Register */
+#define CFG		0x10
+
+/* Interrupt Enable Register */
+#define INT_EN		0x14
+#define CH_INT_EN(c, i)	((1<<i)<<(4*c))
+
+/* Interrupt Status Register */
+#define INT_STA		0x18
+#define CH_INT_STA(c, i)	((1<<i)<<(4*c))
+
+/* Channel Enable Register */
+#define CH_EN		0x1C
+#define CH_TMR_EN(c, t)	((1<<t)<<(4*c))
+
+/* Ch n Control REgister */
+#define CH_CTL(n)	(0x20+0x10*n)
+/* Channel clock source , bit 3 , 0:External clock , 1:APB clock */
+#define APB_CLK		(1<<3)
+/* Channel mode , bit 0~2 */
+#define TMR_32		1
+#define TMR_16		2
+#define TMR_8		3
+#define PWM		4
+
+#define CH_REL(n)	(0x24+0x10*n)
+#define CH_CNT(n)	(0x28+0x10*n)
+
+static unsigned long atcpit100_read_current_timer_down(void)
+{
+	return ~readl(base + CH_CNT(1));
+}
+
+static u64 notrace atcpit100_read_sched_clock_down(void)
+{
+	return atcpit100_read_current_timer_down();
+}
+
+static void atcpit100_clocksource_init(void)
+{
+	writel(0xffffffff, base + CH_REL(1));
+	writel(APB_CLK|TMR_32, base + CH_CTL(1));
+	writel(readl(base + CH_EN) | CH_TMR_EN(1, 0), base + CH_EN);
+	clocksource_mmio_init(base + CH_CNT(1),
+			      "atcpit100_tm1",
+			      freq,
+			      300, 32, clocksource_mmio_readl_down);
+	sched_clock_register(atcpit100_read_sched_clock_down, 32, freq);
+}
+
+static int atcpit100_set_next_event(unsigned long cycles,
+		struct clock_event_device *evt)
+{
+	writel(cycles, base + CH_REL(0));
+
+	return 0;
+}
+
+static int atcpit100_set_state_shutdown(struct clock_event_device *evt)
+{
+	writel(readl(base + CH_EN) & ~CH_TMR_EN(0, 0), base + CH_EN);
+
+	return 0;
+}
+static int atcpit100_set_state_periodic(struct clock_event_device *evt)
+{
+	writel(freq / HZ - 1, base + CH_CNT(0));
+	writel(freq / HZ - 1, base + CH_REL(0));
+	writel(readl(base + CH_EN) | CH_TMR_EN(0, 0), base + CH_EN);
+
+	return 0;
+}
+static int atcpit100_tick_resume(struct clock_event_device *evt)
+{
+	writel(readl(base + INT_STA) | CH_INT_STA(0, 0), base + INT_STA);
+	writel(readl(base + CH_EN) | CH_TMR_EN(0, 0), base + CH_EN);
+
+	return 0;
+}
+static int atcpit100_set_state_oneshot(struct clock_event_device *evt)
+{
+	writel(0xffffffff, base + CH_REL(0));
+	writel(readl(base + CH_EN) | CH_TMR_EN(0, 0), base + CH_EN);
+
+	return 0;
+}
+
+static struct clock_event_device clockevent_atcpit100 = {
+	.name		= "atcpit100_tm0",
+	.features       = CLOCK_EVT_FEAT_ONESHOT | CLOCK_EVT_FEAT_PERIODIC,
+	.shift		= 32,
+	.cpumask	= cpu_all_mask,
+	.set_next_event	= atcpit100_set_next_event,
+	.set_state_shutdown = atcpit100_set_state_shutdown,
+	.set_state_periodic = atcpit100_set_state_periodic,
+	.set_state_oneshot = atcpit100_set_state_oneshot,
+	.tick_resume = atcpit100_tick_resume,
+};
+
+static irqreturn_t timer1_interrupt(int irq, void *dev_id)
+{
+	struct clock_event_device *evt = dev_id;
+
+	writel(readl(base + INT_STA) | CH_INT_STA(0, 0), base + INT_STA);
+
+	evt->event_handler(evt);
+
+	return IRQ_HANDLED;
+}
+
+static struct irqaction timer1_irq = {
+	.name		= "Timer Tick",
+	.flags		= IRQF_TIMER | IRQF_IRQPOLL,
+	.handler	= timer1_interrupt,
+	.dev_id		= &clockevent_atcpit100
+};
+
+static void __init atcpit100_clockevent_init(int irq)
+{
+	struct clock_event_device *evt = &clockevent_atcpit100;
+
+	evt->mult = div_sc(freq, NSEC_PER_SEC, evt->shift);
+	evt->max_delta_ns = clockevent_delta2ns(0xffffffff, evt);
+	evt->min_delta_ns = clockevent_delta2ns(3, evt);
+	clockevents_register_device(evt);
+	setup_irq(irq, &timer1_irq);
+}
+
+static int __init atcpit100_init(struct device_node *dev)
+{
+	int irq;
+
+	base = of_iomap(dev, 0);
+	if (!base) {
+		pr_warn("Can't remap registers");
+		return -ENXIO;
+	}
+
+	if (of_property_read_u32(dev, "clock-frequency", &freq)) {
+		pr_warn("Can't read clock-frequency");
+		return -EINVAL;
+	}
+	irq = irq_of_parse_and_map(dev, 0);
+
+	if (irq <= 0) {
+		pr_warn("Failed to map timer IRQ\n");
+		return -EINVAL;
+	}
+	pr_info("ATCPIT100 timer 1 installed on IRQ %d, with clock %d at %d HZ. in 0x%08x\r\n",
+			irq, freq, HZ, (u32)base);
+	writel(APB_CLK|TMR_32, base + CH_CTL(0));
+	writel(readl(base + INT_EN) | CH_INT_EN(0, 0), base + INT_EN);
+	writel(readl(base + CH_EN) | CH_TMR_EN(0, 0), base + CH_EN);
+	atcpit100_clocksource_init();
+	atcpit100_clockevent_init(irq);
+
+	return 0;
+}
+
+TIMER_OF_DECLARE(atcpit100, "andestech,atcpit100", atcpit100_init);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v2 1/3] clocksource/drivers/atcpit100: Add andestech atcpit100 timer
@ 2017-10-30  5:18 ` Rick Chen
  0 siblings, 0 replies; 8+ messages in thread
From: Rick Chen @ 2017-10-30  5:18 UTC (permalink / raw)
  To: daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A,
	tglx-hfZtesqFncYOwBW4kG4KsQ, robh-DgEjT+Ai2ygdnm+yROfE0A,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA, rick-MUIXKm3Oiri1Z/+hSey0Gg
  Cc: Rick Chen, Greentime Hu

ATCPIT100 is often used on the Andes architecture,
This timer provide 4 PIT channels. Each PIT channel is a
multi-function timer, can be configured as 32,16,8 bit timers
or PWM as well.

For system timer it will set 32-bit timer0 as clock source
and count downwards until underflow and restart again.

It also set 32-bit timer1 as clock event and count downwards
until condition match. It will generate an interrupt for
handling periodically.

Signed-off-by: Greentime Hu <green.hu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Signed-off-by: Rick Chen <rickchen36-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/clocksource/timer-atcpit100.c | 199 ++++++++++++++++++++++++++++++++++
 1 file changed, 199 insertions(+)
 create mode 100644 drivers/clocksource/timer-atcpit100.c

diff --git a/drivers/clocksource/timer-atcpit100.c b/drivers/clocksource/timer-atcpit100.c
new file mode 100644
index 0000000..6b224c4
--- /dev/null
+++ b/drivers/clocksource/timer-atcpit100.c
@@ -0,0 +1,199 @@
+/*
+ *  Andestech ATCPIT100 Timer Device Driver Implementation
+ *
+ *  Copyright (C) 2016 Andes Technology Corporation
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ *
+ */
+#include <linux/irq.h>
+#include <linux/clocksource.h>
+#include <linux/clockchips.h>
+#include <linux/interrupt.h>
+#include <linux/ioport.h>
+#include <linux/cpufreq.h>
+#include <linux/sched.h>
+#include <linux/sched_clock.h>
+#include <linux/of_address.h>
+#include <linux/of_irq.h>
+#include <linux/of_platform.h>
+
+void __iomem *base;
+static u32 freq;
+
+/*
+ * Definition of register offsets
+ */
+
+/* ID and Revision Register */
+#define ID_REV		0x0
+
+/* Configuration Register */
+#define CFG		0x10
+
+/* Interrupt Enable Register */
+#define INT_EN		0x14
+#define CH_INT_EN(c, i)	((1<<i)<<(4*c))
+
+/* Interrupt Status Register */
+#define INT_STA		0x18
+#define CH_INT_STA(c, i)	((1<<i)<<(4*c))
+
+/* Channel Enable Register */
+#define CH_EN		0x1C
+#define CH_TMR_EN(c, t)	((1<<t)<<(4*c))
+
+/* Ch n Control REgister */
+#define CH_CTL(n)	(0x20+0x10*n)
+/* Channel clock source , bit 3 , 0:External clock , 1:APB clock */
+#define APB_CLK		(1<<3)
+/* Channel mode , bit 0~2 */
+#define TMR_32		1
+#define TMR_16		2
+#define TMR_8		3
+#define PWM		4
+
+#define CH_REL(n)	(0x24+0x10*n)
+#define CH_CNT(n)	(0x28+0x10*n)
+
+static unsigned long atcpit100_read_current_timer_down(void)
+{
+	return ~readl(base + CH_CNT(1));
+}
+
+static u64 notrace atcpit100_read_sched_clock_down(void)
+{
+	return atcpit100_read_current_timer_down();
+}
+
+static void atcpit100_clocksource_init(void)
+{
+	writel(0xffffffff, base + CH_REL(1));
+	writel(APB_CLK|TMR_32, base + CH_CTL(1));
+	writel(readl(base + CH_EN) | CH_TMR_EN(1, 0), base + CH_EN);
+	clocksource_mmio_init(base + CH_CNT(1),
+			      "atcpit100_tm1",
+			      freq,
+			      300, 32, clocksource_mmio_readl_down);
+	sched_clock_register(atcpit100_read_sched_clock_down, 32, freq);
+}
+
+static int atcpit100_set_next_event(unsigned long cycles,
+		struct clock_event_device *evt)
+{
+	writel(cycles, base + CH_REL(0));
+
+	return 0;
+}
+
+static int atcpit100_set_state_shutdown(struct clock_event_device *evt)
+{
+	writel(readl(base + CH_EN) & ~CH_TMR_EN(0, 0), base + CH_EN);
+
+	return 0;
+}
+static int atcpit100_set_state_periodic(struct clock_event_device *evt)
+{
+	writel(freq / HZ - 1, base + CH_CNT(0));
+	writel(freq / HZ - 1, base + CH_REL(0));
+	writel(readl(base + CH_EN) | CH_TMR_EN(0, 0), base + CH_EN);
+
+	return 0;
+}
+static int atcpit100_tick_resume(struct clock_event_device *evt)
+{
+	writel(readl(base + INT_STA) | CH_INT_STA(0, 0), base + INT_STA);
+	writel(readl(base + CH_EN) | CH_TMR_EN(0, 0), base + CH_EN);
+
+	return 0;
+}
+static int atcpit100_set_state_oneshot(struct clock_event_device *evt)
+{
+	writel(0xffffffff, base + CH_REL(0));
+	writel(readl(base + CH_EN) | CH_TMR_EN(0, 0), base + CH_EN);
+
+	return 0;
+}
+
+static struct clock_event_device clockevent_atcpit100 = {
+	.name		= "atcpit100_tm0",
+	.features       = CLOCK_EVT_FEAT_ONESHOT | CLOCK_EVT_FEAT_PERIODIC,
+	.shift		= 32,
+	.cpumask	= cpu_all_mask,
+	.set_next_event	= atcpit100_set_next_event,
+	.set_state_shutdown = atcpit100_set_state_shutdown,
+	.set_state_periodic = atcpit100_set_state_periodic,
+	.set_state_oneshot = atcpit100_set_state_oneshot,
+	.tick_resume = atcpit100_tick_resume,
+};
+
+static irqreturn_t timer1_interrupt(int irq, void *dev_id)
+{
+	struct clock_event_device *evt = dev_id;
+
+	writel(readl(base + INT_STA) | CH_INT_STA(0, 0), base + INT_STA);
+
+	evt->event_handler(evt);
+
+	return IRQ_HANDLED;
+}
+
+static struct irqaction timer1_irq = {
+	.name		= "Timer Tick",
+	.flags		= IRQF_TIMER | IRQF_IRQPOLL,
+	.handler	= timer1_interrupt,
+	.dev_id		= &clockevent_atcpit100
+};
+
+static void __init atcpit100_clockevent_init(int irq)
+{
+	struct clock_event_device *evt = &clockevent_atcpit100;
+
+	evt->mult = div_sc(freq, NSEC_PER_SEC, evt->shift);
+	evt->max_delta_ns = clockevent_delta2ns(0xffffffff, evt);
+	evt->min_delta_ns = clockevent_delta2ns(3, evt);
+	clockevents_register_device(evt);
+	setup_irq(irq, &timer1_irq);
+}
+
+static int __init atcpit100_init(struct device_node *dev)
+{
+	int irq;
+
+	base = of_iomap(dev, 0);
+	if (!base) {
+		pr_warn("Can't remap registers");
+		return -ENXIO;
+	}
+
+	if (of_property_read_u32(dev, "clock-frequency", &freq)) {
+		pr_warn("Can't read clock-frequency");
+		return -EINVAL;
+	}
+	irq = irq_of_parse_and_map(dev, 0);
+
+	if (irq <= 0) {
+		pr_warn("Failed to map timer IRQ\n");
+		return -EINVAL;
+	}
+	pr_info("ATCPIT100 timer 1 installed on IRQ %d, with clock %d at %d HZ. in 0x%08x\r\n",
+			irq, freq, HZ, (u32)base);
+	writel(APB_CLK|TMR_32, base + CH_CTL(0));
+	writel(readl(base + INT_EN) | CH_INT_EN(0, 0), base + INT_EN);
+	writel(readl(base + CH_EN) | CH_TMR_EN(0, 0), base + CH_EN);
+	atcpit100_clocksource_init();
+	atcpit100_clockevent_init(irq);
+
+	return 0;
+}
+
+TIMER_OF_DECLARE(atcpit100, "andestech,atcpit100", atcpit100_init);
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v2 2/3] clocksource/drivers/Kconfig: Support andestech atcpit100 timer
  2017-10-30  5:18 ` Rick Chen
  (?)
@ 2017-10-30  5:18 ` Rick Chen
  2017-11-01 20:40     ` kbuild test robot
  -1 siblings, 1 reply; 8+ messages in thread
From: Rick Chen @ 2017-10-30  5:18 UTC (permalink / raw)
  To: daniel.lezcano, tglx, robh, linux-kernel, devicetree, rick
  Cc: Rick Chen, Greentime Hu

Add CLKSRC_ATCPIT100 for Andestech atcpit100 timer selection.
It often be used in Andestech AE3XX platform.

Signed-off-by: Greentime Hu <green.hu@gmail.com>
Signed-off-by: Rick Chen <rickchen36@gmail.com>
---
 drivers/clocksource/Kconfig  | 6 ++++++
 drivers/clocksource/Makefile | 1 +
 2 files changed, 7 insertions(+)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index cc60620..e950066 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -615,4 +615,10 @@ config CLKSRC_ST_LPC
 	  Enable this option to use the Low Power controller timer
 	  as clocksource.
 
+config CLKSRC_ATCPIT100
+	bool "Clocksource for AE3XX platform" if COMPILE_TEST
+  depends on GENERIC_CLOCKEVENTS && HAS_IOMEM
+	help
+	  This option enables support for the Andestech AE3XX platform timers.
+
 endmenu
diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile
index dbc1ad1..24d15bd 100644
--- a/drivers/clocksource/Makefile
+++ b/drivers/clocksource/Makefile
@@ -74,3 +74,4 @@ obj-$(CONFIG_H8300_TMR16)		+= h8300_timer16.o
 obj-$(CONFIG_H8300_TPU)			+= h8300_tpu.o
 obj-$(CONFIG_CLKSRC_ST_LPC)		+= clksrc_st_lpc.o
 obj-$(CONFIG_X86_NUMACHIP)		+= numachip.o
+obj-$(CONFIG_CLKSRC_ATCPIT100)		+= timer-atcpit100.o
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v2 3/3] dt-bindings: timer: Add andestech atcpit100 timer binding doc
  2017-10-30  5:18 ` Rick Chen
  (?)
  (?)
@ 2017-10-30  5:18 ` Rick Chen
  2017-11-01 21:41     ` Rob Herring
  -1 siblings, 1 reply; 8+ messages in thread
From: Rick Chen @ 2017-10-30  5:18 UTC (permalink / raw)
  To: daniel.lezcano, tglx, robh, linux-kernel, devicetree, rick
  Cc: Rick Chen, Greentime Hu

Add a document to describe Andestech atcpit100 timer and
binding information.

Signed-off-by: Greentime Hu <green.hu@gmail.com>
Signed-off-by: Rick Chen <rickchen36@gmail.com>
---
 .../bindings/timer/andestech,atcpit100-timer.txt   | 31 ++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/timer/andestech,atcpit100-timer.txt

diff --git a/Documentation/devicetree/bindings/timer/andestech,atcpit100-timer.txt b/Documentation/devicetree/bindings/timer/andestech,atcpit100-timer.txt
new file mode 100644
index 0000000..a87278a
--- /dev/null
+++ b/Documentation/devicetree/bindings/timer/andestech,atcpit100-timer.txt
@@ -0,0 +1,31 @@
+Andestech ATCPIT100 timer
+------------------------------------------------------------------
+ATCPIT100 is a generic IP block from Andes Technology, embedded in
+Andestech AE3XX platforms and other designs.
+
+This timer is a set of compact multi-function timers, which can be
+used as pulse width modulators (PWM) as well as simple timers.
+
+It supports up to 4 PIT channels. Each PIT channel is a
+multi-function timer and provide the following usage scenarios:
+One 32-bit timer
+Two 16-bit timers
+Four 8-bit timers
+One 16-bit PWM
+One 16-bit timer and one 8-bit PWM
+Two 8-bit timer and one 8-bit PWM
+
+Required properties:
+- compatible	: Should be "andestech,atcpit100"
+- reg		: Address and length of the register set
+- interrupts	: Reference to the timer interrupt
+- clock-frequency : The rate in HZ in input of the Andestech ATCPIT100 timer
+
+Examples:
+
+timer0: timer@f0400000 {
+	compatible = "andestech,atcpit100";
+	reg = <0xf0400000 0x1000>;
+	interrupts = <2 4>;
+	clock-frequency = <30000000>;
+};
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 2/3] clocksource/drivers/Kconfig: Support andestech atcpit100 timer
@ 2017-11-01 20:40     ` kbuild test robot
  0 siblings, 0 replies; 8+ messages in thread
From: kbuild test robot @ 2017-11-01 20:40 UTC (permalink / raw)
  To: Rick Chen
  Cc: kbuild-all, daniel.lezcano, tglx, robh, linux-kernel, devicetree,
	rick, Rick Chen, Greentime Hu

[-- Attachment #1: Type: text/plain, Size: 12972 bytes --]

Hi Rick,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/timers/core]
[also build test WARNING on v4.14-rc7 next-20171018]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Rick-Chen/clocksource-drivers-atcpit100-Add-andestech-atcpit100-timer/20171101-224330
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   include/linux/compiler.h:286:8: sparse: attribute 'no_sanitize_address': unknown attribute
   In file included from include/linux/kernel.h:13:0,
                    from include/linux/list.h:8,
                    from include/linux/smp.h:11,
                    from include/linux/irq.h:12,
                    from drivers/clocksource/timer-atcpit100.c:18:
   drivers/clocksource/timer-atcpit100.c: In function 'atcpit100_init':
>> drivers/clocksource/timer-atcpit100.c:189:19: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
       irq, freq, HZ, (u32)base);
                      ^
   include/linux/printk.h:308:34: note: in definition of macro 'pr_info'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
                                     ^~~~~~~~~~~

vim +189 drivers/clocksource/timer-atcpit100.c

28914401 Rick Chen 2017-10-30  @18  #include <linux/irq.h>
28914401 Rick Chen 2017-10-30   19  #include <linux/clocksource.h>
28914401 Rick Chen 2017-10-30   20  #include <linux/clockchips.h>
28914401 Rick Chen 2017-10-30   21  #include <linux/interrupt.h>
28914401 Rick Chen 2017-10-30   22  #include <linux/ioport.h>
28914401 Rick Chen 2017-10-30   23  #include <linux/cpufreq.h>
28914401 Rick Chen 2017-10-30   24  #include <linux/sched.h>
28914401 Rick Chen 2017-10-30   25  #include <linux/sched_clock.h>
28914401 Rick Chen 2017-10-30   26  #include <linux/of_address.h>
28914401 Rick Chen 2017-10-30   27  #include <linux/of_irq.h>
28914401 Rick Chen 2017-10-30   28  #include <linux/of_platform.h>
28914401 Rick Chen 2017-10-30   29  
28914401 Rick Chen 2017-10-30   30  void __iomem *base;
28914401 Rick Chen 2017-10-30   31  static u32 freq;
28914401 Rick Chen 2017-10-30   32  
28914401 Rick Chen 2017-10-30   33  /*
28914401 Rick Chen 2017-10-30   34   * Definition of register offsets
28914401 Rick Chen 2017-10-30   35   */
28914401 Rick Chen 2017-10-30   36  
28914401 Rick Chen 2017-10-30   37  /* ID and Revision Register */
28914401 Rick Chen 2017-10-30   38  #define ID_REV		0x0
28914401 Rick Chen 2017-10-30   39  
28914401 Rick Chen 2017-10-30   40  /* Configuration Register */
28914401 Rick Chen 2017-10-30   41  #define CFG		0x10
28914401 Rick Chen 2017-10-30   42  
28914401 Rick Chen 2017-10-30   43  /* Interrupt Enable Register */
28914401 Rick Chen 2017-10-30   44  #define INT_EN		0x14
28914401 Rick Chen 2017-10-30   45  #define CH_INT_EN(c, i)	((1<<i)<<(4*c))
28914401 Rick Chen 2017-10-30   46  
28914401 Rick Chen 2017-10-30   47  /* Interrupt Status Register */
28914401 Rick Chen 2017-10-30   48  #define INT_STA		0x18
28914401 Rick Chen 2017-10-30   49  #define CH_INT_STA(c, i)	((1<<i)<<(4*c))
28914401 Rick Chen 2017-10-30   50  
28914401 Rick Chen 2017-10-30   51  /* Channel Enable Register */
28914401 Rick Chen 2017-10-30   52  #define CH_EN		0x1C
28914401 Rick Chen 2017-10-30   53  #define CH_TMR_EN(c, t)	((1<<t)<<(4*c))
28914401 Rick Chen 2017-10-30   54  
28914401 Rick Chen 2017-10-30   55  /* Ch n Control REgister */
28914401 Rick Chen 2017-10-30   56  #define CH_CTL(n)	(0x20+0x10*n)
28914401 Rick Chen 2017-10-30   57  /* Channel clock source , bit 3 , 0:External clock , 1:APB clock */
28914401 Rick Chen 2017-10-30   58  #define APB_CLK		(1<<3)
28914401 Rick Chen 2017-10-30   59  /* Channel mode , bit 0~2 */
28914401 Rick Chen 2017-10-30   60  #define TMR_32		1
28914401 Rick Chen 2017-10-30   61  #define TMR_16		2
28914401 Rick Chen 2017-10-30   62  #define TMR_8		3
28914401 Rick Chen 2017-10-30   63  #define PWM		4
28914401 Rick Chen 2017-10-30   64  
28914401 Rick Chen 2017-10-30   65  #define CH_REL(n)	(0x24+0x10*n)
28914401 Rick Chen 2017-10-30   66  #define CH_CNT(n)	(0x28+0x10*n)
28914401 Rick Chen 2017-10-30   67  
28914401 Rick Chen 2017-10-30   68  static unsigned long atcpit100_read_current_timer_down(void)
28914401 Rick Chen 2017-10-30   69  {
28914401 Rick Chen 2017-10-30   70  	return ~readl(base + CH_CNT(1));
28914401 Rick Chen 2017-10-30   71  }
28914401 Rick Chen 2017-10-30   72  
28914401 Rick Chen 2017-10-30   73  static u64 notrace atcpit100_read_sched_clock_down(void)
28914401 Rick Chen 2017-10-30   74  {
28914401 Rick Chen 2017-10-30   75  	return atcpit100_read_current_timer_down();
28914401 Rick Chen 2017-10-30   76  }
28914401 Rick Chen 2017-10-30   77  
28914401 Rick Chen 2017-10-30   78  static void atcpit100_clocksource_init(void)
28914401 Rick Chen 2017-10-30   79  {
28914401 Rick Chen 2017-10-30   80  	writel(0xffffffff, base + CH_REL(1));
28914401 Rick Chen 2017-10-30   81  	writel(APB_CLK|TMR_32, base + CH_CTL(1));
28914401 Rick Chen 2017-10-30   82  	writel(readl(base + CH_EN) | CH_TMR_EN(1, 0), base + CH_EN);
28914401 Rick Chen 2017-10-30   83  	clocksource_mmio_init(base + CH_CNT(1),
28914401 Rick Chen 2017-10-30   84  			      "atcpit100_tm1",
28914401 Rick Chen 2017-10-30   85  			      freq,
28914401 Rick Chen 2017-10-30   86  			      300, 32, clocksource_mmio_readl_down);
28914401 Rick Chen 2017-10-30   87  	sched_clock_register(atcpit100_read_sched_clock_down, 32, freq);
28914401 Rick Chen 2017-10-30   88  }
28914401 Rick Chen 2017-10-30   89  
28914401 Rick Chen 2017-10-30   90  static int atcpit100_set_next_event(unsigned long cycles,
28914401 Rick Chen 2017-10-30   91  		struct clock_event_device *evt)
28914401 Rick Chen 2017-10-30   92  {
28914401 Rick Chen 2017-10-30   93  	writel(cycles, base + CH_REL(0));
28914401 Rick Chen 2017-10-30   94  
28914401 Rick Chen 2017-10-30   95  	return 0;
28914401 Rick Chen 2017-10-30   96  }
28914401 Rick Chen 2017-10-30   97  
28914401 Rick Chen 2017-10-30   98  static int atcpit100_set_state_shutdown(struct clock_event_device *evt)
28914401 Rick Chen 2017-10-30   99  {
28914401 Rick Chen 2017-10-30  100  	writel(readl(base + CH_EN) & ~CH_TMR_EN(0, 0), base + CH_EN);
28914401 Rick Chen 2017-10-30  101  
28914401 Rick Chen 2017-10-30  102  	return 0;
28914401 Rick Chen 2017-10-30  103  }
28914401 Rick Chen 2017-10-30  104  static int atcpit100_set_state_periodic(struct clock_event_device *evt)
28914401 Rick Chen 2017-10-30  105  {
28914401 Rick Chen 2017-10-30  106  	writel(freq / HZ - 1, base + CH_CNT(0));
28914401 Rick Chen 2017-10-30  107  	writel(freq / HZ - 1, base + CH_REL(0));
28914401 Rick Chen 2017-10-30  108  	writel(readl(base + CH_EN) | CH_TMR_EN(0, 0), base + CH_EN);
28914401 Rick Chen 2017-10-30  109  
28914401 Rick Chen 2017-10-30  110  	return 0;
28914401 Rick Chen 2017-10-30  111  }
28914401 Rick Chen 2017-10-30  112  static int atcpit100_tick_resume(struct clock_event_device *evt)
28914401 Rick Chen 2017-10-30  113  {
28914401 Rick Chen 2017-10-30  114  	writel(readl(base + INT_STA) | CH_INT_STA(0, 0), base + INT_STA);
28914401 Rick Chen 2017-10-30  115  	writel(readl(base + CH_EN) | CH_TMR_EN(0, 0), base + CH_EN);
28914401 Rick Chen 2017-10-30  116  
28914401 Rick Chen 2017-10-30  117  	return 0;
28914401 Rick Chen 2017-10-30  118  }
28914401 Rick Chen 2017-10-30  119  static int atcpit100_set_state_oneshot(struct clock_event_device *evt)
28914401 Rick Chen 2017-10-30  120  {
28914401 Rick Chen 2017-10-30  121  	writel(0xffffffff, base + CH_REL(0));
28914401 Rick Chen 2017-10-30  122  	writel(readl(base + CH_EN) | CH_TMR_EN(0, 0), base + CH_EN);
28914401 Rick Chen 2017-10-30  123  
28914401 Rick Chen 2017-10-30  124  	return 0;
28914401 Rick Chen 2017-10-30  125  }
28914401 Rick Chen 2017-10-30  126  
28914401 Rick Chen 2017-10-30  127  static struct clock_event_device clockevent_atcpit100 = {
28914401 Rick Chen 2017-10-30  128  	.name		= "atcpit100_tm0",
28914401 Rick Chen 2017-10-30  129  	.features       = CLOCK_EVT_FEAT_ONESHOT | CLOCK_EVT_FEAT_PERIODIC,
28914401 Rick Chen 2017-10-30  130  	.shift		= 32,
28914401 Rick Chen 2017-10-30  131  	.cpumask	= cpu_all_mask,
28914401 Rick Chen 2017-10-30  132  	.set_next_event	= atcpit100_set_next_event,
28914401 Rick Chen 2017-10-30  133  	.set_state_shutdown = atcpit100_set_state_shutdown,
28914401 Rick Chen 2017-10-30  134  	.set_state_periodic = atcpit100_set_state_periodic,
28914401 Rick Chen 2017-10-30  135  	.set_state_oneshot = atcpit100_set_state_oneshot,
28914401 Rick Chen 2017-10-30  136  	.tick_resume = atcpit100_tick_resume,
28914401 Rick Chen 2017-10-30  137  };
28914401 Rick Chen 2017-10-30  138  
28914401 Rick Chen 2017-10-30  139  static irqreturn_t timer1_interrupt(int irq, void *dev_id)
28914401 Rick Chen 2017-10-30  140  {
28914401 Rick Chen 2017-10-30  141  	struct clock_event_device *evt = dev_id;
28914401 Rick Chen 2017-10-30  142  
28914401 Rick Chen 2017-10-30  143  	writel(readl(base + INT_STA) | CH_INT_STA(0, 0), base + INT_STA);
28914401 Rick Chen 2017-10-30  144  
28914401 Rick Chen 2017-10-30  145  	evt->event_handler(evt);
28914401 Rick Chen 2017-10-30  146  
28914401 Rick Chen 2017-10-30  147  	return IRQ_HANDLED;
28914401 Rick Chen 2017-10-30  148  }
28914401 Rick Chen 2017-10-30  149  
28914401 Rick Chen 2017-10-30  150  static struct irqaction timer1_irq = {
28914401 Rick Chen 2017-10-30  151  	.name		= "Timer Tick",
28914401 Rick Chen 2017-10-30  152  	.flags		= IRQF_TIMER | IRQF_IRQPOLL,
28914401 Rick Chen 2017-10-30  153  	.handler	= timer1_interrupt,
28914401 Rick Chen 2017-10-30  154  	.dev_id		= &clockevent_atcpit100
28914401 Rick Chen 2017-10-30  155  };
28914401 Rick Chen 2017-10-30  156  
28914401 Rick Chen 2017-10-30  157  static void __init atcpit100_clockevent_init(int irq)
28914401 Rick Chen 2017-10-30  158  {
28914401 Rick Chen 2017-10-30  159  	struct clock_event_device *evt = &clockevent_atcpit100;
28914401 Rick Chen 2017-10-30  160  
28914401 Rick Chen 2017-10-30  161  	evt->mult = div_sc(freq, NSEC_PER_SEC, evt->shift);
28914401 Rick Chen 2017-10-30  162  	evt->max_delta_ns = clockevent_delta2ns(0xffffffff, evt);
28914401 Rick Chen 2017-10-30  163  	evt->min_delta_ns = clockevent_delta2ns(3, evt);
28914401 Rick Chen 2017-10-30  164  	clockevents_register_device(evt);
28914401 Rick Chen 2017-10-30  165  	setup_irq(irq, &timer1_irq);
28914401 Rick Chen 2017-10-30  166  }
28914401 Rick Chen 2017-10-30  167  
28914401 Rick Chen 2017-10-30  168  static int __init atcpit100_init(struct device_node *dev)
28914401 Rick Chen 2017-10-30  169  {
28914401 Rick Chen 2017-10-30  170  	int irq;
28914401 Rick Chen 2017-10-30  171  
28914401 Rick Chen 2017-10-30  172  	base = of_iomap(dev, 0);
28914401 Rick Chen 2017-10-30  173  	if (!base) {
28914401 Rick Chen 2017-10-30  174  		pr_warn("Can't remap registers");
28914401 Rick Chen 2017-10-30  175  		return -ENXIO;
28914401 Rick Chen 2017-10-30  176  	}
28914401 Rick Chen 2017-10-30  177  
28914401 Rick Chen 2017-10-30  178  	if (of_property_read_u32(dev, "clock-frequency", &freq)) {
28914401 Rick Chen 2017-10-30  179  		pr_warn("Can't read clock-frequency");
28914401 Rick Chen 2017-10-30  180  		return -EINVAL;
28914401 Rick Chen 2017-10-30  181  	}
28914401 Rick Chen 2017-10-30  182  	irq = irq_of_parse_and_map(dev, 0);
28914401 Rick Chen 2017-10-30  183  
28914401 Rick Chen 2017-10-30  184  	if (irq <= 0) {
28914401 Rick Chen 2017-10-30  185  		pr_warn("Failed to map timer IRQ\n");
28914401 Rick Chen 2017-10-30  186  		return -EINVAL;
28914401 Rick Chen 2017-10-30  187  	}
28914401 Rick Chen 2017-10-30  188  	pr_info("ATCPIT100 timer 1 installed on IRQ %d, with clock %d at %d HZ. in 0x%08x\r\n",
28914401 Rick Chen 2017-10-30 @189  			irq, freq, HZ, (u32)base);
28914401 Rick Chen 2017-10-30  190  	writel(APB_CLK|TMR_32, base + CH_CTL(0));
28914401 Rick Chen 2017-10-30  191  	writel(readl(base + INT_EN) | CH_INT_EN(0, 0), base + INT_EN);
28914401 Rick Chen 2017-10-30  192  	writel(readl(base + CH_EN) | CH_TMR_EN(0, 0), base + CH_EN);
28914401 Rick Chen 2017-10-30  193  	atcpit100_clocksource_init();
28914401 Rick Chen 2017-10-30  194  	atcpit100_clockevent_init(irq);
28914401 Rick Chen 2017-10-30  195  
28914401 Rick Chen 2017-10-30  196  	return 0;
28914401 Rick Chen 2017-10-30  197  }
28914401 Rick Chen 2017-10-30  198  

:::::: The code at line 189 was first introduced by commit
:::::: 289144019bcc6168c2135488589d11720ef3428e clocksource/drivers/atcpit100: Add andestech atcpit100 timer

:::::: TO: Rick Chen <rickchen36@gmail.com>
:::::: CC: 0day robot <fengguang.wu@intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 61748 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 2/3] clocksource/drivers/Kconfig: Support andestech atcpit100 timer
@ 2017-11-01 20:40     ` kbuild test robot
  0 siblings, 0 replies; 8+ messages in thread
From: kbuild test robot @ 2017-11-01 20:40 UTC (permalink / raw)
  Cc: kbuild-all-JC7UmRfGjtg, daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A,
	tglx-hfZtesqFncYOwBW4kG4KsQ, robh-DgEjT+Ai2ygdnm+yROfE0A,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA, rick-MUIXKm3Oiri1Z/+hSey0Gg,
	Rick Chen, Greentime Hu

[-- Attachment #1: Type: text/plain, Size: 13032 bytes --]

Hi Rick,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/timers/core]
[also build test WARNING on v4.14-rc7 next-20171018]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Rick-Chen/clocksource-drivers-atcpit100-Add-andestech-atcpit100-timer/20171101-224330
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   include/linux/compiler.h:286:8: sparse: attribute 'no_sanitize_address': unknown attribute
   In file included from include/linux/kernel.h:13:0,
                    from include/linux/list.h:8,
                    from include/linux/smp.h:11,
                    from include/linux/irq.h:12,
                    from drivers/clocksource/timer-atcpit100.c:18:
   drivers/clocksource/timer-atcpit100.c: In function 'atcpit100_init':
>> drivers/clocksource/timer-atcpit100.c:189:19: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
       irq, freq, HZ, (u32)base);
                      ^
   include/linux/printk.h:308:34: note: in definition of macro 'pr_info'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
                                     ^~~~~~~~~~~

vim +189 drivers/clocksource/timer-atcpit100.c

28914401 Rick Chen 2017-10-30  @18  #include <linux/irq.h>
28914401 Rick Chen 2017-10-30   19  #include <linux/clocksource.h>
28914401 Rick Chen 2017-10-30   20  #include <linux/clockchips.h>
28914401 Rick Chen 2017-10-30   21  #include <linux/interrupt.h>
28914401 Rick Chen 2017-10-30   22  #include <linux/ioport.h>
28914401 Rick Chen 2017-10-30   23  #include <linux/cpufreq.h>
28914401 Rick Chen 2017-10-30   24  #include <linux/sched.h>
28914401 Rick Chen 2017-10-30   25  #include <linux/sched_clock.h>
28914401 Rick Chen 2017-10-30   26  #include <linux/of_address.h>
28914401 Rick Chen 2017-10-30   27  #include <linux/of_irq.h>
28914401 Rick Chen 2017-10-30   28  #include <linux/of_platform.h>
28914401 Rick Chen 2017-10-30   29  
28914401 Rick Chen 2017-10-30   30  void __iomem *base;
28914401 Rick Chen 2017-10-30   31  static u32 freq;
28914401 Rick Chen 2017-10-30   32  
28914401 Rick Chen 2017-10-30   33  /*
28914401 Rick Chen 2017-10-30   34   * Definition of register offsets
28914401 Rick Chen 2017-10-30   35   */
28914401 Rick Chen 2017-10-30   36  
28914401 Rick Chen 2017-10-30   37  /* ID and Revision Register */
28914401 Rick Chen 2017-10-30   38  #define ID_REV		0x0
28914401 Rick Chen 2017-10-30   39  
28914401 Rick Chen 2017-10-30   40  /* Configuration Register */
28914401 Rick Chen 2017-10-30   41  #define CFG		0x10
28914401 Rick Chen 2017-10-30   42  
28914401 Rick Chen 2017-10-30   43  /* Interrupt Enable Register */
28914401 Rick Chen 2017-10-30   44  #define INT_EN		0x14
28914401 Rick Chen 2017-10-30   45  #define CH_INT_EN(c, i)	((1<<i)<<(4*c))
28914401 Rick Chen 2017-10-30   46  
28914401 Rick Chen 2017-10-30   47  /* Interrupt Status Register */
28914401 Rick Chen 2017-10-30   48  #define INT_STA		0x18
28914401 Rick Chen 2017-10-30   49  #define CH_INT_STA(c, i)	((1<<i)<<(4*c))
28914401 Rick Chen 2017-10-30   50  
28914401 Rick Chen 2017-10-30   51  /* Channel Enable Register */
28914401 Rick Chen 2017-10-30   52  #define CH_EN		0x1C
28914401 Rick Chen 2017-10-30   53  #define CH_TMR_EN(c, t)	((1<<t)<<(4*c))
28914401 Rick Chen 2017-10-30   54  
28914401 Rick Chen 2017-10-30   55  /* Ch n Control REgister */
28914401 Rick Chen 2017-10-30   56  #define CH_CTL(n)	(0x20+0x10*n)
28914401 Rick Chen 2017-10-30   57  /* Channel clock source , bit 3 , 0:External clock , 1:APB clock */
28914401 Rick Chen 2017-10-30   58  #define APB_CLK		(1<<3)
28914401 Rick Chen 2017-10-30   59  /* Channel mode , bit 0~2 */
28914401 Rick Chen 2017-10-30   60  #define TMR_32		1
28914401 Rick Chen 2017-10-30   61  #define TMR_16		2
28914401 Rick Chen 2017-10-30   62  #define TMR_8		3
28914401 Rick Chen 2017-10-30   63  #define PWM		4
28914401 Rick Chen 2017-10-30   64  
28914401 Rick Chen 2017-10-30   65  #define CH_REL(n)	(0x24+0x10*n)
28914401 Rick Chen 2017-10-30   66  #define CH_CNT(n)	(0x28+0x10*n)
28914401 Rick Chen 2017-10-30   67  
28914401 Rick Chen 2017-10-30   68  static unsigned long atcpit100_read_current_timer_down(void)
28914401 Rick Chen 2017-10-30   69  {
28914401 Rick Chen 2017-10-30   70  	return ~readl(base + CH_CNT(1));
28914401 Rick Chen 2017-10-30   71  }
28914401 Rick Chen 2017-10-30   72  
28914401 Rick Chen 2017-10-30   73  static u64 notrace atcpit100_read_sched_clock_down(void)
28914401 Rick Chen 2017-10-30   74  {
28914401 Rick Chen 2017-10-30   75  	return atcpit100_read_current_timer_down();
28914401 Rick Chen 2017-10-30   76  }
28914401 Rick Chen 2017-10-30   77  
28914401 Rick Chen 2017-10-30   78  static void atcpit100_clocksource_init(void)
28914401 Rick Chen 2017-10-30   79  {
28914401 Rick Chen 2017-10-30   80  	writel(0xffffffff, base + CH_REL(1));
28914401 Rick Chen 2017-10-30   81  	writel(APB_CLK|TMR_32, base + CH_CTL(1));
28914401 Rick Chen 2017-10-30   82  	writel(readl(base + CH_EN) | CH_TMR_EN(1, 0), base + CH_EN);
28914401 Rick Chen 2017-10-30   83  	clocksource_mmio_init(base + CH_CNT(1),
28914401 Rick Chen 2017-10-30   84  			      "atcpit100_tm1",
28914401 Rick Chen 2017-10-30   85  			      freq,
28914401 Rick Chen 2017-10-30   86  			      300, 32, clocksource_mmio_readl_down);
28914401 Rick Chen 2017-10-30   87  	sched_clock_register(atcpit100_read_sched_clock_down, 32, freq);
28914401 Rick Chen 2017-10-30   88  }
28914401 Rick Chen 2017-10-30   89  
28914401 Rick Chen 2017-10-30   90  static int atcpit100_set_next_event(unsigned long cycles,
28914401 Rick Chen 2017-10-30   91  		struct clock_event_device *evt)
28914401 Rick Chen 2017-10-30   92  {
28914401 Rick Chen 2017-10-30   93  	writel(cycles, base + CH_REL(0));
28914401 Rick Chen 2017-10-30   94  
28914401 Rick Chen 2017-10-30   95  	return 0;
28914401 Rick Chen 2017-10-30   96  }
28914401 Rick Chen 2017-10-30   97  
28914401 Rick Chen 2017-10-30   98  static int atcpit100_set_state_shutdown(struct clock_event_device *evt)
28914401 Rick Chen 2017-10-30   99  {
28914401 Rick Chen 2017-10-30  100  	writel(readl(base + CH_EN) & ~CH_TMR_EN(0, 0), base + CH_EN);
28914401 Rick Chen 2017-10-30  101  
28914401 Rick Chen 2017-10-30  102  	return 0;
28914401 Rick Chen 2017-10-30  103  }
28914401 Rick Chen 2017-10-30  104  static int atcpit100_set_state_periodic(struct clock_event_device *evt)
28914401 Rick Chen 2017-10-30  105  {
28914401 Rick Chen 2017-10-30  106  	writel(freq / HZ - 1, base + CH_CNT(0));
28914401 Rick Chen 2017-10-30  107  	writel(freq / HZ - 1, base + CH_REL(0));
28914401 Rick Chen 2017-10-30  108  	writel(readl(base + CH_EN) | CH_TMR_EN(0, 0), base + CH_EN);
28914401 Rick Chen 2017-10-30  109  
28914401 Rick Chen 2017-10-30  110  	return 0;
28914401 Rick Chen 2017-10-30  111  }
28914401 Rick Chen 2017-10-30  112  static int atcpit100_tick_resume(struct clock_event_device *evt)
28914401 Rick Chen 2017-10-30  113  {
28914401 Rick Chen 2017-10-30  114  	writel(readl(base + INT_STA) | CH_INT_STA(0, 0), base + INT_STA);
28914401 Rick Chen 2017-10-30  115  	writel(readl(base + CH_EN) | CH_TMR_EN(0, 0), base + CH_EN);
28914401 Rick Chen 2017-10-30  116  
28914401 Rick Chen 2017-10-30  117  	return 0;
28914401 Rick Chen 2017-10-30  118  }
28914401 Rick Chen 2017-10-30  119  static int atcpit100_set_state_oneshot(struct clock_event_device *evt)
28914401 Rick Chen 2017-10-30  120  {
28914401 Rick Chen 2017-10-30  121  	writel(0xffffffff, base + CH_REL(0));
28914401 Rick Chen 2017-10-30  122  	writel(readl(base + CH_EN) | CH_TMR_EN(0, 0), base + CH_EN);
28914401 Rick Chen 2017-10-30  123  
28914401 Rick Chen 2017-10-30  124  	return 0;
28914401 Rick Chen 2017-10-30  125  }
28914401 Rick Chen 2017-10-30  126  
28914401 Rick Chen 2017-10-30  127  static struct clock_event_device clockevent_atcpit100 = {
28914401 Rick Chen 2017-10-30  128  	.name		= "atcpit100_tm0",
28914401 Rick Chen 2017-10-30  129  	.features       = CLOCK_EVT_FEAT_ONESHOT | CLOCK_EVT_FEAT_PERIODIC,
28914401 Rick Chen 2017-10-30  130  	.shift		= 32,
28914401 Rick Chen 2017-10-30  131  	.cpumask	= cpu_all_mask,
28914401 Rick Chen 2017-10-30  132  	.set_next_event	= atcpit100_set_next_event,
28914401 Rick Chen 2017-10-30  133  	.set_state_shutdown = atcpit100_set_state_shutdown,
28914401 Rick Chen 2017-10-30  134  	.set_state_periodic = atcpit100_set_state_periodic,
28914401 Rick Chen 2017-10-30  135  	.set_state_oneshot = atcpit100_set_state_oneshot,
28914401 Rick Chen 2017-10-30  136  	.tick_resume = atcpit100_tick_resume,
28914401 Rick Chen 2017-10-30  137  };
28914401 Rick Chen 2017-10-30  138  
28914401 Rick Chen 2017-10-30  139  static irqreturn_t timer1_interrupt(int irq, void *dev_id)
28914401 Rick Chen 2017-10-30  140  {
28914401 Rick Chen 2017-10-30  141  	struct clock_event_device *evt = dev_id;
28914401 Rick Chen 2017-10-30  142  
28914401 Rick Chen 2017-10-30  143  	writel(readl(base + INT_STA) | CH_INT_STA(0, 0), base + INT_STA);
28914401 Rick Chen 2017-10-30  144  
28914401 Rick Chen 2017-10-30  145  	evt->event_handler(evt);
28914401 Rick Chen 2017-10-30  146  
28914401 Rick Chen 2017-10-30  147  	return IRQ_HANDLED;
28914401 Rick Chen 2017-10-30  148  }
28914401 Rick Chen 2017-10-30  149  
28914401 Rick Chen 2017-10-30  150  static struct irqaction timer1_irq = {
28914401 Rick Chen 2017-10-30  151  	.name		= "Timer Tick",
28914401 Rick Chen 2017-10-30  152  	.flags		= IRQF_TIMER | IRQF_IRQPOLL,
28914401 Rick Chen 2017-10-30  153  	.handler	= timer1_interrupt,
28914401 Rick Chen 2017-10-30  154  	.dev_id		= &clockevent_atcpit100
28914401 Rick Chen 2017-10-30  155  };
28914401 Rick Chen 2017-10-30  156  
28914401 Rick Chen 2017-10-30  157  static void __init atcpit100_clockevent_init(int irq)
28914401 Rick Chen 2017-10-30  158  {
28914401 Rick Chen 2017-10-30  159  	struct clock_event_device *evt = &clockevent_atcpit100;
28914401 Rick Chen 2017-10-30  160  
28914401 Rick Chen 2017-10-30  161  	evt->mult = div_sc(freq, NSEC_PER_SEC, evt->shift);
28914401 Rick Chen 2017-10-30  162  	evt->max_delta_ns = clockevent_delta2ns(0xffffffff, evt);
28914401 Rick Chen 2017-10-30  163  	evt->min_delta_ns = clockevent_delta2ns(3, evt);
28914401 Rick Chen 2017-10-30  164  	clockevents_register_device(evt);
28914401 Rick Chen 2017-10-30  165  	setup_irq(irq, &timer1_irq);
28914401 Rick Chen 2017-10-30  166  }
28914401 Rick Chen 2017-10-30  167  
28914401 Rick Chen 2017-10-30  168  static int __init atcpit100_init(struct device_node *dev)
28914401 Rick Chen 2017-10-30  169  {
28914401 Rick Chen 2017-10-30  170  	int irq;
28914401 Rick Chen 2017-10-30  171  
28914401 Rick Chen 2017-10-30  172  	base = of_iomap(dev, 0);
28914401 Rick Chen 2017-10-30  173  	if (!base) {
28914401 Rick Chen 2017-10-30  174  		pr_warn("Can't remap registers");
28914401 Rick Chen 2017-10-30  175  		return -ENXIO;
28914401 Rick Chen 2017-10-30  176  	}
28914401 Rick Chen 2017-10-30  177  
28914401 Rick Chen 2017-10-30  178  	if (of_property_read_u32(dev, "clock-frequency", &freq)) {
28914401 Rick Chen 2017-10-30  179  		pr_warn("Can't read clock-frequency");
28914401 Rick Chen 2017-10-30  180  		return -EINVAL;
28914401 Rick Chen 2017-10-30  181  	}
28914401 Rick Chen 2017-10-30  182  	irq = irq_of_parse_and_map(dev, 0);
28914401 Rick Chen 2017-10-30  183  
28914401 Rick Chen 2017-10-30  184  	if (irq <= 0) {
28914401 Rick Chen 2017-10-30  185  		pr_warn("Failed to map timer IRQ\n");
28914401 Rick Chen 2017-10-30  186  		return -EINVAL;
28914401 Rick Chen 2017-10-30  187  	}
28914401 Rick Chen 2017-10-30  188  	pr_info("ATCPIT100 timer 1 installed on IRQ %d, with clock %d at %d HZ. in 0x%08x\r\n",
28914401 Rick Chen 2017-10-30 @189  			irq, freq, HZ, (u32)base);
28914401 Rick Chen 2017-10-30  190  	writel(APB_CLK|TMR_32, base + CH_CTL(0));
28914401 Rick Chen 2017-10-30  191  	writel(readl(base + INT_EN) | CH_INT_EN(0, 0), base + INT_EN);
28914401 Rick Chen 2017-10-30  192  	writel(readl(base + CH_EN) | CH_TMR_EN(0, 0), base + CH_EN);
28914401 Rick Chen 2017-10-30  193  	atcpit100_clocksource_init();
28914401 Rick Chen 2017-10-30  194  	atcpit100_clockevent_init(irq);
28914401 Rick Chen 2017-10-30  195  
28914401 Rick Chen 2017-10-30  196  	return 0;
28914401 Rick Chen 2017-10-30  197  }
28914401 Rick Chen 2017-10-30  198  

:::::: The code at line 189 was first introduced by commit
:::::: 289144019bcc6168c2135488589d11720ef3428e clocksource/drivers/atcpit100: Add andestech atcpit100 timer

:::::: TO: Rick Chen <rickchen36-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
:::::: CC: 0day robot <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 61748 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 3/3] dt-bindings: timer: Add andestech atcpit100 timer binding doc
@ 2017-11-01 21:41     ` Rob Herring
  0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2017-11-01 21:41 UTC (permalink / raw)
  To: Rick Chen
  Cc: daniel.lezcano, tglx, linux-kernel, devicetree, rick, Greentime Hu

On Mon, Oct 30, 2017 at 01:18:57PM +0800, Rick Chen wrote:
> Add a document to describe Andestech atcpit100 timer and
> binding information.
> 
> Signed-off-by: Greentime Hu <green.hu@gmail.com>
> Signed-off-by: Rick Chen <rickchen36@gmail.com>
> ---
>  .../bindings/timer/andestech,atcpit100-timer.txt   | 31 ++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/timer/andestech,atcpit100-timer.txt

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 3/3] dt-bindings: timer: Add andestech atcpit100 timer binding doc
@ 2017-11-01 21:41     ` Rob Herring
  0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2017-11-01 21:41 UTC (permalink / raw)
  To: Rick Chen
  Cc: daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A,
	tglx-hfZtesqFncYOwBW4kG4KsQ, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA, rick-MUIXKm3Oiri1Z/+hSey0Gg,
	Greentime Hu

On Mon, Oct 30, 2017 at 01:18:57PM +0800, Rick Chen wrote:
> Add a document to describe Andestech atcpit100 timer and
> binding information.
> 
> Signed-off-by: Greentime Hu <green.hu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Rick Chen <rickchen36-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  .../bindings/timer/andestech,atcpit100-timer.txt   | 31 ++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/timer/andestech,atcpit100-timer.txt

Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2017-11-01 21:41 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-30  5:18 [PATCH v2 1/3] clocksource/drivers/atcpit100: Add andestech atcpit100 timer Rick Chen
2017-10-30  5:18 ` Rick Chen
2017-10-30  5:18 ` [PATCH v2 2/3] clocksource/drivers/Kconfig: Support " Rick Chen
2017-11-01 20:40   ` kbuild test robot
2017-11-01 20:40     ` kbuild test robot
2017-10-30  5:18 ` [PATCH v2 3/3] dt-bindings: timer: Add andestech atcpit100 timer binding doc Rick Chen
2017-11-01 21:41   ` Rob Herring
2017-11-01 21:41     ` Rob Herring

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.