From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <Yazen.Ghannam@amd.com>
Cc: linux-edac@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/mce/AMD: Fix mce_severity_amd_smca() signature
Date: Fri, 3 Nov 2017 13:05:46 +0100 [thread overview]
Message-ID: <20171103120546.xy2r5ulmk7us5tfi@pd.tnic> (raw)
In-Reply-To: <1509563052-10039-1-git-send-email-Yazen.Ghannam@amd.com>
On Wed, Nov 01, 2017 at 02:04:12PM -0500, Yazen Ghannam wrote:
> From: Yazen Ghannam <yazen.ghannam@amd.com>
>
> Change the err_ctx type to "enum context" to match the type passed in.
>
> Suggested-by: Borislav Petkov <bp@suse.de>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> ---
> arch/x86/kernel/cpu/mcheck/mce-severity.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/mcheck/mce-severity.c b/arch/x86/kernel/cpu/mcheck/mce-severity.c
> index f5518706baa6..267311a7fc60 100644
> --- a/arch/x86/kernel/cpu/mcheck/mce-severity.c
> +++ b/arch/x86/kernel/cpu/mcheck/mce-severity.c
> @@ -204,7 +204,7 @@ static int error_context(struct mce *m)
> return IN_KERNEL;
> }
>
> -static int mce_severity_amd_smca(struct mce *m, int err_ctx)
> +static int mce_severity_amd_smca(struct mce *m, enum context err_ctx)
> {
> u32 addr = MSR_AMD64_SMCA_MCx_CONFIG(m->bank);
> u32 low, high;
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <Yazen.Ghannam@amd.com>
Cc: linux-edac@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: x86/mce/AMD: Fix mce_severity_amd_smca() signature
Date: Fri, 3 Nov 2017 13:05:46 +0100 [thread overview]
Message-ID: <20171103120546.xy2r5ulmk7us5tfi@pd.tnic> (raw)
On Wed, Nov 01, 2017 at 02:04:12PM -0500, Yazen Ghannam wrote:
> From: Yazen Ghannam <yazen.ghannam@amd.com>
>
> Change the err_ctx type to "enum context" to match the type passed in.
>
> Suggested-by: Borislav Petkov <bp@suse.de>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> ---
> arch/x86/kernel/cpu/mcheck/mce-severity.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/mcheck/mce-severity.c b/arch/x86/kernel/cpu/mcheck/mce-severity.c
> index f5518706baa6..267311a7fc60 100644
> --- a/arch/x86/kernel/cpu/mcheck/mce-severity.c
> +++ b/arch/x86/kernel/cpu/mcheck/mce-severity.c
> @@ -204,7 +204,7 @@ static int error_context(struct mce *m)
> return IN_KERNEL;
> }
>
> -static int mce_severity_amd_smca(struct mce *m, int err_ctx)
> +static int mce_severity_amd_smca(struct mce *m, enum context err_ctx)
> {
> u32 addr = MSR_AMD64_SMCA_MCx_CONFIG(m->bank);
> u32 low, high;
> --
Applied, thanks.
next prev parent reply other threads:[~2017-11-03 12:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 19:04 [PATCH] x86/mce/AMD: Fix mce_severity_amd_smca() signature Yazen Ghannam
2017-11-01 19:04 ` Yazen Ghannam
2017-11-03 12:05 ` Borislav Petkov [this message]
2017-11-03 12:05 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171103120546.xy2r5ulmk7us5tfi@pd.tnic \
--to=bp@alien8.de \
--cc=Yazen.Ghannam@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.