From: Bjorn Helgaas <helgaas@kernel.org>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: linux-pci@vger.kernel.org, timur@codeaurora.org,
alex.williamson@redhat.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: turn off PCIe services during shutdown
Date: Mon, 6 Nov 2017 18:11:13 -0600 [thread overview]
Message-ID: <20171107001113.GA9538@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <1508958063-6947-1-git-send-email-okaya@codeaurora.org>
On Wed, Oct 25, 2017 at 03:01:02PM -0400, Sinan Kaya wrote:
> Some of the PCIe services such as AER are being left enabled during
> shutdown. This might cause spurious AER errors while SOC is being
> powered down.
>
> Let's clean up the PCIe services gracefully during shutdown to clear
> these false positives.
>
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Applied to pci/portdrv for v4.15, thanks!
> ---
> drivers/pci/pcie/portdrv_pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
> index 083276e..b350d12 100644
> --- a/drivers/pci/pcie/portdrv_pci.c
> +++ b/drivers/pci/pcie/portdrv_pci.c
> @@ -246,6 +246,7 @@ static void pcie_portdrv_err_resume(struct pci_dev *dev)
>
> .probe = pcie_portdrv_probe,
> .remove = pcie_portdrv_remove,
> + .shutdown = pcie_portdrv_remove,
>
> .err_handler = &pcie_portdrv_err_handler,
>
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: linux-pci@vger.kernel.org, timur@codeaurora.org,
linux-kernel@vger.kernel.org, alex.williamson@redhat.com,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: turn off PCIe services during shutdown
Date: Mon, 6 Nov 2017 18:11:13 -0600 [thread overview]
Message-ID: <20171107001113.GA9538@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <1508958063-6947-1-git-send-email-okaya@codeaurora.org>
On Wed, Oct 25, 2017 at 03:01:02PM -0400, Sinan Kaya wrote:
> Some of the PCIe services such as AER are being left enabled during
> shutdown. This might cause spurious AER errors while SOC is being
> powered down.
>
> Let's clean up the PCIe services gracefully during shutdown to clear
> these false positives.
>
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Applied to pci/portdrv for v4.15, thanks!
> ---
> drivers/pci/pcie/portdrv_pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
> index 083276e..b350d12 100644
> --- a/drivers/pci/pcie/portdrv_pci.c
> +++ b/drivers/pci/pcie/portdrv_pci.c
> @@ -246,6 +246,7 @@ static void pcie_portdrv_err_resume(struct pci_dev *dev)
>
> .probe = pcie_portdrv_probe,
> .remove = pcie_portdrv_remove,
> + .shutdown = pcie_portdrv_remove,
>
> .err_handler = &pcie_portdrv_err_handler,
>
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: helgaas@kernel.org (Bjorn Helgaas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: turn off PCIe services during shutdown
Date: Mon, 6 Nov 2017 18:11:13 -0600 [thread overview]
Message-ID: <20171107001113.GA9538@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <1508958063-6947-1-git-send-email-okaya@codeaurora.org>
On Wed, Oct 25, 2017 at 03:01:02PM -0400, Sinan Kaya wrote:
> Some of the PCIe services such as AER are being left enabled during
> shutdown. This might cause spurious AER errors while SOC is being
> powered down.
>
> Let's clean up the PCIe services gracefully during shutdown to clear
> these false positives.
>
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Applied to pci/portdrv for v4.15, thanks!
> ---
> drivers/pci/pcie/portdrv_pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
> index 083276e..b350d12 100644
> --- a/drivers/pci/pcie/portdrv_pci.c
> +++ b/drivers/pci/pcie/portdrv_pci.c
> @@ -246,6 +246,7 @@ static void pcie_portdrv_err_resume(struct pci_dev *dev)
>
> .probe = pcie_portdrv_probe,
> .remove = pcie_portdrv_remove,
> + .shutdown = pcie_portdrv_remove,
>
> .err_handler = &pcie_portdrv_err_handler,
>
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-11-07 0:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 19:01 [PATCH] PCI: turn off PCIe services during shutdown Sinan Kaya
2017-10-25 19:01 ` Sinan Kaya
2017-10-25 19:01 ` Sinan Kaya
2017-11-07 0:11 ` Bjorn Helgaas [this message]
2017-11-07 0:11 ` Bjorn Helgaas
2017-11-07 0:11 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107001113.GA9538@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.