All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] PCI: turn off PCIe services during shutdown
@ 2017-10-25 19:01 ` Sinan Kaya
  0 siblings, 0 replies; 6+ messages in thread
From: Sinan Kaya @ 2017-10-25 19:01 UTC (permalink / raw)
  To: linux-pci, timur, alex.williamson
  Cc: linux-arm-msm, linux-arm-kernel, Sinan Kaya, linux-kernel

Some of the PCIe services such as AER are being left enabled during
shutdown. This might cause spurious AER errors while SOC is being
powered down.

Let's clean up the PCIe services gracefully during shutdown to clear
these false positives.

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/pci/pcie/portdrv_pci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
index 083276e..b350d12 100644
--- a/drivers/pci/pcie/portdrv_pci.c
+++ b/drivers/pci/pcie/portdrv_pci.c
@@ -246,6 +246,7 @@ static void pcie_portdrv_err_resume(struct pci_dev *dev)
 
 	.probe		= pcie_portdrv_probe,
 	.remove		= pcie_portdrv_remove,
+	.shutdown	= pcie_portdrv_remove,
 
 	.err_handler	= &pcie_portdrv_err_handler,
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] PCI: turn off PCIe services during shutdown
@ 2017-10-25 19:01 ` Sinan Kaya
  0 siblings, 0 replies; 6+ messages in thread
From: Sinan Kaya @ 2017-10-25 19:01 UTC (permalink / raw)
  To: linux-pci, timur, alex.williamson
  Cc: Sinan Kaya, linux-arm-msm, linux-kernel, linux-arm-kernel

Some of the PCIe services such as AER are being left enabled during
shutdown. This might cause spurious AER errors while SOC is being
powered down.

Let's clean up the PCIe services gracefully during shutdown to clear
these false positives.

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/pci/pcie/portdrv_pci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
index 083276e..b350d12 100644
--- a/drivers/pci/pcie/portdrv_pci.c
+++ b/drivers/pci/pcie/portdrv_pci.c
@@ -246,6 +246,7 @@ static void pcie_portdrv_err_resume(struct pci_dev *dev)
 
 	.probe		= pcie_portdrv_probe,
 	.remove		= pcie_portdrv_remove,
+	.shutdown	= pcie_portdrv_remove,
 
 	.err_handler	= &pcie_portdrv_err_handler,
 
-- 
1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] PCI: turn off PCIe services during shutdown
@ 2017-10-25 19:01 ` Sinan Kaya
  0 siblings, 0 replies; 6+ messages in thread
From: Sinan Kaya @ 2017-10-25 19:01 UTC (permalink / raw)
  To: linux-arm-kernel

Some of the PCIe services such as AER are being left enabled during
shutdown. This might cause spurious AER errors while SOC is being
powered down.

Let's clean up the PCIe services gracefully during shutdown to clear
these false positives.

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/pci/pcie/portdrv_pci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
index 083276e..b350d12 100644
--- a/drivers/pci/pcie/portdrv_pci.c
+++ b/drivers/pci/pcie/portdrv_pci.c
@@ -246,6 +246,7 @@ static void pcie_portdrv_err_resume(struct pci_dev *dev)
 
 	.probe		= pcie_portdrv_probe,
 	.remove		= pcie_portdrv_remove,
+	.shutdown	= pcie_portdrv_remove,
 
 	.err_handler	= &pcie_portdrv_err_handler,
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: turn off PCIe services during shutdown
  2017-10-25 19:01 ` Sinan Kaya
  (?)
@ 2017-11-07  0:11   ` Bjorn Helgaas
  -1 siblings, 0 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2017-11-07  0:11 UTC (permalink / raw)
  To: Sinan Kaya
  Cc: linux-pci, timur, alex.williamson, linux-arm-msm, linux-kernel,
	linux-arm-kernel

On Wed, Oct 25, 2017 at 03:01:02PM -0400, Sinan Kaya wrote:
> Some of the PCIe services such as AER are being left enabled during
> shutdown. This might cause spurious AER errors while SOC is being
> powered down.
> 
> Let's clean up the PCIe services gracefully during shutdown to clear
> these false positives.
> 
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>

Applied to pci/portdrv for v4.15, thanks!

> ---
>  drivers/pci/pcie/portdrv_pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
> index 083276e..b350d12 100644
> --- a/drivers/pci/pcie/portdrv_pci.c
> +++ b/drivers/pci/pcie/portdrv_pci.c
> @@ -246,6 +246,7 @@ static void pcie_portdrv_err_resume(struct pci_dev *dev)
>  
>  	.probe		= pcie_portdrv_probe,
>  	.remove		= pcie_portdrv_remove,
> +	.shutdown	= pcie_portdrv_remove,
>  
>  	.err_handler	= &pcie_portdrv_err_handler,
>  
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: turn off PCIe services during shutdown
@ 2017-11-07  0:11   ` Bjorn Helgaas
  0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2017-11-07  0:11 UTC (permalink / raw)
  To: Sinan Kaya
  Cc: linux-pci, timur, linux-kernel, alex.williamson, linux-arm-msm,
	linux-arm-kernel

On Wed, Oct 25, 2017 at 03:01:02PM -0400, Sinan Kaya wrote:
> Some of the PCIe services such as AER are being left enabled during
> shutdown. This might cause spurious AER errors while SOC is being
> powered down.
> 
> Let's clean up the PCIe services gracefully during shutdown to clear
> these false positives.
> 
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>

Applied to pci/portdrv for v4.15, thanks!

> ---
>  drivers/pci/pcie/portdrv_pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
> index 083276e..b350d12 100644
> --- a/drivers/pci/pcie/portdrv_pci.c
> +++ b/drivers/pci/pcie/portdrv_pci.c
> @@ -246,6 +246,7 @@ static void pcie_portdrv_err_resume(struct pci_dev *dev)
>  
>  	.probe		= pcie_portdrv_probe,
>  	.remove		= pcie_portdrv_remove,
> +	.shutdown	= pcie_portdrv_remove,
>  
>  	.err_handler	= &pcie_portdrv_err_handler,
>  
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] PCI: turn off PCIe services during shutdown
@ 2017-11-07  0:11   ` Bjorn Helgaas
  0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2017-11-07  0:11 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Oct 25, 2017 at 03:01:02PM -0400, Sinan Kaya wrote:
> Some of the PCIe services such as AER are being left enabled during
> shutdown. This might cause spurious AER errors while SOC is being
> powered down.
> 
> Let's clean up the PCIe services gracefully during shutdown to clear
> these false positives.
> 
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>

Applied to pci/portdrv for v4.15, thanks!

> ---
>  drivers/pci/pcie/portdrv_pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
> index 083276e..b350d12 100644
> --- a/drivers/pci/pcie/portdrv_pci.c
> +++ b/drivers/pci/pcie/portdrv_pci.c
> @@ -246,6 +246,7 @@ static void pcie_portdrv_err_resume(struct pci_dev *dev)
>  
>  	.probe		= pcie_portdrv_probe,
>  	.remove		= pcie_portdrv_remove,
> +	.shutdown	= pcie_portdrv_remove,
>  
>  	.err_handler	= &pcie_portdrv_err_handler,
>  
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-07  0:11 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-25 19:01 [PATCH] PCI: turn off PCIe services during shutdown Sinan Kaya
2017-10-25 19:01 ` Sinan Kaya
2017-10-25 19:01 ` Sinan Kaya
2017-11-07  0:11 ` Bjorn Helgaas
2017-11-07  0:11   ` Bjorn Helgaas
2017-11-07  0:11   ` Bjorn Helgaas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.