All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Stephan Müller" <smueller@chronox.de>
Cc: Romain Izard <romain.izard.pro@gmail.com>,
	linux-crypto@vger.kernel.org,
	Cyrille Pitchen <cyrille.pitchen@microchip.com>,
	Tudor Ambarus <tudor.ambarus@microchip.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] crypto: AF_ALG - remove locking in async callback
Date: Tue, 7 Nov 2017 14:32:12 +0800	[thread overview]
Message-ID: <20171107063212.GA25491@gondor.apana.org.au> (raw)
In-Reply-To: <4677171.2qOLUIFS1s@positron.chronox.de>

On Tue, Nov 07, 2017 at 07:19:32AM +0100, Stephan Müller wrote:
> 
> Where I am not fully sure is whether af_alg_async_cb is called in any case. 
> I.e. when we invoke an AIO operation with a cipher that completes 
> synchronously (e.g. AES-NI), is this callback triggered?

It's the same with any other callback in the crypto API.  The
completion function is called if the return value is EINPROGRESS
or EBUSY.

In fact the algif_aead/algif_skcipher code already frees the SG lists
and areq on a sync return.  So perhaps you can merge this with the
completion function.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

WARNING: multiple messages have this Message-ID (diff)
From: herbert@gondor.apana.org.au (Herbert Xu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] crypto: AF_ALG - remove locking in async callback
Date: Tue, 7 Nov 2017 14:32:12 +0800	[thread overview]
Message-ID: <20171107063212.GA25491@gondor.apana.org.au> (raw)
In-Reply-To: <4677171.2qOLUIFS1s@positron.chronox.de>

On Tue, Nov 07, 2017 at 07:19:32AM +0100, Stephan M?ller wrote:
> 
> Where I am not fully sure is whether af_alg_async_cb is called in any case. 
> I.e. when we invoke an AIO operation with a cipher that completes 
> synchronously (e.g. AES-NI), is this callback triggered?

It's the same with any other callback in the crypto API.  The
completion function is called if the return value is EINPROGRESS
or EBUSY.

In fact the algif_aead/algif_skcipher code already frees the SG lists
and areq on a sync return.  So perhaps you can merge this with the
completion function.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2017-11-07  6:32 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-25 15:26 "BUG: scheduling while atomic" in atmel-aes on Linux v4.14-rc6 Romain Izard
2017-10-25 15:26 ` Romain Izard
2017-10-25 15:59 ` Stephan Mueller
2017-10-25 15:59   ` Stephan Mueller
2017-10-29 20:39 ` [PATCH] crypto: AF_ALG - remove locking in async callback Stephan Müller
2017-10-29 20:39   ` Stephan Müller
2017-10-30 17:15   ` Romain Izard
2017-10-30 17:15     ` Romain Izard
2017-11-03 13:20   ` Herbert Xu
2017-11-03 13:20     ` Herbert Xu
2017-11-03 13:34     ` Stephan Mueller
2017-11-03 13:34       ` Stephan Mueller
2017-11-06 16:06     ` Stephan Mueller
2017-11-06 16:06       ` Stephan Mueller
2017-11-07  5:22       ` Herbert Xu
2017-11-07  5:22         ` Herbert Xu
2017-11-07  6:19         ` Stephan Müller
2017-11-07  6:19           ` Stephan Müller
2017-11-07  6:32           ` Herbert Xu [this message]
2017-11-07  6:32             ` Herbert Xu
2017-11-07  9:05             ` [PATCH v2] " Stephan Müller
2017-11-07  9:05               ` Stephan Müller
2017-11-10 11:10               ` Herbert Xu
2017-11-10 11:10                 ` Herbert Xu
2017-11-10 12:20                 ` [PATCH v3] " Stephan Müller
2017-11-10 12:20                   ` Stephan Müller
2017-11-10 16:50                   ` Romain Izard
2017-11-10 16:50                     ` Romain Izard
2017-11-24  7:37                   ` Herbert Xu
2017-11-24  7:37                     ` Herbert Xu
2017-11-24 16:04                     ` Stephan Mueller
2017-11-24 16:04                       ` Stephan Mueller
2017-11-24 17:37                       ` Jonathan Cameron
2017-11-24 17:37                         ` Jonathan Cameron
2017-11-25  0:17                       ` Herbert Xu
2017-11-25  0:17                         ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171107063212.GA25491@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=cyrille.pitchen@microchip.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=romain.izard.pro@gmail.com \
    --cc=smueller@chronox.de \
    --cc=tudor.ambarus@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.