From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Stephan Müller" <smueller@chronox.de>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
Cyrille Pitchen <cyrille.pitchen@microchip.com>,
linux-crypto@vger.kernel.org,
Romain Izard <romain.izard.pro@gmail.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3] crypto: AF_ALG - remove locking in async callback
Date: Fri, 24 Nov 2017 18:37:39 +1100 [thread overview]
Message-ID: <20171124073739.GB15597@gondor.apana.org.au> (raw)
In-Reply-To: <1966139.WIlnTlQG5u@positron.chronox.de>
On Fri, Nov 10, 2017 at 01:20:55PM +0100, Stephan Müller wrote:
> The code paths protected by the socket-lock do not use or modify the
> socket in a non-atomic fashion. The actions pertaining the socket do not
> even need to be handled as an atomic operation. Thus, the socket-lock
> can be safely ignored.
>
> This fixes a bug regarding scheduling in atomic as the callback function
> may be invoked in interrupt context.
>
> In addition, the sock_hold is moved before the AIO encrypt/decrypt
> operation to ensure that the socket is always present. This avoids a
> tiny race window where the socket is unprotected and yet used by the AIO
> operation.
>
> Finally, the release of resources for a crypto operation is moved into a
> common function of af_alg_free_resources.
>
> Fixes: e870456d8e7c8 ("crypto: algif_skcipher - overhaul memory management")
> Fixes: d887c52d6ae43 ("crypto: algif_aead - overhaul memory management")
> Reported-by: Romain Izard <romain.izard.pro@gmail.com>
> Signed-off-by: Stephan Mueller <smueller@chronox.de>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
WARNING: multiple messages have this Message-ID (diff)
From: herbert@gondor.apana.org.au (Herbert Xu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] crypto: AF_ALG - remove locking in async callback
Date: Fri, 24 Nov 2017 18:37:39 +1100 [thread overview]
Message-ID: <20171124073739.GB15597@gondor.apana.org.au> (raw)
In-Reply-To: <1966139.WIlnTlQG5u@positron.chronox.de>
On Fri, Nov 10, 2017 at 01:20:55PM +0100, Stephan M?ller wrote:
> The code paths protected by the socket-lock do not use or modify the
> socket in a non-atomic fashion. The actions pertaining the socket do not
> even need to be handled as an atomic operation. Thus, the socket-lock
> can be safely ignored.
>
> This fixes a bug regarding scheduling in atomic as the callback function
> may be invoked in interrupt context.
>
> In addition, the sock_hold is moved before the AIO encrypt/decrypt
> operation to ensure that the socket is always present. This avoids a
> tiny race window where the socket is unprotected and yet used by the AIO
> operation.
>
> Finally, the release of resources for a crypto operation is moved into a
> common function of af_alg_free_resources.
>
> Fixes: e870456d8e7c8 ("crypto: algif_skcipher - overhaul memory management")
> Fixes: d887c52d6ae43 ("crypto: algif_aead - overhaul memory management")
> Reported-by: Romain Izard <romain.izard.pro@gmail.com>
> Signed-off-by: Stephan Mueller <smueller@chronox.de>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2017-11-24 7:37 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 15:26 "BUG: scheduling while atomic" in atmel-aes on Linux v4.14-rc6 Romain Izard
2017-10-25 15:26 ` Romain Izard
2017-10-25 15:59 ` Stephan Mueller
2017-10-25 15:59 ` Stephan Mueller
2017-10-29 20:39 ` [PATCH] crypto: AF_ALG - remove locking in async callback Stephan Müller
2017-10-29 20:39 ` Stephan Müller
2017-10-30 17:15 ` Romain Izard
2017-10-30 17:15 ` Romain Izard
2017-11-03 13:20 ` Herbert Xu
2017-11-03 13:20 ` Herbert Xu
2017-11-03 13:34 ` Stephan Mueller
2017-11-03 13:34 ` Stephan Mueller
2017-11-06 16:06 ` Stephan Mueller
2017-11-06 16:06 ` Stephan Mueller
2017-11-07 5:22 ` Herbert Xu
2017-11-07 5:22 ` Herbert Xu
2017-11-07 6:19 ` Stephan Müller
2017-11-07 6:19 ` Stephan Müller
2017-11-07 6:32 ` Herbert Xu
2017-11-07 6:32 ` Herbert Xu
2017-11-07 9:05 ` [PATCH v2] " Stephan Müller
2017-11-07 9:05 ` Stephan Müller
2017-11-10 11:10 ` Herbert Xu
2017-11-10 11:10 ` Herbert Xu
2017-11-10 12:20 ` [PATCH v3] " Stephan Müller
2017-11-10 12:20 ` Stephan Müller
2017-11-10 16:50 ` Romain Izard
2017-11-10 16:50 ` Romain Izard
2017-11-24 7:37 ` Herbert Xu [this message]
2017-11-24 7:37 ` Herbert Xu
2017-11-24 16:04 ` Stephan Mueller
2017-11-24 16:04 ` Stephan Mueller
2017-11-24 17:37 ` Jonathan Cameron
2017-11-24 17:37 ` Jonathan Cameron
2017-11-25 0:17 ` Herbert Xu
2017-11-25 0:17 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171124073739.GB15597@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=cyrille.pitchen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=romain.izard.pro@gmail.com \
--cc=smueller@chronox.de \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.