* [Qemu-devel] [PATCH] block: Fix error path in bdrv_backing_update_filename()
@ 2017-11-06 16:55 Kevin Wolf
2017-11-06 17:04 ` Eric Blake
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Kevin Wolf @ 2017-11-06 16:55 UTC (permalink / raw)
To: qemu-block; +Cc: kwolf, qemu-devel
error_setg_errno() takes a positive errno code.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block.c b/block.c
index 684cb018da..f6415547fe 100644
--- a/block.c
+++ b/block.c
@@ -998,7 +998,7 @@ static int bdrv_backing_update_filename(BdrvChild *c, BlockDriverState *base,
ret = bdrv_change_backing_file(parent, filename,
base->drv ? base->drv->format_name : "");
if (ret < 0) {
- error_setg_errno(errp, ret, "Could not update backing file link");
+ error_setg_errno(errp, -ret, "Could not update backing file link");
}
if (!(orig_flags & BDRV_O_RDWR)) {
--
2.13.6
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] block: Fix error path in bdrv_backing_update_filename()
2017-11-06 16:55 [Qemu-devel] [PATCH] block: Fix error path in bdrv_backing_update_filename() Kevin Wolf
@ 2017-11-06 17:04 ` Eric Blake
2017-11-06 20:18 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Eric Blake @ 2017-11-06 17:04 UTC (permalink / raw)
To: Kevin Wolf, qemu-block; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 453 bytes --]
On 11/06/2017 10:55 AM, Kevin Wolf wrote:
> error_setg_errno() takes a positive errno code.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
Worth mentioning Coverity in the commit message?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] block: Fix error path in bdrv_backing_update_filename()
2017-11-06 16:55 [Qemu-devel] [PATCH] block: Fix error path in bdrv_backing_update_filename() Kevin Wolf
2017-11-06 17:04 ` Eric Blake
@ 2017-11-06 20:18 ` Alberto Garcia
2017-11-09 11:24 ` [Qemu-devel] " Stefan Hajnoczi
2017-11-15 19:41 ` Peter Maydell
3 siblings, 0 replies; 6+ messages in thread
From: Alberto Garcia @ 2017-11-06 20:18 UTC (permalink / raw)
To: Kevin Wolf, qemu-block; +Cc: qemu-devel
On Mon 06 Nov 2017 05:55:00 PM CET, Kevin Wolf <kwolf@redhat.com> wrote:
> error_setg_errno() takes a positive errno code.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Berto
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] block: Fix error path in bdrv_backing_update_filename()
2017-11-06 16:55 [Qemu-devel] [PATCH] block: Fix error path in bdrv_backing_update_filename() Kevin Wolf
2017-11-06 17:04 ` Eric Blake
2017-11-06 20:18 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
@ 2017-11-09 11:24 ` Stefan Hajnoczi
2017-11-15 19:41 ` Peter Maydell
3 siblings, 0 replies; 6+ messages in thread
From: Stefan Hajnoczi @ 2017-11-09 11:24 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-block, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
On Mon, Nov 06, 2017 at 05:55:00PM +0100, Kevin Wolf wrote:
> error_setg_errno() takes a positive errno code.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] block: Fix error path in bdrv_backing_update_filename()
2017-11-06 16:55 [Qemu-devel] [PATCH] block: Fix error path in bdrv_backing_update_filename() Kevin Wolf
` (2 preceding siblings ...)
2017-11-09 11:24 ` [Qemu-devel] " Stefan Hajnoczi
@ 2017-11-15 19:41 ` Peter Maydell
2017-11-16 11:59 ` Kevin Wolf
3 siblings, 1 reply; 6+ messages in thread
From: Peter Maydell @ 2017-11-15 19:41 UTC (permalink / raw)
To: Kevin Wolf; +Cc: Qemu-block, QEMU Developers
On 6 November 2017 at 16:55, Kevin Wolf <kwolf@redhat.com> wrote:
> error_setg_errno() takes a positive errno code.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block.c b/block.c
> index 684cb018da..f6415547fe 100644
> --- a/block.c
> +++ b/block.c
> @@ -998,7 +998,7 @@ static int bdrv_backing_update_filename(BdrvChild *c, BlockDriverState *base,
> ret = bdrv_change_backing_file(parent, filename,
> base->drv ? base->drv->format_name : "");
> if (ret < 0) {
> - error_setg_errno(errp, ret, "Could not update backing file link");
> + error_setg_errno(errp, -ret, "Could not update backing file link");
> }
>
> if (!(orig_flags & BDRV_O_RDWR)) {
> --
> 2.13.6
Just noticed going through coverity warnings that this didn't
make it into rc1 -- could we get it in for rc2, please?
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] block: Fix error path in bdrv_backing_update_filename()
2017-11-15 19:41 ` Peter Maydell
@ 2017-11-16 11:59 ` Kevin Wolf
0 siblings, 0 replies; 6+ messages in thread
From: Kevin Wolf @ 2017-11-16 11:59 UTC (permalink / raw)
To: Peter Maydell; +Cc: Qemu-block, QEMU Developers
Am 15.11.2017 um 20:41 hat Peter Maydell geschrieben:
> On 6 November 2017 at 16:55, Kevin Wolf <kwolf@redhat.com> wrote:
> > error_setg_errno() takes a positive errno code.
> >
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> > block.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/block.c b/block.c
> > index 684cb018da..f6415547fe 100644
> > --- a/block.c
> > +++ b/block.c
> > @@ -998,7 +998,7 @@ static int bdrv_backing_update_filename(BdrvChild *c, BlockDriverState *base,
> > ret = bdrv_change_backing_file(parent, filename,
> > base->drv ? base->drv->format_name : "");
> > if (ret < 0) {
> > - error_setg_errno(errp, ret, "Could not update backing file link");
> > + error_setg_errno(errp, -ret, "Could not update backing file link");
> > }
> >
> > if (!(orig_flags & BDRV_O_RDWR)) {
> > --
> > 2.13.6
>
> Just noticed going through coverity warnings that this didn't
> make it into rc1 -- could we get it in for rc2, please?
Yes. I was sick at the start of the week and Max didn't include my queue
in his pull request, so all the patches I had queued missed -rc1 and
will be sent for -rc2 instead.
Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-16 11:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-06 16:55 [Qemu-devel] [PATCH] block: Fix error path in bdrv_backing_update_filename() Kevin Wolf
2017-11-06 17:04 ` Eric Blake
2017-11-06 20:18 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-11-09 11:24 ` [Qemu-devel] " Stefan Hajnoczi
2017-11-15 19:41 ` Peter Maydell
2017-11-16 11:59 ` Kevin Wolf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.