[LTP] [PATCH 1/1] network/ipsec: TCONF instead of TFAIL when operation not supported

[LTP] [PATCH 1/1] network/ipsec: TCONF instead of TFAIL when operation not supported

[Petr Vorel]

This happens when kernel module ip_vti resp. ip6_vti is missing.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 testcases/network/stress/ipsec/ipsec_lib.sh | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/testcases/network/stress/ipsec/ipsec_lib.sh b/testcases/network/stress/ipsec/ipsec_lib.sh
index 2f10a3bd5..cee755fe0 100644
--- a/testcases/network/stress/ipsec/ipsec_lib.sh
+++ b/testcases/network/stress/ipsec/ipsec_lib.sh
@@ -168,6 +168,9 @@ ipsec_try()
 		echo "$output" | grep -q \
 			'RTNETLINK answers: Function not implemented' && \
 			tst_brkm TCONF "'$@': not implemented"
+		echo "$output" | grep -q \
+			'RTNETLINK answers: Operation not supported' && \
+			tst_brkm TCONF "'$@': not supported (maybe missing 'ip${TST_IPV6}_vti' kernel module)"
 		tst_brkm TBROK "$@ failed: $output"
 	fi
 }
@@ -257,7 +260,7 @@ tst_ipsec_vti()
 	cleanup_vti=$vti
 
 	if [ $target = lhost ]; then
-		ROD ip li add $vti $type local $src remote $dst $key $d
+		ipsec_try ip li add $vti $type local $src remote $dst $key $d
 		ROD ip li set $vti up
 
 		local spi_1="spi 0x$SPI"
-- 
2.15.0

[LTP] [PATCH 1/1] network/ipsec: TCONF instead of TFAIL when operation not supported

[Petr Vorel]

> This happens when kernel module ip_vti resp. ip6_vti is missing.
And I propose to parse this and also TCONF it:
Garbage instead of arguments "local ...". Try "ip link help".

I find it on 3.16 (quite old kernel), but IMHO worth of taking care of it.

Kind regards,
Petr

[LTP] [PATCH 1/1] network/ipsec: TCONF instead of TFAIL when operation not supported

[Alexey Kodanev]

On 11/23/2017 02:50 PM, Petr Vorel wrote:
> This happens when kernel module ip_vti resp. ip6_vti is missing.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  testcases/network/stress/ipsec/ipsec_lib.sh | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/testcases/network/stress/ipsec/ipsec_lib.sh b/testcases/network/stress/ipsec/ipsec_lib.sh
> index 2f10a3bd5..cee755fe0 100644
> --- a/testcases/network/stress/ipsec/ipsec_lib.sh
> +++ b/testcases/network/stress/ipsec/ipsec_lib.sh
> @@ -168,6 +168,9 @@ ipsec_try()
>  		echo "$output" | grep -q \
>  			'RTNETLINK answers: Function not implemented' && \
>  			tst_brkm TCONF "'$@': not implemented"
> +		echo "$output" | grep -q \
> +			'RTNETLINK answers: Operation not supported' && \
> +			tst_brkm TCONF "'$@': not supported (maybe missing 'ip${TST_IPV6}_vti' kernel module)"
>  		tst_brkm TBROK "$@ failed: $output"
>  	fi
>  }
> @@ -257,7 +260,7 @@ tst_ipsec_vti()
>  	cleanup_vti=$vti
>  
>  	if [ $target = lhost ]; then
> -		ROD ip li add $vti $type local $src remote $dst $key $d
> +		ipsec_try ip li add $vti $type local $src remote $dst $key $d
>  		ROD ip li set $vti up

Right, we should handle this case.Acked.

Thanks,
Alexey

[LTP] [PATCH 1/1] network/ipsec: TCONF instead of TFAIL when operation not supported

[Alexey Kodanev]

On 11/23/2017 03:15 PM, Petr Vorel wrote:
>> This happens when kernel module ip_vti resp. ip6_vti is missing.
> And I propose to parse this and also TCONF it:
> Garbage instead of arguments "local ...". Try "ip link help".

Is it because iproute doesn't support it?

Thanks,
Alexey


>
> I find it on 3.16 (quite old kernel), but IMHO worth of taking care of it.
>
> Kind regards,
> Petr
>

[LTP] [PATCH 1/1] network/ipsec: TCONF instead of TFAIL when operation not supported

[Petr Vorel]

Hi,

> On 11/23/2017 02:50 PM, Petr Vorel wrote:
> > This happens when kernel module ip_vti resp. ip6_vti is missing.

> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
...
> Right, we should handle this case.Acked.
Pushed, thanks!


Kind regards,
Petr