* [LTP] [PATCH 1/1] network/ipsec: TCONF instead of TFAIL when operation not supported
@ 2017-11-23 11:50 Petr Vorel
2017-11-23 12:15 ` Petr Vorel
2017-11-27 12:33 ` Alexey Kodanev
0 siblings, 2 replies; 5+ messages in thread
From: Petr Vorel @ 2017-11-23 11:50 UTC (permalink / raw)
To: ltp
This happens when kernel module ip_vti resp. ip6_vti is missing.
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
testcases/network/stress/ipsec/ipsec_lib.sh | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/testcases/network/stress/ipsec/ipsec_lib.sh b/testcases/network/stress/ipsec/ipsec_lib.sh
index 2f10a3bd5..cee755fe0 100644
--- a/testcases/network/stress/ipsec/ipsec_lib.sh
+++ b/testcases/network/stress/ipsec/ipsec_lib.sh
@@ -168,6 +168,9 @@ ipsec_try()
echo "$output" | grep -q \
'RTNETLINK answers: Function not implemented' && \
tst_brkm TCONF "'$@': not implemented"
+ echo "$output" | grep -q \
+ 'RTNETLINK answers: Operation not supported' && \
+ tst_brkm TCONF "'$@': not supported (maybe missing 'ip${TST_IPV6}_vti' kernel module)"
tst_brkm TBROK "$@ failed: $output"
fi
}
@@ -257,7 +260,7 @@ tst_ipsec_vti()
cleanup_vti=$vti
if [ $target = lhost ]; then
- ROD ip li add $vti $type local $src remote $dst $key $d
+ ipsec_try ip li add $vti $type local $src remote $dst $key $d
ROD ip li set $vti up
local spi_1="spi 0x$SPI"
--
2.15.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [LTP] [PATCH 1/1] network/ipsec: TCONF instead of TFAIL when operation not supported
2017-11-23 11:50 [LTP] [PATCH 1/1] network/ipsec: TCONF instead of TFAIL when operation not supported Petr Vorel
@ 2017-11-23 12:15 ` Petr Vorel
2017-11-27 12:36 ` Alexey Kodanev
2017-11-27 12:33 ` Alexey Kodanev
1 sibling, 1 reply; 5+ messages in thread
From: Petr Vorel @ 2017-11-23 12:15 UTC (permalink / raw)
To: ltp
> This happens when kernel module ip_vti resp. ip6_vti is missing.
And I propose to parse this and also TCONF it:
Garbage instead of arguments "local ...". Try "ip link help".
I find it on 3.16 (quite old kernel), but IMHO worth of taking care of it.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] [PATCH 1/1] network/ipsec: TCONF instead of TFAIL when operation not supported
2017-11-23 12:15 ` Petr Vorel
@ 2017-11-27 12:36 ` Alexey Kodanev
0 siblings, 0 replies; 5+ messages in thread
From: Alexey Kodanev @ 2017-11-27 12:36 UTC (permalink / raw)
To: ltp
On 11/23/2017 03:15 PM, Petr Vorel wrote:
>> This happens when kernel module ip_vti resp. ip6_vti is missing.
> And I propose to parse this and also TCONF it:
> Garbage instead of arguments "local ...". Try "ip link help".
Is it because iproute doesn't support it?
Thanks,
Alexey
>
> I find it on 3.16 (quite old kernel), but IMHO worth of taking care of it.
>
> Kind regards,
> Petr
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] [PATCH 1/1] network/ipsec: TCONF instead of TFAIL when operation not supported
2017-11-23 11:50 [LTP] [PATCH 1/1] network/ipsec: TCONF instead of TFAIL when operation not supported Petr Vorel
2017-11-23 12:15 ` Petr Vorel
@ 2017-11-27 12:33 ` Alexey Kodanev
2017-11-27 13:06 ` Petr Vorel
1 sibling, 1 reply; 5+ messages in thread
From: Alexey Kodanev @ 2017-11-27 12:33 UTC (permalink / raw)
To: ltp
On 11/23/2017 02:50 PM, Petr Vorel wrote:
> This happens when kernel module ip_vti resp. ip6_vti is missing.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> testcases/network/stress/ipsec/ipsec_lib.sh | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/testcases/network/stress/ipsec/ipsec_lib.sh b/testcases/network/stress/ipsec/ipsec_lib.sh
> index 2f10a3bd5..cee755fe0 100644
> --- a/testcases/network/stress/ipsec/ipsec_lib.sh
> +++ b/testcases/network/stress/ipsec/ipsec_lib.sh
> @@ -168,6 +168,9 @@ ipsec_try()
> echo "$output" | grep -q \
> 'RTNETLINK answers: Function not implemented' && \
> tst_brkm TCONF "'$@': not implemented"
> + echo "$output" | grep -q \
> + 'RTNETLINK answers: Operation not supported' && \
> + tst_brkm TCONF "'$@': not supported (maybe missing 'ip${TST_IPV6}_vti' kernel module)"
> tst_brkm TBROK "$@ failed: $output"
> fi
> }
> @@ -257,7 +260,7 @@ tst_ipsec_vti()
> cleanup_vti=$vti
>
> if [ $target = lhost ]; then
> - ROD ip li add $vti $type local $src remote $dst $key $d
> + ipsec_try ip li add $vti $type local $src remote $dst $key $d
> ROD ip li set $vti up
Right, we should handle this case.Acked.
Thanks,
Alexey
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-27 13:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-23 11:50 [LTP] [PATCH 1/1] network/ipsec: TCONF instead of TFAIL when operation not supported Petr Vorel
2017-11-23 12:15 ` Petr Vorel
2017-11-27 12:36 ` Alexey Kodanev
2017-11-27 12:33 ` Alexey Kodanev
2017-11-27 13:06 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.