From: "Tobin C. Harding" <me@tobin.cc>
To: kaiwan.billimoria@gmail.com
Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
kernel-hardening@lists.openwall.com
Subject: Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses
Date: Mon, 4 Dec 2017 11:11:06 +1100 [thread overview]
Message-ID: <20171204001106.GB27780@eros> (raw)
In-Reply-To: <1512133747.17323.3.camel@gmail.com>
On Fri, Dec 01, 2017 at 06:39:07PM +0530, kaiwan.billimoria@gmail.com wrote:
> Hi,
>
> Applies upon the previous one in this thread.
> Found and fixed some minor issues with light testing on a 32-bit x86.
> (I realize this isn't an ideal description, forgive me!).
>
> Have also emitted a 'noisy' warning on PAGE_OFFSET fallback to 0xc00000000.
>
> Signed-off-by: Kaiwan N Billimoria <kaiwan.billimoria@gmail.com>
> ---
> scripts/leaking_addresses.pl | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
> index fcf1ebe0f043..3a8691a642c8 100755
> --- a/scripts/leaking_addresses.pl
> +++ b/scripts/leaking_addresses.pl
> @@ -160,7 +160,6 @@ if (!$input_raw and ($squash_by_path or $squash_by_filename)) {
>
> if (!is_supported_architecture()) {
> show_detected_architecture() if $debug;
> -} else {
> printf "\nScript does not support your architecture, sorry.\n";
> printf "\nCurrently we support: \n\n";
> foreach(@SUPPORTED_ARCHITECTURES) {
> @@ -267,7 +266,7 @@ sub is_false_positive
> sub is_false_positive_ix86_32
> {
> my ($match) = @_;
> - state $page_offset = get_page_offset(); # only gets called once
> + state $page_offset = eval get_page_offset(); # only gets called once
Why do you use 'eval' here?
thanks,
Tobin.
WARNING: multiple messages have this Message-ID (diff)
From: "Tobin C. Harding" <me@tobin.cc>
To: kaiwan.billimoria@gmail.com
Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
kernel-hardening@lists.openwall.com
Subject: [kernel-hardening] Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses
Date: Mon, 4 Dec 2017 11:11:06 +1100 [thread overview]
Message-ID: <20171204001106.GB27780@eros> (raw)
In-Reply-To: <1512133747.17323.3.camel@gmail.com>
On Fri, Dec 01, 2017 at 06:39:07PM +0530, kaiwan.billimoria@gmail.com wrote:
> Hi,
>
> Applies upon the previous one in this thread.
> Found and fixed some minor issues with light testing on a 32-bit x86.
> (I realize this isn't an ideal description, forgive me!).
>
> Have also emitted a 'noisy' warning on PAGE_OFFSET fallback to 0xc00000000.
>
> Signed-off-by: Kaiwan N Billimoria <kaiwan.billimoria@gmail.com>
> ---
> scripts/leaking_addresses.pl | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
> index fcf1ebe0f043..3a8691a642c8 100755
> --- a/scripts/leaking_addresses.pl
> +++ b/scripts/leaking_addresses.pl
> @@ -160,7 +160,6 @@ if (!$input_raw and ($squash_by_path or $squash_by_filename)) {
>
> if (!is_supported_architecture()) {
> show_detected_architecture() if $debug;
> -} else {
> printf "\nScript does not support your architecture, sorry.\n";
> printf "\nCurrently we support: \n\n";
> foreach(@SUPPORTED_ARCHITECTURES) {
> @@ -267,7 +266,7 @@ sub is_false_positive
> sub is_false_positive_ix86_32
> {
> my ($match) = @_;
> - state $page_offset = get_page_offset(); # only gets called once
> + state $page_offset = eval get_page_offset(); # only gets called once
Why do you use 'eval' here?
thanks,
Tobin.
next prev parent reply other threads:[~2017-12-04 0:11 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 6:32 [PATCH] leaking_addresses: add support for 32-bit kernel addresses Tobin C. Harding
2017-11-28 6:32 ` [kernel-hardening] " Tobin C. Harding
2017-11-28 13:16 ` Alexander Kapshuk
2017-11-28 13:16 ` [kernel-hardening] " Alexander Kapshuk
2017-11-28 21:10 ` Tobin C. Harding
2017-11-28 21:10 ` [kernel-hardening] " Tobin C. Harding
2017-11-29 7:59 ` Alexander Kapshuk
2017-11-29 7:59 ` [kernel-hardening] " Alexander Kapshuk
2017-11-29 10:16 ` Tobin C. Harding
2017-11-29 10:16 ` [kernel-hardening] " Tobin C. Harding
2017-11-29 11:02 ` Kaiwan N Billimoria
2017-11-29 11:02 ` [kernel-hardening] " Kaiwan N Billimoria
2017-11-29 20:48 ` Tobin C. Harding
2017-11-29 20:48 ` [kernel-hardening] " Tobin C. Harding
2017-12-01 13:03 ` Kaiwan N Billimoria
2017-12-01 13:03 ` [kernel-hardening] " Kaiwan N Billimoria
2017-12-01 13:09 ` kaiwan.billimoria
2017-12-01 13:09 ` [kernel-hardening] " kaiwan.billimoria
2017-12-04 0:11 ` Tobin C. Harding [this message]
2017-12-04 0:11 ` Tobin C. Harding
2017-12-04 4:41 ` kaiwan.billimoria
2017-12-04 4:41 ` [kernel-hardening] " kaiwan.billimoria
2017-12-04 4:55 ` Tobin C. Harding
2017-12-04 4:55 ` [kernel-hardening] " Tobin C. Harding
2017-12-04 5:09 ` Kaiwan N Billimoria
2017-12-04 5:09 ` [kernel-hardening] " Kaiwan N Billimoria
2017-12-04 5:21 ` Kaiwan N Billimoria
2017-12-04 5:21 ` [kernel-hardening] " Kaiwan N Billimoria
2017-12-04 8:21 ` Tobin C. Harding
2017-12-04 8:21 ` [kernel-hardening] " Tobin C. Harding
2017-12-04 10:20 ` kaiwan.billimoria
2017-12-04 10:20 ` [kernel-hardening] " kaiwan.billimoria
2017-12-04 12:37 ` Alexander Kapshuk
2017-12-04 12:37 ` [kernel-hardening] " Alexander Kapshuk
2017-12-04 13:28 ` Kaiwan N Billimoria
2017-12-04 14:08 ` Kaiwan N Billimoria
2017-12-04 14:08 ` [kernel-hardening] " Kaiwan N Billimoria
2017-12-04 20:59 ` Tobin C. Harding
2017-12-04 20:59 ` [kernel-hardening] " Tobin C. Harding
2017-11-29 11:30 ` Alexander Kapshuk
2017-11-29 11:30 ` [kernel-hardening] " Alexander Kapshuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204001106.GB27780@eros \
--to=me@tobin.cc \
--cc=alexander.kapshuk@gmail.com \
--cc=kaiwan.billimoria@gmail.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.