[PATCH iproute2] iproute2: Fix undeclared __kernel_long_t type build error in RHEL 6.8

* [PATCH iproute2] iproute2: Fix undeclared __kernel_long_t type build error in RHEL 6.8
@ 2017-12-01 11:04 Leon Romanovsky
  2017-12-01 16:48 ` Stephen Hemminger
  2017-12-06  1:33 ` Stephen Hemminger
  0 siblings, 2 replies; 8+ messages in thread
From: Leon Romanovsky @ 2017-12-01 11:04 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: netdev, Leon Romanovsky, Riad Abo Raed, Guy Ergas

From: Leon Romanovsky <leonro@mellanox.com>

Add asm/posix_types.h header file to the list of needed includes,
because the headers files in RHEL 6.8 are too old and doesn't
have declaration of __kernel_long_t.

In file included from ../include/uapi/linux/kernel.h:5,
                 from ../include/uapi/linux/netfilter/x_tables.h:4,
                 from ../include/xtables.h:20,
                 from em_ipset.c:26:
../include/uapi/linux/sysinfo.h:9: error: expected specifier-qualifier-list before ‘__kernel_long_t’

Cc: Riad Abo Raed <riada@mellanox.com>
Cc: Guy Ergas <guye@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
Stephen,
I don't know how to properly solve this type of errors and would like to
hear your guidance on it.

Should I simply add kernel file? Or maybe I need to add HAVE_xxx checks
to configure script to check __kernel_long_t existence and declare only
this type?

I also have another build error on RHEL 6.8 system and looking for a
solution.

In file included from em_ipset.c:26:
../include/xtables.h:35:29: error: xtables-version.h: No such file or directory
make[1]: *** [em_ipset.o] Error 1

The iptables-devel is iptables-devel-1.4.7-16.el6.x86_64 so check_xt()
success, but RH headers don't have xtable-version.h and the relevant defines
are embedded in the main xtables.h header file.

Thanks
---
 include/uapi/asm/posix_types.h | 97 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 97 insertions(+)
 create mode 100644 include/uapi/asm/posix_types.h

diff --git a/include/uapi/asm/posix_types.h b/include/uapi/asm/posix_types.h
new file mode 100644
index 00000000..5e6ea22b
--- /dev/null
+++ b/include/uapi/asm/posix_types.h
@@ -0,0 +1,97 @@
+/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
+#ifndef __ASM_GENERIC_POSIX_TYPES_H
+#define __ASM_GENERIC_POSIX_TYPES_H
+
+#include <asm/bitsperlong.h>
+/*
+ * This file is generally used by user-level software, so you need to
+ * be a little careful about namespace pollution etc.
+ *
+ * First the types that are often defined in different ways across
+ * architectures, so that you can override them.
+ */
+
+#ifndef __kernel_long_t
+typedef long		__kernel_long_t;
+typedef unsigned long	__kernel_ulong_t;
+#endif
+
+#ifndef __kernel_ino_t
+typedef __kernel_ulong_t __kernel_ino_t;
+#endif
+
+#ifndef __kernel_mode_t
+typedef unsigned int	__kernel_mode_t;
+#endif
+
+#ifndef __kernel_pid_t
+typedef int		__kernel_pid_t;
+#endif
+
+#ifndef __kernel_ipc_pid_t
+typedef int		__kernel_ipc_pid_t;
+#endif
+
+#ifndef __kernel_uid_t
+typedef unsigned int	__kernel_uid_t;
+typedef unsigned int	__kernel_gid_t;
+#endif
+
+#ifndef __kernel_suseconds_t
+typedef __kernel_long_t		__kernel_suseconds_t;
+#endif
+
+#ifndef __kernel_daddr_t
+typedef int		__kernel_daddr_t;
+#endif
+
+#ifndef __kernel_uid32_t
+typedef unsigned int	__kernel_uid32_t;
+typedef unsigned int	__kernel_gid32_t;
+#endif
+
+#ifndef __kernel_old_uid_t
+typedef __kernel_uid_t	__kernel_old_uid_t;
+typedef __kernel_gid_t	__kernel_old_gid_t;
+#endif
+
+#ifndef __kernel_old_dev_t
+typedef unsigned int	__kernel_old_dev_t;
+#endif
+
+/*
+ * Most 32 bit architectures use "unsigned int" size_t,
+ * and all 64 bit architectures use "unsigned long" size_t.
+ */
+#ifndef __kernel_size_t
+#if __BITS_PER_LONG != 64
+typedef unsigned int	__kernel_size_t;
+typedef int		__kernel_ssize_t;
+typedef int		__kernel_ptrdiff_t;
+#else
+typedef __kernel_ulong_t __kernel_size_t;
+typedef __kernel_long_t	__kernel_ssize_t;
+typedef __kernel_long_t	__kernel_ptrdiff_t;
+#endif
+#endif
+
+#ifndef __kernel_fsid_t
+typedef struct {
+	int	val[2];
+} __kernel_fsid_t;
+#endif
+
+/*
+ * anything below here should be completely generic
+ */
+typedef __kernel_long_t	__kernel_off_t;
+typedef long long	__kernel_loff_t;
+typedef __kernel_long_t	__kernel_time_t;
+typedef __kernel_long_t	__kernel_clock_t;
+typedef int		__kernel_timer_t;
+typedef int		__kernel_clockid_t;
+typedef char *		__kernel_caddr_t;
+typedef unsigned short	__kernel_uid16_t;
+typedef unsigned short	__kernel_gid16_t;
+
+#endif /* __ASM_GENERIC_POSIX_TYPES_H */

^ permalink raw reply related	[flat|nested] 8+ messages in thread