* [PATCH] xen-netback: Fix logging message with spurious period after newline
@ 2017-12-06 6:40 Joe Perches
2017-12-06 9:30 ` Paul Durrant
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Joe Perches @ 2017-12-06 6:40 UTC (permalink / raw)
To: Wei Liu, Paul Durrant; +Cc: xen-devel, netdev, linux-kernel
Using a period after a newline causes bad output.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/xen-netback/interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index d6dff347f896..78ebe494fef0 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -186,7 +186,7 @@ static int xenvif_start_xmit(struct sk_buff *skb, struct net_device *dev)
/* Obtain the queue to be used to transmit this packet */
index = skb_get_queue_mapping(skb);
if (index >= num_queues) {
- pr_warn_ratelimited("Invalid queue %hu for packet on interface %s\n.",
+ pr_warn_ratelimited("Invalid queue %hu for packet on interface %s\n",
index, vif->dev->name);
index %= num_queues;
}
--
2.15.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] xen-netback: Fix logging message with spurious period after newline
2017-12-06 6:40 [PATCH] xen-netback: Fix logging message with spurious period after newline Joe Perches
@ 2017-12-06 9:30 ` Paul Durrant
2017-12-06 9:30 ` Paul Durrant
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Paul Durrant @ 2017-12-06 9:30 UTC (permalink / raw)
To: 'Joe Perches', Wei Liu; +Cc: xen-devel, linux-kernel, netdev
> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com]
> Sent: 06 December 2017 06:40
> To: Wei Liu <wei.liu2@citrix.com>; Paul Durrant <Paul.Durrant@citrix.com>
> Cc: xen-devel@lists.xenproject.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] xen-netback: Fix logging message with spurious period
> after newline
>
> Using a period after a newline causes bad output.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
> ---
> drivers/net/xen-netback/interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-
> netback/interface.c
> index d6dff347f896..78ebe494fef0 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -186,7 +186,7 @@ static int xenvif_start_xmit(struct sk_buff *skb, struct
> net_device *dev)
> /* Obtain the queue to be used to transmit this packet */
> index = skb_get_queue_mapping(skb);
> if (index >= num_queues) {
> - pr_warn_ratelimited("Invalid queue %hu for packet on
> interface %s\n.",
> + pr_warn_ratelimited("Invalid queue %hu for packet on
> interface %s\n",
> index, vif->dev->name);
> index %= num_queues;
> }
> --
> 2.15.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] xen-netback: Fix logging message with spurious period after newline
2017-12-06 6:40 [PATCH] xen-netback: Fix logging message with spurious period after newline Joe Perches
2017-12-06 9:30 ` Paul Durrant
@ 2017-12-06 9:30 ` Paul Durrant
2017-12-06 20:10 ` David Miller
2017-12-06 20:10 ` David Miller
3 siblings, 0 replies; 6+ messages in thread
From: Paul Durrant @ 2017-12-06 9:30 UTC (permalink / raw)
To: 'Joe Perches', Wei Liu; +Cc: xen-devel, netdev, linux-kernel
> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com]
> Sent: 06 December 2017 06:40
> To: Wei Liu <wei.liu2@citrix.com>; Paul Durrant <Paul.Durrant@citrix.com>
> Cc: xen-devel@lists.xenproject.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] xen-netback: Fix logging message with spurious period
> after newline
>
> Using a period after a newline causes bad output.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
> ---
> drivers/net/xen-netback/interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-
> netback/interface.c
> index d6dff347f896..78ebe494fef0 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -186,7 +186,7 @@ static int xenvif_start_xmit(struct sk_buff *skb, struct
> net_device *dev)
> /* Obtain the queue to be used to transmit this packet */
> index = skb_get_queue_mapping(skb);
> if (index >= num_queues) {
> - pr_warn_ratelimited("Invalid queue %hu for packet on
> interface %s\n.",
> + pr_warn_ratelimited("Invalid queue %hu for packet on
> interface %s\n",
> index, vif->dev->name);
> index %= num_queues;
> }
> --
> 2.15.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] xen-netback: Fix logging message with spurious period after newline
2017-12-06 6:40 [PATCH] xen-netback: Fix logging message with spurious period after newline Joe Perches
2017-12-06 9:30 ` Paul Durrant
2017-12-06 9:30 ` Paul Durrant
@ 2017-12-06 20:10 ` David Miller
2017-12-06 20:10 ` David Miller
3 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2017-12-06 20:10 UTC (permalink / raw)
To: joe; +Cc: xen-devel, paul.durrant, wei.liu2, linux-kernel, netdev
From: Joe Perches <joe@perches.com>
Date: Tue, 5 Dec 2017 22:40:25 -0800
> Using a period after a newline causes bad output.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen-netback: Fix logging message with spurious period after newline
2017-12-06 6:40 [PATCH] xen-netback: Fix logging message with spurious period after newline Joe Perches
` (2 preceding siblings ...)
2017-12-06 20:10 ` David Miller
@ 2017-12-06 20:10 ` David Miller
3 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2017-12-06 20:10 UTC (permalink / raw)
To: joe; +Cc: wei.liu2, paul.durrant, xen-devel, netdev, linux-kernel
From: Joe Perches <joe@perches.com>
Date: Tue, 5 Dec 2017 22:40:25 -0800
> Using a period after a newline causes bad output.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] xen-netback: Fix logging message with spurious period after newline
@ 2017-12-06 6:40 Joe Perches
0 siblings, 0 replies; 6+ messages in thread
From: Joe Perches @ 2017-12-06 6:40 UTC (permalink / raw)
To: Wei Liu, Paul Durrant; +Cc: xen-devel, linux-kernel, netdev
Using a period after a newline causes bad output.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/xen-netback/interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index d6dff347f896..78ebe494fef0 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -186,7 +186,7 @@ static int xenvif_start_xmit(struct sk_buff *skb, struct net_device *dev)
/* Obtain the queue to be used to transmit this packet */
index = skb_get_queue_mapping(skb);
if (index >= num_queues) {
- pr_warn_ratelimited("Invalid queue %hu for packet on interface %s\n.",
+ pr_warn_ratelimited("Invalid queue %hu for packet on interface %s\n",
index, vif->dev->name);
index %= num_queues;
}
--
2.15.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-12-06 20:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-06 6:40 [PATCH] xen-netback: Fix logging message with spurious period after newline Joe Perches
2017-12-06 9:30 ` Paul Durrant
2017-12-06 9:30 ` Paul Durrant
2017-12-06 20:10 ` David Miller
2017-12-06 20:10 ` David Miller
2017-12-06 6:40 Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.