From: Dave Chinner <david@fromorbit.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>, Jan Kara <jack@suse.cz>,
fstests <fstests@vger.kernel.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [xfsprogs PATCH v2 3/3] xfs_io: add a new 'log_writes' command
Date: Wed, 6 Dec 2017 11:29:46 +1100 [thread overview]
Message-ID: <20171206002946.GD5858@dastard> (raw)
In-Reply-To: <20171205235651.17102-4-ross.zwisler@linux.intel.com>
On Tue, Dec 05, 2017 at 04:56:51PM -0700, Ross Zwisler wrote:
> Add a new 'log_writes' command to xfs_io so that we can add dm-log-writes
> log marks. It's helpful to allow users of xfs_io to adds these marks from
> within xfs_io instead of waiting until after xfs_io exits because then they
> are able to replay the dm-log-writes log up to immediately after another
> xfs_io operation such as mwrite. This isolates the log replay from other
> operations that happen as part of xfs_io exiting (file handles being
> closed, mmaps being torn down, etc.). This also allows users to insert
> multiple marks between different xfs_io commands.
>
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Suggested-by: Dave Chinner <david@fromorbit.com>
having just looked at the xfs_io mess, this new command needs to set
"exitcode = 1" on failure. I haven't looked at anything else in the
patch.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
fstests <fstests@vger.kernel.org>, Jan Kara <jack@suse.cz>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [xfsprogs PATCH v2 3/3] xfs_io: add a new 'log_writes' command
Date: Wed, 6 Dec 2017 11:29:46 +1100 [thread overview]
Message-ID: <20171206002946.GD5858@dastard> (raw)
In-Reply-To: <20171205235651.17102-4-ross.zwisler@linux.intel.com>
On Tue, Dec 05, 2017 at 04:56:51PM -0700, Ross Zwisler wrote:
> Add a new 'log_writes' command to xfs_io so that we can add dm-log-writes
> log marks. It's helpful to allow users of xfs_io to adds these marks from
> within xfs_io instead of waiting until after xfs_io exits because then they
> are able to replay the dm-log-writes log up to immediately after another
> xfs_io operation such as mwrite. This isolates the log replay from other
> operations that happen as part of xfs_io exiting (file handles being
> closed, mmaps being torn down, etc.). This also allows users to insert
> multiple marks between different xfs_io commands.
>
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Suggested-by: Dave Chinner <david@fromorbit.com>
having just looked at the xfs_io mess, this new command needs to set
"exitcode = 1" on failure. I haven't looked at anything else in the
patch.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2017-12-06 0:25 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 23:56 [xfsprogs PATCH v2 0/3] Add necessary items for MAP_SYNC testing Ross Zwisler
2017-12-05 23:56 ` Ross Zwisler
2017-12-05 23:56 ` [xfsprogs PATCH v2 1/3] xfs_io: fix compiler warnings in getfsmap code Ross Zwisler
2017-12-05 23:56 ` Ross Zwisler
2017-12-06 0:03 ` Darrick J. Wong
2017-12-06 0:03 ` Darrick J. Wong
2017-12-06 0:27 ` Dave Chinner
2017-12-06 0:27 ` Dave Chinner
2017-12-06 13:59 ` Eric Sandeen
2017-12-06 13:59 ` Eric Sandeen
2017-12-06 20:10 ` Ross Zwisler
2017-12-06 20:10 ` Ross Zwisler
2017-12-06 20:47 ` Darrick J. Wong
2017-12-06 20:47 ` Darrick J. Wong
2017-12-06 20:58 ` Ross Zwisler
2017-12-06 20:58 ` Ross Zwisler
2017-12-05 23:56 ` [xfsprogs PATCH v2 2/3] xfs_io: add MAP_SYNC support to mmap() Ross Zwisler
2017-12-05 23:56 ` Ross Zwisler
2017-12-21 17:09 ` Darrick J. Wong
2017-12-21 17:09 ` Darrick J. Wong
2017-12-21 17:41 ` Ross Zwisler
2017-12-21 17:41 ` Ross Zwisler
2017-12-21 17:46 ` Darrick J. Wong
2017-12-21 17:46 ` Darrick J. Wong
2017-12-05 23:56 ` [xfsprogs PATCH v2 3/3] xfs_io: add a new 'log_writes' command Ross Zwisler
2017-12-05 23:56 ` Ross Zwisler
2017-12-06 0:29 ` Dave Chinner [this message]
2017-12-06 0:29 ` Dave Chinner
2017-12-06 4:38 ` Ross Zwisler
2017-12-06 4:38 ` Ross Zwisler
2017-12-06 4:41 ` Ross Zwisler
2017-12-06 4:41 ` Ross Zwisler
2017-12-06 5:43 ` Dave Chinner
2017-12-06 5:43 ` Dave Chinner
2017-12-06 18:13 ` [xfsprogs PATCH v3 " Ross Zwisler
2017-12-06 18:13 ` Ross Zwisler
2017-12-21 17:14 ` Darrick J. Wong
2017-12-21 17:14 ` Darrick J. Wong
2017-12-13 16:45 ` [xfsprogs PATCH v2 0/3] Add necessary items for MAP_SYNC testing Ross Zwisler
2017-12-13 16:45 ` Ross Zwisler
2017-12-21 16:55 ` Ross Zwisler
2017-12-21 16:55 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171206002946.GD5858@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.