All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: dmaengine@vger.kernel.org, timur@codeaurora.org,
	devicetree@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V6 3/7] device property: Introduce a common API to fetch device match data
Date: Fri, 8 Dec 2017 00:06:42 +0200	[thread overview]
Message-ID: <20171207220642.qqiwf4vvk2gf42uf@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <c2b38889-888a-3518-bf59-c2377f64a8ce@codeaurora.org>

On Thu, Dec 07, 2017 at 03:17:52PM -0500, Sinan Kaya wrote:
> On 12/7/2017 7:40 AM, Sakari Ailus wrote:
> > On Tue, Dec 05, 2017 at 12:04:48PM -0500, Sinan Kaya wrote:
> >> @@ -101,6 +103,8 @@ struct fwnode_operations {
> >>  	(*graph_get_port_parent)(struct fwnode_handle *fwnode);
> >>  	int (*graph_parse_endpoint)(const struct fwnode_handle *fwnode,
> >>  				    struct fwnode_endpoint *endpoint);
> >> +	void *(*get_match_data)(const struct fwnode_handle *fwnode,
> >> +				struct device *dev);
> > 
> > You can make dev const, too.
> > 
> 
> done, I couldn't change device_get_match_data() parameter const due to
> dev_fwnode() function.
> 
>                  from /local/mnt/workspace/projects/caf/kernel/drivers/base/property.c:13:
> 
> /local/mnt/workspace/projects/caf/kernel/drivers/base/property.c:1341:39: warning: passing argument 1 of 'dev_fwnode' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>   return fwnode_call_ptr_op(dev_fwnode(dev), device_get_match_data,

Right. Makes sense.

I guess it's not perhaps worth it introducing dev_fwnode_const just for
this. devices are seldom if ever const anyway.

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi

WARNING: multiple messages have this Message-ID (diff)
From: sakari.ailus@iki.fi (Sakari Ailus)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V6 3/7] device property: Introduce a common API to fetch device match data
Date: Fri, 8 Dec 2017 00:06:42 +0200	[thread overview]
Message-ID: <20171207220642.qqiwf4vvk2gf42uf@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <c2b38889-888a-3518-bf59-c2377f64a8ce@codeaurora.org>

On Thu, Dec 07, 2017 at 03:17:52PM -0500, Sinan Kaya wrote:
> On 12/7/2017 7:40 AM, Sakari Ailus wrote:
> > On Tue, Dec 05, 2017 at 12:04:48PM -0500, Sinan Kaya wrote:
> >> @@ -101,6 +103,8 @@ struct fwnode_operations {
> >>  	(*graph_get_port_parent)(struct fwnode_handle *fwnode);
> >>  	int (*graph_parse_endpoint)(const struct fwnode_handle *fwnode,
> >>  				    struct fwnode_endpoint *endpoint);
> >> +	void *(*get_match_data)(const struct fwnode_handle *fwnode,
> >> +				struct device *dev);
> > 
> > You can make dev const, too.
> > 
> 
> done, I couldn't change device_get_match_data() parameter const due to
> dev_fwnode() function.
> 
>                  from /local/mnt/workspace/projects/caf/kernel/drivers/base/property.c:13:
> 
> /local/mnt/workspace/projects/caf/kernel/drivers/base/property.c:1341:39: warning: passing argument 1 of 'dev_fwnode' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>   return fwnode_call_ptr_op(dev_fwnode(dev), device_get_match_data,

Right. Makes sense.

I guess it's not perhaps worth it introducing dev_fwnode_const just for
this. devices are seldom if ever const anyway.

-- 
Sakari Ailus
e-mail: sakari.ailus at iki.fi

  reply	other threads:[~2017-12-07 22:06 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 17:04 [PATCH V6 0/7] dmaengine: qcom_hidma: add support for bugfixed HW Sinan Kaya
2017-12-05 17:04 ` Sinan Kaya
     [not found] ` <1512493493-6464-1-git-send-email-okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-12-05 17:04   ` [PATCH V6 1/7] Documentation: DT: qcom_hidma: Bump HW revision for the " Sinan Kaya
2017-12-05 17:04     ` Sinan Kaya
2017-12-05 17:04     ` Sinan Kaya
2017-12-05 17:04 ` [PATCH V6 2/7] ACPI / bus: Introduce acpi_get_match_data() function Sinan Kaya
2017-12-05 17:04   ` Sinan Kaya
2017-12-05 17:04   ` Sinan Kaya
2017-12-05 22:04   ` Rafael J. Wysocki
2017-12-05 22:04     ` Rafael J. Wysocki
2017-12-05 22:04     ` Rafael J. Wysocki
2017-12-06 16:41     ` Sinan Kaya
2017-12-06 16:41       ` Sinan Kaya
2017-12-06 16:41       ` Sinan Kaya
2017-12-05 17:04 ` [PATCH V6 3/7] device property: Introduce a common API to fetch device match data Sinan Kaya
2017-12-05 17:04   ` Sinan Kaya
2017-12-05 17:04   ` Sinan Kaya
2017-12-07 12:29   ` Sakari Ailus
2017-12-07 12:29     ` Sakari Ailus
2017-12-07 20:15     ` Sinan Kaya
2017-12-07 20:15       ` Sinan Kaya
2017-12-07 12:40   ` Sakari Ailus
2017-12-07 12:40     ` Sakari Ailus
2017-12-07 20:17     ` Sinan Kaya
2017-12-07 20:17       ` Sinan Kaya
2017-12-07 22:06       ` Sakari Ailus [this message]
2017-12-07 22:06         ` Sakari Ailus
2017-12-07 22:19         ` Rafael J. Wysocki
2017-12-07 22:19           ` Rafael J. Wysocki
2017-12-07 22:19           ` Rafael J. Wysocki
     [not found]           ` <CAJZ5v0inHMCLGyPaAeuJNo2VH7f3Th0KdpT2UkPBCsvrSDi0gQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-14 10:28             ` Sakari Ailus
2017-12-14 10:28               ` Sakari Ailus
2017-12-14 10:28               ` Sakari Ailus
2017-12-05 17:04 ` [PATCH V6 4/7] OF: properties: Implement get_match_data() callback Sinan Kaya
2017-12-05 17:04   ` Sinan Kaya
2017-12-05 17:04   ` Sinan Kaya
2017-12-05 21:21   ` Rob Herring
2017-12-05 21:21     ` Rob Herring
2017-12-05 21:21     ` Rob Herring
2017-12-07 12:38   ` Sakari Ailus
2017-12-07 12:38     ` Sakari Ailus
2017-12-07 13:10   ` Lothar Waßmann
2017-12-07 13:10     ` Lothar Waßmann
2017-12-07 13:10     ` Lothar Waßmann
2017-12-07 14:45     ` Sinan Kaya
2017-12-07 14:45       ` Sinan Kaya
     [not found]       ` <def8e351-bc2d-7adc-fdc5-362b365302a8-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-12-07 15:20         ` Lothar Waßmann
2017-12-07 15:20           ` Lothar Waßmann
2017-12-07 15:20           ` Lothar Waßmann
2017-12-07 17:50           ` Sinan Kaya
2017-12-07 17:50             ` Sinan Kaya
2017-12-08  8:09             ` Lothar Waßmann
2017-12-08  8:09               ` Lothar Waßmann
2017-12-08  9:11             ` Lothar Waßmann
2017-12-08  9:11               ` Lothar Waßmann
2017-12-08 14:33               ` Sinan Kaya
2017-12-08 14:33                 ` Sinan Kaya
2017-12-08 14:40                 ` Sinan Kaya
2017-12-08 14:40                   ` Sinan Kaya
2017-12-05 17:04 ` [PATCH V6 5/7] ACPI: " Sinan Kaya
2017-12-05 17:04   ` Sinan Kaya
2017-12-05 17:04   ` Sinan Kaya
2017-12-05 17:04 ` [PATCH V6 6/7] dmaengine: qcom_hidma: Add support for the new revision Sinan Kaya
2017-12-05 17:04   ` Sinan Kaya
2017-12-05 17:04   ` Sinan Kaya
2017-12-05 17:04 ` [PATCH V6 7/7] dmaengine: qcom_hidma: Add identity register support Sinan Kaya
2017-12-05 17:04   ` Sinan Kaya
2017-12-05 17:04   ` Sinan Kaya
2017-12-05 22:05 ` [PATCH V6 0/7] dmaengine: qcom_hidma: add support for bugfixed HW Rafael J. Wysocki
2017-12-05 22:05   ` Rafael J. Wysocki
2017-12-07 12:41   ` Sakari Ailus
2017-12-07 12:41     ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171207220642.qqiwf4vvk2gf42uf@valkosipuli.retiisi.org.uk \
    --to=sakari.ailus@iki.fi \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=okaya@codeaurora.org \
    --cc=rjw@rjwysocki.net \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.