From: Sinan Kaya <okaya@codeaurora.org>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: dmaengine@vger.kernel.org, timur@codeaurora.org,
devicetree@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback
Date: Thu, 7 Dec 2017 09:45:31 -0500 [thread overview]
Message-ID: <def8e351-bc2d-7adc-fdc5-362b365302a8@codeaurora.org> (raw)
In-Reply-To: <20171207141029.575c0a03@karo-electronics.de>
On 12/7/2017 8:10 AM, Lothar Waßmann wrote:
>> +void *of_fwnode_get_match_data(const struct fwnode_handle *fwnode,
>> + struct device *dev)
> Shouldn't this be 'const void *of_fwnode_get_match_data
OF keeps the driver data as a (const void*) internally. ACPI keeps the
driver data as kernel_ulong_t in struct acpi_device_id.
I tried to find the middle ground here by converting output to void*
but not keeping const.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback
Date: Thu, 7 Dec 2017 09:45:31 -0500 [thread overview]
Message-ID: <def8e351-bc2d-7adc-fdc5-362b365302a8@codeaurora.org> (raw)
In-Reply-To: <20171207141029.575c0a03@karo-electronics.de>
On 12/7/2017 8:10 AM, Lothar Wa?mann wrote:
>> +void *of_fwnode_get_match_data(const struct fwnode_handle *fwnode,
>> + struct device *dev)
> Shouldn't this be 'const void *of_fwnode_get_match_data
OF keeps the driver data as a (const void*) internally. ACPI keeps the
driver data as kernel_ulong_t in struct acpi_device_id.
I tried to find the middle ground here by converting output to void*
but not keeping const.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-12-07 14:45 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 17:04 [PATCH V6 0/7] dmaengine: qcom_hidma: add support for bugfixed HW Sinan Kaya
2017-12-05 17:04 ` Sinan Kaya
[not found] ` <1512493493-6464-1-git-send-email-okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-12-05 17:04 ` [PATCH V6 1/7] Documentation: DT: qcom_hidma: Bump HW revision for the " Sinan Kaya
2017-12-05 17:04 ` Sinan Kaya
2017-12-05 17:04 ` Sinan Kaya
2017-12-05 17:04 ` [PATCH V6 2/7] ACPI / bus: Introduce acpi_get_match_data() function Sinan Kaya
2017-12-05 17:04 ` Sinan Kaya
2017-12-05 17:04 ` Sinan Kaya
2017-12-05 22:04 ` Rafael J. Wysocki
2017-12-05 22:04 ` Rafael J. Wysocki
2017-12-05 22:04 ` Rafael J. Wysocki
2017-12-06 16:41 ` Sinan Kaya
2017-12-06 16:41 ` Sinan Kaya
2017-12-06 16:41 ` Sinan Kaya
2017-12-05 17:04 ` [PATCH V6 3/7] device property: Introduce a common API to fetch device match data Sinan Kaya
2017-12-05 17:04 ` Sinan Kaya
2017-12-05 17:04 ` Sinan Kaya
2017-12-07 12:29 ` Sakari Ailus
2017-12-07 12:29 ` Sakari Ailus
2017-12-07 20:15 ` Sinan Kaya
2017-12-07 20:15 ` Sinan Kaya
2017-12-07 12:40 ` Sakari Ailus
2017-12-07 12:40 ` Sakari Ailus
2017-12-07 20:17 ` Sinan Kaya
2017-12-07 20:17 ` Sinan Kaya
2017-12-07 22:06 ` Sakari Ailus
2017-12-07 22:06 ` Sakari Ailus
2017-12-07 22:19 ` Rafael J. Wysocki
2017-12-07 22:19 ` Rafael J. Wysocki
2017-12-07 22:19 ` Rafael J. Wysocki
[not found] ` <CAJZ5v0inHMCLGyPaAeuJNo2VH7f3Th0KdpT2UkPBCsvrSDi0gQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-14 10:28 ` Sakari Ailus
2017-12-14 10:28 ` Sakari Ailus
2017-12-14 10:28 ` Sakari Ailus
2017-12-05 17:04 ` [PATCH V6 4/7] OF: properties: Implement get_match_data() callback Sinan Kaya
2017-12-05 17:04 ` Sinan Kaya
2017-12-05 17:04 ` Sinan Kaya
2017-12-05 21:21 ` Rob Herring
2017-12-05 21:21 ` Rob Herring
2017-12-05 21:21 ` Rob Herring
2017-12-07 12:38 ` Sakari Ailus
2017-12-07 12:38 ` Sakari Ailus
2017-12-07 13:10 ` Lothar Waßmann
2017-12-07 13:10 ` Lothar Waßmann
2017-12-07 13:10 ` Lothar Waßmann
2017-12-07 14:45 ` Sinan Kaya [this message]
2017-12-07 14:45 ` Sinan Kaya
[not found] ` <def8e351-bc2d-7adc-fdc5-362b365302a8-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-12-07 15:20 ` Lothar Waßmann
2017-12-07 15:20 ` Lothar Waßmann
2017-12-07 15:20 ` Lothar Waßmann
2017-12-07 17:50 ` Sinan Kaya
2017-12-07 17:50 ` Sinan Kaya
2017-12-08 8:09 ` Lothar Waßmann
2017-12-08 8:09 ` Lothar Waßmann
2017-12-08 9:11 ` Lothar Waßmann
2017-12-08 9:11 ` Lothar Waßmann
2017-12-08 14:33 ` Sinan Kaya
2017-12-08 14:33 ` Sinan Kaya
2017-12-08 14:40 ` Sinan Kaya
2017-12-08 14:40 ` Sinan Kaya
2017-12-05 17:04 ` [PATCH V6 5/7] ACPI: " Sinan Kaya
2017-12-05 17:04 ` Sinan Kaya
2017-12-05 17:04 ` Sinan Kaya
2017-12-05 17:04 ` [PATCH V6 6/7] dmaengine: qcom_hidma: Add support for the new revision Sinan Kaya
2017-12-05 17:04 ` Sinan Kaya
2017-12-05 17:04 ` Sinan Kaya
2017-12-05 17:04 ` [PATCH V6 7/7] dmaengine: qcom_hidma: Add identity register support Sinan Kaya
2017-12-05 17:04 ` Sinan Kaya
2017-12-05 17:04 ` Sinan Kaya
2017-12-05 22:05 ` [PATCH V6 0/7] dmaengine: qcom_hidma: add support for bugfixed HW Rafael J. Wysocki
2017-12-05 22:05 ` Rafael J. Wysocki
2017-12-07 12:41 ` Sakari Ailus
2017-12-07 12:41 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=def8e351-bc2d-7adc-fdc5-362b365302a8@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=LW@KARO-electronics.de \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.