* [Buildroot] [PATCH 1/1] janus-gateway: add RTSP streaming support.
@ 2017-12-05 13:10 Adam Duskett
2017-12-05 18:40 ` Baruch Siach
0 siblings, 1 reply; 5+ messages in thread
From: Adam Duskett @ 2017-12-05 13:10 UTC (permalink / raw)
To: buildroot
The streaming protocol works without libcurl via RTP, but if a user wishes to
stream via RTSP, libcurl must be built first.
Signed-off-by: Adam Duskett <aduskett@gmail.com>
---
package/janus-gateway/Config.in | 8 +++++++-
package/janus-gateway/janus-gateway.mk | 4 ++++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/package/janus-gateway/Config.in b/package/janus-gateway/Config.in
index 5bd4e9586b..ed68e270d6 100644
--- a/package/janus-gateway/Config.in
+++ b/package/janus-gateway/Config.in
@@ -38,6 +38,12 @@ config BR2_PACKAGE_JANUS_STREAMING
# SO_REUSEPORT
depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9
+if BR2_PACKAGE_JANUS_STREAMING
+config BR2_PACKAGE_JANUS_STREAMING_RTSP
+ bool "RTSP streaming"
+ select BR2_PACKAGE_LIBCURL
+endif
+
comment "streaming plugin needs a toolchain w/ headers >= 3.9"
depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9
@@ -90,7 +96,7 @@ config BR2_PACKAGE_JANUS_WEBSOCKETS
depends on BR2_USE_MMU
select BR2_PACKAGE_LIBWEBSOCKETS
-endif
+endif #BR2_PACKAGE_JANUS_GATEWAY
comment "janus-gateway needs a toolchain w/ dynamic library, threads, wchar"
depends on BR2_USE_MMU
diff --git a/package/janus-gateway/janus-gateway.mk b/package/janus-gateway/janus-gateway.mk
index bf3e590ac5..be31c465f8 100644
--- a/package/janus-gateway/janus-gateway.mk
+++ b/package/janus-gateway/janus-gateway.mk
@@ -58,6 +58,10 @@ else
JANUS_GATEWAY_CONF_OPTS += --disable-plugin-streaming
endif
+ifeq ($(BR2_PACKAGE_JANUS_STREAMING_RTSP),y)
+JANUS_GATEWAY_DEPENDENCIES += libcurl
+endif
+
ifeq ($(BR2_PACKAGE_JANUS_TEXT_ROOM),y)
JANUS_GATEWAY_CONF_OPTS += --enable-plugin-textroom
else
--
2.14.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] janus-gateway: add RTSP streaming support.
2017-12-05 13:10 [Buildroot] [PATCH 1/1] janus-gateway: add RTSP streaming support Adam Duskett
@ 2017-12-05 18:40 ` Baruch Siach
2017-12-12 11:30 ` Adam Duskett
0 siblings, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2017-12-05 18:40 UTC (permalink / raw)
To: buildroot
Hi Adam,
On Tue, Dec 05, 2017 at 08:10:05AM -0500, Adam Duskett wrote:
> The streaming protocol works without libcurl via RTP, but if a user wishes to
> stream via RTSP, libcurl must be built first.
>
> Signed-off-by: Adam Duskett <aduskett@gmail.com>
> ---
> package/janus-gateway/Config.in | 8 +++++++-
> package/janus-gateway/janus-gateway.mk | 4 ++++
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/package/janus-gateway/Config.in b/package/janus-gateway/Config.in
> index 5bd4e9586b..ed68e270d6 100644
> --- a/package/janus-gateway/Config.in
> +++ b/package/janus-gateway/Config.in
> @@ -38,6 +38,12 @@ config BR2_PACKAGE_JANUS_STREAMING
> # SO_REUSEPORT
> depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9
>
> +if BR2_PACKAGE_JANUS_STREAMING
> +config BR2_PACKAGE_JANUS_STREAMING_RTSP
> + bool "RTSP streaming"
> + select BR2_PACKAGE_LIBCURL
> +endif
> +
> comment "streaming plugin needs a toolchain w/ headers >= 3.9"
> depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9
>
> @@ -90,7 +96,7 @@ config BR2_PACKAGE_JANUS_WEBSOCKETS
> depends on BR2_USE_MMU
> select BR2_PACKAGE_LIBWEBSOCKETS
>
> -endif
> +endif #BR2_PACKAGE_JANUS_GATEWAY
>
> comment "janus-gateway needs a toolchain w/ dynamic library, threads, wchar"
> depends on BR2_USE_MMU
> diff --git a/package/janus-gateway/janus-gateway.mk b/package/janus-gateway/janus-gateway.mk
> index bf3e590ac5..be31c465f8 100644
> --- a/package/janus-gateway/janus-gateway.mk
> +++ b/package/janus-gateway/janus-gateway.mk
> @@ -58,6 +58,10 @@ else
> JANUS_GATEWAY_CONF_OPTS += --disable-plugin-streaming
> endif
>
> +ifeq ($(BR2_PACKAGE_JANUS_STREAMING_RTSP),y)
> +JANUS_GATEWAY_DEPENDENCIES += libcurl
> +endif
Is there a way to disable RTSP? If not, RTSP will be enabled whenever libcurl
happens to build before janus-gateway, right? So maybe having libcurl as a
usual optional dependency would be better.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 1/1] janus-gateway: add RTSP streaming support.
2017-12-05 18:40 ` Baruch Siach
@ 2017-12-12 11:30 ` Adam Duskett
2017-12-12 18:58 ` Baruch Siach
2017-12-13 13:33 ` Thomas Petazzoni
0 siblings, 2 replies; 5+ messages in thread
From: Adam Duskett @ 2017-12-12 11:30 UTC (permalink / raw)
To: buildroot
Hi Barauch;
On Tue, Dec 5, 2017 at 1:40 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Adam,
>
> On Tue, Dec 05, 2017 at 08:10:05AM -0500, Adam Duskett wrote:
>> The streaming protocol works without libcurl via RTP, but if a user wishes to
>> stream via RTSP, libcurl must be built first.
>>
>> Signed-off-by: Adam Duskett <aduskett@gmail.com>
>> ---
>> package/janus-gateway/Config.in | 8 +++++++-
>> package/janus-gateway/janus-gateway.mk | 4 ++++
>> 2 files changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/janus-gateway/Config.in b/package/janus-gateway/Config.in
>> index 5bd4e9586b..ed68e270d6 100644
>> --- a/package/janus-gateway/Config.in
>> +++ b/package/janus-gateway/Config.in
>> @@ -38,6 +38,12 @@ config BR2_PACKAGE_JANUS_STREAMING
>> # SO_REUSEPORT
>> depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9
>>
>> +if BR2_PACKAGE_JANUS_STREAMING
>> +config BR2_PACKAGE_JANUS_STREAMING_RTSP
>> + bool "RTSP streaming"
>> + select BR2_PACKAGE_LIBCURL
>> +endif
>> +
>> comment "streaming plugin needs a toolchain w/ headers >= 3.9"
>> depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9
>>
>> @@ -90,7 +96,7 @@ config BR2_PACKAGE_JANUS_WEBSOCKETS
>> depends on BR2_USE_MMU
>> select BR2_PACKAGE_LIBWEBSOCKETS
>>
>> -endif
>> +endif #BR2_PACKAGE_JANUS_GATEWAY
>>
>> comment "janus-gateway needs a toolchain w/ dynamic library, threads, wchar"
>> depends on BR2_USE_MMU
>> diff --git a/package/janus-gateway/janus-gateway.mk b/package/janus-gateway/janus-gateway.mk
>> index bf3e590ac5..be31c465f8 100644
>> --- a/package/janus-gateway/janus-gateway.mk
>> +++ b/package/janus-gateway/janus-gateway.mk
>> @@ -58,6 +58,10 @@ else
>> JANUS_GATEWAY_CONF_OPTS += --disable-plugin-streaming
>> endif
>>
>> +ifeq ($(BR2_PACKAGE_JANUS_STREAMING_RTSP),y)
>> +JANUS_GATEWAY_DEPENDENCIES += libcurl
>> +endif
>
> Is there a way to disable RTSP? If not, RTSP will be enabled whenever libcurl
> happens to build before janus-gateway, right? So maybe having libcurl as a
> usual optional dependency would be better.
>
> baruch
>
There isn't a way to disable RTSP, however, I am not sure the best way
to go about this.
I like being able to just select an option and have it select the dependency.
What would you suggest? Just "if libcurl is selected depend on it" ?
> --
> http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 1/1] janus-gateway: add RTSP streaming support.
2017-12-12 11:30 ` Adam Duskett
@ 2017-12-12 18:58 ` Baruch Siach
2017-12-13 13:33 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Baruch Siach @ 2017-12-12 18:58 UTC (permalink / raw)
To: buildroot
Hi Adam,
On Tue, Dec 12, 2017 at 06:30:42AM -0500, Adam Duskett wrote:
> On Tue, Dec 5, 2017 at 1:40 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> > On Tue, Dec 05, 2017 at 08:10:05AM -0500, Adam Duskett wrote:
[...]
> >> +ifeq ($(BR2_PACKAGE_JANUS_STREAMING_RTSP),y)
> >> +JANUS_GATEWAY_DEPENDENCIES += libcurl
> >> +endif
> >
> > Is there a way to disable RTSP? If not, RTSP will be enabled whenever libcurl
> > happens to build before janus-gateway, right? So maybe having libcurl as a
> > usual optional dependency would be better.
>
> There isn't a way to disable RTSP, however, I am not sure the best way
> to go about this.
> I like being able to just select an option and have it select the dependency.
>
> What would you suggest? Just "if libcurl is selected depend on it" ?
I think so. A comment in the Config.in help text might be useful in that case.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 1/1] janus-gateway: add RTSP streaming support.
2017-12-12 11:30 ` Adam Duskett
2017-12-12 18:58 ` Baruch Siach
@ 2017-12-13 13:33 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2017-12-13 13:33 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 12 Dec 2017 06:30:42 -0500, Adam Duskett wrote:
> >> comment "janus-gateway needs a toolchain w/ dynamic library, threads, wchar"
> >> depends on BR2_USE_MMU
> >> diff --git a/package/janus-gateway/janus-gateway.mk b/package/janus-gateway/janus-gateway.mk
> >> index bf3e590ac5..be31c465f8 100644
> >> --- a/package/janus-gateway/janus-gateway.mk
> >> +++ b/package/janus-gateway/janus-gateway.mk
> >> @@ -58,6 +58,10 @@ else
> >> JANUS_GATEWAY_CONF_OPTS += --disable-plugin-streaming
> >> endif
> >>
> >> +ifeq ($(BR2_PACKAGE_JANUS_STREAMING_RTSP),y)
> >> +JANUS_GATEWAY_DEPENDENCIES += libcurl
> >> +endif
> >
> > Is there a way to disable RTSP? If not, RTSP will be enabled whenever libcurl
> > happens to build before janus-gateway, right? So maybe having libcurl as a
> > usual optional dependency would be better.
> >
> > baruch
> >
> There isn't a way to disable RTSP, however, I am not sure the best way
> to go about this.
> I like being able to just select an option and have it select the dependency.
>
> What would you suggest? Just "if libcurl is selected depend on it" ?
Note: I agree with Baruch on this. If you have an option to enable RTSP
support, then RTSP support should be disabled if the option is
disabled. Since this is not possible with janus-gateway build system,
then you should simply add libcurl as a dependency if
BR2_PACKAGE_LIBCURL=y.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-13 13:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-05 13:10 [Buildroot] [PATCH 1/1] janus-gateway: add RTSP streaming support Adam Duskett
2017-12-05 18:40 ` Baruch Siach
2017-12-12 11:30 ` Adam Duskett
2017-12-12 18:58 ` Baruch Siach
2017-12-13 13:33 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.