* [PATCH][next] net: phy: meson-gxl: make function meson_gxl_read_status static
@ 2017-12-12 13:03 ` Colin King
0 siblings, 0 replies; 12+ messages in thread
From: Colin King @ 2017-12-12 13:03 UTC (permalink / raw)
To: linus-amlogic
From: Colin Ian King <colin.king@canonical.com>
The function meson_gxl_read_status is local to the source and does
not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'meson_gxl_read_status' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/phy/meson-gxl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
index c64b81e50f60..4ee630afe43a 100644
--- a/drivers/net/phy/meson-gxl.c
+++ b/drivers/net/phy/meson-gxl.c
@@ -67,7 +67,7 @@ static int meson_gxl_config_init(struct phy_device *phydev)
* When this failure happens, the first retry is usually successful but,
* in some cases, it may take up to 6 retries to get a decent result
*/
-int meson_gxl_read_status(struct phy_device *phydev)
+static int meson_gxl_read_status(struct phy_device *phydev)
{
int ret, wol, lpa, exp;
--
2.14.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH][next] net: phy: meson-gxl: make function meson_gxl_read_status static
@ 2017-12-12 13:03 ` Colin King
0 siblings, 0 replies; 12+ messages in thread
From: Colin King @ 2017-12-12 13:03 UTC (permalink / raw)
To: linux-arm-kernel
From: Colin Ian King <colin.king@canonical.com>
The function meson_gxl_read_status is local to the source and does
not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'meson_gxl_read_status' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/phy/meson-gxl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
index c64b81e50f60..4ee630afe43a 100644
--- a/drivers/net/phy/meson-gxl.c
+++ b/drivers/net/phy/meson-gxl.c
@@ -67,7 +67,7 @@ static int meson_gxl_config_init(struct phy_device *phydev)
* When this failure happens, the first retry is usually successful but,
* in some cases, it may take up to 6 retries to get a decent result
*/
-int meson_gxl_read_status(struct phy_device *phydev)
+static int meson_gxl_read_status(struct phy_device *phydev)
{
int ret, wol, lpa, exp;
--
2.14.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH][next] net: phy: meson-gxl: make function meson_gxl_read_status static
@ 2017-12-12 13:03 ` Colin King
0 siblings, 0 replies; 12+ messages in thread
From: Colin King @ 2017-12-12 13:03 UTC (permalink / raw)
To: linus-amlogic
From: Colin Ian King <colin.king@canonical.com>
The function meson_gxl_read_status is local to the source and does
not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'meson_gxl_read_status' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/phy/meson-gxl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
index c64b81e50f60..4ee630afe43a 100644
--- a/drivers/net/phy/meson-gxl.c
+++ b/drivers/net/phy/meson-gxl.c
@@ -67,7 +67,7 @@ static int meson_gxl_config_init(struct phy_device *phydev)
* When this failure happens, the first retry is usually successful but,
* in some cases, it may take up to 6 retries to get a decent result
*/
-int meson_gxl_read_status(struct phy_device *phydev)
+static int meson_gxl_read_status(struct phy_device *phydev)
{
int ret, wol, lpa, exp;
--
2.14.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH][next] net: phy: meson-gxl: make function meson_gxl_read_status static
2017-12-12 13:03 ` Colin King
(?)
(?)
@ 2017-12-12 14:20 ` Jerome Brunet
-1 siblings, 0 replies; 12+ messages in thread
From: Jerome Brunet @ 2017-12-12 14:20 UTC (permalink / raw)
To: Colin King, Andrew Lunn, Florian Fainelli, Carlo Caione,
Kevin Hilman, netdev, linux-arm-kernel, linux-amlogic
Cc: kernel-janitors, linux-kernel
On Tue, 2017-12-12 at 13:03 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function meson_gxl_read_status is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'meson_gxl_read_status' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Indeed, silly mistake, thx for spotting it.
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH][next] net: phy: meson-gxl: make function meson_gxl_read_status static
@ 2017-12-12 14:20 ` Jerome Brunet
0 siblings, 0 replies; 12+ messages in thread
From: Jerome Brunet @ 2017-12-12 14:20 UTC (permalink / raw)
To: linus-amlogic
On Tue, 2017-12-12 at 13:03 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function meson_gxl_read_status is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'meson_gxl_read_status' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Indeed, silly mistake, thx for spotting it.
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH][next] net: phy: meson-gxl: make function meson_gxl_read_status static
@ 2017-12-12 14:20 ` Jerome Brunet
0 siblings, 0 replies; 12+ messages in thread
From: Jerome Brunet @ 2017-12-12 14:20 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2017-12-12 at 13:03 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function meson_gxl_read_status is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'meson_gxl_read_status' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Indeed, silly mistake, thx for spotting it.
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH][next] net: phy: meson-gxl: make function meson_gxl_read_status static
@ 2017-12-12 14:20 ` Jerome Brunet
0 siblings, 0 replies; 12+ messages in thread
From: Jerome Brunet @ 2017-12-12 14:20 UTC (permalink / raw)
To: linus-amlogic
On Tue, 2017-12-12 at 13:03 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function meson_gxl_read_status is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'meson_gxl_read_status' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Indeed, silly mistake, thx for spotting it.
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH][next] net: phy: meson-gxl: make function meson_gxl_read_status static
2017-12-12 13:03 ` Colin King
(?)
(?)
@ 2017-12-13 20:05 ` David Miller
-1 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2017-12-13 20:05 UTC (permalink / raw)
To: colin.king
Cc: andrew, f.fainelli, carlo, khilman, netdev, linux-arm-kernel,
linux-amlogic, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Tue, 12 Dec 2017 13:03:11 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> The function meson_gxl_read_status is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'meson_gxl_read_status' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH][next] net: phy: meson-gxl: make function meson_gxl_read_status static
@ 2017-12-13 20:05 ` David Miller
0 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2017-12-13 20:05 UTC (permalink / raw)
To: linus-amlogic
From: Colin King <colin.king@canonical.com>
Date: Tue, 12 Dec 2017 13:03:11 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> The function meson_gxl_read_status is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'meson_gxl_read_status' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH][next] net: phy: meson-gxl: make function meson_gxl_read_status static
@ 2017-12-13 20:05 ` David Miller
0 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2017-12-13 20:05 UTC (permalink / raw)
To: linux-arm-kernel
From: Colin King <colin.king@canonical.com>
Date: Tue, 12 Dec 2017 13:03:11 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> The function meson_gxl_read_status is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'meson_gxl_read_status' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH][next] net: phy: meson-gxl: make function meson_gxl_read_status static
@ 2017-12-13 20:05 ` David Miller
0 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2017-12-13 20:05 UTC (permalink / raw)
To: linus-amlogic
From: Colin King <colin.king@canonical.com>
Date: Tue, 12 Dec 2017 13:03:11 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> The function meson_gxl_read_status is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'meson_gxl_read_status' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 12+ messages in thread