All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH igt] igt/tools_test: Check the tools exist before executing
@ 2017-12-12 17:22 Chris Wilson
  2017-12-12 17:39 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (10 more replies)
  0 siblings, 11 replies; 17+ messages in thread
From: Chris Wilson @ 2017-12-12 17:22 UTC (permalink / raw)
  To: intel-gfx

As a simple fail-safe against a bad installation, check the tools exist
before testing whether they work.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102935
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/tools_test.c | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/tests/tools_test.c b/tests/tools_test.c
index 6aea7a8a4..a4fc68e8b 100644
--- a/tests/tools_test.c
+++ b/tests/tools_test.c
@@ -26,6 +26,9 @@
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
+#include <unistd.h>
+
+#define TOOLS "../tools/"
 
 struct line_check {
 	int found;
@@ -112,17 +115,13 @@ igt_main
 	}
 
 	igt_subtest("tools_test") {
-		char *cmd;
-
-		igt_assert(asprintf(&cmd,
-				    "../tools/intel_reg read 0x4030")
-			   != -1);
-		igt_assert(igt_system_quiet(cmd) == IGT_EXIT_SUCCESS);
-		free(cmd);
-
-		igt_assert(asprintf(&cmd, "../tools/intel_reg dump")
-			   != -1);
-		igt_assert(igt_system_quiet(cmd) == IGT_EXIT_SUCCESS);
-		free(cmd);
+		igt_require(access(TOOLS "intel_reg_read", X_OK) == 0);
+		igt_require(access(TOOLS "intel_reg_dump", X_OK) == 0);
+
+		igt_assert_eq(igt_system_quiet(TOOLS "intel_reg read 0x4030"),
+			      IGT_EXIT_SUCCESS);
+
+		igt_assert_eq(igt_system_quiet(TOOLS "intel_reg dump"),
+			      IGT_EXIT_SUCCESS);
 	}
 }
-- 
2.15.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* ✓ Fi.CI.BAT: success for igt/tools_test: Check the tools exist before executing
  2017-12-12 17:22 [PATCH igt] igt/tools_test: Check the tools exist before executing Chris Wilson
@ 2017-12-12 17:39 ` Patchwork
  2017-12-12 18:45 ` ✗ Fi.CI.IGT: warning " Patchwork
                   ` (9 subsequent siblings)
  10 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2017-12-12 17:39 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: igt/tools_test: Check the tools exist before executing
URL   : https://patchwork.freedesktop.org/series/35237/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
74407418720ff7a9de7caabec05d4c3afe9a5c51 igt/kms_flip: Allow very large bo to fail pageflips with E2BIG

with latest DRM-Tip kernel build CI_DRM_3501
f49a92217adc drm-tip: 2017y-12m-12d-12h-12m-26s UTC integration manifest

No testlist changes.

Test debugfs_test:
        Subgroup read_all_entries:
                dmesg-warn -> PASS       (fi-elk-e7500) fdo#103989 +1
Test gem_exec_suspend:
        Subgroup basic-s3:
                incomplete -> PASS       (fi-glk-1) fdo#103326
Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                pass       -> FAIL       (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                pass       -> DMESG-WARN (fi-kbl-r) fdo#104172 +1

fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#103326 https://bugs.freedesktop.org/show_bug.cgi?id=103326
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:435s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:448s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:382s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:511s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:280s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:508s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:512s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:491s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:478s
fi-elk-e7500     total:224  pass:163  dwarn:15  dfail:0   fail:0   skip:45 
fi-gdg-551       total:288  pass:178  dwarn:1   dfail:0   fail:1   skip:108 time:270s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:539s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:374s
fi-hsw-4770r     total:288  pass:224  dwarn:0   dfail:0   fail:0   skip:64  time:259s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:394s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:473s
fi-ivb-3770      total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:450s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:485s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:527s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:472s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:528s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:591s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:460s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:535s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:567s
fi-skl-6700k     total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:518s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:498s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:451s
fi-snb-2520m     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:547s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:417s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:599s
fi-cnl-y         total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:634s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_658/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* ✗ Fi.CI.IGT: warning for igt/tools_test: Check the tools exist before executing
  2017-12-12 17:22 [PATCH igt] igt/tools_test: Check the tools exist before executing Chris Wilson
  2017-12-12 17:39 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-12-12 18:45 ` Patchwork
  2017-12-13  9:53 ` [PATCH igt] " Petri Latvala
                   ` (8 subsequent siblings)
  10 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2017-12-12 18:45 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: igt/tools_test: Check the tools exist before executing
URL   : https://patchwork.freedesktop.org/series/35237/
State : warning

== Summary ==

Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
                pass       -> FAIL       (shard-snb) fdo#101623
Test drm_read:
        Subgroup short-buffer-block:
                pass       -> SKIP       (shard-hsw)
Test kms_properties:
        Subgroup crtc-properties-atomic:
                pass       -> SKIP       (shard-hsw) fdo#103706
Test kms_busy:
        Subgroup extended-modeset-hang-oldfb-render-c:
                pass       -> SKIP       (shard-hsw)
Test tools_test:
        Subgroup tools_test:
                pass       -> SKIP       (shard-snb)
                pass       -> SKIP       (shard-hsw)
Test gem_tiled_swapping:
        Subgroup non-threaded:
                incomplete -> PASS       (shard-snb) fdo#104009

fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103706 https://bugs.freedesktop.org/show_bug.cgi?id=103706
fdo#104009 https://bugs.freedesktop.org/show_bug.cgi?id=104009

shard-hsw        total:2712 pass:1533 dwarn:1   dfail:0   fail:10  skip:1168 time:9488s
shard-snb        total:2712 pass:1308 dwarn:1   dfail:0   fail:12  skip:1391 time:8111s
Blacklisted hosts:
shard-apl        total:2618 pass:1617 dwarn:1   dfail:0   fail:23  skip:976 time:12974s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_658/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH igt] igt/tools_test: Check the tools exist before executing
  2017-12-12 17:22 [PATCH igt] igt/tools_test: Check the tools exist before executing Chris Wilson
  2017-12-12 17:39 ` ✓ Fi.CI.BAT: success for " Patchwork
  2017-12-12 18:45 ` ✗ Fi.CI.IGT: warning " Patchwork
@ 2017-12-13  9:53 ` Petri Latvala
  2017-12-13 10:48 ` Joonas Lahtinen
                   ` (7 subsequent siblings)
  10 siblings, 0 replies; 17+ messages in thread
From: Petri Latvala @ 2017-12-13  9:53 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

On Tue, Dec 12, 2017 at 05:22:01PM +0000, Chris Wilson wrote:
> As a simple fail-safe against a bad installation, check the tools exist
> before testing whether they work.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102935
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/tools_test.c | 23 +++++++++++------------
>  1 file changed, 11 insertions(+), 12 deletions(-)
> 
> diff --git a/tests/tools_test.c b/tests/tools_test.c
> index 6aea7a8a4..a4fc68e8b 100644
> --- a/tests/tools_test.c
> +++ b/tests/tools_test.c
> @@ -26,6 +26,9 @@
>  #include <sys/types.h>
>  #include <sys/stat.h>
>  #include <fcntl.h>
> +#include <unistd.h>
> +
> +#define TOOLS "../tools/"
>  
>  struct line_check {
>  	int found;
> @@ -112,17 +115,13 @@ igt_main
>  	}
>  
>  	igt_subtest("tools_test") {
> -		char *cmd;
> -
> -		igt_assert(asprintf(&cmd,
> -				    "../tools/intel_reg read 0x4030")
> -			   != -1);
> -		igt_assert(igt_system_quiet(cmd) == IGT_EXIT_SUCCESS);
> -		free(cmd);
> -
> -		igt_assert(asprintf(&cmd, "../tools/intel_reg dump")
> -			   != -1);
> -		igt_assert(igt_system_quiet(cmd) == IGT_EXIT_SUCCESS);
> -		free(cmd);
> +		igt_require(access(TOOLS "intel_reg_read", X_OK) == 0);
> +		igt_require(access(TOOLS "intel_reg_dump", X_OK) == 0);
> +
> +		igt_assert_eq(igt_system_quiet(TOOLS "intel_reg read 0x4030"),
> +			      IGT_EXIT_SUCCESS);
> +
> +		igt_assert_eq(igt_system_quiet(TOOLS "intel_reg dump"),
> +			      IGT_EXIT_SUCCESS);
>  	}
>  }


This whole test needs some loving in the form of a helper to find an
executable in $srcdir/tools or $bindir, like igt_fopen_data(), but
that can be left for later.

Can you also add the same check in the l3 parity subtest?


Reviewed-by: Petri Latvala <petri.latvala@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH igt] igt/tools_test: Check the tools exist before executing
  2017-12-12 17:22 [PATCH igt] igt/tools_test: Check the tools exist before executing Chris Wilson
                   ` (2 preceding siblings ...)
  2017-12-13  9:53 ` [PATCH igt] " Petri Latvala
@ 2017-12-13 10:48 ` Joonas Lahtinen
  2017-12-13 14:56 ` [PATCH igt v2] " Chris Wilson
                   ` (6 subsequent siblings)
  10 siblings, 0 replies; 17+ messages in thread
From: Joonas Lahtinen @ 2017-12-13 10:48 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx

On Tue, 2017-12-12 at 17:22 +0000, Chris Wilson wrote:
> As a simple fail-safe against a bad installation, check the tools exist
> before testing whether they work.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102935
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH igt v2] igt/tools_test: Check the tools exist before executing
  2017-12-12 17:22 [PATCH igt] igt/tools_test: Check the tools exist before executing Chris Wilson
                   ` (3 preceding siblings ...)
  2017-12-13 10:48 ` Joonas Lahtinen
@ 2017-12-13 14:56 ` Chris Wilson
  2017-12-14 11:11   ` Petri Latvala
  2017-12-13 17:16 ` ✓ Fi.CI.BAT: success for igt/tools_test: Check the tools exist before executing (rev2) Patchwork
                   ` (5 subsequent siblings)
  10 siblings, 1 reply; 17+ messages in thread
From: Chris Wilson @ 2017-12-13 14:56 UTC (permalink / raw)
  To: intel-gfx

As a simple fail-safe against a bad installation, check the tools exist
before testing whether they work.

v2: Check intel_l3_parity as well

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102935
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 tests/tools_test.c | 48 +++++++++++++++++++++++++++++-------------------
 1 file changed, 29 insertions(+), 19 deletions(-)

diff --git a/tests/tools_test.c b/tests/tools_test.c
index 6aea7a8a4..4183456e2 100644
--- a/tests/tools_test.c
+++ b/tests/tools_test.c
@@ -26,6 +26,10 @@
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
+#include <libgen.h>
+#include <unistd.h>
+
+#define TOOLS "../tools/"
 
 struct line_check {
 	int found;
@@ -59,10 +63,19 @@ igt_main
 {
 	igt_skip_on_simulation();
 
+	igt_fixture {
+		char path[4096];
+
+		if (readlink("/proc/self/exe", path, sizeof(path)) > 0)
+			chdir(dirname(path));
+	}
+
 	igt_subtest("sysfs_l3_parity") {
 		int exec_return;
 		struct line_check line;
 
+		igt_require(access(TOOLS "intel_l3_parity", X_OK) == 0);
+
 		/* Sanity check that l3 parity tool is usable: Enable
 		 * row,bank,subbank 0,0,0.
 		 *
@@ -71,27 +84,28 @@ igt_main
 		 * piglit.
 		 */
 		igt_system_cmd(exec_return,
-			       "../tools/intel_l3_parity -r 0 -b 0 "
+			       TOOLS "intel_l3_parity -r 0 -b 0 "
 			       "-s 0 -e");
 		assert_cmd_success(exec_return);
 
 		/* Disable row,bank,subbank 0,0,0. */
-		igt_system_cmd(exec_return, "../tools/intel_l3_parity -r 0 -b 0 "
+		igt_system_cmd(exec_return,
+			       TOOLS "intel_l3_parity -r 0 -b 0 "
 			       "-s 0 -d");
 		assert_cmd_success(exec_return);
 
 		/* Check that disabling was successful */
-		igt_system_cmd(exec_return, "../tools/intel_l3_parity -l");
+		igt_system_cmd(exec_return,
+			       TOOLS "intel_l3_parity -l");
 		assert_cmd_success(exec_return);
 		line.substr = "Row 0, Bank 0, Subbank 0 is disabled";
 		line.found = 0;
-		igt_log_buffer_inspect(check_cmd_output,
-				       &line);
+		igt_log_buffer_inspect(check_cmd_output, &line);
 		igt_assert_eq(line.found, 1);
 
 		/* Re-enable row,bank,subbank 0,0,0 */
 		igt_system_cmd(exec_return,
-			       "../tools/intel_l3_parity -r 0 -b 0 "
+			       TOOLS "intel_l3_parity -r 0 -b 0 "
 			       "-s 0 -e");
 		assert_cmd_success(exec_return);
 
@@ -102,7 +116,8 @@ igt_main
 		 * The previously printed line is already in the log
 		 * buffer so we check for count 1.
 		 */
-		igt_system_cmd(exec_return, "../tools/intel_l3_parity -l");
+		igt_system_cmd(exec_return,
+			       TOOLS "intel_l3_parity -l");
 		assert_cmd_success(exec_return);
 		line.substr = "Row 0, Bank 0, Subbank 0 is disabled";
 		line.found = 0;
@@ -112,17 +127,12 @@ igt_main
 	}
 
 	igt_subtest("tools_test") {
-		char *cmd;
-
-		igt_assert(asprintf(&cmd,
-				    "../tools/intel_reg read 0x4030")
-			   != -1);
-		igt_assert(igt_system_quiet(cmd) == IGT_EXIT_SUCCESS);
-		free(cmd);
-
-		igt_assert(asprintf(&cmd, "../tools/intel_reg dump")
-			   != -1);
-		igt_assert(igt_system_quiet(cmd) == IGT_EXIT_SUCCESS);
-		free(cmd);
+		igt_require(access(TOOLS "intel_reg", X_OK) == 0);
+
+		igt_assert_eq(igt_system_quiet(TOOLS "intel_reg read 0x4030"),
+			      IGT_EXIT_SUCCESS);
+
+		igt_assert_eq(igt_system_quiet(TOOLS "intel_reg dump"),
+			      IGT_EXIT_SUCCESS);
 	}
 }
-- 
2.15.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* ✓ Fi.CI.BAT: success for igt/tools_test: Check the tools exist before executing (rev2)
  2017-12-12 17:22 [PATCH igt] igt/tools_test: Check the tools exist before executing Chris Wilson
                   ` (4 preceding siblings ...)
  2017-12-13 14:56 ` [PATCH igt v2] " Chris Wilson
@ 2017-12-13 17:16 ` Patchwork
  2017-12-13 18:59 ` ✗ Fi.CI.IGT: warning " Patchwork
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2017-12-13 17:16 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: igt/tools_test: Check the tools exist before executing (rev2)
URL   : https://patchwork.freedesktop.org/series/35237/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
4112f30aedbb252bf8cdd27dbba485c0458faca7 igt/gem_shrink: Exercise allocations in the middle of execbuf under oom-pressure

with latest DRM-Tip kernel build CI_DRM_3508
1a717c76c96c drm-tip: 2017y-12m-13d-14h-48m-36s UTC integration manifest

No testlist changes.

Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                pass       -> FAIL       (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                pass       -> DMESG-WARN (fi-kbl-r) fdo#104172 +1

fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:441s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:444s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:387s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:515s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:281s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:503s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:512s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:490s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:473s
fi-elk-e7500     total:224  pass:163  dwarn:15  dfail:0   fail:0   skip:45 
fi-gdg-551       total:288  pass:178  dwarn:1   dfail:0   fail:1   skip:108 time:268s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:542s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:409s
fi-hsw-4770r     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:416s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:393s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:479s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:434s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:488s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:530s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:476s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:534s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:582s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:446s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:544s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:565s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:496s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:445s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:549s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:418s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:598s
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:491s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_665/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* ✗ Fi.CI.IGT: warning for igt/tools_test: Check the tools exist before executing (rev2)
  2017-12-12 17:22 [PATCH igt] igt/tools_test: Check the tools exist before executing Chris Wilson
                   ` (5 preceding siblings ...)
  2017-12-13 17:16 ` ✓ Fi.CI.BAT: success for igt/tools_test: Check the tools exist before executing (rev2) Patchwork
@ 2017-12-13 18:59 ` Patchwork
  2017-12-14 11:39 ` [PATCH igt v3] igt/tools_test: Check the tools exist before executing Chris Wilson
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2017-12-13 18:59 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: igt/tools_test: Check the tools exist before executing (rev2)
URL   : https://patchwork.freedesktop.org/series/35237/
State : warning

== Summary ==

Test kms_flip:
        Subgroup plain-flip-fb-recreate-interruptible:
                pass       -> FAIL       (shard-hsw) fdo#100368
Test kms_frontbuffer_tracking:
        Subgroup fbc-suspend:
                pass       -> SKIP       (shard-hsw) fdo#103540
        Subgroup fbc-1p-offscren-pri-shrfb-draw-blt:
                fail       -> PASS       (shard-snb) fdo#101623
Test tools_test:
        Subgroup tools_test:
                pass       -> SKIP       (shard-snb)
                pass       -> SKIP       (shard-hsw)
        Subgroup sysfs_l3_parity:
                pass       -> SKIP       (shard-hsw)
Test kms_cursor_crc:
        Subgroup cursor-256x256-suspend:
                skip       -> PASS       (shard-snb) fdo#103375
Test gem_eio:
        Subgroup in-flight-contexts:
                pass       -> DMESG-FAIL (shard-snb) fdo#104058 +1

fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#104058 https://bugs.freedesktop.org/show_bug.cgi?id=104058

shard-hsw        total:2712 pass:1533 dwarn:1   dfail:0   fail:11  skip:1167 time:9413s
shard-snb        total:2712 pass:1307 dwarn:2   dfail:1   fail:11  skip:1391 time:8127s
Blacklisted hosts:
shard-apl        total:2712 pass:1686 dwarn:1   dfail:0   fail:23  skip:1002 time:13856s
shard-kbl        total:2712 pass:1807 dwarn:1   dfail:0   fail:24  skip:880 time:11160s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_665/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH igt v2] igt/tools_test: Check the tools exist before executing
  2017-12-13 14:56 ` [PATCH igt v2] " Chris Wilson
@ 2017-12-14 11:11   ` Petri Latvala
  2017-12-14 11:14     ` Chris Wilson
  0 siblings, 1 reply; 17+ messages in thread
From: Petri Latvala @ 2017-12-14 11:11 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

On Wed, Dec 13, 2017 at 02:56:10PM +0000, Chris Wilson wrote:
> As a simple fail-safe against a bad installation, check the tools exist
> before testing whether they work.
> 
> v2: Check intel_l3_parity as well
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102935
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
>  tests/tools_test.c | 48 +++++++++++++++++++++++++++++-------------------
>  1 file changed, 29 insertions(+), 19 deletions(-)
> 
> diff --git a/tests/tools_test.c b/tests/tools_test.c
> index 6aea7a8a4..4183456e2 100644
> --- a/tests/tools_test.c
> +++ b/tests/tools_test.c
> @@ -26,6 +26,10 @@
>  #include <sys/types.h>
>  #include <sys/stat.h>
>  #include <fcntl.h>
> +#include <libgen.h>
> +#include <unistd.h>
> +
> +#define TOOLS "../tools/"
>  
>  struct line_check {
>  	int found;
> @@ -59,10 +63,19 @@ igt_main
>  {
>  	igt_skip_on_simulation();
>  
> +	igt_fixture {
> +		char path[4096];
> +
> +		if (readlink("/proc/self/exe", path, sizeof(path)) > 0)
> +			chdir(dirname(path));
> +	}


Why the chdir?

CI runs tests with IGT installed (make install). The test's directory
is $libexecdir/intel-gpu-tools/, ../tools is $libexecdir/tools and
that doesn't exist.


-- 
Petri Latvala
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH igt v2] igt/tools_test: Check the tools exist before executing
  2017-12-14 11:11   ` Petri Latvala
@ 2017-12-14 11:14     ` Chris Wilson
  2017-12-14 11:20       ` Petri Latvala
  0 siblings, 1 reply; 17+ messages in thread
From: Chris Wilson @ 2017-12-14 11:14 UTC (permalink / raw)
  To: Petri Latvala; +Cc: intel-gfx

Quoting Petri Latvala (2017-12-14 11:11:47)
> On Wed, Dec 13, 2017 at 02:56:10PM +0000, Chris Wilson wrote:
> > As a simple fail-safe against a bad installation, check the tools exist
> > before testing whether they work.
> > 
> > v2: Check intel_l3_parity as well
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102935
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > ---
> >  tests/tools_test.c | 48 +++++++++++++++++++++++++++++-------------------
> >  1 file changed, 29 insertions(+), 19 deletions(-)
> > 
> > diff --git a/tests/tools_test.c b/tests/tools_test.c
> > index 6aea7a8a4..4183456e2 100644
> > --- a/tests/tools_test.c
> > +++ b/tests/tools_test.c
> > @@ -26,6 +26,10 @@
> >  #include <sys/types.h>
> >  #include <sys/stat.h>
> >  #include <fcntl.h>
> > +#include <libgen.h>
> > +#include <unistd.h>
> > +
> > +#define TOOLS "../tools/"
> >  
> >  struct line_check {
> >       int found;
> > @@ -59,10 +63,19 @@ igt_main
> >  {
> >       igt_skip_on_simulation();
> >  
> > +     igt_fixture {
> > +             char path[4096];
> > +
> > +             if (readlink("/proc/self/exe", path, sizeof(path)) > 0)
> > +                     chdir(dirname(path));
> > +     }
> 
> 
> Why the chdir?

For me, I was trying to standardise the test, since "../tools" bakes in
so many assumptions that simply aren't true when one invokes
$path/tools_test. Back to the igt_data_dir() request.
 
> CI runs tests with IGT installed (make install). The test's directory
> is $libexecdir/intel-gpu-tools/, ../tools is $libexecdir/tools and
> that doesn't exist.

So where was it expecting to find the tools?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH igt v2] igt/tools_test: Check the tools exist before executing
  2017-12-14 11:14     ` Chris Wilson
@ 2017-12-14 11:20       ` Petri Latvala
  2017-12-14 11:24         ` Chris Wilson
  0 siblings, 1 reply; 17+ messages in thread
From: Petri Latvala @ 2017-12-14 11:20 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

On Thu, Dec 14, 2017 at 11:14:35AM +0000, Chris Wilson wrote:
> > 
> > Why the chdir?
> 
> For me, I was trying to standardise the test, since "../tools" bakes in
> so many assumptions that simply aren't true when one invokes
> $path/tools_test. Back to the igt_data_dir() request.

Aye, the assumption is bad and should get changed to support both run
methods (within build dir, with installed). Currently it works by
carefully setting up the CI deployment so paths match. =(

>  
> > CI runs tests with IGT installed (make install). The test's directory
> > is $libexecdir/intel-gpu-tools/, ../tools is $libexecdir/tools and
> > that doesn't exist.
> 
> So where was it expecting to find the tools?


CI deploys the tools next to piglit. $cwd is piglit's directory when
running through piglit, tools are deployed to $piglit/../tools.



-- 
Petri Latvala
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH igt v2] igt/tools_test: Check the tools exist before executing
  2017-12-14 11:20       ` Petri Latvala
@ 2017-12-14 11:24         ` Chris Wilson
  2017-12-14 12:39           ` Petri Latvala
  0 siblings, 1 reply; 17+ messages in thread
From: Chris Wilson @ 2017-12-14 11:24 UTC (permalink / raw)
  To: Petri Latvala; +Cc: intel-gfx

Quoting Petri Latvala (2017-12-14 11:20:18)
> On Thu, Dec 14, 2017 at 11:14:35AM +0000, Chris Wilson wrote:
> > > 
> > > Why the chdir?
> > 
> > For me, I was trying to standardise the test, since "../tools" bakes in
> > so many assumptions that simply aren't true when one invokes
> > $path/tools_test. Back to the igt_data_dir() request.
> 
> Aye, the assumption is bad and should get changed to support both run
> methods (within build dir, with installed). Currently it works by
> carefully setting up the CI deployment so paths match. =(
> 
> >  
> > > CI runs tests with IGT installed (make install). The test's directory
> > > is $libexecdir/intel-gpu-tools/, ../tools is $libexecdir/tools and
> > > that doesn't exist.
> > 
> > So where was it expecting to find the tools?
> 
> 
> CI deploys the tools next to piglit. $cwd is piglit's directory when
> running through piglit, tools are deployed to $piglit/../tools.

How about

if (access("../tools/", F_OK)) {
	chdir();
}

Got to love temporary hacks.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH igt v3] igt/tools_test: Check the tools exist before executing
  2017-12-12 17:22 [PATCH igt] igt/tools_test: Check the tools exist before executing Chris Wilson
                   ` (6 preceding siblings ...)
  2017-12-13 18:59 ` ✗ Fi.CI.IGT: warning " Patchwork
@ 2017-12-14 11:39 ` Chris Wilson
  2017-12-14 11:57 ` ✗ Fi.CI.BAT: warning for igt/tools_test: Check the tools exist before executing (rev3) Patchwork
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 17+ messages in thread
From: Chris Wilson @ 2017-12-14 11:39 UTC (permalink / raw)
  To: intel-gfx

As a simple fail-safe against a bad installation, check the tools exist
before testing whether they work.

v2: Check intel_l3_parity as well
v3: Hunt for tools/

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102935
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Petri Latvala <petri.latvala@intel.com> #v1
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> #v1
---
 tests/tools_test.c | 53 ++++++++++++++++++++++++++++++++++-------------------
 1 file changed, 34 insertions(+), 19 deletions(-)

diff --git a/tests/tools_test.c b/tests/tools_test.c
index 6aea7a8a4..a0025bedf 100644
--- a/tests/tools_test.c
+++ b/tests/tools_test.c
@@ -26,6 +26,10 @@
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
+#include <libgen.h>
+#include <unistd.h>
+
+#define TOOLS "../tools/"
 
 struct line_check {
 	int found;
@@ -59,10 +63,24 @@ igt_main
 {
 	igt_skip_on_simulation();
 
+	igt_fixture {
+		char path[4096];
+
+		/* Try to guess where the TOOLS are! */
+		if (access(TOOLS, F_OK) &&
+		    readlink("/proc/self/exe", path, sizeof(path)) > 0)
+			chdir(dirname(path));
+
+		igt_require_f(chdir(TOOLS) == 0,
+			      "Unable to determine the tools directory, expecting them in $cwd/" TOOLS " or $path/" TOOLS "\n");
+	}
+
 	igt_subtest("sysfs_l3_parity") {
 		int exec_return;
 		struct line_check line;
 
+		igt_require(access("intel_l3_parity", X_OK) == 0);
+
 		/* Sanity check that l3 parity tool is usable: Enable
 		 * row,bank,subbank 0,0,0.
 		 *
@@ -71,27 +89,28 @@ igt_main
 		 * piglit.
 		 */
 		igt_system_cmd(exec_return,
-			       "../tools/intel_l3_parity -r 0 -b 0 "
+			       "./intel_l3_parity -r 0 -b 0 "
 			       "-s 0 -e");
 		assert_cmd_success(exec_return);
 
 		/* Disable row,bank,subbank 0,0,0. */
-		igt_system_cmd(exec_return, "../tools/intel_l3_parity -r 0 -b 0 "
+		igt_system_cmd(exec_return,
+			       "./intel_l3_parity -r 0 -b 0 "
 			       "-s 0 -d");
 		assert_cmd_success(exec_return);
 
 		/* Check that disabling was successful */
-		igt_system_cmd(exec_return, "../tools/intel_l3_parity -l");
+		igt_system_cmd(exec_return,
+			       "./intel_l3_parity -l");
 		assert_cmd_success(exec_return);
 		line.substr = "Row 0, Bank 0, Subbank 0 is disabled";
 		line.found = 0;
-		igt_log_buffer_inspect(check_cmd_output,
-				       &line);
+		igt_log_buffer_inspect(check_cmd_output, &line);
 		igt_assert_eq(line.found, 1);
 
 		/* Re-enable row,bank,subbank 0,0,0 */
 		igt_system_cmd(exec_return,
-			       "../tools/intel_l3_parity -r 0 -b 0 "
+			       "./intel_l3_parity -r 0 -b 0 "
 			       "-s 0 -e");
 		assert_cmd_success(exec_return);
 
@@ -102,7 +121,8 @@ igt_main
 		 * The previously printed line is already in the log
 		 * buffer so we check for count 1.
 		 */
-		igt_system_cmd(exec_return, "../tools/intel_l3_parity -l");
+		igt_system_cmd(exec_return,
+			       "./intel_l3_parity -l");
 		assert_cmd_success(exec_return);
 		line.substr = "Row 0, Bank 0, Subbank 0 is disabled";
 		line.found = 0;
@@ -112,17 +132,12 @@ igt_main
 	}
 
 	igt_subtest("tools_test") {
-		char *cmd;
-
-		igt_assert(asprintf(&cmd,
-				    "../tools/intel_reg read 0x4030")
-			   != -1);
-		igt_assert(igt_system_quiet(cmd) == IGT_EXIT_SUCCESS);
-		free(cmd);
-
-		igt_assert(asprintf(&cmd, "../tools/intel_reg dump")
-			   != -1);
-		igt_assert(igt_system_quiet(cmd) == IGT_EXIT_SUCCESS);
-		free(cmd);
+		igt_require(access("intel_reg", X_OK) == 0);
+
+		igt_assert_eq(igt_system_quiet("./intel_reg read 0x4030"),
+			      IGT_EXIT_SUCCESS);
+
+		igt_assert_eq(igt_system_quiet("./intel_reg dump"),
+			      IGT_EXIT_SUCCESS);
 	}
 }
-- 
2.15.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* ✗ Fi.CI.BAT: warning for igt/tools_test: Check the tools exist before executing (rev3)
  2017-12-12 17:22 [PATCH igt] igt/tools_test: Check the tools exist before executing Chris Wilson
                   ` (7 preceding siblings ...)
  2017-12-14 11:39 ` [PATCH igt v3] igt/tools_test: Check the tools exist before executing Chris Wilson
@ 2017-12-14 11:57 ` Patchwork
  2017-12-14 21:57 ` ✓ Fi.CI.BAT: success " Patchwork
  2017-12-14 23:38 ` ✗ Fi.CI.IGT: failure " Patchwork
  10 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2017-12-14 11:57 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: igt/tools_test: Check the tools exist before executing (rev3)
URL   : https://patchwork.freedesktop.org/series/35237/
State : warning

== Summary ==

IGT patchset tested on top of latest successful build
103af7286e2d1014e3d7126691fe046ab2c9f73e lib: Ask the kernel to quiesce the GPU

with latest DRM-Tip kernel build CI_DRM_3516
91d06d0bbd1a drm-tip: 2017y-12m-14d-09h-49m-51s UTC integration manifest

No testlist changes.

Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                pass       -> FAIL       (fi-gdg-551) fdo#102575
Test kms_busy:
        Subgroup basic-flip-a:
                pass       -> DMESG-WARN (fi-elk-e7500) fdo#103989
Test kms_psr_sink_crc:
        Subgroup psr_basic:
                dmesg-warn -> PASS       (fi-skl-6700hq) fdo#101144
Test drv_module_reload:
        Subgroup basic-reload-inject:
                pass       -> DMESG-WARN (fi-bsw-n3050)

fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:435s
fi-blb-e6850     total:288  pass:222  dwarn:1   dfail:1   fail:0   skip:64  time:394s
fi-bsw-n3050     total:288  pass:241  dwarn:1   dfail:0   fail:0   skip:46  time:508s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:279s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:501s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:499s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:484s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:477s
fi-elk-e7500     total:224  pass:163  dwarn:15  dfail:0   fail:0   skip:45 
fi-gdg-551       total:288  pass:178  dwarn:1   dfail:0   fail:1   skip:108 time:266s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:531s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:416s
fi-hsw-4770r     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:413s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:390s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:468s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:426s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:482s
fi-kbl-7560u     total:288  pass:268  dwarn:1   dfail:0   fail:0   skip:19  time:523s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:468s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:523s
fi-pnv-d510      total:288  pass:221  dwarn:1   dfail:0   fail:1   skip:65  time:593s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:440s
fi-skl-6600u     total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:538s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:560s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:489s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:450s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:558s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:419s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:597s
fi-cnl-y         total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:619s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_668/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH igt v2] igt/tools_test: Check the tools exist before executing
  2017-12-14 11:24         ` Chris Wilson
@ 2017-12-14 12:39           ` Petri Latvala
  0 siblings, 0 replies; 17+ messages in thread
From: Petri Latvala @ 2017-12-14 12:39 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx



On 12/14/2017 01:24 PM, Chris Wilson wrote:
> Quoting Petri Latvala (2017-12-14 11:20:18)
>> On Thu, Dec 14, 2017 at 11:14:35AM +0000, Chris Wilson wrote:
>>>> Why the chdir?
>>> For me, I was trying to standardise the test, since "../tools" bakes in
>>> so many assumptions that simply aren't true when one invokes
>>> $path/tools_test. Back to the igt_data_dir() request.
>> Aye, the assumption is bad and should get changed to support both run
>> methods (within build dir, with installed). Currently it works by
>> carefully setting up the CI deployment so paths match. =(
>>
>>>   
>>>> CI runs tests with IGT installed (make install). The test's directory
>>>> is $libexecdir/intel-gpu-tools/, ../tools is $libexecdir/tools and
>>>> that doesn't exist.
>>> So where was it expecting to find the tools?
>>
>> CI deploys the tools next to piglit. $cwd is piglit's directory when
>> running through piglit, tools are deployed to $piglit/../tools.
> How about
>
> if (access("../tools/", F_OK)) {
> 	chdir();
> }
>

Should be fine that way. Add a TODO comment somewhere about finding the 
directory for real.


-- 
Petri Latvala

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* ✓ Fi.CI.BAT: success for igt/tools_test: Check the tools exist before executing (rev3)
  2017-12-12 17:22 [PATCH igt] igt/tools_test: Check the tools exist before executing Chris Wilson
                   ` (8 preceding siblings ...)
  2017-12-14 11:57 ` ✗ Fi.CI.BAT: warning for igt/tools_test: Check the tools exist before executing (rev3) Patchwork
@ 2017-12-14 21:57 ` Patchwork
  2017-12-14 23:38 ` ✗ Fi.CI.IGT: failure " Patchwork
  10 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2017-12-14 21:57 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: igt/tools_test: Check the tools exist before executing (rev3)
URL   : https://patchwork.freedesktop.org/series/35237/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
103af7286e2d1014e3d7126691fe046ab2c9f73e lib: Ask the kernel to quiesce the GPU

with latest DRM-Tip kernel build CI_DRM_3521
ad43db157c69 drm-tip: 2017y-12m-14d-20h-09m-53s UTC integration manifest

No testlist changes.

Test debugfs_test:
        Subgroup read_all_entries:
                dmesg-fail -> DMESG-WARN (fi-elk-e7500) fdo#103989 +1
                incomplete -> PASS       (fi-snb-2520m) fdo#103713
Test gem_sync:
        Subgroup basic-each:
                skip       -> PASS       (fi-blb-e6850)
        Subgroup basic-many-each:
                skip       -> PASS       (fi-blb-e6850)
        Subgroup basic-store-all:
                skip       -> PASS       (fi-blb-e6850)
        Subgroup basic-store-each:
                skip       -> PASS       (fi-blb-e6850)
Test gem_tiled_blits:
        Subgroup basic:
                skip       -> PASS       (fi-blb-e6850)
Test gem_tiled_fence_blits:
        Subgroup basic:
                skip       -> PASS       (fi-blb-e6850)
Test gem_wait:
        Subgroup basic-busy-all:
                skip       -> PASS       (fi-blb-e6850)
        Subgroup basic-wait-all:
                skip       -> PASS       (fi-blb-e6850)
        Subgroup basic-await-all:
                skip       -> PASS       (fi-blb-e6850)
Test kms_busy:
        Subgroup basic-flip-a:
                skip       -> PASS       (fi-blb-e6850)
        Subgroup basic-flip-b:
                skip       -> PASS       (fi-blb-e6850)
Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-legacy:
                skip       -> PASS       (fi-blb-e6850)
Test kms_psr_sink_crc:
        Subgroup psr_basic:
                dmesg-warn -> PASS       (fi-skl-6700hq) fdo#101144

fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:437s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:440s
fi-blb-e6850     total:288  pass:222  dwarn:1   dfail:1   fail:0   skip:64  time:395s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:518s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:281s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:500s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:502s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:486s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:469s
fi-elk-e7500     total:224  pass:163  dwarn:15  dfail:0   fail:0   skip:45 
fi-gdg-551       total:288  pass:178  dwarn:1   dfail:0   fail:1   skip:108 time:266s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:533s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:408s
fi-hsw-4770r     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:415s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:394s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:477s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:428s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:481s
fi-kbl-7560u     total:288  pass:268  dwarn:1   dfail:0   fail:0   skip:19  time:524s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:467s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:521s
fi-pnv-d510      total:288  pass:221  dwarn:1   dfail:0   fail:1   skip:65  time:602s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:443s
fi-skl-6600u     total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:532s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:556s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:491s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:451s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:554s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:416s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:604s
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:480s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_674/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* ✗ Fi.CI.IGT: failure for igt/tools_test: Check the tools exist before executing (rev3)
  2017-12-12 17:22 [PATCH igt] igt/tools_test: Check the tools exist before executing Chris Wilson
                   ` (9 preceding siblings ...)
  2017-12-14 21:57 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2017-12-14 23:38 ` Patchwork
  10 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2017-12-14 23:38 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: igt/tools_test: Check the tools exist before executing (rev3)
URL   : https://patchwork.freedesktop.org/series/35237/
State : failure

== Summary ==

Test kms_cursor_legacy:
        Subgroup flip-vs-cursor-toggle:
                pass       -> FAIL       (shard-hsw) fdo#102670
Test gem_wait:
        Subgroup await-render:
                pass       -> FAIL       (shard-hsw)
Test kms_flip:
        Subgroup plain-flip-ts-check-interruptible:
                pass       -> FAIL       (shard-hsw) fdo#100368
        Subgroup vblank-vs-suspend:
                incomplete -> PASS       (shard-hsw) fdo#103375
Test drv_module_reload:
        Subgroup basic-reload-inject:
                pass       -> DMESG-WARN (shard-snb) fdo#102707
Test gvt_basic:
        Subgroup invalid-placeholder-test:
                skip       -> DMESG-FAIL (shard-snb)
Test kms_frontbuffer_tracking:
        Subgroup fbcpsr-1p-primscrn-spr-indfb-move:
                skip       -> INCOMPLETE (shard-snb)
        Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
                fail       -> PASS       (shard-snb) fdo#101623
Test gem_tiled_swapping:
        Subgroup non-threaded:
                dmesg-warn -> PASS       (shard-hsw) fdo#104218 +1

fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#102707 https://bugs.freedesktop.org/show_bug.cgi?id=102707
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#104218 https://bugs.freedesktop.org/show_bug.cgi?id=104218

shard-hsw        total:2712 pass:1534 dwarn:1   dfail:0   fail:13  skip:1164 time:9445s
shard-snb        total:2700 pass:1302 dwarn:2   dfail:1   fail:11  skip:1383 time:7738s
Blacklisted hosts:
shard-apl        total:2712 pass:1671 dwarn:1   dfail:0   fail:23  skip:1017 time:13793s
shard-kbl        total:2712 pass:1757 dwarn:47  dfail:2   fail:29  skip:877 time:11273s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_674/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2017-12-14 23:38 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-12 17:22 [PATCH igt] igt/tools_test: Check the tools exist before executing Chris Wilson
2017-12-12 17:39 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-12-12 18:45 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-12-13  9:53 ` [PATCH igt] " Petri Latvala
2017-12-13 10:48 ` Joonas Lahtinen
2017-12-13 14:56 ` [PATCH igt v2] " Chris Wilson
2017-12-14 11:11   ` Petri Latvala
2017-12-14 11:14     ` Chris Wilson
2017-12-14 11:20       ` Petri Latvala
2017-12-14 11:24         ` Chris Wilson
2017-12-14 12:39           ` Petri Latvala
2017-12-13 17:16 ` ✓ Fi.CI.BAT: success for igt/tools_test: Check the tools exist before executing (rev2) Patchwork
2017-12-13 18:59 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-12-14 11:39 ` [PATCH igt v3] igt/tools_test: Check the tools exist before executing Chris Wilson
2017-12-14 11:57 ` ✗ Fi.CI.BAT: warning for igt/tools_test: Check the tools exist before executing (rev3) Patchwork
2017-12-14 21:57 ` ✓ Fi.CI.BAT: success " Patchwork
2017-12-14 23:38 ` ✗ Fi.CI.IGT: failure " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.