All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@citrix.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [Qemu-devel] [PATCH v6 1/4] hw: convert virtio-input-hid device to keycodemapdb
Date: Wed, 13 Dec 2017 15:04:55 +0000	[thread overview]
Message-ID: <20171213150455.GG2216@perard.uk.xensource.com> (raw)
In-Reply-To: <20171212141044.2582-2-berrange@redhat.com>

On Tue, Dec 12, 2017 at 02:10:41PM +0000, Daniel P. Berrange wrote:
> diff --git a/Makefile b/Makefile
> index ab0354c153..5aaff5fe1e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -227,6 +227,7 @@ KEYCODEMAP_CSV = $(SRC_PATH)/ui/keycodemapdb/data/keymaps.csv
>  
>  KEYCODEMAP_FILES = \
>  		 ui/input-keymap-linux-to-qcode.c \
> +		 ui/input-keymap-qcode-to-linux.c \
>  		 ui/input-keymap-qcode-to-qnum.c \
>  		 ui/input-keymap-qnum-to-qcode.c \
>  		 $(NULL)

FYI, there is a patch on the mailing list that does just generate the
new keymap:
<20171103115631.15175-2-owen.smith@citrix.com>
([PATCH v5 1/4] ui: generate qcode to linux mappings)

> diff --git a/include/ui/input.h b/include/ui/input.h
> index f8cee43f65..6f56d868c7 100644
> --- a/include/ui/input.h
> +++ b/include/ui/input.h
> @@ -71,6 +71,9 @@ void qemu_remove_mouse_mode_change_notifier(Notifier *notify);
>  extern const guint qemu_input_map_linux_to_qcode_len;
>  extern const guint16 qemu_input_map_linux_to_qcode[];
>  
> +extern const guint qemu_input_map_qcode_to_linux_len;
> +extern const guint16 qemu_input_map_qcode_to_linux[];
> +
>  extern const guint qemu_input_map_qcode_to_qnum_len;
>  extern const guint16 qemu_input_map_qcode_to_qnum[];
>  
> diff --git a/ui/input-keymap.c b/ui/input-keymap.c
> index 3a19a169f5..6e543d651f 100644
> --- a/ui/input-keymap.c
> +++ b/ui/input-keymap.c
> @@ -6,6 +6,7 @@
>  #include "standard-headers/linux/input.h"
>  
>  #include "ui/input-keymap-linux-to-qcode.c"
> +#include "ui/input-keymap-qcode-to-linux.c"
>  #include "ui/input-keymap-qcode-to-qnum.c"
>  #include "ui/input-keymap-qnum-to-qcode.c"

-- 
Anthony PERARD

WARNING: multiple messages have this Message-ID (diff)
From: Anthony PERARD <anthony.perard@citrix.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	xen-devel@lists.xenproject.org, qemu-devel@nongnu.org,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v6 1/4] hw: convert virtio-input-hid device to keycodemapdb
Date: Wed, 13 Dec 2017 15:04:55 +0000	[thread overview]
Message-ID: <20171213150455.GG2216@perard.uk.xensource.com> (raw)
In-Reply-To: <20171212141044.2582-2-berrange@redhat.com>

On Tue, Dec 12, 2017 at 02:10:41PM +0000, Daniel P. Berrange wrote:
> diff --git a/Makefile b/Makefile
> index ab0354c153..5aaff5fe1e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -227,6 +227,7 @@ KEYCODEMAP_CSV = $(SRC_PATH)/ui/keycodemapdb/data/keymaps.csv
>  
>  KEYCODEMAP_FILES = \
>  		 ui/input-keymap-linux-to-qcode.c \
> +		 ui/input-keymap-qcode-to-linux.c \
>  		 ui/input-keymap-qcode-to-qnum.c \
>  		 ui/input-keymap-qnum-to-qcode.c \
>  		 $(NULL)

FYI, there is a patch on the mailing list that does just generate the
new keymap:
<20171103115631.15175-2-owen.smith@citrix.com>
([PATCH v5 1/4] ui: generate qcode to linux mappings)

> diff --git a/include/ui/input.h b/include/ui/input.h
> index f8cee43f65..6f56d868c7 100644
> --- a/include/ui/input.h
> +++ b/include/ui/input.h
> @@ -71,6 +71,9 @@ void qemu_remove_mouse_mode_change_notifier(Notifier *notify);
>  extern const guint qemu_input_map_linux_to_qcode_len;
>  extern const guint16 qemu_input_map_linux_to_qcode[];
>  
> +extern const guint qemu_input_map_qcode_to_linux_len;
> +extern const guint16 qemu_input_map_qcode_to_linux[];
> +
>  extern const guint qemu_input_map_qcode_to_qnum_len;
>  extern const guint16 qemu_input_map_qcode_to_qnum[];
>  
> diff --git a/ui/input-keymap.c b/ui/input-keymap.c
> index 3a19a169f5..6e543d651f 100644
> --- a/ui/input-keymap.c
> +++ b/ui/input-keymap.c
> @@ -6,6 +6,7 @@
>  #include "standard-headers/linux/input.h"
>  
>  #include "ui/input-keymap-linux-to-qcode.c"
> +#include "ui/input-keymap-qcode-to-linux.c"
>  #include "ui/input-keymap-qcode-to-qnum.c"
>  #include "ui/input-keymap-qnum-to-qcode.c"

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2017-12-13 15:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-12 14:10 [Qemu-devel] [PATCH v6 0/4] Convert hw backends to use keycodemapdb Daniel P. Berrange
2017-12-12 14:10 ` Daniel P. Berrange
2017-12-12 14:10 ` [Qemu-devel] [PATCH v6 1/4] hw: convert virtio-input-hid device to keycodemapdb Daniel P. Berrange
2017-12-12 14:10   ` Daniel P. Berrange
2017-12-13 15:04   ` Anthony PERARD [this message]
2017-12-13 15:04     ` Anthony PERARD
2017-12-12 14:10 ` [Qemu-devel] [PATCH v6 2/4] hw: convert ps2 " Daniel P. Berrange
2017-12-12 14:10   ` Daniel P. Berrange
2017-12-12 14:10 ` [Qemu-devel] [PATCH v6 3/4] hw: convert the escc " Daniel P. Berrange
2017-12-12 14:10   ` Daniel P. Berrange
2017-12-12 14:10 ` [Qemu-devel] [PATCH v6 4/4] hw: convert XenInput keyboard " Daniel P. Berrange
2017-12-12 14:10   ` Daniel P. Berrange
2017-12-13 15:01   ` [Qemu-devel] " Anthony PERARD
2017-12-13 15:01     ` Anthony PERARD
2017-12-15  9:33     ` [Qemu-devel] " Daniel P. Berrange
2017-12-15  9:33       ` Daniel P. Berrange
2018-01-15 15:11       ` [Qemu-devel] " Gerd Hoffmann
2018-01-15 15:11         ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171213150455.GG2216@perard.uk.xensource.com \
    --to=anthony.perard@citrix.com \
    --cc=berrange@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.