From: Tomasz Kramkowski <tk@the-tk.com>
To: Alex Manoussakis <amanou@gnu.org>
Cc: "Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Yuxuan Shui" <yshuiv7@gmail.com>,
"Diego Elio Pettenò" <flameeyes@flameeyes.eu>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: elecom: rewrite report fixup for EX-G and future mice
Date: Wed, 13 Dec 2017 21:47:46 +0000 [thread overview]
Message-ID: <20171213214746.GA23615@gaia.local> (raw)
In-Reply-To: <20171211173116.GA9941@gnu.org>
On Mon, Dec 11, 2017 at 12:31:16PM -0500, Alex Manoussakis wrote:
> Tomasz please add the wireless version in your next patch, a web search
> shows it's called M-XT3DRBK and the USB ID is 0x00fc.
M-XT3DRBK is the full model number for the wireless EX-G but since the
HUGE and DEFT both use their short names in the hid-ids macros then I'll
call this one EX_G_WIRELESS so that it matches the naming style of
everything else.
However, I'm a bit apprehensive about sending in a patch for a device I
can't test. Even if it's most likely going to work. Do you know of
anyone who can test this wireless EX-G variant?
I guess Jiri can chip in if he thinks this is not necessary. Technically
this patch should sit in linux-next for a while (but reportedly few
people actually run on that iirc) and the worst that could happen is
that the checks in the report fixup function don't match the expected
report and don't apply the fix, or (unlikely) some padding bits get
exposed as buttons with no function.
Either way, I've made this change locally and will be submitting v2 when
I have a bit more time later this week.
> Thanks,
> Alex
--
Tomasz Kramkowski | GPG: 40B037BA0A5B8680 | Web: https://the-tk.com/
next prev parent reply other threads:[~2017-12-13 21:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 20:55 [PATCH] HID: elecom: rewrite report fixup for EX-G and future mice Tomasz Kramkowski
2017-12-05 20:17 ` Tomasz Kramkowski
2017-12-07 10:04 ` Jiri Kosina
2017-12-09 17:23 ` Tomasz Kramkowski
2017-12-11 10:28 ` Jiri Kosina
2017-12-11 17:31 ` Alex Manoussakis
2017-12-13 21:47 ` Tomasz Kramkowski [this message]
2017-12-14 1:02 ` Alex Manoussakis
2017-12-19 20:44 ` [PATCH v2] " Tomasz Kramkowski
2018-01-23 14:40 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213214746.GA23615@gaia.local \
--to=tk@the-tk.com \
--cc=amanou@gnu.org \
--cc=benjamin.tissoires@redhat.com \
--cc=flameeyes@flameeyes.eu \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yshuiv7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.