From: Jiri Kosina <jikos@kernel.org>
To: Tomasz Kramkowski <tk@the-tk.com>
Cc: "Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Yuxuan Shui" <yshuiv7@gmail.com>,
"Diego Elio Pettenò" <flameeyes@flameeyes.eu>,
"Alex Manoussakis" <amanou@gnu.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] HID: elecom: rewrite report fixup for EX-G and future mice
Date: Tue, 23 Jan 2018 15:40:21 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.1801231540110.11852@cbobk.fhfr.pm> (raw)
In-Reply-To: <20171219204436.27737-1-tk@the-tk.com>
On Tue, 19 Dec 2017, Tomasz Kramkowski wrote:
> This patch rewrites the mouse report fixup used for the DEFT and HUGE
> elecom trackballs in order to make it generic enough to fix other
> elecom mice with similar issues. This patch also uses this new report
> fixup function to fix the Elecom EX-G trackball which has 6 physical
> buttons and a similar issue to the other two mice.
>
> Elecom's track record has so far shown that they like to re-use the
> same report descriptor for multiple different mice regardless of the
> number of buttons the mouse has. This means that the missing buttons
> on multiple mice can be fixed in one function without introducing
> phantom buttons which would in turn cause the number of mouse buttons
> to be misreported to userspace.
>
> This patch drops the very verbose report descriptor "diff" comment for
> a more abridged yet hopefully just as informative generic version.
>
> Signed-off-by: Tomasz Kramkowski <tk@the-tk.com>
> ---
> v2 changes:
> * pass rsize directly to mouse_button_fixup
> * add support for wireless EX-G variant
> v1: https://marc.info/?i=20171204205550.2621-1-tk@the-tk.com
Applied, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2018-01-23 14:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 20:55 [PATCH] HID: elecom: rewrite report fixup for EX-G and future mice Tomasz Kramkowski
2017-12-05 20:17 ` Tomasz Kramkowski
2017-12-07 10:04 ` Jiri Kosina
2017-12-09 17:23 ` Tomasz Kramkowski
2017-12-11 10:28 ` Jiri Kosina
2017-12-11 17:31 ` Alex Manoussakis
2017-12-13 21:47 ` Tomasz Kramkowski
2017-12-14 1:02 ` Alex Manoussakis
2017-12-19 20:44 ` [PATCH v2] " Tomasz Kramkowski
2018-01-23 14:40 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.1801231540110.11852@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=amanou@gnu.org \
--cc=benjamin.tissoires@redhat.com \
--cc=flameeyes@flameeyes.eu \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tk@the-tk.com \
--cc=yshuiv7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.